X-Git-Url: http://koha-dev.rot13.org:8081/gitweb/?a=blobdiff_plain;f=circ%2Fbranchtransfers.pl;h=cb10b5b0f1654fee8d658eeda4c209c00e32e155;hb=f41f272ff087d65ed11d760e6c7c58818c3a24d4;hp=ae97c6e84c460ce444393fb69697b1a37d5e8b8a;hpb=cc9524a875d8b032a40fa943de3973d4c93854bf;p=koha-ffzg.git

diff --git a/circ/branchtransfers.pl b/circ/branchtransfers.pl
index ae97c6e84c..cb10b5b0f1 100755
--- a/circ/branchtransfers.pl
+++ b/circ/branchtransfers.pl
@@ -1,327 +1,249 @@
 #!/usr/bin/perl
-# WARNING: This file uses 4-character tabs!
 
-#written 11/3/2002 by Finlay
 #script to execute branch transfers of books
 
-
 # Copyright 2000-2002 Katipo Communications
+# copyright 2010 BibLibre
 #
 # This file is part of Koha.
 #
-# Koha is free software; you can redistribute it and/or modify it under the
-# terms of the GNU General Public License as published by the Free Software
-# Foundation; either version 2 of the License, or (at your option) any later
-# version.
+# Koha is free software; you can redistribute it and/or modify it
+# under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
 #
-# Koha is distributed in the hope that it will be useful, but WITHOUT ANY
-# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
-# A PARTICULAR PURPOSE.  See the GNU General Public License for more details.
+# Koha is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
 #
-# You should have received a copy of the GNU General Public License along with
-# Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
-# Suite 330, Boston, MA  02111-1307 USA
-
-use strict;
-use CGI;
-use C4::Circulation::Circ2;
-use C4::Output;
-use C4::Reserves2;
-use C4::Auth;
-use C4::Interface::CGI::Output;
-use HTML::Template;
-use C4::Koha;
-
-###############################################
-# constants
-
-my %env;
-my $linecolor1= 0;
-my $linecolor2= 1;
-
-my $branches = getbranches();
-my $printers = getprinters(\%env);
-
+# You should have received a copy of the GNU General Public License
+# along with Koha; if not, see <http://www.gnu.org/licenses>.
+
+use Modern::Perl;
+use CGI qw ( -utf8 );
+use C4::Circulation qw( transferbook barcodedecode );
+use C4::Output qw( output_html_with_http_headers );
+use C4::Reserves qw( ModReserve ModReserveAffect );
+use C4::Auth qw( get_session get_template_and_user );
+use C4::Members;
+use Koha::BiblioFrameworks;
+use Koha::AuthorisedValues;
+use Koha::Holds;
+use Koha::Items;
+use Koha::Patrons;
 
 ###############################################
 #  Getting state
 
-my $query=new CGI;
+my $query = CGI->new;
 
+if (!C4::Context->userenv){
+	my $sessionID = $query->cookie("CGISESSID");
+    my $session;
+	$session = get_session($sessionID) if $sessionID;
+    if (!$session){
+		# no branch set we can't transfer
+        print $query->redirect("/cgi-bin/koha/circ/set-library.pl");
+		exit;
+	}
+}
 
-my $branch = getbranch($query, $branches);
-my $printer = getprinter($query, $printers);
+#######################################################################################
+# Make the page .....
+my ($template, $user, $cookie, $flags ) = get_template_and_user(
+    {
+        template_name   => "circ/branchtransfers.tt",
+        query           => $query,
+        type            => "intranet",
+        flagsrequired   => { circulate => "circulate_remaining_permissions" },
+    }
+);
 
-my $genbrname = $branches->{$branch}->{'branchname'} ;
-my $genprname = $printers->{$printer}->{'printername'};
+# Check transfers is allowed from system preference
+if ( C4::Context->preference("IndependentBranchesTransfers") && !C4::Context->IsSuperLibrarian() ) {
+    print $query->redirect("/cgi-bin/koha/errors/403.pl");
+    exit;
+}
 
 my $messages;
 my $found;
 my $reserved;
 my $waiting;
+my $hold_transferred;
+my $hold_processed;
 my $reqmessage;
 my $cancelled;
-my $setwaiting;
-my $reqbrchname;
-my $allmessages;
-
-my $request=$query->param('request');
-my $borrnum = $query->param('borrowernumber');
+my $settransit;
 
-my $tobranchcd=$query->param('tobranchcd');
-my $frbranchcd='';
+my $request        = $query->param('request')        || '';
+my $borrowernumber = $query->param('borrowernumber') ||  0;
+my $tobranchcd     = $query->param('tobranchcd')     || '';
+my $trigger        = 'Manual';
 
+my $ignoreRs = 0;
 ############
 # Deal with the requests....
-if ($request eq "KillWaiting") {
+if ( $request eq "KillWaiting" ) {
     my $item = $query->param('itemnumber');
-    CancelReserve(0, $item, $borrnum);
-	$cancelled = 1;
-	$reqmessage =1;
-	$allmessages = 1;
+    my $holds = Koha::Holds->search({
+        itemnumber     => $item,
+        borrowernumber => $borrowernumber
+    });
+    if ( $holds->count ) {
+        $holds->next->cancel;
+        $cancelled   = 1;
+        $reqmessage  = 1;
+    } # FIXME else?
 }
-
-my $ignoreRs = 0;
-if ($request eq "SetWaiting") {
+elsif ( $request eq "SetTransit" ) {
     my $item = $query->param('itemnumber');
-    $tobranchcd = ReserveWaiting($item, $borrnum);
-	$reqbrchname = $branches->{$tobranchcd}->{'branchname'};
-    $ignoreRs = 1;
-	$setwaiting = 1;
-	$reqmessage =1;
-	$allmessages = 1;
-}
-if ($request eq 'KillReserved'){
-    my $biblio = $query->param('biblionumber');
-    CancelReserve($biblio, 0, $borrnum);
-	$cancelled = 1;
-	$reqmessage =1;
-	$allmessages = 1;
+    my $reserve_id = $query->param('reserve_id');
+    ModReserveAffect( $item, $borrowernumber, 1, $reserve_id );
+    $ignoreRs    = 1;
+    $settransit  = 1;
+    $reqmessage  = 1;
+    $trigger     = 'Reserve';
 }
-
-
-
-# set up the branchselect options....
-my @branchoptionloop;
-foreach my $br (keys %$branches) {
-    #(next) unless $branches->{$br}->{'CU'}; #FIXME disabled to fix bug 202
-    my %branch;
-    $branch{selected}=($br eq $tobranchcd);
-	$branch{code}=$br;
-	$branch{name}=$branches->{$br}->{'branchname'};
-	push (@branchoptionloop, \%branch);
+elsif ( $request eq 'KillReserved' ) {
+    my $biblionumber = $query->param('biblionumber');
+    my $reserve_id = $query->param('reserve_id');
+    my $hold = Koha::Holds->find({ reserve_id => $reserve_id });
+    if ( $hold ) {
+        $hold->cancel;
+        $cancelled   = 1;
+        $reqmessage  = 1;
+    } # FIXME else?
 }
 
-
-# collect the stack of books already transfered so they can printed...
+# collect the stack of books already transferred so they can printed...
 my @trsfitemloop;
-my %transfereditems;
-my %frbranchcds;
-my %tobranchcds;
-my $color=$linecolor2;
-my $transfered;
+my $transferred;
 my $barcode = $query->param('barcode');
+# remove leading/trailing whitespace
+$barcode = barcodedecode($barcode) if $barcode;
+# warn "barcode : $barcode";
 if ($barcode) {
 
-	my $iteminformation;
-	($transfered, $messages, $iteminformation)
-			= transferbook($tobranchcd, $barcode, $ignoreRs);
-	$found = $messages->{'ResFound'};
-	if ($transfered) {
-		my %item;
-		my $frbranchcd = $iteminformation->{'frbranchcd'};
-		if (not ($found)) {
-			($color eq $linecolor1) ? ($color=$linecolor2) : ($color=$linecolor1);
-			$item{'color'}=$color;
-			$item{'biblionumber'}=$iteminformation->{'biblionumber'};
-			$item{'title'}=$iteminformation->{'title'};
-			$item{'author'}=$iteminformation->{'author'};
-			$item{'itemtype'}=$iteminformation->{'itemtype'};
-			$item{'frbrname'}=$branches->{$frbranchcd}->{'branchname'};
-			$item{'tobrname'}=$branches->{$tobranchcd}->{'branchname'};
-		}
-		$item{counter}=0;
-		$item{barcode}=$barcode;
-		$item{frombrcd}=$frbranchcd;
-		$item{tobrcd}=$tobranchcd;
-##########
-#Are these lines still useful ???
-		$transfereditems{0}=$barcode;
-		$frbranchcds{0}=$frbranchcd;
-		$tobranchcds{0}=$tobranchcd;
-##########
-		push (@trsfitemloop, \%item);
-	}
+    ( $transferred, $messages ) =
+        transferbook({
+            from_branch => C4::Context->userenv->{'branch'},
+            to_branch => $tobranchcd,
+            barcode => $barcode,
+            ignore_reserves => $ignoreRs,
+            trigger => $trigger
+        });
+    my $item = Koha::Items->find({ barcode => $barcode });
+    $found = $messages->{'ResFound'} unless $settransit;
+    if ($transferred) {
+        my %trsfitem;
+        my $frbranchcd =  C4::Context->userenv->{'branch'};
+        $trsfitem{item}     = $item;
+        $trsfitem{counter}  = 0;
+        $trsfitem{frombrcd} = $frbranchcd;
+        $trsfitem{tobrcd}   = $tobranchcd;
+        push( @trsfitemloop, \%trsfitem );
+    }
 }
 
-foreach ($query->param){
-	(next) unless (/bc-(\d*)/);
-	my $counter=$1;
-	my %item;
-	my $bc=$query->param("bc-$counter");
-	my $frbcd=$query->param("fb-$counter");
-	my $tobcd=$query->param("tb-$counter");
-	$counter++;
-	$item{counter}=$counter;
-	$item{barcode}=$bc;
-	$item{frombrcd}=$frbcd;
-	$item{tobrcd}=$tobcd;
-	my ($iteminformation) = getiteminformation(\%env, 0, $bc);
-	($color eq $linecolor1) ? ($color=$linecolor2) : ($color=$linecolor1);
-	$item{'color'}=$color;
-	$item{'biblionumber'}=$iteminformation->{'biblionumber'};
-	$item{'title'}=$iteminformation->{'title'};
-	$item{'author'}=$iteminformation->{'author'};
-	$item{'itemtype'}=$iteminformation->{'itemtype'};
-	$item{'frbrname'}=$branches->{$frbcd}->{'branchname'};
-	$item{'tobrname'}=$branches->{$tobcd}->{'branchname'};
-##########
-#Are these lines still useful ???
-	$transfereditems{$counter}=$bc;
-	$frbranchcds{$counter}=$frbcd;
-	$tobranchcds{$counter}=$tobcd;
-#########
-	push (@trsfitemloop, \%item);
+foreach ( $query->param ) {
+    (next) unless (/bc-(\d*)/);
+    my $counter = $1;
+    my %trsfitem;
+    my $bc    = $query->param("bc-$counter");
+    my $frbcd = $query->param("fb-$counter");
+    my $tobcd = $query->param("tb-$counter");
+    $counter++;
+    $trsfitem{counter}  = $counter;
+    $trsfitem{frombrcd} = $frbcd;
+    $trsfitem{tobrcd}   = $tobcd;
+    my $item = Koha::Items->find({ barcode => $bc });
+    $trsfitem{item}     = $item;
+    push( @trsfitemloop, \%trsfitem );
 }
 
-my $title;
-my $surname;
-my $firstname;
-my $bornum;
-my $borphone;
-my $borstraddress;
-my $borcity;
-my $borzip;
-my $boremail;
-my $bornum;
-my $borcnum;
 my $itemnumber;
-my $biblionum;
-my $branchname;
-my $wastransferred;
-
+my $biblionumber;
 
 #####################
 
-if ($found) {
-    my $res = $messages->{'ResFound'};
-	$branchname = $branches->{$res->{'branchcode'}}->{'branchname'};
-	my ($borr) = getpatroninformation(\%env, $res->{'borrowernumber'}, 0);
-	$title = $borr->{'title'};
-	$surname = $borr->{'surname'};
-	$firstname = $borr->{'firstname'};
-	$bornum = $borr->{'borrowernumber'};
-    $borphone = $borr->{'phone'};
-    $borstraddress = $borr->{'streetaddress'};
-	$borcity = $borr->{'city'};
-	$borzip = $borr->{'zipcode'};
-	$boremail = $borr->{'emailadress'};
-	
-	#Hopefully, borr->{borrowernumber}=res->{borrowernumber}
-	$borcnum = $borr->{'cardnumber'};
-	$itemnumber = $res->{'itemnumber'};
-
-	if ($res->{'ResFound'} eq "Waiting") {
-		$waiting = 1;
-	}
-	if ($res->{'ResFound'} eq "Reserved") {
-		$reserved = 1;
-		$biblionum = $res->{'biblionumber'};
-	}
+my $hold;
+if ($found){
+    $hold = Koha::Holds->find(
+        { reserve_id => $found->{reserve_id} },
+        { prefetch => ['item','patron'] }
+    );
+    $itemnumber = $found->{'itemnumber'};
+    $borrowernumber = $found->{'borrowernumber'};
+
+    if ( $found->{'ResFound'} eq "Waiting" ) {
+        $waiting = 1;
+    } elsif ( $found->{'ResFound'} eq "Transferred" ) {
+        $hold_transferred = 1;
+    } elsif ( $found->{'ResFound'} eq "Processing" ) {
+        $hold_processed = 1;
+    } elsif ( $found->{'ResFound'} eq "Reserved" ) {
+        $reserved  = 1;
+        $biblionumber = $found->{'biblionumber'};
+    }
 }
 
-#####################
-
 my @errmsgloop;
-foreach my $code (keys %$messages) {
-	my %err;
-
-	if ($code eq 'BadBarcode') {
-		$err{msg}=$messages->{'BadBarcode'};
-		$err{errbadcode} = 1;
-		$allmessages = 1;
-	}
-
-    if ($code eq 'IsPermanent'){
-		$err{errispermanent} = 1;
-		$err{msg} = $branches->{$messages->{'IsPermanent'}}->{'branchname'};
-		# Here, msg contains the branchname
-		# Not so satisfied with this... But should work
-		$allmessages = 1;
+foreach my $code ( keys %$messages ) {
+    if ( $code ne 'WasTransfered' ) {
+        my %err;
+        if ( $code eq 'BadBarcode' ) {
+            $err{msg}        = $messages->{'BadBarcode'};
+            $err{errbadcode} = 1;
+        }
+        elsif ( $code eq "NotAllowed" ) {
+            warn "NotAllowed: $messages->{'NotAllowed'} to branchcode " . $messages->{'NotAllowed'};
+            # Do we really want a error log message here? --atz
+            $err{errnotallowed} =  1;
+            my ( $tbr, $typecode ) = split( /::/,  $messages->{'NotAllowed'} );
+            $err{tbr}      = $tbr;
+            $err{code}     = $typecode;
+        }
+        elsif ( $code eq 'WasReturned' ) {
+            $err{errwasreturned} = 1;
+            $err{borrowernumber} = $messages->{'WasReturned'};
+            my $patron = Koha::Patrons->find( $messages->{'WasReturned'} );
+            if ( $patron ) { # Just in case...
+                $err{patron} = $patron;
+            }
+        }
+        elsif ( $code eq 'DestinationEqualsHolding' ) {
+            $err{errdesteqholding} = 1;
+        }
+        push( @errmsgloop, \%err ) if (keys %err);
     }
-    $err{errdesteqholding} = ($code eq 'DestinationEqualsHolding');
-
-	if ($code eq 'WasReturned') {
-		$err{errwasreturned} = 1;
-		$allmessages = 1;
-		my ($borrowerinfo) = getpatroninformation(\%env, $messages->{'WasReturned'}, 0);
-		$title = $borrowerinfo->{'title'};
-		$surname = $borrowerinfo->{'surname'};
-		$firstname = $borrowerinfo->{'firstname'};
-		$bornum =$borrowerinfo->{'borrowernumber'};
-		$borcnum =$borrowerinfo->{'cardnumber'};
-    }
-#    if ($code eq 'WasTransfered'){
-# Put code here if you want to notify the user that item was transfered...
-#		$wastransferred = 1;
-#    }
-	push (@errmsgloop, \%err);
 }
 
-#######################################################################################
-# Make the page .....
-my ($template, $borrowernumber, $cookie)
-    = get_template_and_user({template_name => "circ/branchtransfers.tmpl",
-							query => $query,
-                            type => "intranet",
-                            authnotrequired => 0,
-                            flagsrequired => {circulate => 1},
-                         });
-if($allmessages){
-	$template->param(allmessages => 1);
-}
+# use Data::Dumper;
+# warn "FINAL ============= ".Dumper(@trsfitemloop);
+
+$template->param(
+    found                   => $found,
+    hold                    => $hold,
+    reserved                => $reserved,
+    waiting                 => $waiting,
+    transferred             => $hold_transferred,
+    processing              => $hold_processed,
+    borrowernumber          => $borrowernumber,
+    itemnumber              => $itemnumber,
+    barcode                 => $barcode,
+    biblionumber            => $biblionumber,
+    tobranchcd              => $tobranchcd,
+    reqmessage              => $reqmessage,
+    cancelled               => $cancelled,
+    settransit              => $settransit,
+    trsfitemloop            => \@trsfitemloop,
+    errmsgloop              => \@errmsgloop,
+    PatronAutoComplete    => C4::Context->preference("PatronAutoComplete"),
+);
+
+# Checking if there is a Fast Cataloging Framework
+$template->param( fast_cataloging => 1 ) if Koha::BiblioFrameworks->find( 'FA' );
 
-$template->param(	genbrname => $genbrname,
-								genprname => $genprname,
-								branch => $branch,
-								printer => $printer,
-								found => $found,
-								reserved => $reserved,
-								waiting => $waiting,
-								title => $title,
-								surname => $surname,
-								firstname => $firstname,
-								borphone => $borphone,
-								borstraddress => $borstraddress,
-								borcity => $borcity,
-								borzip => $borzip,
-								boremail => $boremail,
-								bornum => $bornum,
-								borcnum => $borcnum,
-								branchname => $branchname,
-								itemnumber => $itemnumber,
-								barcode => $barcode,
-								biblionumber => $biblionum,
-								tobranchcd => $tobranchcd,
-								reqmessage => $reqmessage,
-								cancelled => $cancelled,
-								setwaiting => $setwaiting,
-								wastransferred => $wastransferred,
-								trsfitemloop => \@trsfitemloop,
-								branchoptionloop => \@branchoptionloop,
-								errmsgloop => \@errmsgloop,
-								intranetcolorstylesheet => C4::Context->preference("intranetcolorstylesheet"),
-		intranetstylesheet => C4::Context->preference("intranetstylesheet"),
-		IntranetNav => C4::Context->preference("IntranetNav"),
-							);
 output_html_with_http_headers $query, $cookie, $template->output;
 
-
-sub name {
-	my ($borinfo) = @_;
-	return $borinfo->{'surname'}." ".$borinfo->{'title'}." ".$borinfo->{'firstname'};
-}
-
-# Local Variables:
-# tab-width: 4
-# End: