X-Git-Url: http://koha-dev.rot13.org:8081/gitweb/?a=blobdiff_plain;f=admin%2Fcheckmarc.pl;h=8734441f1b70daa2d4d8cbe218f58cf43e30ad9c;hb=5d6c092921919526ade501facb1220f8a108a08f;hp=e5df99b2da1ba49d8a6a445c8e517e8bbabe1404;hpb=e1d907c688499de689ed613014261c761a0158c8;p=koha_fer diff --git a/admin/checkmarc.pl b/admin/checkmarc.pl index e5df99b2da..8734441f1b 100755 --- a/admin/checkmarc.pl +++ b/admin/checkmarc.pl @@ -14,11 +14,12 @@ # WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR # A PARTICULAR PURPOSE. See the GNU General Public License for more details. # -# You should have received a copy of the GNU General Public License along with -# Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place, -# Suite 330, Boston, MA 02111-1307 USA +# You should have received a copy of the GNU General Public License along +# with Koha; if not, write to the Free Software Foundation, Inc., +# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Output; use C4::Auth; use CGI; @@ -33,36 +34,54 @@ my ($template, $borrowernumber, $cookie) query => $input, type => "intranet", authnotrequired => 0, - flagsrequired => {parameters => 1}, + flagsrequired => {parameters => 'parameters_remaining_permissions'}, debug => 1, }); my $dbh = C4::Context->dbh; -my $total; +my $total = 0; # checks itemnum field my $sth = $dbh->prepare("select tab from marc_subfield_structure where kohafield=\"items.itemnumber\""); $sth->execute; -my ($res) = $sth->fetchrow; -if ($res==-1) { - $template->param(itemnum => 0); -} else { - $template->param(itemnum => 1); - $total++; +while (my ($res) = $sth->fetchrow) { + if ($res==-1) { + $template->param(itemnum => 0); + } else { + $template->param(itemnum => 1); + $total++; + last; + } } # checks biblio.biblionumber and biblioitem.biblioitemnumber (same tag and tab=-1) -$sth = $dbh->prepare("select tagfield,tab from marc_subfield_structure where kohafield=\"biblio.biblionumber\""); +$sth = $dbh->prepare("select tagfield,tab,frameworkcode from marc_subfield_structure where kohafield=\"biblio.biblionumber\""); $sth->execute; -my $tab; -($res,$tab) = $sth->fetchrow; -$sth = $dbh->prepare("select tagfield,tab from marc_subfield_structure where kohafield=\"biblioitems.biblioitemnumber\""); -$sth->execute; -my ($res2,$tab2) = $sth->fetchrow; -if ($res && $res2 && $tab==-1 && $tab2==-1) { - $template->param(biblionumber => 0); -} else { - $template->param(biblionumber => 1); - $total++; +my $first = 1; +my $bibliotag = ''; +while (my ($res,$tab,$frameworkcode) = $sth->fetchrow) { + if ($first) { + $bibliotag = $res; + $first = 0; + } else { + if ($bibliotag != $res) { + $template->param(biblionumber => 1); + $total++; + last; + } + } + my $sth2 = $dbh->prepare("SELECT tagfield,tab + FROM marc_subfield_structure + WHERE kohafield=\"biblioitems.biblioitemnumber\" + AND frameworkcode = ? "); + $sth2->execute($frameworkcode); + my ($res2,$tab2) = $sth2->fetchrow; + if ($res && $res2 && $tab==-1 && $tab2==-1) { + $template->param(biblionumber => 0); + } else { + $template->param(biblionumber => 1); + $total++; + last; + } } # checks all item fields are in the same tag and in tab 10 @@ -70,9 +89,12 @@ if ($res && $res2 && $tab==-1 && $tab2==-1) { $sth = $dbh->prepare("select tagfield,tab,kohafield from marc_subfield_structure where kohafield like \"items.%\" and tab >=0"); $sth->execute; my $field; +my $res; +my $res2; +my $tab; ($res,$res2,$field) = $sth->fetchrow; my $tagfield = $res; -my $tab = $res2; +$tab = $res2; my $subtotal=0; #warn "TAGF : $tagfield"; while (($res,$res2,$field) = $sth->fetchrow) { @@ -115,59 +137,64 @@ if ($totaltags > 1) { # checks biblioitems.itemtype must be mapped and use authorised_value=itemtype $sth = $dbh->prepare("select tagfield,tab,authorised_value from marc_subfield_structure where kohafield = \"biblioitems.itemtype\""); $sth->execute; -($res,$res2,$field) = $sth->fetchrow; -if ($res && $res2>=0 && $field eq "itemtypes") { - $template->param(itemtype => 0); -} else { - $template->param(itemtype => 1); - $total++; +while (($res,$res2,$field) = $sth->fetchrow) { + if ($res && $res2>=0 && $field eq "itemtypes") { + $template->param(itemtype => 0); + } else { + $template->param(itemtype => 1); + $total++; + last; + } } # checks items.homebranch must be mapped and use authorised_value=branches $sth = $dbh->prepare("select tagfield,tab,authorised_value from marc_subfield_structure where kohafield = \"items.homebranch\""); $sth->execute; -($res,$res2,$field) = $sth->fetchrow; -if ($res && $res2 eq 10 && $field eq "branches") { - $template->param(branch => 0); -} else { - $template->param(branch => 1); - $total++; +while (($res,$res2,$field) = $sth->fetchrow) { + if ($res && $res2 eq 10 && $field eq "branches") { + $template->param(branch => 0); + } else { + $template->param(branch => 1); + $total++; + last; + } } + # checks items.homebranch must be mapped and use authorised_value=branches $sth = $dbh->prepare("select tagfield,tab,authorised_value from marc_subfield_structure where kohafield = \"items.holdingbranch\""); $sth->execute; -($res,$res2,$field) = $sth->fetchrow; -if ($res && $res2 eq 10 && $field eq "branches") { - $template->param(holdingbranch => 0); -} else { - $template->param(holdingbranch => 1); - $total++; +while (($res,$res2,$field) = $sth->fetchrow) { + if ($res && $res2 eq 10 && $field eq "branches") { + $template->param(holdingbranch => 0); + } else { + $template->param(holdingbranch => 1); + $total++; + last; #MR + } } # checks that itemtypes & branches tables are not empty $sth = $dbh->prepare("select count(*) from itemtypes"); $sth->execute; ($res) = $sth->fetchrow; -unless ($res) { +if ($res) { + $template->param(itemtypes_empty =>0); +} else { $template->param(itemtypes_empty =>1); $total++; } + $sth = $dbh->prepare("select count(*) from branches"); $sth->execute; ($res) = $sth->fetchrow; -unless ($res) { +if ($res) { + $template->param(branches_empty =>0); +} else { $template->param(branches_empty =>1); $total++; } -$sth = $dbh->prepare("select count(*) from marc_biblio where frameworkcode is NULL"); -$sth->execute; -($res) = $sth->fetchrow; -if ($res) { - $template->param(frameworknull =>1); - $total++; -} $sth = $dbh->prepare("select count(*) from marc_subfield_structure where frameworkcode is NULL"); $sth->execute; ($res) = $sth->fetchrow; @@ -183,9 +210,41 @@ if ($res) { $total++; } +# verify that all of a field's subfields (except the ones explicitly ignored) +# are in the same tab +$sth = $dbh->prepare("SELECT tagfield, frameworkcode, frameworktext, GROUP_CONCAT(DISTINCT tab) AS tabs + FROM marc_subfield_structure + LEFT JOIN biblio_framework USING (frameworkcode) + WHERE tab != -1 + GROUP BY tagfield, frameworkcode, frameworktext + HAVING COUNT(DISTINCT tab) > 1"); +$sth->execute; +my $inconsistent_tabs = $sth->fetchall_arrayref({}); +if (scalar(@$inconsistent_tabs) > 0) { + $total++; + $template->param(inconsistent_tabs => 1); + $template->param(tab_info => $inconsistent_tabs); +} + +# verify that authtypecodes used in the framework +# are defined in auth_types +$sth = $dbh->prepare("SELECT frameworkcode, frameworktext, tagfield, tagsubfield, authtypecode + FROM marc_subfield_structure + LEFT JOIN biblio_framework USING (frameworkcode) + WHERE authtypecode IS NOT NULL + AND authtypecode <> '' + AND tab > '-1' + AND authtypecode NOT IN (SELECT authtypecode FROM auth_types) + ORDER BY frameworkcode, tagfield, tagsubfield"); +$sth->execute; +my $invalid_authtypecodes = $sth->fetchall_arrayref({}); +if (scalar(@$invalid_authtypecodes) > 0) { + $total++; + $template->param(invalid_authtypecodes => 1); + $template->param(authtypecode_info => $invalid_authtypecodes); +} + $template->param(total => $total, - intranetcolorstylesheet => C4::Context->preference("intranetcolorstylesheet"), - intranetstylesheet => C4::Context->preference("intranetstylesheet"), - IntranetNav => C4::Context->preference("IntranetNav"), ); + output_html_with_http_headers $input, $cookie, $template->output;