X-Git-Url: http://koha-dev.rot13.org:8081/gitweb/?a=blobdiff_plain;f=admin%2Faqbudgets.pl;h=9da555dbc6c337b7340982dd245e7a1de348c407;hb=6241d54c52b9ad1e8f1117b260cbbc86c4d37faa;hp=8c6d2b4eaa4d747bd27854c0a9214cac55c33280;hpb=8eac9d81805d436162839a7339d5b3c6e9c27e72;p=koha_fer diff --git a/admin/aqbudgets.pl b/admin/aqbudgets.pl index 8c6d2b4eaa..9da555dbc6 100755 --- a/admin/aqbudgets.pl +++ b/admin/aqbudgets.pl @@ -20,6 +20,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use CGI; use List::Util qw/min/; use Number::Format qw(format_price); @@ -68,7 +69,7 @@ if ( not defined $template->{param_map}->{'CAN_user_acquisition_budget_add_del my $num=FormatNumber; my $script_name = "/cgi-bin/koha/admin/aqbudgets.pl"; -my $budget_hash=$input->Vars; +my $budget_hash = $input->Vars; my $budget_id = $$budget_hash{budget_id}; my $budget_permission = $input->param('budget_permission'); my $budget_period_dropbox = $input->param('budget_period_dropbox'); @@ -238,11 +239,12 @@ if ($op eq 'add_form') { my $period_total = 0; my ( $period_alloc_total, $base_spent_total ); - use YAML; - $debug && warn Dump(@budgets); #This Looks WEIRD to me : should budgets be filtered in such a way ppl who donot own it would not see the amount spent on the budget by others ? foreach my $budget (@budgets) { + #Level and sublevels total spent + $budget->{'total_levels_spent'} = GetChildBudgetsSpent($budget->{"budget_id"}); + # PERMISSIONS unless($staffflags->{'superlibrarian'} % 2 == 1 ) { #IF NO PERMS, THEN DISABLE EDIT/DELETE @@ -283,17 +285,20 @@ if ($op eq 'add_form') { # adds to total - only if budget is a 'top-level' budget $period_alloc_total += $budget->{'budget_amount_total'} if $budget->{'depth'} == 0; $base_spent_total += $budget->{'budget_spent'}; - $budget->{'budget_remaining'} = $budget->{'budget_amount'} - $budget->{'budget_spent'}; + $budget->{'budget_remaining'} = $budget->{'budget_amount'} - $budget->{'total_levels_spent'}; # if amount == 0 dont display... delete $budget->{'budget_unalloc_sublevel'} if $budget->{'budget_unalloc_sublevel'} == 0 ; $budget->{'remaining_pos'} = 1 if $budget->{'budget_remaining'} > 0; $budget->{'remaining_neg'} = 1 if $budget->{'budget_remaining'} < 0; - for (grep {/budget_spent|budget_amount|budget_remaining|budget_unalloc/} keys %$budget){ + for (grep {/total_levels_spent|budget_spent|budget_amount|budget_remaining|budget_unalloc/} keys %$budget){ $$budget{$_} = $num->format_price( $$budget{$_} ) if defined($$budget{$_}) } + # Value of budget_spent equals 0 instead of undefined value + $$budget{"budget_spent"} = $num->format_price(0) unless defined($$budget{"budget_spent"}); + my $borrower = &GetMember( borrowernumber=>$budget->{budget_owner_id} ); $budget->{"budget_owner_name"} = $borrower->{'firstname'} . ' ' . $borrower->{'surname'}; $budget->{"budget_borrowernumber"} = $borrower->{'borrowernumber'};