X-Git-Url: http://koha-dev.rot13.org:8081/gitweb/?a=blobdiff_plain;f=C4%2FRotatingCollections.pm;h=d6fad87b377d38cfd6a2f1ad58e0f5af346ed02f;hb=b0f39cee0de80568d78903b1926fa6eeefb6f16e;hp=6b1383f62c43983c8c9395743df01ab442a66c52;hpb=c9ba8c899d854d4190df783f3f1aec2989d2cb10;p=koha_fer diff --git a/C4/RotatingCollections.pm b/C4/RotatingCollections.pm index 6b1383f62c..d6fad87b37 100644 --- a/C4/RotatingCollections.pm +++ b/C4/RotatingCollections.pm @@ -37,7 +37,7 @@ use Data::Dumper; use vars qw($VERSION @ISA @EXPORT); # set the version for version checking -$VERSION = 0.01; +$VERSION = 3.07.00.049; =head1 NAME @@ -45,8 +45,6 @@ C4::RotatingCollections - Functions for managing rotating collections =head1 FUNCTIONS -=over 2 - =cut @ISA = qw( Exporter ); @@ -67,7 +65,7 @@ C4::RotatingCollections - Functions for managing rotating collections GetCollectionItemBranches ); -=item CreateCollection +=head2 CreateCollection ( $success, $errorcode, $errormessage ) = CreateCollection( $title, $description ); Creates a new collection @@ -79,7 +77,9 @@ C4::RotatingCollections - Functions for managing rotating collections $success: 1 if all database operations were successful, 0 otherwise $errorCode: Code for reason of failure, good for translating errors in templates $errorMessage: English description of error + =cut + sub CreateCollection { my ( $title, $description ) = @_; @@ -99,15 +99,16 @@ sub CreateCollection { $sth = $dbh->prepare("INSERT INTO collections ( colId, colTitle, colDesc ) VALUES ( NULL, ?, ? )"); $sth->execute( $title, $description ) or return ( 0, 3, $sth->errstr() ); - $sth->finish; return 1; - + } -=item UpdateCollection +=head2 UpdateCollection + ( $success, $errorcode, $errormessage ) = UpdateCollection( $colId, $title, $description ); - Updates a collection + +Updates a collection Input: $colId: id of the collection to be updated @@ -118,7 +119,9 @@ sub CreateCollection { $success: 1 if all database operations were successful, 0 otherwise $errorCode: Code for reason of failure, good for translating errors in templates $errorMessage: English description of error + =cut + sub UpdateCollection { my ( $colId, $title, $description ) = @_; @@ -141,13 +144,13 @@ sub UpdateCollection { colTitle = ?, colDesc = ? WHERE colId = ?"); $sth->execute( $title, $description, $colId ) or return ( 0, 4, $sth->errstr() ); - $sth->finish; return 1; } -=item DeleteCollection +=head2 DeleteCollection + ( $success, $errorcode, $errormessage ) = DeleteCollection( $colId ); Deletes a collection of the given id @@ -158,7 +161,9 @@ sub UpdateCollection { $success: 1 if all database operations were successful, 0 otherwise $errorCode: Code for reason of failure, good for translating errors in templates $errorMessage: English description of error + =cut + sub DeleteCollection { my ( $colId ) = @_; @@ -173,12 +178,12 @@ sub DeleteCollection { $sth = $dbh->prepare("DELETE FROM collections WHERE colId = ?"); $sth->execute( $colId ) or return ( 0, 4, $sth->errstr() ); - $sth->finish; return 1; } -=item GetCollections +=head2 GetCollections + $collections = GetCollections(); Returns data about all collections @@ -188,7 +193,9 @@ sub DeleteCollection { On Failure: $errorCode: Code for reason of failure, good for translating errors in templates $errorMessage: English description of error + =cut + sub GetCollections { my $dbh = C4::Context->dbh; @@ -201,13 +208,13 @@ sub GetCollections { push( @results , $row ); } - $sth->finish; - return \@results; } -=item GetItemsInCollection +=head2 GetItemsInCollection + ( $results, $success, $errorcode, $errormessage ) = GetItemsInCollection( $colId ); + Returns information about the items in the given collection Input: @@ -218,7 +225,9 @@ sub GetCollections { $success: 1 if all database operations were successful, 0 otherwise $errorCode: Code for reason of failure, good for translating errors in templates $errorMessage: English description of error + =cut + sub GetItemsInCollection { my ( $colId ) = @_; @@ -245,20 +254,22 @@ sub GetItemsInCollection { push( @results , $row ); } - $sth->finish; - return \@results; } -=item GetCollection +=head2 GetCollection + ( $colId, $colTitle, $colDesc, $colBranchcode ) = GetCollection( $colId ); - Returns information about a collection + +Returns information about a collection Input: $colId: Id of the collection Output: $colId, $colTitle, $colDesc, $colBranchcode + =cut + sub GetCollection { my ( $colId ) = @_; @@ -270,8 +281,6 @@ sub GetCollection { my $row = $sth->fetchrow_hashref; - $sth->finish; - return ( $$row{'colId'}, $$row{'colTitle'}, @@ -281,9 +290,11 @@ sub GetCollection { } -=item AddItemToCollection +=head2 AddItemToCollection + ( $success, $errorcode, $errormessage ) = AddItemToCollection( $colId, $itemnumber ); - Adds an item to a rotating collection. + +Adds an item to a rotating collection. Input: $colId: Collection to add the item to. @@ -292,7 +303,9 @@ sub GetCollection { $success: 1 if all database operations were successful, 0 otherwise $errorCode: Code for reason of failure, good for translating errors in templates $errorMessage: English description of error + =cut + sub AddItemToCollection { my ( $colId, $itemnumber ) = @_; @@ -313,18 +326,19 @@ sub AddItemToCollection { my $dbh = C4::Context->dbh; my $sth; - $sth = $dbh->prepare("INSERT INTO collections_tracking ( ctId, colId, itemnumber ) + $sth = $dbh->prepare("INSERT INTO collections_tracking ( collections_tracking_id, colId, itemnumber ) VALUES ( NULL, ?, ? )"); $sth->execute( $colId, $itemnumber ) or return ( 0, 3, $sth->errstr() ); - $sth->finish; return 1; } -=item RemoveItemFromCollection +=head2 RemoveItemFromCollection + ( $success, $errorcode, $errormessage ) = RemoveItemFromCollection( $colId, $itemnumber ); - Removes an item to a collection + +Removes an item to a collection Input: $colId: Collection to add the item to. @@ -334,7 +348,9 @@ sub AddItemToCollection { $success: 1 if all database operations were successful, 0 otherwise $errorCode: Code for reason of failure, good for translating errors in templates $errorMessage: English description of error + =cut + sub RemoveItemFromCollection { my ( $colId, $itemnumber ) = @_; @@ -353,14 +369,15 @@ sub RemoveItemFromCollection { $sth = $dbh->prepare("DELETE FROM collections_tracking WHERE itemnumber = ?"); $sth->execute( $itemnumber ) or return ( 0, 3, $sth->errstr() ); - $sth->finish; return 1; } -=item TransferCollection +=head2 TransferCollection + ( $success, $errorcode, $errormessage ) = TransferCollection( $colId, $colBranchcode ); - Transfers a collection to another branch + +Transfers a collection to another branch Input: $colId: id of the collection to be updated @@ -370,7 +387,9 @@ sub RemoveItemFromCollection { $success: 1 if all database operations were successful, 0 otherwise $errorCode: Code for reason of failure, good for translating errors in templates $errorMessage: English description of error + =cut + sub TransferCollection { my ( $colId, $colBranchcode ) = @_; @@ -390,7 +409,6 @@ sub TransferCollection { colBranchcode = ? WHERE colId = ?"); $sth->execute( $colBranchcode, $colId ) or return ( 0, 4, $sth->errstr() ); - $sth->finish; $sth = $dbh->prepare("SELECT barcode FROM items, collections_tracking WHERE items.itemnumber = collections_tracking.itemnumber @@ -400,16 +418,17 @@ sub TransferCollection { while ( my $item = $sth->fetchrow_hashref ) { my ( $dotransfer, $messages, $iteminformation ) = transferbook( $colBranchcode, $item->{'barcode'}, my $ignore_reserves = 1); } - - return 1; } -=item GetCollectionItemBranches - my ( $holdingBranch, $collectionBranch ) = GetCollectionItemBranches( $itemnumber ); +=head2 GetCollectionItemBranches + + my ( $holdingBranch, $collectionBranch ) = GetCollectionItemBranches( $itemnumber ); + =cut + sub GetCollectionItemBranches { my ( $itemnumber ) = @_; @@ -428,17 +447,18 @@ sub GetCollectionItemBranches { my $row = $sth->fetchrow_hashref; - $sth->finish; - return ( $$row{'holdingbranch'}, $$row{'colBranchcode'}, ); } -=item isItemInThisCollection -$inCollection = isItemInThisCollection( $itemnumber, $colId ); -=cut +=head2 isItemInThisCollection + + $inCollection = isItemInThisCollection( $itemnumber, $colId ); + +=cut + sub isItemInThisCollection { my ( $itemnumber, $colId ) = @_; @@ -452,9 +472,12 @@ sub isItemInThisCollection { return $$row{'inCollection'}; } -=item isItemInAnyCollection +=head2 isItemInAnyCollection + $inCollection = isItemInAnyCollection( $itemnumber ); + =cut + sub isItemInAnyCollection { my ( $itemnumber ) = @_; @@ -465,9 +488,7 @@ sub isItemInAnyCollection { my $row = $sth->fetchrow_hashref; - my $itemnumber = $$row{'itemnumber'}; - $sth->finish; - + $itemnumber = $row->{itemnumber}; if ( $itemnumber ) { return 1; } else { @@ -479,8 +500,6 @@ sub isItemInAnyCollection { __END__ -=back - =head1 AUTHOR Kyle Hall