X-Git-Url: http://koha-dev.rot13.org:8081/gitweb/?a=blobdiff_plain;f=C4%2FNewsChannels.pm;h=47772efc890512623b4e3ecd11c8641595f82ec5;hb=2b8b5ae225af6119e41e2112f9a8573b4170b927;hp=7c413aa815ddb1305c78e4eaa5e6b379472c26db;hpb=53f15f678f3e64156f9c969b3b019a73e9691cbd;p=koha_fer

diff --git a/C4/NewsChannels.pm b/C4/NewsChannels.pm
index 7c413aa815..47772efc89 100644
--- a/C4/NewsChannels.pm
+++ b/C4/NewsChannels.pm
@@ -61,9 +61,9 @@ sub add_opac_new {
     if ($href_entry) {
         my @fields = keys %{$href_entry};
         my @values = values %{$href_entry};
-        my $field_string = join ',',@fields;
+        my $field_string = join ',', @fields;
         $field_string = $field_string // q{};
-        my $values_string = '?,' x ($#fields) . '?';
+        my $values_string = join(',', map { '?' } @fields);
         my $dbh = C4::Context->dbh;
         my $sth = $dbh->prepare("INSERT INTO opac_news ( $field_string ) VALUES ( $values_string )");
         $sth->execute(@values);
@@ -150,7 +150,7 @@ sub get_opac_news {
                   FROM opac_news LEFT JOIN branches
                       ON opac_news.branchcode=branches.branchcode
                 };
-    $query = ' WHERE 1';
+    $query .= ' WHERE 1';
     if ($lang) {
         $query .= " AND (opac_news.lang='' OR opac_news.lang=?)";
         push @values,$lang;