Bug 17600: Standardize our EXPORT_OK

[srvgit] / t / db_dependent / rollingloans.t

diff --git a/t/db_dependent/rollingloans.t b/t/db_dependent/rollingloans.t
old mode 100644 (file)
new mode 100755 (executable)
index af9e454..f72fa9f
--- a/t/db_dependent/rollingloans.t
+++ b/t/db_dependent/rollingloans.t
@@ -1,41 +1,73 @@
+#!/usr/bin/perl
 
-use strict;
-use warnings;
-use 5.010;
+use Modern::Perl;
 use C4::Context;
-use C4::Circulation;
+use C4::Circulation qw( CanBookBeIssued AddIssue AddReturn );
 use C4::Members;
+use C4::Items;
+use Koha::DateUtils;
+use Koha::Libraries;
+use Koha::Patrons;
+use t::lib::TestBuilder;
+use t::lib::Mocks qw(mock_preference);
 
 use Test::More tests => 8;
-C4::Context->_new_userenv(1234567);
-C4::Context->set_userenv(91, 'CLIstaff', '23529001223661', 'CPL',
-                         'CPL', 'CPL', '', 'cc@cscnet.co.uk');
 
+my $schema = Koha::Database->new->schema;
+$schema->storage->txn_begin;
 
+my $builder = t::lib::TestBuilder->new;
+$builder->build({ source => 'Branch', value => { branchcode => 'CPL' } })
+    unless Koha::Libraries->find('CPL');
+
+t::lib::Mocks::mock_userenv({ branchcode => 'CPL' });
+
+t::lib::Mocks::mock_preference('BlockReturnOfWithdrawnItems',0);
 my $test_patron = '23529001223651';
 my $test_item_fic = '502326000402';
 my $test_item_24 = '502326000404';
 my $test_item_48 = '502326000403';
 
-for my $item_barcode ( $test_item_fic, $test_item_24, $test_item_48) {
-    my $duedate = try_issue($test_patron, $item_barcode);
-    isa_ok($duedate, 'DateTime');
-    if ($item_barcode eq $test_item_fic) {
-        is($duedate->hour(), 23, "daily loan hours = 23");
-        is($duedate->minute(), 59, "daily loan mins = 59");
+my $borrower1 = $builder->build_object({ class => 'Koha::Patrons', value => { cardnumber => $test_patron } });
+my $item1 = $builder->build_sample_item(
+    {
+        barcode => $test_item_fic,
     }
-    my $ret_ok = try_return($item_barcode);
-    is($ret_ok, 1, 'Return succeeded');
-}
+);
+my $item2 = $builder->build_sample_item(
+    {
+        barcode => $test_item_24,
+    }
+);
+my $item3 = $builder->build_sample_item(
+    {
+        barcode => $test_item_48,
+    }
+);
+
+SKIP: {
+    skip 'Missing test borrower or item, skipping tests', 8
+      unless ( defined $borrower1 && defined $item1 );
 
+    for my $item_barcode ( $test_item_fic, $test_item_24, $test_item_48 ) {
+        my $duedate = try_issue( $test_patron, $item_barcode );
+        isa_ok( $duedate, 'DateTime' );
+        if ( $item_barcode eq $test_item_fic ) {
+            is( $duedate->hour(),   23, "daily loan hours = 23" );
+            is( $duedate->minute(), 59, "daily loan mins = 59" );
+        }
+        my $ret_ok = try_return($item_barcode);
+        is( $ret_ok, 1, 'Return succeeded' );
+    }
+}
 
 sub try_issue {
     my ($cardnumber, $item ) = @_;
     my $issuedate = '2011-05-16';
-    my $borrower = GetMemberDetails(0, $cardnumber);
-    my ($issuingimpossible,$needsconfirmation) = CanBookBeIssued( $borrower, $item );
-       my $due_date = AddIssue($borrower, $item, undef, 0, $issuedate);
-    return $due_date;
+    my $patron = Koha::Patrons->find( { cardnumber => $cardnumber } );
+    my ($issuingimpossible,$needsconfirmation) = CanBookBeIssued( $patron, $item );
+    my $issue = AddIssue($patron->unblessed, $item, undef, 0, $issuedate);
+    return dt_from_string( $issue->date_due );
 }
 
 sub try_return {