Bug 31351: (QA follow-up) Extend the encode/decode test

[koha-ffzg.git] / t / db_dependent / Stats.t

diff --git a/t/db_dependent/Stats.t b/t/db_dependent/Stats.t
old mode 100644 (file)
new mode 100755 (executable)
index 7675a16..ce41190
--- a/t/db_dependent/Stats.t
+++ b/t/db_dependent/Stats.t
@@ -1,24 +1,22 @@
 #!/usr/bin/perl
 
 use Modern::Perl;
-use C4::Stats;
+use C4::Stats qw( UpdateStats );
+use Koha::Database;
 
-use Test::More tests => 20;
+use Test::More tests => 18;
 
 BEGIN {
-    use_ok('C4::Stats');
+    use_ok('C4::Stats', qw( UpdateStats ));
 }
 can_ok(
     'C4::Stats',
-    qw(UpdateStats
-    TotalPaid
-      )
+    qw(UpdateStats)
 );
 
-#Start transaction
+my $schema = Koha::Database->new->schema;
+$schema->storage->txn_begin;
 my $dbh = C4::Context->dbh;
-$dbh->{RaiseError} = 1;
-$dbh->{AutoCommit} = 0;
 
 #
 # Test UpdateStats
@@ -34,7 +32,6 @@ my $params = {
               other => "bla",
               itemtype => "BK",
               location => "LOC",
-              accountno => 51,
               ccode => "CODE",
 };
 my $return_error;
@@ -58,7 +55,7 @@ $return_error = $@;
 isnt ($return_error,'',"UpdateStats returns undef and croaks if type is undef");
 
 # returns undef and croaks if mandatory params are missing
-my @allowed_circulation_types = qw (renew issue localuse return);
+my @allowed_circulation_types = qw (renew issue localuse return onsite_checkout recall);
 my @allowed_accounts_types = qw (writeoff payment);
 my @circulation_mandatory_keys = qw (branch borrowernumber itemnumber ccode itemtype); #don't check type here
 my @accounts_mandatory_keys = qw (branch borrowernumber amount); #don't check type here
@@ -107,7 +104,6 @@ $params = {
               other => "bla",
               itemtype => "BK",
               location => "LOC",
-              accountno => 51,
               ccode => "CODE",
               type => "return"
 };
@@ -122,7 +118,6 @@ cmp_ok($params->{amount},'==', $line->{value},          "UpdateStats save amount
 is ($params->{other},          $line->{other},          "UpdateStats save other param in other field of statistics table");
 is ($params->{itemtype},       $line->{itemtype},       "UpdateStats save itemtype param in itemtype field of statistics table");
 is ($params->{location},       $line->{location},       "UpdateStats save location param in location field of statistics table");
-is ($params->{accountno},      $line->{proccode},       "UpdateStats save accountno param in proccode field of statistics table");
 is ($params->{ccode},          $line->{ccode},          "UpdateStats save ccode param in ccode field of statistics table");
 
 $dbh->do(q|DELETE FROM statistics|);
@@ -133,7 +128,6 @@ $params = {
     amount         => 5.1,
     other          => "bla",
     itemtype       => "BK",
-    accountno      => 51,
     ccode          => "CODE",
     type           => "return"
 };
@@ -153,7 +147,6 @@ $params = {
     other          => "bla",
     itemtype       => "BK",
     location       => undef,
-    accountno      => 51,
     ccode          => "CODE",
     type           => "return"
 };
@@ -164,12 +157,4 @@ $line = ${ $sth->fetchall_arrayref( {} ) }[0];
 is( $line->{location}, undef,
     "UpdateStats sets location to NULL if undef is passed in." );
 
-#
-# Test TotalPaid
-#
-
-is (TotalPaid (),undef,"TotalPaid returns undef if no params are given");
 # More tests to write!
-
-#End transaction
-$dbh->rollback;