Bug 17600: Standardize our EXPORT_OK

[srvgit] / t / db_dependent / Members / GetAllIssues.t

diff --git a/t/db_dependent/Members/GetAllIssues.t b/t/db_dependent/Members/GetAllIssues.t
old mode 100644 (file)
new mode 100755 (executable)
index 6433201..b327c8f
--- a/t/db_dependent/Members/GetAllIssues.t
+++ b/t/db_dependent/Members/GetAllIssues.t
@@ -22,10 +22,10 @@ use Test::MockModule;
 
 use t::lib::TestBuilder;
 
-use C4::Biblio;
+use C4::Circulation qw( AddIssue );
+use C4::Biblio qw( AddBiblio );
 use C4::Items;
-use C4::Members;
-use C4::Circulation;
+use C4::Members qw( GetAllIssues );
 use Koha::Libraries;
 use Koha::Patrons;
 use MARC::Record;
@@ -54,23 +54,22 @@ my %item_infos = (
 );
 
 my ($biblionumber1) = AddBiblio( MARC::Record->new, '' );
-my $itemnumber1 =
-  AddItem( { barcode => '0101', %item_infos }, $biblionumber1 );
-my $itemnumber2 =
-  AddItem( { barcode => '0102', %item_infos }, $biblionumber1 );
+
+# FIXME These tests will fail if the barcode exists in DB
+my $itemnumber1 = $builder->build_sample_item({ biblionumber => $biblionumber1, barcode => '0101', %item_infos })->itemnumber;
+my $itemnumber2 = $builder->build_sample_item({ biblionumber => $biblionumber1, barcode => '0102', %item_infos })->itemnumber;
 
 my ($biblionumber2) = AddBiblio( MARC::Record->new, '' );
-my $itemnumber3 =
-  AddItem( { barcode => '0203', %item_infos }, $biblionumber2 );
+my $itemnumber3 = $builder->build_sample_item({ biblionumber => $biblionumber2, barcode => '0202', %item_infos })->itemnumber;
 
 my $borrowernumber1 =
-  AddMember( categorycode => $categorycode, branchcode => $branchcode );
+  Koha::Patron->new({ categorycode => $categorycode, branchcode => $branchcode })->store->borrowernumber;
 my $borrowernumber2 =
-  AddMember( categorycode => $categorycode, branchcode => $branchcode );
+  Koha::Patron->new({ categorycode => $categorycode, branchcode => $branchcode })->store->borrowernumber;
 my $borrower1 = Koha::Patrons->find( $borrowernumber1 )->unblessed;
 my $borrower2 = Koha::Patrons->find( $borrowernumber2 )->unblessed;
 
-my $module = new Test::MockModule('C4::Context');
+my $module = Test::MockModule->new('C4::Context');
 $module->mock( 'userenv', sub { { branch => $branchcode } } );
 
 my $issues = C4::Members::GetAllIssues();
@@ -101,7 +100,7 @@ is( $issues->[1]->{itemnumber}, $itemnumber2, '' );
 $issues = C4::Members::GetAllIssues($borrowernumber2);
 is( @$issues, 0, 'GetAllIssues returns the correct number of elements' );
 
-AddIssue( $borrower2, '0203' );
+AddIssue( $borrower2, '0202' );
 $issues = C4::Members::GetAllIssues($borrowernumber1);
 is( @$issues, 2, 'GetAllIssues returns the correct number of elements' );
 is( $issues->[0]->{itemnumber}, $itemnumber1, '' );