#!/usr/bin/perl
#
-# This Koha test module is a stub!
-# Add more tests here!!!
+# This file is part of Koha.
+#
+# Koha is free software; you can redistribute it and/or modify it under the
+# terms of the GNU General Public License as published by the Free Software
+# Foundation; either version 2 of the License, or (at your option) any later
+# version.
+#
+# Koha is distributed in the hope that it will be useful, but WITHOUT ANY
+# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
+# A PARTICULAR PURPOSE. See the GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License along
+# with Koha; if not, write to the Free Software Foundation, Inc.,
+# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+#
+
+use Modern::Perl;
-use strict;
-use warnings;
use MARC::Record;
use C4::Biblio;
+use Koha::Database;
+use Koha::Library;
+
+use t::lib::Mocks;
+use t::lib::TestBuilder;
+
+use Test::More tests => 9;
-use Test::More tests => 7;
+use Test::Warn;
BEGIN {
use_ok('C4::Items');
+ use_ok('Koha::Items');
}
-# Helper biblio.
-diag("Creating biblio instance for testing.");
-my ($bibnum, $bibitemnum) = get_biblio();
+my $schema = Koha::Database->new->schema;
+my $location = 'My Location';
+
+subtest 'General Add, Get and Del tests' => sub {
+
+ plan tests => 14;
+
+ $schema->storage->txn_begin;
+
+ my $builder = t::lib::TestBuilder->new;
+ my $library = $builder->build({
+ source => 'Branch',
+ });
+
+ # Create a biblio instance for testing
+ t::lib::Mocks::mock_preference('marcflavour', 'MARC21');
+ my ($bibnum, $bibitemnum) = get_biblio();
+
+ # Add an item.
+ my ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem({ homebranch => $library->{branchcode}, holdingbranch => $library->{branchcode}, location => $location } , $bibnum);
+ cmp_ok($item_bibnum, '==', $bibnum, "New item is linked to correct biblionumber.");
+ cmp_ok($item_bibitemnum, '==', $bibitemnum, "New item is linked to correct biblioitemnumber.");
+
+ # Get item.
+ my $getitem = GetItem($itemnumber);
+ cmp_ok($getitem->{'itemnumber'}, '==', $itemnumber, "Retrieved item has correct itemnumber.");
+ cmp_ok($getitem->{'biblioitemnumber'}, '==', $item_bibitemnum, "Retrieved item has correct biblioitemnumber.");
+ is( $getitem->{location}, $location, "The location should not have been modified" );
+ is( $getitem->{permanent_location}, $location, "The permanent_location should have been set to the location value" );
+
+ # Modify item; setting barcode.
+ ModItem({ barcode => '987654321' }, $bibnum, $itemnumber);
+ my $moditem = GetItem($itemnumber);
+ cmp_ok($moditem->{'barcode'}, '==', '987654321', 'Modified item barcode successfully to: '.$moditem->{'barcode'} . '.');
+
+ # Delete item.
+ DelItem({ biblionumber => $bibnum, itemnumber => $itemnumber });
+ my $getdeleted = GetItem($itemnumber);
+ is($getdeleted->{'itemnumber'}, undef, "Item deleted as expected.");
+
+ ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem({ homebranch => $library->{branchcode}, holdingbranch => $library->{branchcode}, location => $location, permanent_location => 'my permanent location' } , $bibnum);
+ $getitem = GetItem($itemnumber);
+ is( $getitem->{location}, $location, "The location should not have been modified" );
+ is( $getitem->{permanent_location}, 'my permanent location', "The permanent_location should not have modified" );
+
+ ModItem({ location => $location }, $bibnum, $itemnumber);
+ $getitem = GetItem($itemnumber);
+ is( $getitem->{location}, $location, "The location should have been set to correct location" );
+ is( $getitem->{permanent_location}, $location, "The permanent_location should have been set to location" );
+
+ ModItem({ location => 'CART' }, $bibnum, $itemnumber);
+ $getitem = GetItem($itemnumber);
+ is( $getitem->{location}, 'CART', "The location should have been set to CART" );
+ is( $getitem->{permanent_location}, $location, "The permanent_location should not have been set to CART" );
+
+ $schema->storage->txn_rollback;
+};
+
+subtest 'GetHiddenItemnumbers tests' => sub {
+
+ plan tests => 9;
+
+ # This sub is controlled by the OpacHiddenItems system preference.
+
+ $schema->storage->txn_begin;
+
+ my $builder = t::lib::TestBuilder->new;
+ my $library1 = $builder->build({
+ source => 'Branch',
+ });
+
+ my $library2 = $builder->build({
+ source => 'Branch',
+ });
+
+ # Create a new biblio
+ t::lib::Mocks::mock_preference('marcflavour', 'MARC21');
+ my ($biblionumber, $biblioitemnumber) = get_biblio();
+
+ # Add two items
+ my ($item1_bibnum, $item1_bibitemnum, $item1_itemnumber) = AddItem(
+ { homebranch => $library1->{branchcode},
+ holdingbranch => $library1->{branchcode},
+ withdrawn => 1 },
+ $biblionumber
+ );
+ my ($item2_bibnum, $item2_bibitemnum, $item2_itemnumber) = AddItem(
+ { homebranch => $library2->{branchcode},
+ holdingbranch => $library2->{branchcode},
+ withdrawn => 0 },
+ $biblionumber
+ );
+
+ my $opachiddenitems;
+ my @itemnumbers = ($item1_itemnumber,$item2_itemnumber);
+ my @hidden;
+ my @items;
+ push @items, GetItem( $item1_itemnumber );
+ push @items, GetItem( $item2_itemnumber );
+
+ # Empty OpacHiddenItems
+ t::lib::Mocks::mock_preference('OpacHiddenItems','');
+ ok( !defined( GetHiddenItemnumbers( @items ) ),
+ "Hidden items list undef if OpacHiddenItems empty");
+
+ # Blank spaces
+ t::lib::Mocks::mock_preference('OpacHiddenItems',' ');
+ ok( scalar GetHiddenItemnumbers( @items ) == 0,
+ "Hidden items list empty if OpacHiddenItems only contains blanks");
+
+ # One variable / value
+ $opachiddenitems = "
+ withdrawn: [1]";
+ t::lib::Mocks::mock_preference( 'OpacHiddenItems', $opachiddenitems );
+ @hidden = GetHiddenItemnumbers( @items );
+ ok( scalar @hidden == 1, "Only one hidden item");
+ is( $hidden[0], $item1_itemnumber, "withdrawn=1 is hidden");
+
+ # One variable, two values
+ $opachiddenitems = "
+ withdrawn: [1,0]";
+ t::lib::Mocks::mock_preference( 'OpacHiddenItems', $opachiddenitems );
+ @hidden = GetHiddenItemnumbers( @items );
+ ok( scalar @hidden == 2, "Two items hidden");
+ is_deeply( \@hidden, \@itemnumbers, "withdrawn=1 and withdrawn=0 hidden");
+
+ # Two variables, a value each
+ $opachiddenitems = "
+ withdrawn: [1]
+ homebranch: [$library2->{branchcode}]
+ ";
+ t::lib::Mocks::mock_preference( 'OpacHiddenItems', $opachiddenitems );
+ @hidden = GetHiddenItemnumbers( @items );
+ ok( scalar @hidden == 2, "Two items hidden");
+ is_deeply( \@hidden, \@itemnumbers, "withdrawn=1 and homebranch library2 hidden");
+
+ # Valid OpacHiddenItems, empty list
+ @items = ();
+ @hidden = GetHiddenItemnumbers( @items );
+ ok( scalar @hidden == 0, "Empty items list, no item hidden");
+
+ $schema->storage->txn_rollback;
+};
+
+subtest 'GetItemsInfo tests' => sub {
+
+ plan tests => 4;
+
+ $schema->storage->txn_begin;
+
+ my $builder = t::lib::TestBuilder->new;
+ my $library1 = $builder->build({
+ source => 'Branch',
+ });
+ my $library2 = $builder->build({
+ source => 'Branch',
+ });
+
+ # Add a biblio
+ my ($biblionumber, $biblioitemnumber) = get_biblio();
+ # Add an item
+ my ($item_bibnum, $item_bibitemnum, $itemnumber)
+ = AddItem({
+ homebranch => $library1->{branchcode},
+ holdingbranch => $library2->{branchcode},
+ }, $biblionumber );
+
+ my $library = Koha::Libraries->find( $library1->{branchcode} );
+ $library->opac_info("homebranch OPAC info");
+ $library->store;
+
+ $library = Koha::Libraries->find( $library2->{branchcode} );
+ $library->opac_info("holdingbranch OPAC info");
+ $library->store;
+
+ my @results = GetItemsInfo( $biblionumber );
+ ok( @results, 'GetItemsInfo returns results');
+ is( $results[0]->{ home_branch_opac_info }, "homebranch OPAC info",
+ 'GetItemsInfo returns the correct home branch OPAC info notice' );
+ is( $results[0]->{ holding_branch_opac_info }, "holdingbranch OPAC info",
+ 'GetItemsInfo returns the correct holding branch OPAC info notice' );
+ is( exists( $results[0]->{ onsite_checkout } ), 1,
+ 'GetItemsInfo returns a onsite_checkout key' );
+
+ $schema->storage->txn_rollback;
+};
+
+subtest q{Test Koha::Database->schema()->resultset('Item')->itemtype()} => sub {
+
+ plan tests => 4;
+
+ $schema->storage->txn_begin;
+
+ my $biblio = $schema->resultset('Biblio')->create({
+ title => "Test title",
+ biblioitems => [ { itemtype => 'BIB_LEVEL' } ],
+ });
+ my $biblioitem = $biblio->biblioitems->first;
+ my $item = $schema->resultset('Item')->create({
+ biblioitemnumber => $biblioitem->biblioitemnumber,
+ biblionumber => $biblio->biblionumber,
+ itype => "ITEM_LEVEL",
+ });
+
+ t::lib::Mocks::mock_preference( 'item-level_itypes', 0 );
+ is( $item->effective_itemtype(), 'BIB_LEVEL', '$item->itemtype() returns biblioitem.itemtype when item-level_itypes is disabled' );
-# Add an item.
-my ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem({ homebranch => 'CPL', holdingbranch => 'CPL' } , $bibnum);
-cmp_ok($item_bibnum, '==', $bibnum, "New item is linked to correct biblionumber.");
-cmp_ok($item_bibitemnum, '==', $bibitemnum, "New item is linked to correct biblioitemnumber.");
+ t::lib::Mocks::mock_preference( 'item-level_itypes', 1 );
+ is( $item->effective_itemtype(), 'ITEM_LEVEL', '$item->itemtype() returns items.itype when item-level_itypes is enabled' );
-# Get item.
-my $getitem = GetItem($itemnumber);
-cmp_ok($getitem->{'itemnumber'}, '==', $itemnumber, "Retrieved item has correct itemnumber.");
-cmp_ok($getitem->{'biblioitemnumber'}, '==', $item_bibnum, "Retrieved item has correct biblioitemnumber.");
+ # If itemtype is not defined and item-level_level item types are set
+ # fallback to biblio-level itemtype (Bug 14651) and warn
+ $item->itype( undef );
+ $item->update();
+ my $effective_itemtype;
+ warning_is { $effective_itemtype = $item->effective_itemtype() }
+ "item-level_itypes set but no itemtype set for item ($item->itemnumber)",
+ '->effective_itemtype() raises a warning when falling back to bib-level';
-# Modify item; setting barcode.
-ModItem({ barcode => '987654321' }, $bibnum, $itemnumber);
-my $moditem = GetItem($itemnumber);
-cmp_ok($moditem->{'barcode'}, '==', '987654321', 'Modified item barcode successfully to: '.$moditem->{'barcode'} . '.');
+ ok( defined $effective_itemtype &&
+ $effective_itemtype eq 'BIB_LEVEL',
+ '$item->effective_itemtype() falls back to biblioitems.itemtype when item-level_itypes is enabled but undef' );
-# Delete item.
-my $dbh = C4::Context->dbh;
-DelItem($dbh, $bibnum, $itemnumber);
-my $getdeleted = GetItem($itemnumber);
-is($getdeleted->{'itemnumber'}, undef, "Item deleted as expected.");
+ $schema->storage->txn_rollback;
+};
+
+subtest 'SearchItems test' => sub {
+ plan tests => 14;
+
+ $schema->storage->txn_begin;
+ my $dbh = C4::Context->dbh;
+ my $builder = t::lib::TestBuilder->new;
+
+ my $library1 = $builder->build({
+ source => 'Branch',
+ });
+ my $library2 = $builder->build({
+ source => 'Branch',
+ });
+
+ t::lib::Mocks::mock_preference('marcflavour', 'MARC21');
+ my $cpl_items_before = SearchItemsByField( 'homebranch', $library1->{branchcode});
+
+ my ($biblionumber) = get_biblio();
+
+ my (undef, $initial_items_count) = SearchItems(undef, {rows => 1});
+
+ # Add two items
+ my (undef, undef, $item1_itemnumber) = AddItem({
+ homebranch => $library1->{branchcode},
+ holdingbranch => $library1->{branchcode},
+ }, $biblionumber);
+ my (undef, undef, $item2_itemnumber) = AddItem({
+ homebranch => $library2->{branchcode},
+ holdingbranch => $library2->{branchcode},
+ }, $biblionumber);
+
+ my ($items, $total_results);
+
+ ($items, $total_results) = SearchItems();
+ is($total_results, $initial_items_count + 2, "Created 2 new items");
+ is(scalar @$items, $total_results, "SearchItems() returns all items");
+
+ ($items, $total_results) = SearchItems(undef, {rows => 1});
+ is($total_results, $initial_items_count + 2);
+ is(scalar @$items, 1, "SearchItems(undef, {rows => 1}) returns only 1 item");
+
+ # Search all items where homebranch = 'CPL'
+ my $filter = {
+ field => 'homebranch',
+ query => $library1->{branchcode},
+ operator => '=',
+ };
+ ($items, $total_results) = SearchItems($filter);
+ ok($total_results > 0, "There is at least one CPL item");
+ my $all_items_are_CPL = 1;
+ foreach my $item (@$items) {
+ if ($item->{homebranch} ne $library1->{branchcode}) {
+ $all_items_are_CPL = 0;
+ last;
+ }
+ }
+ ok($all_items_are_CPL, "All items returned by SearchItems are from CPL");
+
+ # Search all items where homebranch != 'CPL'
+ $filter = {
+ field => 'homebranch',
+ query => $library1->{branchcode},
+ operator => '!=',
+ };
+ ($items, $total_results) = SearchItems($filter);
+ ok($total_results > 0, "There is at least one non-CPL item");
+ my $all_items_are_not_CPL = 1;
+ foreach my $item (@$items) {
+ if ($item->{homebranch} eq $library1->{branchcode}) {
+ $all_items_are_not_CPL = 0;
+ last;
+ }
+ }
+ ok($all_items_are_not_CPL, "All items returned by SearchItems are not from CPL");
+
+ # Search all items where biblio title (245$a) is like 'Silence in the %'
+ $filter = {
+ field => 'marc:245$a',
+ query => 'Silence in the %',
+ operator => 'like',
+ };
+ ($items, $total_results) = SearchItems($filter);
+ ok($total_results >= 2, "There is at least 2 items with a biblio title like 'Silence in the %'");
+
+ # Search all items where biblio title is 'Silence in the library'
+ # and homebranch is 'CPL'
+ $filter = {
+ conjunction => 'AND',
+ filters => [
+ {
+ field => 'marc:245$a',
+ query => 'Silence in the %',
+ operator => 'like',
+ },
+ {
+ field => 'homebranch',
+ query => $library1->{branchcode},
+ operator => '=',
+ },
+ ],
+ };
+ ($items, $total_results) = SearchItems($filter);
+ my $found = 0;
+ foreach my $item (@$items) {
+ if ($item->{itemnumber} == $item1_itemnumber) {
+ $found = 1;
+ last;
+ }
+ }
+ ok($found, "item1 found");
+
+ my ($itemfield) = GetMarcFromKohaField('items.itemnumber', '');
+
+ # Create item subfield 'z' without link
+ $dbh->do('DELETE FROM marc_subfield_structure WHERE tagfield=? AND tagsubfield="z" AND frameworkcode=""', undef, $itemfield);
+ $dbh->do('INSERT INTO marc_subfield_structure (tagfield, tagsubfield, frameworkcode) VALUES (?, "z", "")', undef, $itemfield);
+
+ # Clear cache
+ $C4::Context::context->{marcfromkohafield} = undef;
+ $C4::Biblio::inverted_field_map = undef;
+
+ my $item3_record = new MARC::Record;
+ $item3_record->append_fields(
+ new MARC::Field($itemfield, '', '', 'z' => 'foobar')
+ );
+ my (undef, undef, $item3_itemnumber) = AddItemFromMarc($item3_record,
+ $biblionumber);
+
+ # Search item where item subfield z is "foobar"
+ $filter = {
+ field => 'marc:' . $itemfield . '$z',
+ query => 'foobar',
+ operator => 'like',
+ };
+ ($items, $total_results) = SearchItems($filter);
+ ok(scalar @$items == 1, 'found 1 item with $z = "foobar"');
+
+ # Link $z to items.itemnotes (and make sure there is no other subfields
+ # linked to it)
+ $dbh->do('DELETE FROM marc_subfield_structure WHERE kohafield="items.itemnotes" AND frameworkcode=""', undef, $itemfield);
+ $dbh->do('UPDATE marc_subfield_structure SET kohafield="items.itemnotes" WHERE tagfield=? AND tagsubfield="z" AND frameworkcode=""', undef, $itemfield);
+
+ # Clear cache
+ $C4::Context::context->{marcfromkohafield} = undef;
+ $C4::Biblio::inverted_field_map = undef;
+
+ ModItemFromMarc($item3_record, $biblionumber, $item3_itemnumber);
+
+ # Make sure the link is used
+ my $item3 = GetItem($item3_itemnumber);
+ ok($item3->{itemnotes} eq 'foobar', 'itemnotes eq "foobar"');
+
+ # Do the same search again.
+ # This time it will search in items.itemnotes
+ ($items, $total_results) = SearchItems($filter);
+ ok(scalar @$items == 1, 'found 1 item with itemnotes = "foobar"');
+
+ my $cpl_items_after = SearchItemsByField( 'homebranch', $library1->{branchcode});
+ is( ( scalar( @$cpl_items_after ) - scalar ( @$cpl_items_before ) ), 1, 'SearchItemsByField should return something' );
+
+ $schema->storage->txn_rollback;
+};
+
+subtest 'Koha::Item(s) tests' => sub {
+
+ plan tests => 5;
+
+ $schema->storage->txn_begin();
+
+ my $builder = t::lib::TestBuilder->new;
+ my $library1 = $builder->build({
+ source => 'Branch',
+ });
+ my $library2 = $builder->build({
+ source => 'Branch',
+ });
+
+ # Create a biblio and item for testing
+ t::lib::Mocks::mock_preference('marcflavour', 'MARC21');
+ my ($bibnum, $bibitemnum) = get_biblio();
+ my ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem({ homebranch => $library1->{branchcode}, holdingbranch => $library2->{branchcode} } , $bibnum);
+
+ # Get item.
+ my $item = Koha::Items->find( $itemnumber );
+ is( ref($item), 'Koha::Item', "Got Koha::Item" );
+
+ my $homebranch = $item->home_branch();
+ is( ref($homebranch), 'Koha::Library', "Got Koha::Library from home_branch method" );
+ is( $homebranch->branchcode(), $library1->{branchcode}, "Home branch code matches homebranch" );
+
+ my $holdingbranch = $item->holding_branch();
+ is( ref($holdingbranch), 'Koha::Library', "Got Koha::Library from holding_branch method" );
+ is( $holdingbranch->branchcode(), $library2->{branchcode}, "Home branch code matches holdingbranch" );
+
+ $schema->storage->txn_rollback;
+};
+
+subtest 'C4::Biblio::EmbedItemsInMarcBiblio' => sub {
+ plan tests => 7;
+
+ $schema->storage->txn_begin();
+
+ my $builder = t::lib::TestBuilder->new;
+ my $library1 = $builder->build({
+ source => 'Branch',
+ });
+ my $library2 = $builder->build({
+ source => 'Branch',
+ });
+
+ my ( $biblionumber, $biblioitemnumber ) = get_biblio();
+ my $item_infos = [
+ { homebranch => $library1->{branchcode}, holdingbranch => $library1->{branchcode} },
+ { homebranch => $library1->{branchcode}, holdingbranch => $library1->{branchcode} },
+ { homebranch => $library1->{branchcode}, holdingbranch => $library1->{branchcode} },
+ { homebranch => $library2->{branchcode}, holdingbranch => $library2->{branchcode} },
+ { homebranch => $library2->{branchcode}, holdingbranch => $library2->{branchcode} },
+ { homebranch => $library1->{branchcode}, holdingbranch => $library2->{branchcode} },
+ { homebranch => $library1->{branchcode}, holdingbranch => $library2->{branchcode} },
+ { homebranch => $library1->{branchcode}, holdingbranch => $library2->{branchcode} },
+ ];
+ my $number_of_items = scalar @$item_infos;
+ my $number_of_items_with_homebranch_is_CPL =
+ grep { $_->{homebranch} eq $library1->{branchcode} } @$item_infos;
+
+ my @itemnumbers;
+ for my $item_info (@$item_infos) {
+ my ( undef, undef, $itemnumber ) = AddItem(
+ {
+ homebranch => $item_info->{homebranch},
+ holdingbranch => $item_info->{holdingbanch}
+ },
+ $biblionumber
+ );
+ push @itemnumbers, $itemnumber;
+ }
+
+ # Emptied the OpacHiddenItems pref
+ t::lib::Mocks::mock_preference( 'OpacHiddenItems', '' );
+
+ my ($itemfield) =
+ C4::Biblio::GetMarcFromKohaField( 'items.itemnumber', '' );
+ my $record = C4::Biblio::GetMarcBiblio($biblionumber);
+ warning_is { C4::Biblio::EmbedItemsInMarcBiblio() }
+ { carped => 'EmbedItemsInMarcBiblio: No MARC record passed' },
+ 'Should crap is no record passed.';
+
+ C4::Biblio::EmbedItemsInMarcBiblio( $record, $biblionumber );
+ my @items = $record->field($itemfield);
+ is( scalar @items, $number_of_items, 'Should return all items' );
+
+ C4::Biblio::EmbedItemsInMarcBiblio( $record, $biblionumber,
+ [ $itemnumbers[1], $itemnumbers[3] ] );
+ @items = $record->field($itemfield);
+ is( scalar @items, 2, 'Should return all items present in the list' );
+
+ C4::Biblio::EmbedItemsInMarcBiblio( $record, $biblionumber, undef, 1 );
+ @items = $record->field($itemfield);
+ is( scalar @items, $number_of_items, 'Should return all items for opac' );
+
+ my $opachiddenitems = "
+ homebranch: ['$library1->{branchcode}']";
+ t::lib::Mocks::mock_preference( 'OpacHiddenItems', $opachiddenitems );
+
+ C4::Biblio::EmbedItemsInMarcBiblio( $record, $biblionumber );
+ @items = $record->field($itemfield);
+ is( scalar @items,
+ $number_of_items,
+ 'Even with OpacHiddenItems set, all items should have been embedded' );
+
+ C4::Biblio::EmbedItemsInMarcBiblio( $record, $biblionumber, undef, 1 );
+ @items = $record->field($itemfield);
+ is(
+ scalar @items,
+ $number_of_items - $number_of_items_with_homebranch_is_CPL,
+'For OPAC, the pref OpacHiddenItems should have been take into account. Only items with homebranch ne CPL should have been embedded'
+ );
+
+ $opachiddenitems = "
+ homebranch: ['$library1->{branchcode}', '$library2->{branchcode}']";
+ t::lib::Mocks::mock_preference( 'OpacHiddenItems', $opachiddenitems );
+ C4::Biblio::EmbedItemsInMarcBiblio( $record, $biblionumber, undef, 1 );
+ @items = $record->field($itemfield);
+ is(
+ scalar @items,
+ 0,
+'For OPAC, If all items are hidden, no item should have been embedded'
+ );
-# Delete helper Biblio.
-diag("Deleting biblio testing instance.");
-DelBiblio($bibnum);
+ $schema->storage->txn_rollback;
+};
# Helper method to set up a Biblio.
sub get_biblio {
MARC::Field->new('100', ' ', ' ', a => 'Moffat, Steven'),
MARC::Field->new('245', ' ', ' ', a => 'Silence in the library'),
);
- return ($bibnum, $bibitemnum) = AddBiblio($bib, '');
+ my ($bibnum, $bibitemnum) = AddBiblio($bib, '');
+ return ($bibnum, $bibitemnum);
}
projects / srvgit / blobdiff