use Modern::Perl;
use t::lib::Mocks;
+use t::lib::TestBuilder;
+
use C4::Context;
-use C4::Branch;
-use Test::More tests => 38;
+use Test::More tests => 71;
use MARC::Record;
+
use C4::Biblio;
-use C4::Items;
-use C4::Members;
use C4::Calendar;
+use C4::Items;
+use C4::Reserves qw( AddReserve CalculatePriority ModReserve ToggleSuspend AutoUnsuspendReserves SuspendAll ModReserveMinusPriority AlterPriority CanItemBeReserved CheckReserves );
+use C4::Circulation qw( CanBookBeRenewed );
+use Koha::Biblios;
+use Koha::CirculationRules;
+use Koha::Database;
use Koha::DateUtils qw( dt_from_string output_pref );
+use Koha::Holds;
+use Koha::Checkout;
+use Koha::Item::Transfer::Limits;
+use Koha::Items;
+use Koha::Libraries;
+use Koha::Library::Groups;
+use Koha::Patrons;
BEGIN {
use FindBin;
use lib $FindBin::Bin;
- use_ok('C4::Reserves');
}
-my $dbh = C4::Context->dbh;
+my $schema = Koha::Database->new->schema;
+$schema->storage->txn_begin;
+
+my $builder = t::lib::TestBuilder->new();
+my $dbh = C4::Context->dbh;
-# Start transaction
-$dbh->{AutoCommit} = 0;
-$dbh->{RaiseError} = 1;
+# Create two random branches
+my $branch_1 = $builder->build({ source => 'Branch' })->{ branchcode };
+my $branch_2 = $builder->build({ source => 'Branch' })->{ branchcode };
+
+my $category = $builder->build({ source => 'Category' });
my $borrowers_count = 5;
$dbh->do('DELETE FROM itemtypes');
+$dbh->do('DELETE FROM reserves');
+$dbh->do('DELETE FROM circulation_rules');
my $insert_sth = $dbh->prepare('INSERT INTO itemtypes (itemtype) VALUES (?)');
$insert_sth->execute('CAN');
$insert_sth->execute('CANNOT');
+$insert_sth->execute('DUMMY');
+$insert_sth->execute('ONLY1');
# Setup Test------------------------
-# Create a biblio instance for testing
-my ($bibnum, $title, $bibitemnum) = create_helper_biblio();
+my $biblio = $builder->build_sample_biblio({ itemtype => 'DUMMY' });
# Create item instance for testing.
-my ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem({ homebranch => 'CPL', holdingbranch => 'CPL' } , $bibnum);
+my $itemnumber = $builder->build_sample_item({ library => $branch_1, biblionumber => $biblio->biblionumber })->itemnumber;
# Create some borrowers
my @borrowernumbers;
foreach (1..$borrowers_count) {
- my $borrowernumber = AddMember(
+ my $borrowernumber = Koha::Patron->new({
firstname => 'my firstname',
surname => 'my surname ' . $_,
- categorycode => 'S',
- branchcode => 'CPL',
- );
+ categorycode => $category->{categorycode},
+ branchcode => $branch_1,
+ })->store->borrowernumber;
push @borrowernumbers, $borrowernumber;
}
-my $biblionumber = $bibnum;
-
-my @branches = GetBranchesLoop();
-my $branch = $branches[0][0]{value};
-
# Create five item level holds
foreach my $borrowernumber ( @borrowernumbers ) {
AddReserve(
- $branch,
- $borrowernumber,
- $biblionumber,
- my $constraint = 'a',
- my $bibitems = q{},
- my $priority,
- my $resdate,
- my $expdate,
- my $notes = q{},
- $title,
- my $checkitem = $itemnumber,
- my $found,
+ {
+ branchcode => $branch_1,
+ borrowernumber => $borrowernumber,
+ biblionumber => $biblio->biblionumber,
+ priority => C4::Reserves::CalculatePriority( $biblio->biblionumber ),
+ itemnumber => $itemnumber,
+ }
);
}
+my $holds = $biblio->holds;
+is( $holds->count, $borrowers_count, 'Test GetReserves()' );
+is( $holds->next->priority, 1, "Reserve 1 has a priority of 1" );
+is( $holds->next->priority, 2, "Reserve 2 has a priority of 2" );
+is( $holds->next->priority, 3, "Reserve 3 has a priority of 3" );
+is( $holds->next->priority, 4, "Reserve 4 has a priority of 4" );
+is( $holds->next->priority, 5, "Reserve 5 has a priority of 5" );
-my $reserves = GetReservesFromBiblionumber({ biblionumber => $biblionumber });
-is( scalar(@$reserves), $borrowers_count, "Test GetReserves()" );
-
+my $item = Koha::Items->find( $itemnumber );
+$holds = $item->current_holds;
+my $first_hold = $holds->next;
+my $reservedate = $first_hold->reservedate;
+my $borrowernumber = $first_hold->borrowernumber;
+my $branch_1code = $first_hold->branchcode;
+my $reserve_id = $first_hold->reserve_id;
+is( $reservedate, output_pref({ dt => dt_from_string, dateformat => 'iso', dateonly => 1 }), "holds_placed_today should return a valid reserve date");
+is( $borrowernumber, $borrowernumbers[0], "holds_placed_today should return a valid borrowernumber");
+is( $branch_1code, $branch_1, "holds_placed_today should return a valid branchcode");
+ok($reserve_id, "Test holds_placed_today()");
-my ( $reservedate, $borrowernumber, $branchcode, $reserve_id ) = GetReservesFromItemnumber($itemnumber);
-is( $reservedate, output_pref({ dt => dt_from_string, dateformat => 'iso', dateonly => 1 }), "GetReservesFromItemnumber should return a valid reserve date");
-is( $borrowernumber, $borrowernumbers[0], "GetReservesFromItemnumber should return a valid borrowernumber");
-is( $branchcode, 'CPL', "GetReservesFromItemnumber should return a valid branchcode");
-ok($reserve_id, "Test GetReservesFromItemnumber()");
+my $hold = Koha::Holds->find( $reserve_id );
+ok( $hold, "Koha::Holds found the hold" );
+my $hold_biblio = $hold->biblio();
+ok( $hold_biblio, "Got biblio using biblio() method" );
+ok( $hold_biblio == $hold->biblio(), "biblio method returns stashed biblio" );
+my $hold_item = $hold->item();
+ok( $hold_item, "Got item using item() method" );
+ok( $hold_item == $hold->item(), "item method returns stashed item" );
+my $hold_branch = $hold->branch();
+ok( $hold_branch, "Got branch using branch() method" );
+ok( $hold_branch == $hold->branch(), "branch method returns stashed branch" );
+my $hold_found = $hold->found();
+$hold->set({ found => 'W'})->store();
+is( Koha::Holds->waiting()->count(), 1, "Koha::Holds->waiting returns waiting holds" );
+is( Koha::Holds->unfilled()->count(), 4, "Koha::Holds->unfilled returns unfilled holds" );
+my $patron = Koha::Patrons->find( $borrowernumbers[0] );
+$holds = $patron->holds;
+is( $holds->next->borrowernumber, $borrowernumbers[0], "Test Koha::Patron->holds");
-my ( $reserve ) = GetReservesFromBorrowernumber($borrowernumbers[0]);
-ok( $reserve->{'borrowernumber'} eq $borrowernumbers[0], "Test GetReservesFromBorrowernumber()");
+$holds = $item->current_holds;
+$first_hold = $holds->next;
+$borrowernumber = $first_hold->borrowernumber;
+$branch_1code = $first_hold->branchcode;
+$reserve_id = $first_hold->reserve_id;
-ok( GetReserveCount( $borrowernumbers[0] ), "Test GetReserveCount()" );
-
-
-CancelReserve({ 'reserve_id' => $reserve_id });
-$reserves = GetReservesFromBiblionumber({ biblionumber => $biblionumber });
-is( scalar(@$reserves), $borrowers_count - 1, "Test CancelReserve()" );
-
-
-( $reservedate, $borrowernumber, $branchcode, $reserve_id ) = GetReservesFromItemnumber($itemnumber);
ModReserve({
reserve_id => $reserve_id,
rank => '4',
- branchcode => $branch,
+ branchcode => $branch_1,
itemnumber => $itemnumber,
- suspend_until => C4::Dates->new("2013-01-01","iso")->output(),
+ suspend_until => output_pref( { dt => dt_from_string( "2013-01-01", "iso" ), dateonly => 1 } ),
});
-$reserve = GetReserve( $reserve_id );
-ok( $reserve->{'priority'} eq '4', "Test GetReserve(), priority changed correctly" );
-ok( $reserve->{'suspend'}, "Test GetReserve(), suspend hold" );
-ok( $reserve->{'suspend_until'} eq '2013-01-01 00:00:00', "Test GetReserve(), suspend until date" );
+
+$hold = Koha::Holds->find( $reserve_id );
+ok( $hold->priority eq '4', "Test ModReserve, priority changed correctly" );
+ok( $hold->suspend, "Test ModReserve, suspend hold" );
+is( $hold->suspend_until, '2013-01-01 00:00:00', "Test ModReserve, suspend until date" );
+
+ModReserve({ # call without reserve_id
+ rank => '3',
+ biblionumber => $biblio->biblionumber,
+ itemnumber => $itemnumber,
+ borrowernumber => $borrowernumber,
+});
+$hold = Koha::Holds->find( $reserve_id );
+ok( $hold->priority eq '3', "Test ModReserve, priority changed correctly" );
ToggleSuspend( $reserve_id );
-$reserve = GetReserve( $reserve_id );
-ok( !$reserve->{'suspend'}, "Test ToggleSuspend(), no date" );
+$hold = Koha::Holds->find( $reserve_id );
+ok( ! $hold->suspend, "Test ToggleSuspend(), no date" );
ToggleSuspend( $reserve_id, '2012-01-01' );
-$reserve = GetReserve( $reserve_id );
-ok( $reserve->{'suspend_until'} eq '2012-01-01 00:00:00', "Test ToggleSuspend(), with date" );
+$hold = Koha::Holds->find( $reserve_id );
+is( $hold->suspend_until, '2012-01-01 00:00:00', "Test ToggleSuspend(), with date" );
AutoUnsuspendReserves();
-$reserve = GetReserve( $reserve_id );
-ok( !$reserve->{'suspend'}, "Test AutoUnsuspendReserves()" );
+$hold = Koha::Holds->find( $reserve_id );
+ok( ! $hold->suspend, "Test AutoUnsuspendReserves()" );
-# Add a new hold for the borrower whose hold we canceled earlier, this time at the bib level
-AddReserve(
- $branch,
- $borrowernumber,
- $biblionumber,
- my $constraint = 'a',
- my $bibitems = q{},
- my $priority,
- my $resdate,
- my $expdate,
- my $notes = q{},
- $title,
- my $checkitem,
- my $found,
+SuspendAll(
+ borrowernumber => $borrowernumber,
+ biblionumber => $biblio->biblionumber,
+ suspend => 1,
+ suspend_until => '2012-01-01',
);
-( $reserve ) = GetReservesFromBorrowernumber($borrowernumber);
-my $reserveid = C4::Reserves::GetReserveId(
- {
- biblionumber => $biblionumber,
- borrowernumber => $borrowernumber
- }
-);
-is( $reserveid, $reserve->{reserve_id}, "Test GetReserveId" );
-ModReserveMinusPriority( $itemnumber, $reserve->{'reserve_id'} );
-( $reserve ) = GetReservesFromBorrowernumber($borrowernumber);
-ok( $reserve->{'itemnumber'} eq $itemnumber, "Test ModReserveMinusPriority()" );
+$hold = Koha::Holds->find( $reserve_id );
+is( $hold->suspend, 1, "Test SuspendAll()" );
+is( $hold->suspend_until, '2012-01-01 00:00:00', "Test SuspendAll(), with date" );
+SuspendAll(
+ borrowernumber => $borrowernumber,
+ biblionumber => $biblio->biblionumber,
+ suspend => 0,
+);
+$hold = Koha::Holds->find( $reserve_id );
+is( $hold->suspend, 0, "Test resuming with SuspendAll()" );
+is( $hold->suspend_until, undef, "Test resuming with SuspendAll(), should have no suspend until date" );
-my $reserve2 = GetReserveInfo( $reserve->{'reserve_id'} );
-ok( $reserve->{'reserve_id'} eq $reserve2->{'reserve_id'}, "Test GetReserveInfo()" );
+# Add a new hold for the borrower whose hold we canceled earlier, this time at the bib level
+ AddReserve(
+ {
+ branchcode => $branch_1,
+ borrowernumber => $borrowernumbers[0],
+ biblionumber => $biblio->biblionumber,
+ }
+ );
+$patron = Koha::Patrons->find( $borrowernumber );
+$holds = $patron->holds;
+my $reserveid = Koha::Holds->search({ biblionumber => $biblio->biblionumber, borrowernumber => $borrowernumbers[0] })->next->reserve_id;
+ModReserveMinusPriority( $itemnumber, $reserveid );
+$holds = $patron->holds;
+is( $holds->search({ itemnumber => $itemnumber })->count, 1, "Test ModReserveMinusPriority()" );
-$reserves = GetReservesFromBiblionumber({ biblionumber => $biblionumber, all_dates => 1 });
-$reserve = $reserves->[1];
-AlterPriority( 'top', $reserve->{'reserve_id'} );
-$reserve = GetReserve( $reserve->{'reserve_id'} );
-ok( $reserve->{'priority'} eq '1', "Test AlterPriority(), move to top" );
+$holds = $biblio->holds;
+$hold = $holds->next;
+AlterPriority( 'top', $hold->reserve_id, undef, 2, 1, 6 );
+$hold = Koha::Holds->find( $reserveid );
+is( $hold->priority, '1', "Test AlterPriority(), move to top" );
-AlterPriority( 'down', $reserve->{'reserve_id'} );
-$reserve = GetReserve( $reserve->{'reserve_id'} );
-ok( $reserve->{'priority'} eq '2', "Test AlterPriority(), move down" );
+AlterPriority( 'down', $hold->reserve_id, undef, 2, 1, 6 );
+$hold = Koha::Holds->find( $reserveid );
+is( $hold->priority, '2', "Test AlterPriority(), move down" );
-AlterPriority( 'up', $reserve->{'reserve_id'} );
-$reserve = GetReserve( $reserve->{'reserve_id'} );
-ok( $reserve->{'priority'} eq '1', "Test AlterPriority(), move up" );
+AlterPriority( 'up', $hold->reserve_id, 1, 3, 1, 6 );
+$hold = Koha::Holds->find( $reserveid );
+is( $hold->priority, '1', "Test AlterPriority(), move up" );
-AlterPriority( 'bottom', $reserve->{'reserve_id'} );
-$reserve = GetReserve( $reserve->{'reserve_id'} );
-ok( $reserve->{'priority'} eq '5', "Test AlterPriority(), move to bottom" );
+AlterPriority( 'bottom', $hold->reserve_id, undef, 2, 1, 6 );
+$hold = Koha::Holds->find( $reserveid );
+is( $hold->priority, '6', "Test AlterPriority(), move to bottom" );
# Regression test for bug 2394
#
# Note that canreservefromotherbranches has no effect if
# IndependentBranches is OFF.
-my ($foreign_bibnum, $foreign_title, $foreign_bibitemnum) = create_helper_biblio();
-my ($foreign_item_bibnum, $foreign_item_bibitemnum, $foreign_itemnumber)
- = AddItem({ homebranch => 'MPL', holdingbranch => 'MPL' } , $foreign_bibnum);
-$dbh->do('DELETE FROM issuingrules');
-$dbh->do(
- q{INSERT INTO issuingrules (categorycode, branchcode, itemtype, reservesallowed)
- VALUES (?, ?, ?, ?)},
- {},
- '*', '*', '*', 25
+my $foreign_biblio = $builder->build_sample_biblio({ itemtype => 'DUMMY' });
+my $foreign_itemnumber = $builder->build_sample_item({ library => $branch_2, biblionumber => $foreign_biblio->biblionumber })->itemnumber;
+Koha::CirculationRules->set_rules(
+ {
+ categorycode => undef,
+ branchcode => undef,
+ itemtype => undef,
+ rules => {
+ reservesallowed => 25,
+ holds_per_record => 99,
+ }
+ }
);
-$dbh->do(
- q{INSERT INTO issuingrules (categorycode, branchcode, itemtype, reservesallowed)
- VALUES (?, ?, ?, ?)},
- {},
- '*', '*', 'CANNOT', 0
+Koha::CirculationRules->set_rules(
+ {
+ categorycode => undef,
+ branchcode => undef,
+ itemtype => 'CANNOT',
+ rules => {
+ reservesallowed => 0,
+ holds_per_record => 99,
+ }
+ }
);
# make sure some basic sysprefs are set
-t::lib::Mocks::mock_preference('ReservesControlBranch', 'homebranch');
+t::lib::Mocks::mock_preference('ReservesControlBranch', 'ItemHomeLibrary');
t::lib::Mocks::mock_preference('item-level_itypes', 1);
-# if IndependentBranches is OFF, a CPL patron can reserve an MPL item
+# if IndependentBranches is OFF, a $branch_1 patron can reserve an $branch_2 item
t::lib::Mocks::mock_preference('IndependentBranches', 0);
-ok(
- CanItemBeReserved($borrowernumbers[0], $foreign_itemnumber),
- 'CPL patron allowed to reserve MPL item with IndependentBranches OFF (bug 2394)'
+
+is(
+ CanItemBeReserved($borrowernumbers[0], $foreign_itemnumber)->{status}, 'OK',
+ '$branch_1 patron allowed to reserve $branch_2 item with IndependentBranches OFF (bug 2394)'
);
-# if IndependentBranches is OFF, a CPL patron cannot reserve an MPL item
+# if IndependentBranches is OFF, a $branch_1 patron cannot reserve an $branch_2 item
t::lib::Mocks::mock_preference('IndependentBranches', 1);
t::lib::Mocks::mock_preference('canreservefromotherbranches', 0);
ok(
- ! CanItemBeReserved($borrowernumbers[0], $foreign_itemnumber),
- 'CPL patron NOT allowed to reserve MPL item with IndependentBranches ON ... (bug 2394)'
+ CanItemBeReserved($borrowernumbers[0], $foreign_itemnumber)->{status} eq 'cannotReserveFromOtherBranches',
+ '$branch_1 patron NOT allowed to reserve $branch_2 item with IndependentBranches ON ... (bug 2394)'
);
# ... unless canreservefromotherbranches is ON
t::lib::Mocks::mock_preference('canreservefromotherbranches', 1);
ok(
- CanItemBeReserved($borrowernumbers[0], $foreign_itemnumber),
+ CanItemBeReserved($borrowernumbers[0], $foreign_itemnumber)->{status} eq 'OK',
'... unless canreservefromotherbranches is ON (bug 2394)'
);
-# Regression test for bug 11336
-($bibnum, $title, $bibitemnum) = create_helper_biblio();
-($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem({ homebranch => 'CPL', holdingbranch => 'CPL' } , $bibnum);
-AddReserve(
- $branch,
- $borrowernumbers[0],
- $bibnum,
- 'a',
- '',
- 1,
-);
+{
+ # Regression test for bug 11336 # Test if ModReserve correctly recalculate the priorities
+ $biblio = $builder->build_sample_biblio({ itemtype => 'DUMMY' });
+ $itemnumber = $builder->build_sample_item({ library => $branch_1, biblionumber => $biblio->biblionumber })->itemnumber;
+ my $reserveid1 = AddReserve(
+ {
+ branchcode => $branch_1,
+ borrowernumber => $borrowernumbers[0],
+ biblionumber => $biblio->biblionumber,
+ priority => 1
+ }
+ );
+
+ $itemnumber = $builder->build_sample_item({ library => $branch_1, biblionumber => $biblio->biblionumber })->itemnumber;
+ my $reserveid2 = AddReserve(
+ {
+ branchcode => $branch_1,
+ borrowernumber => $borrowernumbers[1],
+ biblionumber => $biblio->biblionumber,
+ priority => 2
+ }
+ );
-my $reserveid1 = C4::Reserves::GetReserveId(
+ $itemnumber = $builder->build_sample_item({ library => $branch_1, biblionumber => $biblio->biblionumber })->itemnumber;
+ my $reserveid3 = AddReserve(
+ {
+ branchcode => $branch_1,
+ borrowernumber => $borrowernumbers[2],
+ biblionumber => $biblio->biblionumber,
+ priority => 3
+ }
+ );
+
+ my $hhh = Koha::Holds->search({ biblionumber => $biblio->biblionumber });
+ my $hold3 = Koha::Holds->find( $reserveid3 );
+ is( $hold3->priority, 3, "The 3rd hold should have a priority set to 3" );
+ ModReserve({ reserve_id => $reserveid1, rank => 'del' });
+ ModReserve({ reserve_id => $reserveid2, rank => 'del' });
+ is( $hold3->discard_changes->priority, 1, "After ModReserve, the 3rd reserve becomes the first on the waiting list" );
+}
+
+Koha::Items->find($itemnumber)->damaged(1)->store; # FIXME The $itemnumber is a bit confusing here
+t::lib::Mocks::mock_preference( 'AllowHoldsOnDamagedItems', 1 );
+is( CanItemBeReserved( $borrowernumbers[0], $itemnumber)->{status}, 'OK', "Patron can reserve damaged item with AllowHoldsOnDamagedItems enabled" );
+ok( defined( ( CheckReserves($itemnumber) )[1] ), "Hold can be trapped for damaged item with AllowHoldsOnDamagedItems enabled" );
+
+$hold = Koha::Hold->new(
{
- biblionumber => $bibnum,
- borrowernumber => $borrowernumbers[0]
+ borrowernumber => $borrowernumbers[0],
+ itemnumber => $itemnumber,
+ biblionumber => $biblio->biblionumber,
}
+)->store();
+is( CanItemBeReserved( $borrowernumbers[0], $itemnumber )->{status},
+ 'itemAlreadyOnHold',
+ "Patron cannot place a second item level hold for a given item" );
+$hold->delete();
+
+t::lib::Mocks::mock_preference( 'AllowHoldsOnDamagedItems', 0 );
+ok( CanItemBeReserved( $borrowernumbers[0], $itemnumber)->{status} eq 'damaged', "Patron cannot reserve damaged item with AllowHoldsOnDamagedItems disabled" );
+ok( !defined( ( CheckReserves($itemnumber) )[1] ), "Hold cannot be trapped for damaged item with AllowHoldsOnDamagedItems disabled" );
+
+# Items that are not for loan, but holdable should not be trapped until they are available for loan
+t::lib::Mocks::mock_preference( 'TrapHoldsOnOrder', 0 );
+Koha::Items->find($itemnumber)->damaged(0)->notforloan(-1)->store;
+Koha::Holds->search({ biblionumber => $biblio->id })->delete();
+is( CanItemBeReserved( $borrowernumbers[0], $itemnumber)->{status}, 'OK', "Patron can place hold on item that is not for loan but holdable ( notforloan < 0 )" );
+$hold = Koha::Hold->new(
+ {
+ borrowernumber => $borrowernumbers[0],
+ itemnumber => $itemnumber,
+ biblionumber => $biblio->biblionumber,
+ found => undef,
+ priority => 1,
+ reservedate => dt_from_string,
+ branchcode => $branch_1,
+ }
+)->store();
+ok( !defined( ( CheckReserves($itemnumber) )[1] ), "Hold cannot be trapped for item that is not for loan but holdable ( notforloan < 0 )" );
+t::lib::Mocks::mock_preference( 'TrapHoldsOnOrder', 1 );
+ok( defined( ( CheckReserves($itemnumber) )[1] ), "Hold is trapped for item that is not for loan but holdable ( notforloan < 0 )" );
+t::lib::Mocks::mock_preference( 'SkipHoldTrapOnNotForLoanValue', '-1' );
+ok( !defined( ( CheckReserves($itemnumber) )[1] ), "Hold cannot be trapped for item with notforloan value matching SkipHoldTrapOnNotForLoanValue" );
+t::lib::Mocks::mock_preference( 'SkipHoldTrapOnNotForLoanValue', '-1|1' );
+ok( !defined( ( CheckReserves($itemnumber) )[1] ), "Hold cannot be trapped for item with notforloan value matching SkipHoldTrapOnNotForLoanValue" );
+is(
+ CanItemBeReserved( $borrowernumbers[0], $itemnumber)->{status}, 'itemAlreadyOnHold',
+ "cannot request item that you have already reservedd"
+);
+is(
+ CanItemBeReserved( $borrowernumbers[0], $item->itemnumber, undef, { ignore_hold_counts => 1 })->{status}, 'OK',
+ "can request item if we are not checking holds counts, but only if policy allows or forbids it"
);
+$hold->delete();
-($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem({ homebranch => 'CPL', holdingbranch => 'CPL' } , $bibnum);
+# Regression test for bug 9532
+$biblio = $builder->build_sample_biblio({ itemtype => 'CANNOT' });
+$item = $builder->build_sample_item({ library => $branch_1, itype => 'CANNOT', biblionumber => $biblio->biblionumber});
AddReserve(
- $branch,
- $borrowernumbers[1],
- $bibnum,
- 'a',
- '',
- 2,
-);
-my $reserveid2 = C4::Reserves::GetReserveId(
{
- biblionumber => $bibnum,
- borrowernumber => $borrowernumbers[1]
+ branchcode => $branch_1,
+ borrowernumber => $borrowernumbers[0],
+ biblionumber => $biblio->biblionumber,
+ priority => 1,
}
);
+is(
+ CanItemBeReserved( $borrowernumbers[0], $item->itemnumber)->{status}, 'noReservesAllowed',
+ "cannot request item if policy that matches on item-level item type forbids it"
+);
+is(
+ CanItemBeReserved( $borrowernumbers[0], $item->itemnumber, undef, { ignore_hold_counts => 1 })->{status}, 'noReservesAllowed',
+ "cannot request item if policy that matches on item-level item type forbids it even if ignoring counts"
+);
-CancelReserve({ reserve_id => $reserveid1 });
+subtest 'CanItemBeReserved' => sub {
+ plan tests => 2;
-$reserve2 = GetReserve( $reserveid2 );
-is( $reserve2->{priority}, 1, "After cancelreserve, the 2nd reserve becomes the first on the waiting list" );
+ my $itemtype_can = $builder->build({source => "Itemtype"})->{itemtype};
+ my $itemtype_cant = $builder->build({source => "Itemtype"})->{itemtype};
+ my $itemtype_cant_record = $builder->build({source => "Itemtype"})->{itemtype};
-($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem({ homebranch => 'CPL', holdingbranch => 'CPL' } , $bibnum);
-AddReserve(
- $branch,
- $borrowernumbers[0],
- $bibnum,
- 'a',
- '',
- 2,
+ Koha::CirculationRules->set_rules(
+ {
+ categorycode => undef,
+ branchcode => undef,
+ itemtype => $itemtype_cant,
+ rules => {
+ reservesallowed => 0,
+ holds_per_record => 99,
+ }
+ }
+ );
+ Koha::CirculationRules->set_rules(
+ {
+ categorycode => undef,
+ branchcode => undef,
+ itemtype => $itemtype_can,
+ rules => {
+ reservesallowed => 2,
+ holds_per_record => 2,
+ }
+ }
+ );
+ Koha::CirculationRules->set_rules(
+ {
+ categorycode => undef,
+ branchcode => undef,
+ itemtype => $itemtype_cant_record,
+ rules => {
+ reservesallowed => 0,
+ holds_per_record => 0,
+ }
+ }
+ );
+
+ Koha::CirculationRules->set_rules(
+ {
+ branchcode => $branch_1,
+ itemtype => $itemtype_cant,
+ rules => {
+ holdallowed => 0,
+ returnbranch => 'homebranch',
+ }
+ }
+ );
+ Koha::CirculationRules->set_rules(
+ {
+ branchcode => $branch_1,
+ itemtype => $itemtype_can,
+ rules => {
+ holdallowed => 1,
+ returnbranch => 'homebranch',
+ }
+ }
+ );
+
+ subtest 'noReservesAllowed' => sub {
+ plan tests => 5;
+
+ my $biblionumber_cannot = $builder->build_sample_biblio({ itemtype => $itemtype_cant })->biblionumber;
+ my $biblionumber_can = $builder->build_sample_biblio({ itemtype => $itemtype_can })->biblionumber;
+ my $biblionumber_record_cannot = $builder->build_sample_biblio({ itemtype => $itemtype_cant_record })->biblionumber;
+
+ my $itemnumber_1_can = $builder->build_sample_item({ homebranch => $branch_1, holdingbranch => $branch_1, itype => $itemtype_can, biblionumber => $biblionumber_cannot })->itemnumber;
+ my $itemnumber_1_cannot = $builder->build_sample_item({ homebranch => $branch_1, holdingbranch => $branch_1, itype => $itemtype_cant, biblionumber => $biblionumber_cannot })->itemnumber;
+ my $itemnumber_2_can = $builder->build_sample_item({ homebranch => $branch_1, holdingbranch => $branch_1, itype => $itemtype_can, biblionumber => $biblionumber_can })->itemnumber;
+ my $itemnumber_2_cannot = $builder->build_sample_item({ homebranch => $branch_1, holdingbranch => $branch_1, itype => $itemtype_cant, biblionumber => $biblionumber_can })->itemnumber;
+ my $itemnumber_3_cannot = $builder->build_sample_item({ homebranch => $branch_1, holdingbranch => $branch_1, itype => $itemtype_cant_record, biblionumber => $biblionumber_record_cannot })->itemnumber;
+
+ Koha::Holds->search({borrowernumber => $borrowernumbers[0]})->delete;
+
+ t::lib::Mocks::mock_preference('item-level_itypes', 1);
+ is(
+ CanItemBeReserved( $borrowernumbers[0], $itemnumber_2_cannot)->{status}, 'noReservesAllowed',
+ "With item level set, rule from item must be picked (CANNOT)"
+ );
+ is(
+ CanItemBeReserved( $borrowernumbers[0], $itemnumber_1_can)->{status}, 'OK',
+ "With item level set, rule from item must be picked (CAN)"
+ );
+ t::lib::Mocks::mock_preference('item-level_itypes', 0);
+ is(
+ CanItemBeReserved( $borrowernumbers[0], $itemnumber_1_can)->{status}, 'noReservesAllowed',
+ "With biblio level set, rule from biblio must be picked (CANNOT)"
+ );
+ is(
+ CanItemBeReserved( $borrowernumbers[0], $itemnumber_2_cannot)->{status}, 'OK',
+ "With biblio level set, rule from biblio must be picked (CAN)"
+ );
+ is(
+ CanItemBeReserved( $borrowernumbers[0], $itemnumber_3_cannot)->{status}, 'noReservesAllowed',
+ "When no holds allowed and no holds per record allowed should return noReservesAllowed"
+ );
+ };
+
+ subtest 'tooManyHoldsForThisRecord + tooManyReserves + itemAlreadyOnHold' => sub {
+ plan tests => 7;
+
+ my $biblionumber_1 = $builder->build_sample_biblio({ itemtype => $itemtype_can })->biblionumber;
+ my $itemnumber_11 = $builder->build_sample_item({ homebranch => $branch_1, holdingbranch => $branch_1, itype => $itemtype_can, biblionumber => $biblionumber_1 })->itemnumber;
+ my $itemnumber_12 = $builder->build_sample_item({ homebranch => $branch_1, holdingbranch => $branch_1, itype => $itemtype_can, biblionumber => $biblionumber_1 })->itemnumber;
+ my $biblionumber_2 = $builder->build_sample_biblio({ itemtype => $itemtype_can })->biblionumber;
+ my $itemnumber_21 = $builder->build_sample_item({ homebranch => $branch_1, holdingbranch => $branch_1, itype => $itemtype_can, biblionumber => $biblionumber_2 })->itemnumber;
+ my $itemnumber_22 = $builder->build_sample_item({ homebranch => $branch_1, holdingbranch => $branch_1, itype => $itemtype_can, biblionumber => $biblionumber_2 })->itemnumber;
+
+ Koha::Holds->search({borrowernumber => $borrowernumbers[0]})->delete;
+
+ # Biblio-level hold
+ AddReserve({
+ branch => $branch_1,
+ borrowernumber => $borrowernumbers[0],
+ biblionumber => $biblionumber_1,
+ });
+ for my $item_level ( 0..1 ) {
+ t::lib::Mocks::mock_preference('item-level_itypes', $item_level);
+ is(
+ # FIXME This is not really correct, but CanItemBeReserved does not check if biblio-level holds already exist
+ CanItemBeReserved( $borrowernumbers[0], $itemnumber_11)->{status}, 'OK',
+ "A biblio-level hold already exists - another hold can be placed on a specific item item"
+ );
+ }
+
+ Koha::Holds->search({borrowernumber => $borrowernumbers[0]})->delete;
+ # Item-level hold
+ AddReserve({
+ branch => $branch_1,
+ borrowernumber => $borrowernumbers[0],
+ biblionumber => $biblionumber_1,
+ itemnumber => $itemnumber_11,
+ });
+
+ $dbh->do('DELETE FROM circulation_rules');
+ Koha::CirculationRules->set_rules(
+ {
+ categorycode => undef,
+ branchcode => undef,
+ itemtype => undef,
+ rules => {
+ reservesallowed => 5,
+ holds_per_record => 1,
+ }
+ }
+ );
+ is(
+ CanItemBeReserved( $borrowernumbers[0], $itemnumber_12)->{status}, 'tooManyHoldsForThisRecord',
+ "A item-level hold already exists and holds_per_record=1, another hold cannot be placed on this record"
+ );
+ Koha::CirculationRules->set_rules(
+ {
+ categorycode => undef,
+ branchcode => undef,
+ itemtype => undef,
+ rules => {
+ reservesallowed => 1,
+ holds_per_record => 1,
+ }
+ }
+ );
+ is(
+ CanItemBeReserved( $borrowernumbers[0], $itemnumber_12)->{status}, 'tooManyHoldsForThisRecord',
+ "A item-level hold already exists and holds_per_record=1 - tooManyHoldsForThisRecord has priority over tooManyReserves"
+ );
+ Koha::CirculationRules->set_rules(
+ {
+ categorycode => undef,
+ branchcode => undef,
+ itemtype => undef,
+ rules => {
+ reservesallowed => 5,
+ holds_per_record => 2,
+ }
+ }
+ );
+ is(
+ CanItemBeReserved( $borrowernumbers[0], $itemnumber_12)->{status}, 'OK',
+ "A item-level hold already exists but holds_per_record=2- another item-level hold can be placed on this record"
+ );
+
+ AddReserve({
+ branch => $branch_1,
+ borrowernumber => $borrowernumbers[0],
+ biblionumber => $biblionumber_2,
+ itemnumber => $itemnumber_21
+ });
+ Koha::CirculationRules->set_rules(
+ {
+ categorycode => undef,
+ branchcode => undef,
+ itemtype => undef,
+ rules => {
+ reservesallowed => 2,
+ holds_per_record => 2,
+ }
+ }
+ );
+ is(
+ CanItemBeReserved( $borrowernumbers[0], $itemnumber_21)->{status}, 'itemAlreadyOnHold',
+ "A item-level holds already exists on this item, itemAlreadyOnHold should be raised"
+ );
+ is(
+ CanItemBeReserved( $borrowernumbers[0], $itemnumber_22)->{status}, 'tooManyReserves',
+ "This patron has already placed reservesallowed holds, tooManyReserves should be raised"
+ );
+ };
+};
+
+
+# Test branch item rules
+
+$dbh->do('DELETE FROM circulation_rules');
+Koha::CirculationRules->set_rules(
+ {
+ categorycode => undef,
+ branchcode => undef,
+ itemtype => undef,
+ rules => {
+ reservesallowed => 25,
+ holds_per_record => 99,
+ }
+ }
+);
+Koha::CirculationRules->set_rules(
+ {
+ branchcode => $branch_1,
+ itemtype => 'CANNOT',
+ rules => {
+ holdallowed => 'not_allowed',
+ returnbranch => 'homebranch',
+ }
+ }
);
-my $reserveid3 = C4::Reserves::GetReserveId(
+Koha::CirculationRules->set_rules(
{
- biblionumber => $bibnum,
- borrowernumber => $borrowernumbers[0]
+ branchcode => $branch_1,
+ itemtype => 'CAN',
+ rules => {
+ holdallowed => 'from_home_library',
+ returnbranch => 'homebranch',
+ }
}
);
+$biblio = $builder->build_sample_biblio({ itemtype => 'CANNOT' });
+$itemnumber = $builder->build_sample_item({ library => $branch_1, itype => 'CANNOT', biblionumber => $biblio->biblionumber})->itemnumber;
+is(CanItemBeReserved($borrowernumbers[0], $itemnumber)->{status}, 'notReservable',
+ "CanItemBeReserved should return 'notReservable'");
-my $reserve3 = GetReserve( $reserveid3 );
-is( $reserve3->{priority}, 2, "New reserve for patron 0, the reserve has a priority = 2" );
+t::lib::Mocks::mock_preference( 'ReservesControlBranch', 'PatronLibrary' );
+$itemnumber = $builder->build_sample_item({ library => $branch_2, itype => 'CAN', biblionumber => $biblio->biblionumber})->itemnumber;
+is(CanItemBeReserved($borrowernumbers[0], $itemnumber)->{status},
+ 'cannotReserveFromOtherBranches',
+ "CanItemBeReserved should use PatronLibrary rule when ReservesControlBranch set to 'PatronLibrary'");
+t::lib::Mocks::mock_preference( 'ReservesControlBranch', 'ItemHomeLibrary' );
+is(CanItemBeReserved($borrowernumbers[0], $itemnumber)->{status},
+ 'OK',
+ "CanItemBeReserved should use item home library rule when ReservesControlBranch set to 'ItemsHomeLibrary'");
-ModReserve({ reserve_id => $reserveid2, rank => 'del' });
-$reserve3 = GetReserve( $reserveid3 );
-is( $reserve3->{priority}, 1, "After ModReserve, the 3rd reserve becomes the first on the waiting list" );
+$itemnumber = $builder->build_sample_item({ library => $branch_1, itype => 'CAN', biblionumber => $biblio->biblionumber})->itemnumber;
+is(CanItemBeReserved($borrowernumbers[0], $itemnumber)->{status}, 'OK',
+ "CanItemBeReserved should return 'OK'");
-ModItem({ damaged => 1 }, $item_bibnum, $itemnumber);
-C4::Context->set_preference( 'AllowHoldsOnDamagedItems', 1 );
-ok( CanItemBeReserved( $borrowernumbers[0], $itemnumber), "Patron can reserve damaged item with AllowHoldsOnDamagedItems enabled" );
-ok( defined( ( CheckReserves($itemnumber) )[1] ), "Hold can be trapped for damaged item with AllowHoldsOnDamagedItems enabled" );
-C4::Context->set_preference( 'AllowHoldsOnDamagedItems', 0 );
-ok( !CanItemBeReserved( $borrowernumbers[0], $itemnumber), "Patron cannot reserve damaged item with AllowHoldsOnDamagedItems disabled" );
-ok( !defined( ( CheckReserves($itemnumber) )[1] ), "Hold cannot be trapped for damaged item with AllowHoldsOnDamagedItems disabled" );
+# Bug 12632
+t::lib::Mocks::mock_preference( 'item-level_itypes', 1 );
+t::lib::Mocks::mock_preference( 'ReservesControlBranch', 'PatronLibrary' );
-# Regression test for bug 9532
-($bibnum, $title, $bibitemnum) = create_helper_biblio('CANNOT');
-($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem({ homebranch => 'CPL', holdingbranch => 'CPL', itype => 'CANNOT' } , $bibnum);
-AddReserve(
- $branch,
- $borrowernumbers[0],
- $bibnum,
- 'a',
- '',
- 1,
-);
-ok(
- !CanItemBeReserved( $borrowernumbers[0], $itemnumber),
- "cannot request item if policy that matches on item-level item type forbids it"
-);
-ModItem({ itype => 'CAN' }, $item_bibnum, $itemnumber);
-ok(
- CanItemBeReserved( $borrowernumbers[0], $itemnumber),
- "can request item if policy that matches on item type allows it"
-);
+$dbh->do('DELETE FROM reserves');
+$dbh->do('DELETE FROM issues');
+$dbh->do('DELETE FROM items');
+$dbh->do('DELETE FROM biblio');
-t::lib::Mocks::mock_preference('item-level_itypes', 0);
-ModItem({ itype => undef }, $item_bibnum, $itemnumber);
-ok(
- !CanItemBeReserved( $borrowernumbers[0], $itemnumber),
- "cannot request item if policy that matches on bib-level item type forbids it (bug 9532)"
+$biblio = $builder->build_sample_biblio({ itemtype => 'ONLY1' });
+$itemnumber = $builder->build_sample_item({ library => $branch_1, biblionumber => $biblio->biblionumber})->itemnumber;
+
+Koha::CirculationRules->set_rules(
+ {
+ categorycode => undef,
+ branchcode => undef,
+ itemtype => 'ONLY1',
+ rules => {
+ reservesallowed => 1,
+ holds_per_record => 99,
+ }
+ }
);
+is( CanItemBeReserved( $borrowernumbers[0], $itemnumber )->{status},
+ 'OK', 'Patron can reserve item with hold limit of 1, no holds placed' );
-# Test CancelExpiredReserves
-C4::Context->set_preference('ExpireReservesMaxPickUpDelay', 1);
-C4::Context->set_preference('ReservesMaxPickUpDelay', 1);
-
-my ( $sec, $min, $hour, $mday, $mon, $year, $wday, $yday, $isdst ) = localtime(time);
-$year += 1900;
-$mon += 1;
-$reserves = $dbh->selectall_arrayref('SELECT * FROM reserves', { Slice => {} });
-$reserve = $reserves->[0];
-my $calendar = C4::Calendar->new(branchcode => $reserve->{branchcode});
-$calendar->insert_single_holiday(
- day => $mday,
- month => $mon,
- year => $year,
- title => 'Test',
- description => 'Test',
+my $res_id = AddReserve(
+ {
+ branchcode => $branch_1,
+ borrowernumber => $borrowernumbers[0],
+ biblionumber => $biblio->biblionumber,
+ priority => 1,
+ }
);
-$reserve_id = $reserve->{reserve_id};
-$dbh->do("UPDATE reserves SET waitingdate = DATE_SUB( NOW(), INTERVAL 5 DAY ), found = 'W', priority = 0 WHERE reserve_id = ?", undef, $reserve_id );
-C4::Context->set_preference('ExpireReservesOnHolidays', 0);
-CancelExpiredReserves();
-my $count = $dbh->selectrow_array("SELECT COUNT(*) FROM reserves WHERE reserve_id = ?", undef, $reserve_id );
-is( $count, 1, "Waiting reserve beyond max pickup delay *not* canceled on holiday" );
-C4::Context->set_preference('ExpireReservesOnHolidays', 1);
-CancelExpiredReserves();
-$count = $dbh->selectrow_array("SELECT COUNT(*) FROM reserves WHERE reserve_id = ?", undef, $reserve_id );
-is( $count, 0, "Waiting reserve beyond max pickup delay canceled on holiday" );
-
-# Test expirationdate
-$reserve = $reserves->[1];
-$reserve_id = $reserve->{reserve_id};
-$dbh->do("UPDATE reserves SET expirationdate = DATE_SUB( NOW(), INTERVAL 1 DAY ) WHERE reserve_id = ?", undef, $reserve_id );
-CancelExpiredReserves();
-$count = $dbh->selectrow_array("SELECT COUNT(*) FROM reserves WHERE reserve_id = ?", undef, $reserve_id );
-is( $count, 0, "Reserve with manual expiration date canceled correctly" );
-
-# Helper method to set up a Biblio.
-sub create_helper_biblio {
- my $itemtype = shift;
- my $bib = MARC::Record->new();
- my $title = 'Silence in the library';
- $bib->append_fields(
- MARC::Field->new('100', ' ', ' ', a => 'Moffat, Steven'),
- MARC::Field->new('245', ' ', ' ', a => $title),
- MARC::Field->new('942', ' ', ' ', c => $itemtype),
- );
- return ($bibnum, $title, $bibitemnum) = AddBiblio($bib, '');
-}
+
+is( CanItemBeReserved( $borrowernumbers[0], $itemnumber )->{status},
+ 'tooManyReserves', 'Patron cannot reserve item with hold limit of 1, 1 bib level hold placed' );
+is( CanItemBeReserved( $borrowernumbers[0], $itemnumber, undef, { ignore_hold_counts => 1 } )->{status},
+ 'OK', 'Patron can reserve item if checking policy but not counts' );
+
+ #results should be the same for both ReservesControlBranch settings
+t::lib::Mocks::mock_preference( 'ReservesControlBranch', 'ItemHomeLibrary' );
+is( CanItemBeReserved( $borrowernumbers[0], $itemnumber )->{status},
+ 'tooManyReserves', 'Patron cannot reserve item with hold limit of 1, 1 bib level hold placed' );
+#reset for further tests
+t::lib::Mocks::mock_preference( 'ReservesControlBranch', 'PatronLibrary' );
+
+subtest 'Test max_holds per library/patron category' => sub {
+ plan tests => 6;
+
+ $dbh->do('DELETE FROM reserves');
+
+ $biblio = $builder->build_sample_biblio;
+ $itemnumber = $builder->build_sample_item({ library => $branch_1, biblionumber => $biblio->biblionumber})->itemnumber;
+ Koha::CirculationRules->set_rules(
+ {
+ categorycode => undef,
+ branchcode => undef,
+ itemtype => $biblio->itemtype,
+ rules => {
+ reservesallowed => 99,
+ holds_per_record => 99,
+ }
+ }
+ );
+
+ for ( 1 .. 3 ) {
+ AddReserve(
+ {
+ branchcode => $branch_1,
+ borrowernumber => $borrowernumbers[0],
+ biblionumber => $biblio->biblionumber,
+ priority => 1,
+ }
+ );
+ }
+
+ my $count =
+ Koha::Holds->search( { borrowernumber => $borrowernumbers[0] } )->count();
+ is( $count, 3, 'Patron now has 3 holds' );
+
+ my $ret = CanItemBeReserved( $borrowernumbers[0], $itemnumber );
+ is( $ret->{status}, 'OK', 'Patron can place hold with no borrower circ rules' );
+
+ my $rule_all = Koha::CirculationRules->set_rule(
+ {
+ categorycode => $category->{categorycode},
+ branchcode => undef,
+ rule_name => 'max_holds',
+ rule_value => 3,
+ }
+ );
+
+ my $rule_branch = Koha::CirculationRules->set_rule(
+ {
+ branchcode => $branch_1,
+ categorycode => $category->{categorycode},
+ rule_name => 'max_holds',
+ rule_value => 5,
+ }
+ );
+
+ $ret = CanItemBeReserved( $borrowernumbers[0], $itemnumber );
+ is( $ret->{status}, 'OK', 'Patron can place hold with branch/category rule of 5, category rule of 3' );
+
+ $rule_branch->delete();
+
+ $ret = CanItemBeReserved( $borrowernumbers[0], $itemnumber );
+ is( $ret->{status}, 'tooManyReserves', 'Patron cannot place hold with only a category rule of 3' );
+
+ $rule_all->delete();
+ $rule_branch->rule_value(3);
+ $rule_branch->store();
+
+ $ret = CanItemBeReserved( $borrowernumbers[0], $itemnumber );
+ is( $ret->{status}, 'tooManyReserves', 'Patron cannot place hold with only a branch/category rule of 3' );
+
+ $rule_branch->rule_value(5);
+ $rule_branch->update();
+ $rule_branch->rule_value(5);
+ $rule_branch->store();
+
+ $ret = CanItemBeReserved( $borrowernumbers[0], $itemnumber );
+ is( $ret->{status}, 'OK', 'Patron can place hold with branch/category rule of 5, category rule of 5' );
+};
+
+subtest 'Pickup location availability tests' => sub {
+ plan tests => 4;
+
+ $biblio = $builder->build_sample_biblio({ itemtype => 'ONLY1' });
+ $itemnumber = $builder->build_sample_item({ library => $branch_1, biblionumber => $biblio->biblionumber})->itemnumber;
+ #Add a default rule to allow some holds
+
+ Koha::CirculationRules->set_rules(
+ {
+ branchcode => undef,
+ categorycode => undef,
+ itemtype => undef,
+ rules => {
+ reservesallowed => 25,
+ holds_per_record => 99,
+ }
+ }
+ );
+ my $item = Koha::Items->find($itemnumber);
+ my $branch_to = $builder->build({ source => 'Branch' })->{ branchcode };
+ my $library = Koha::Libraries->find($branch_to);
+ $library->pickup_location('1')->store;
+ my $patron = $builder->build({ source => 'Borrower' })->{ borrowernumber };
+
+ t::lib::Mocks::mock_preference('UseBranchTransferLimits', 1);
+ t::lib::Mocks::mock_preference('BranchTransferLimitsType', 'itemtype');
+
+ $library->pickup_location('1')->store;
+ is(CanItemBeReserved($patron, $item->itemnumber, $branch_to)->{status},
+ 'OK', 'Library is a pickup location');
+
+ my $limit = Koha::Item::Transfer::Limit->new({
+ fromBranch => $item->holdingbranch,
+ toBranch => $branch_to,
+ itemtype => $item->effective_itemtype,
+ })->store;
+ is(CanItemBeReserved($patron, $item->itemnumber, $branch_to)->{status},
+ 'cannotBeTransferred', 'Item cannot be transferred');
+ $limit->delete;
+
+ $library->pickup_location('0')->store;
+ is(CanItemBeReserved($patron, $item->itemnumber, $branch_to)->{status},
+ 'libraryNotPickupLocation', 'Library is not a pickup location');
+ is(CanItemBeReserved($patron, $item->itemnumber, 'nonexistent')->{status},
+ 'libraryNotFound', 'Cannot set unknown library as pickup location');
+};
+
+$schema->storage->txn_rollback;
+
+subtest 'CanItemBeReserved / holds_per_day tests' => sub {
+
+ plan tests => 10;
+
+ $schema->storage->txn_begin;
+
+ my $itemtype = $builder->build_object( { class => 'Koha::ItemTypes' } );
+ my $library = $builder->build_object( { class => 'Koha::Libraries' } );
+ my $patron = $builder->build_object( { class => 'Koha::Patrons' } );
+
+ # Create 3 biblios with items
+ my $biblio_1 = $builder->build_sample_biblio({ itemtype => $itemtype->itemtype });
+ my $itemnumber_1 = $builder->build_sample_item({ library => $library->branchcode, biblionumber => $biblio_1->biblionumber})->itemnumber;
+ my $biblio_2 = $builder->build_sample_biblio({ itemtype => $itemtype->itemtype });
+ my $itemnumber_2 = $builder->build_sample_item({ library => $library->branchcode, biblionumber => $biblio_2->biblionumber})->itemnumber;
+ my $biblio_3 = $builder->build_sample_biblio({ itemtype => $itemtype->itemtype });
+ my $itemnumber_3 = $builder->build_sample_item({ library => $library->branchcode, biblionumber => $biblio_3->biblionumber})->itemnumber;
+
+ Koha::CirculationRules->set_rules(
+ {
+ categorycode => '*',
+ branchcode => '*',
+ itemtype => $itemtype->itemtype,
+ rules => {
+ reservesallowed => 1,
+ holds_per_record => 99,
+ holds_per_day => 2
+ }
+ }
+ );
+
+ is_deeply(
+ CanItemBeReserved( $patron->borrowernumber, $itemnumber_1 ),
+ { status => 'OK' },
+ 'Patron can reserve item with hold limit of 1, no holds placed'
+ );
+
+ AddReserve(
+ {
+ branchcode => $library->branchcode,
+ borrowernumber => $patron->borrowernumber,
+ biblionumber => $biblio_1->biblionumber,
+ priority => 1,
+ }
+ );
+
+ is_deeply(
+ CanItemBeReserved( $patron->borrowernumber, $itemnumber_1 ),
+ { status => 'tooManyReserves', limit => 1 },
+ 'Patron cannot reserve item with hold limit of 1, 1 bib level hold placed'
+ );
+
+ # Raise reservesallowed to avoid tooManyReserves from it
+ Koha::CirculationRules->set_rule(
+ {
+
+ categorycode => '*',
+ branchcode => '*',
+ itemtype => $itemtype->itemtype,
+ rule_name => 'reservesallowed',
+ rule_value => 3,
+ }
+ );
+
+ is_deeply(
+ CanItemBeReserved( $patron->borrowernumber, $itemnumber_2 ),
+ { status => 'OK' },
+ 'Patron can reserve item with 2 reserves daily cap'
+ );
+
+ # Add a second reserve
+ my $res_id = AddReserve(
+ {
+ branchcode => $library->branchcode,
+ borrowernumber => $patron->borrowernumber,
+ biblionumber => $biblio_2->biblionumber,
+ priority => 1,
+ }
+ );
+ is_deeply(
+ CanItemBeReserved( $patron->borrowernumber, $itemnumber_2 ),
+ { status => 'tooManyReservesToday', limit => 2 },
+ 'Patron cannot a third item with 2 reserves daily cap'
+ );
+
+ # Update last hold so reservedate is in the past, so 2 holds, but different day
+ $hold = Koha::Holds->find($res_id);
+ my $yesterday = dt_from_string() - DateTime::Duration->new( days => 1 );
+ $hold->reservedate($yesterday)->store;
+
+ is_deeply(
+ CanItemBeReserved( $patron->borrowernumber, $itemnumber_2 ),
+ { status => 'OK' },
+ 'Patron can reserve item with 2 bib level hold placed on different days, 2 reserves daily cap'
+ );
+
+ # Set holds_per_day to 0
+ Koha::CirculationRules->set_rule(
+ {
+
+ categorycode => '*',
+ branchcode => '*',
+ itemtype => $itemtype->itemtype,
+ rule_name => 'holds_per_day',
+ rule_value => 0,
+ }
+ );
+
+
+ # Delete existing holds
+ Koha::Holds->search->delete;
+ is_deeply(
+ CanItemBeReserved( $patron->borrowernumber, $itemnumber_2 ),
+ { status => 'tooManyReservesToday', limit => 0 },
+ 'Patron cannot reserve if holds_per_day is 0 (i.e. 0 is 0)'
+ );
+
+ Koha::CirculationRules->set_rule(
+ {
+
+ categorycode => '*',
+ branchcode => '*',
+ itemtype => $itemtype->itemtype,
+ rule_name => 'holds_per_day',
+ rule_value => undef,
+ }
+ );
+
+ Koha::Holds->search->delete;
+ is_deeply(
+ CanItemBeReserved( $patron->borrowernumber, $itemnumber_2 ),
+ { status => 'OK' },
+ 'Patron can reserve if holds_per_day is undef (i.e. undef is unlimited daily cap)'
+ );
+ AddReserve(
+ {
+ branchcode => $library->branchcode,
+ borrowernumber => $patron->borrowernumber,
+ biblionumber => $biblio_1->biblionumber,
+ priority => 1,
+ }
+ );
+ AddReserve(
+ {
+ branchcode => $library->branchcode,
+ borrowernumber => $patron->borrowernumber,
+ biblionumber => $biblio_2->biblionumber,
+ priority => 1,
+ }
+ );
+
+ is_deeply(
+ CanItemBeReserved( $patron->borrowernumber, $itemnumber_3 ),
+ { status => 'OK' },
+ 'Patron can reserve if holds_per_day is undef (i.e. undef is unlimited daily cap)'
+ );
+ AddReserve(
+ {
+ branchcode => $library->branchcode,
+ borrowernumber => $patron->borrowernumber,
+ biblionumber => $biblio_3->biblionumber,
+ priority => 1,
+ }
+ );
+ is_deeply(
+ CanItemBeReserved( $patron->borrowernumber, $itemnumber_3 ),
+ { status => 'tooManyReserves', limit => 3 },
+ 'Unlimited daily holds, but reached reservesallowed'
+ );
+ #results should be the same for both ReservesControlBranch settings
+ t::lib::Mocks::mock_preference('ReservesControlBranch', 'ItemHomeLibrary');
+ is_deeply(
+ CanItemBeReserved( $patron->borrowernumber, $itemnumber_3 ),
+ { status => 'tooManyReserves', limit => 3 },
+ 'Unlimited daily holds, but reached reservesallowed'
+ );
+
+ $schema->storage->txn_rollback;
+};
+
+subtest 'CanItemBeReserved / branch_not_in_hold_group' => sub {
+ plan tests => 9;
+
+ $schema->storage->txn_begin;
+
+ Koha::CirculationRules->set_rule(
+ {
+ branchcode => undef,
+ categorycode => undef,
+ itemtype => undef,
+ rule_name => 'reservesallowed',
+ rule_value => 25,
+ }
+ );
+
+ # Create item types
+ my $itemtype1 = $builder->build_object( { class => 'Koha::ItemTypes' } );
+ my $itemtype2 = $builder->build_object( { class => 'Koha::ItemTypes' } );
+
+ # Create libraries
+ my $library1 = $builder->build_object( { class => 'Koha::Libraries' } );
+ my $library2 = $builder->build_object( { class => 'Koha::Libraries' } );
+ my $library3 = $builder->build_object( { class => 'Koha::Libraries' } );
+
+ # Create library groups hierarchy
+ my $rootgroup = $builder->build_object( { class => 'Koha::Library::Groups', value => {ft_local_hold_group => 1} } );
+ my $group1 = $builder->build_object( { class => 'Koha::Library::Groups', value => {parent_id => $rootgroup->id, branchcode => $library1->branchcode}} );
+ my $group2 = $builder->build_object( { class => 'Koha::Library::Groups', value => {parent_id => $rootgroup->id, branchcode => $library2->branchcode} } );
+
+ # Create 2 patrons
+ my $patron1 = $builder->build_object( { class => 'Koha::Patrons', value => {branchcode => $library1->branchcode} } );
+ my $patron3 = $builder->build_object( { class => 'Koha::Patrons', value => {branchcode => $library3->branchcode} } );
+
+ # Create 3 biblios with items
+ my $biblio_1 = $builder->build_sample_biblio({ itemtype => $itemtype1->itemtype });
+ my $item_1 = $builder->build_sample_item(
+ {
+ biblionumber => $biblio_1->biblionumber,
+ library => $library1->branchcode
+ }
+ );
+ my $biblio_2 = $builder->build_sample_biblio({ itemtype => $itemtype2->itemtype });
+ my $item_2 = $builder->build_sample_item(
+ {
+ biblionumber => $biblio_2->biblionumber,
+ library => $library2->branchcode
+ }
+ );
+ my $itemnumber_2 = $item_2->itemnumber;
+ my $biblio_3 = $builder->build_sample_biblio({ itemtype => $itemtype1->itemtype });
+ my $item_3 = $builder->build_sample_item(
+ {
+ biblionumber => $biblio_3->biblionumber,
+ library => $library1->branchcode
+ }
+ );
+
+ # Test 1: Patron 3 can place hold
+ is_deeply(
+ CanItemBeReserved( $patron3->borrowernumber, $itemnumber_2 ),
+ { status => 'OK' },
+ 'Patron can place hold if no circ_rules where defined'
+ );
+
+ # Insert default circ rule of holds allowed only from local hold group for all libraries
+ Koha::CirculationRules->set_rules(
+ {
+ branchcode => undef,
+ itemtype => undef,
+ rules => {
+ holdallowed => 'from_local_hold_group',
+ hold_fulfillment_policy => 'any',
+ returnbranch => 'any'
+ }
+ }
+ );
+
+ # Test 2: Patron 1 can place hold
+ is_deeply(
+ CanItemBeReserved( $patron1->borrowernumber, $itemnumber_2 ),
+ { status => 'OK' },
+ 'Patron can place hold because patron\'s home library is part of hold group'
+ );
+
+ # Test 3: Patron 3 cannot place hold
+ is_deeply(
+ CanItemBeReserved( $patron3->borrowernumber, $itemnumber_2 ),
+ { status => 'branchNotInHoldGroup' },
+ 'Patron cannot place hold because patron\'s home library is not part of hold group'
+ );
+
+ # Insert default circ rule to "any" for library 2
+ Koha::CirculationRules->set_rules(
+ {
+ branchcode => $library2->branchcode,
+ itemtype => undef,
+ rules => {
+ holdallowed => 'from_any_library',
+ hold_fulfillment_policy => 'any',
+ returnbranch => 'any'
+ }
+ }
+ );
+
+ # Test 4: Patron 3 can place hold
+ is_deeply(
+ CanItemBeReserved( $patron3->borrowernumber, $itemnumber_2 ),
+ { status => 'OK' },
+ 'Patron can place hold if holdallowed is set to "any" for library 2'
+ );
+
+ # Update default circ rule to "hold group" for library 2
+ Koha::CirculationRules->set_rules(
+ {
+ branchcode => $library2->branchcode,
+ itemtype => undef,
+ rules => {
+ holdallowed => 'from_local_hold_group',
+ hold_fulfillment_policy => 'any',
+ returnbranch => 'any'
+ }
+ }
+ );
+
+ # Test 5: Patron 3 cannot place hold
+ is_deeply(
+ CanItemBeReserved( $patron3->borrowernumber, $itemnumber_2 ),
+ { status => 'branchNotInHoldGroup' },
+ 'Patron cannot place hold if holdallowed is set to "hold group" for library 2'
+ );
+
+ # Insert default item rule to "any" for itemtype 2
+ Koha::CirculationRules->set_rules(
+ {
+ branchcode => $library2->branchcode,
+ itemtype => $itemtype2->itemtype,
+ rules => {
+ holdallowed => 'from_any_library',
+ hold_fulfillment_policy => 'any',
+ returnbranch => 'any'
+ }
+ }
+ );
+
+ # Test 6: Patron 3 can place hold
+ is_deeply(
+ CanItemBeReserved( $patron3->borrowernumber, $itemnumber_2 ),
+ { status => 'OK' },
+ 'Patron can place hold if holdallowed is set to "any" for itemtype 2'
+ );
+
+ # Update default item rule to "hold group" for itemtype 2
+ Koha::CirculationRules->set_rules(
+ {
+ branchcode => $library2->branchcode,
+ itemtype => $itemtype2->itemtype,
+ rules => {
+ holdallowed => 'from_local_hold_group',
+ hold_fulfillment_policy => 'any',
+ returnbranch => 'any'
+ }
+ }
+ );
+
+ # Test 7: Patron 3 cannot place hold
+ is_deeply(
+ CanItemBeReserved( $patron3->borrowernumber, $itemnumber_2 ),
+ { status => 'branchNotInHoldGroup' },
+ 'Patron cannot place hold if holdallowed is set to "hold group" for itemtype 2'
+ );
+
+ # Insert branch item rule to "any" for itemtype 2 and library 2
+ Koha::CirculationRules->set_rules(
+ {
+ branchcode => $library2->branchcode,
+ itemtype => $itemtype2->itemtype,
+ rules => {
+ holdallowed => 'from_any_library',
+ hold_fulfillment_policy => 'any',
+ returnbranch => 'any'
+ }
+ }
+ );
+
+ # Test 8: Patron 3 can place hold
+ is_deeply(
+ CanItemBeReserved( $patron3->borrowernumber, $itemnumber_2 ),
+ { status => 'OK' },
+ 'Patron can place hold if holdallowed is set to "any" for itemtype 2 and library 2'
+ );
+
+ # Update branch item rule to "hold group" for itemtype 2 and library 2
+ Koha::CirculationRules->set_rules(
+ {
+ branchcode => $library2->branchcode,
+ itemtype => $itemtype2->itemtype,
+ rules => {
+ holdallowed => 'from_local_hold_group',
+ hold_fulfillment_policy => 'any',
+ returnbranch => 'any'
+ }
+ }
+ );
+
+ # Test 9: Patron 3 cannot place hold
+ is_deeply(
+ CanItemBeReserved( $patron3->borrowernumber, $itemnumber_2 ),
+ { status => 'branchNotInHoldGroup' },
+ 'Patron cannot place hold if holdallowed is set to "hold group" for itemtype 2 and library 2'
+ );
+
+ $schema->storage->txn_rollback;
+
+};
+
+subtest 'CanItemBeReserved / pickup_not_in_hold_group' => sub {
+ plan tests => 9;
+
+ $schema->storage->txn_begin;
+ Koha::CirculationRules->set_rule(
+ {
+ branchcode => undef,
+ categorycode => undef,
+ itemtype => undef,
+ rule_name => 'reservesallowed',
+ rule_value => 25,
+ }
+ );
+
+ # Create item types
+ my $itemtype1 = $builder->build_object( { class => 'Koha::ItemTypes' } );
+ my $itemtype2 = $builder->build_object( { class => 'Koha::ItemTypes' } );
+
+ # Create libraries
+ my $library1 = $builder->build_object( { class => 'Koha::Libraries', value => {pickup_location => 1} } );
+ my $library2 = $builder->build_object( { class => 'Koha::Libraries', value => {pickup_location => 1} } );
+ my $library3 = $builder->build_object( { class => 'Koha::Libraries', value => {pickup_location => 1} } );
+
+ # Create library groups hierarchy
+ my $rootgroup = $builder->build_object( { class => 'Koha::Library::Groups', value => {ft_local_hold_group => 1} } );
+ my $group1 = $builder->build_object( { class => 'Koha::Library::Groups', value => {parent_id => $rootgroup->id, branchcode => $library1->branchcode}} );
+ my $group2 = $builder->build_object( { class => 'Koha::Library::Groups', value => {parent_id => $rootgroup->id, branchcode => $library2->branchcode} } );
+
+ # Create 2 patrons
+ my $patron1 = $builder->build_object( { class => 'Koha::Patrons', value => {branchcode => $library1->branchcode} } );
+ my $patron3 = $builder->build_object( { class => 'Koha::Patrons', value => {branchcode => $library3->branchcode} } );
+
+ # Create 3 biblios with items
+ my $biblio_1 = $builder->build_sample_biblio({ itemtype => $itemtype1->itemtype });
+ my $item_1 = $builder->build_sample_item(
+ {
+ biblionumber => $biblio_1->biblionumber,
+ library => $library1->branchcode
+ }
+ );
+ my $biblio_2 = $builder->build_sample_biblio({ itemtype => $itemtype2->itemtype });
+ my $item_2 = $builder->build_sample_item(
+ {
+ biblionumber => $biblio_2->biblionumber,
+ library => $library2->branchcode
+ }
+ );
+ my $itemnumber_2 = $item_2->itemnumber;
+ my $biblio_3 = $builder->build_sample_biblio({ itemtype => $itemtype1->itemtype });
+ my $item_3 = $builder->build_sample_item(
+ {
+ biblionumber => $biblio_3->biblionumber,
+ library => $library1->branchcode
+ }
+ );
+
+ # Test 1: Patron 3 can place hold
+ is_deeply(
+ CanItemBeReserved( $patron3->borrowernumber, $itemnumber_2, $library3->branchcode ),
+ { status => 'OK' },
+ 'Patron can place hold if no circ_rules where defined'
+ );
+
+ # Insert default circ rule of holds allowed only from local hold group for all libraries
+ Koha::CirculationRules->set_rules(
+ {
+ branchcode => undef,
+ itemtype => undef,
+ rules => {
+ holdallowed => 'from_any_library',
+ hold_fulfillment_policy => 'holdgroup',
+ returnbranch => 'any'
+ }
+ }
+ );
+
+ # Test 2: Patron 1 can place hold
+ is_deeply(
+ CanItemBeReserved( $patron3->borrowernumber, $itemnumber_2, $library1->branchcode ),
+ { status => 'OK' },
+ 'Patron can place hold because pickup location is part of hold group'
+ );
+
+ # Test 3: Patron 3 cannot place hold
+ is_deeply(
+ CanItemBeReserved( $patron3->borrowernumber, $itemnumber_2, $library3->branchcode ),
+ { status => 'pickupNotInHoldGroup' },
+ 'Patron cannot place hold because pickup location is not part of hold group'
+ );
+
+ # Insert default circ rule to "any" for library 2
+ Koha::CirculationRules->set_rules(
+ {
+ branchcode => $library2->branchcode,
+ itemtype => undef,
+ rules => {
+ holdallowed => 'from_any_library',
+ hold_fulfillment_policy => 'any',
+ returnbranch => 'any'
+ }
+ }
+ );
+
+ # Test 4: Patron 3 can place hold
+ is_deeply(
+ CanItemBeReserved( $patron3->borrowernumber, $itemnumber_2, $library3->branchcode ),
+ { status => 'OK' },
+ 'Patron can place hold if default_branch_circ_rules is set to "any" for library 2'
+ );
+
+ # Update default circ rule to "hold group" for library 2
+ Koha::CirculationRules->set_rules(
+ {
+ branchcode => $library2->branchcode,
+ itemtype => undef,
+ rules => {
+ holdallowed => 'from_any_library',
+ hold_fulfillment_policy => 'holdgroup',
+ returnbranch => 'any'
+ }
+ }
+ );
+
+ # Test 5: Patron 3 cannot place hold
+ is_deeply(
+ CanItemBeReserved( $patron3->borrowernumber, $itemnumber_2, $library3->branchcode ),
+ { status => 'pickupNotInHoldGroup' },
+ 'Patron cannot place hold if hold_fulfillment_policy is set to "hold group" for library 2'
+ );
+
+ # Insert default item rule to "any" for itemtype 2
+ Koha::CirculationRules->set_rules(
+ {
+ branchcode => $library2->branchcode,
+ itemtype => $itemtype2->itemtype,
+ rules => {
+ holdallowed => 'from_any_library',
+ hold_fulfillment_policy => 'any',
+ returnbranch => 'any'
+ }
+ }
+ );
+
+ # Test 6: Patron 3 can place hold
+ is_deeply(
+ CanItemBeReserved( $patron3->borrowernumber, $itemnumber_2, $library3->branchcode ),
+ { status => 'OK' },
+ 'Patron can place hold if hold_fulfillment_policy is set to "any" for itemtype 2'
+ );
+
+ # Update default item rule to "hold group" for itemtype 2
+ Koha::CirculationRules->set_rules(
+ {
+ branchcode => $library2->branchcode,
+ itemtype => $itemtype2->itemtype,
+ rules => {
+ holdallowed => 'from_any_library',
+ hold_fulfillment_policy => 'holdgroup',
+ returnbranch => 'any'
+ }
+ }
+ );
+
+ # Test 7: Patron 3 cannot place hold
+ is_deeply(
+ CanItemBeReserved( $patron3->borrowernumber, $itemnumber_2, $library3->branchcode ),
+ { status => 'pickupNotInHoldGroup' },
+ 'Patron cannot place hold if hold_fulfillment_policy is set to "hold group" for itemtype 2'
+ );
+
+ # Insert branch item rule to "any" for itemtype 2 and library 2
+ Koha::CirculationRules->set_rules(
+ {
+ branchcode => $library2->branchcode,
+ itemtype => $itemtype2->itemtype,
+ rules => {
+ holdallowed => 'from_any_library',
+ hold_fulfillment_policy => 'any',
+ returnbranch => 'any'
+ }
+ }
+ );
+
+ # Test 8: Patron 3 can place hold
+ is_deeply(
+ CanItemBeReserved( $patron3->borrowernumber, $itemnumber_2, $library3->branchcode ),
+ { status => 'OK' },
+ 'Patron can place hold if hold_fulfillment_policy is set to "any" for itemtype 2 and library 2'
+ );
+
+ # Update branch item rule to "hold group" for itemtype 2 and library 2
+ Koha::CirculationRules->set_rules(
+ {
+ branchcode => $library2->branchcode,
+ itemtype => $itemtype2->itemtype,
+ rules => {
+ holdallowed => 'from_any_library',
+ hold_fulfillment_policy => 'holdgroup',
+ returnbranch => 'any'
+ }
+ }
+ );
+
+ # Test 9: Patron 3 cannot place hold
+ is_deeply(
+ CanItemBeReserved( $patron3->borrowernumber, $itemnumber_2, $library3->branchcode ),
+ { status => 'pickupNotInHoldGroup' },
+ 'Patron cannot place hold if hold_fulfillment_policy is set to "hold group" for itemtype 2 and library 2'
+ );
+
+ $schema->storage->txn_rollback;
+};
+
+subtest 'non priority holds' => sub {
+
+ plan tests => 6;
+
+ $schema->storage->txn_begin;
+
+ Koha::CirculationRules->set_rules(
+ {
+ branchcode => undef,
+ categorycode => undef,
+ itemtype => undef,
+ rules => {
+ renewalsallowed => 5,
+ reservesallowed => 5,
+ }
+ }
+ );
+
+ my $item = $builder->build_sample_item;
+
+ my $patron1 = $builder->build_object(
+ {
+ class => 'Koha::Patrons',
+ value => { branchcode => $item->homebranch }
+ }
+ );
+ my $patron2 = $builder->build_object(
+ {
+ class => 'Koha::Patrons',
+ value => { branchcode => $item->homebranch }
+ }
+ );
+
+ Koha::Checkout->new(
+ {
+ borrowernumber => $patron1->borrowernumber,
+ itemnumber => $item->itemnumber,
+ branchcode => $item->homebranch
+ }
+ )->store;
+
+ my $hid = AddReserve(
+ {
+ branchcode => $item->homebranch,
+ borrowernumber => $patron2->borrowernumber,
+ biblionumber => $item->biblionumber,
+ priority => 1,
+ itemnumber => $item->itemnumber,
+ }
+ );
+
+ my ( $ok, $err ) =
+ CanBookBeRenewed( $patron1->borrowernumber, $item->itemnumber );
+
+ ok( !$ok, 'Cannot renew' );
+ is( $err, 'on_reserve', 'Item is on hold' );
+
+ my $hold = Koha::Holds->find($hid);
+ $hold->non_priority(1)->store;
+
+ ( $ok, $err ) =
+ CanBookBeRenewed( $patron1->borrowernumber, $item->itemnumber );
+
+ ok( $ok, 'Can renew' );
+ is( $err, undef, 'Item is on non priority hold' );
+
+ my $patron3 = $builder->build_object(
+ {
+ class => 'Koha::Patrons',
+ value => { branchcode => $item->homebranch }
+ }
+ );
+
+ # Add second hold with non_priority = 0
+ AddReserve(
+ {
+ branchcode => $item->homebranch,
+ borrowernumber => $patron3->borrowernumber,
+ biblionumber => $item->biblionumber,
+ priority => 2,
+ itemnumber => $item->itemnumber,
+ }
+ );
+
+ ( $ok, $err ) =
+ CanBookBeRenewed( $patron1->borrowernumber, $item->itemnumber );
+
+ ok( !$ok, 'Cannot renew' );
+ is( $err, 'on_reserve', 'Item is on hold' );
+
+ $schema->storage->txn_rollback;
+
+};
+
+subtest 'CanItemBeReserved rule precedence tests' => sub {
+
+ plan tests => 3;
+
+ t::lib::Mocks::mock_preference('ReservesControlBranch', 'ItemHomeLibrary');
+ $schema->storage->txn_begin;
+ my $library = $builder->build_object( { class => 'Koha::Libraries', value => {
+ pickup_location => 1,
+ }});
+ my $item = $builder->build_sample_item({
+ homebranch => $library->branchcode,
+ holdingbranch => $library->branchcode
+ });
+ my $item2 = $builder->build_sample_item({
+ homebranch => $library->branchcode,
+ holdingbranch => $library->branchcode,
+ itype => $item->itype
+ });
+ my $patron = $builder->build_object({ class => 'Koha::Patrons', value => {
+ branchcode => $library->branchcode
+ }});
+ Koha::CirculationRules->set_rules(
+ {
+ branchcode => undef,
+ categorycode => $patron->categorycode,
+ itemtype => $item->itype,
+ rules => {
+ reservesallowed => 1,
+ }
+ }
+ );
+ is_deeply(
+ CanItemBeReserved( $patron->borrowernumber, $item->itemnumber, $library->branchcode ),
+ { status => 'OK' },
+ 'Patron of specified category can place 1 hold on specified itemtype'
+ );
+ my $hold = $builder->build_object({ class => 'Koha::Holds', value => {
+ biblionumber => $item2->biblionumber,
+ itemnumber => $item2->itemnumber,
+ found => undef,
+ priority => 1,
+ branchcode => $library->branchcode,
+ borrowernumber => $patron->borrowernumber,
+ }});
+ is_deeply(
+ CanItemBeReserved( $patron->borrowernumber, $item->itemnumber, $library->branchcode ),
+ { status => 'tooManyReserves', limit => 1 },
+ 'Patron of specified category can place 1 hold on specified itemtype, cannot place a second'
+ );
+ Koha::CirculationRules->set_rules(
+ {
+ branchcode => $library->branchcode,
+ categorycode => undef,
+ itemtype => undef,
+ rules => {
+ reservesallowed => 2,
+ }
+ }
+ );
+ is_deeply(
+ CanItemBeReserved( $patron->borrowernumber, $item->itemnumber, $library->branchcode ),
+ { status => 'OK' },
+ 'Patron of specified category can place 1 hold on specified itemtype if library rule for all types and categories set to 2'
+ );
+
+ $schema->storage->txn_rollback;
+
+};
projects / srvgit / blobdiff