use Koha::Database;
use Koha::Libraries;
use Koha::Patrons;
+use Koha::Holds;
use Koha::Item;
use Koha::DateUtils;
use t::lib::TestBuilder;
-use Test::More tests => 32;
+use Test::More tests => 29;
use Test::Warn;
use_ok('Koha::Hold');
ok( $hold_borrower, 'Got hold borrower' );
is( $hold_borrower->borrowernumber(), $borrower->{borrowernumber}, 'Hold borrower matches correct borrower' );
-t::lib::Mocks::mock_preference( 'ReservesMaxPickUpDelay', '' );
-$dt = $hold->waiting_expires_on();
-is( $dt, undef, "Koha::Hold->waiting_expires_on returns undef if ReservesMaxPickUpDelay is not set" );
-
is( $hold->is_waiting, 1, 'The hold is waiting' );
is( $hold->is_found, 1, 'The hold is found');
ok( !$hold->is_in_transit, 'The hold is not in transit' );
t::lib::Mocks::mock_preference( 'ReservesMaxPickUpDelay', '5' );
-$dt = $hold->waiting_expires_on();
-is( $dt->ymd, "2000-01-06",
- "Koha::Hold->waiting_expires_on returns DateTime of waitingdate + ReservesMaxPickUpDelay if set" );
-
$hold->found('T');
-$dt = $hold->waiting_expires_on();
-is( $dt, undef, "Koha::Hold->waiting_expires_on returns undef if found is not 'W' ( Set to 'T' )" );
isnt( $hold->is_waiting, 1, 'The hold is not waiting (T)' );
is( $hold->is_found, 1, 'The hold is found');
is( $hold->is_in_transit, 1, 'The hold is in transit' );
$hold->found(q{});
-$dt = $hold->waiting_expires_on();
-is( $dt, undef, "Koha::Hold->waiting_expires_on returns undef if found is not 'W' ( Set to empty string )" );
isnt( $hold->is_waiting, 1, 'The hold is not waiting (W)' );
is( $hold->is_found, 0, 'The hold is not found' );
ok( !$hold->is_in_transit, 'The hold is not in transit' );
$schema->storage->txn_rollback();
-1;
+subtest "delete() tests" => sub {
+
+ plan tests => 6;
+
+ $schema->storage->txn_begin();
+
+ # Disable logging
+ t::lib::Mocks::mock_preference( 'HoldsLog', 0 );
+
+ my $hold = $builder->build({ source => 'Reserve' });
+
+ my $hold_object = Koha::Holds->find( $hold->{ reserve_id } );
+ my $deleted = $hold_object->delete;
+ is( $deleted, 1, 'Koha::Hold->delete should return 1 if the hold has been correctly deleted' );
+ is( Koha::Holds->search({ reserve_id => $hold->{ reserve_id } })->count, 0,
+ "Koha::Hold->delete should have deleted the hold" );
+
+ my $number_of_logs = $schema->resultset('ActionLog')->search(
+ { module => 'HOLDS', action => 'DELETE', object => $hold->{ reserve_id } } )->count;
+ is( $number_of_logs, 0, 'With HoldsLogs, Koha::Hold->delete shouldn\'t have been logged' );
+
+ # Enable logging
+ t::lib::Mocks::mock_preference( 'HoldsLog', 1 );
+
+ $hold = $builder->build({ source => 'Reserve' });
+
+ $hold_object = Koha::Holds->find( $hold->{ reserve_id } );
+ $deleted = $hold_object->delete;
+ is( $deleted, 1, 'Koha::Hold->delete should return 1 if the hold has been correctly deleted' );
+ is( Koha::Holds->search({ reserve_id => $hold->{ reserve_id } })->count, 0,
+ "Koha::Hold->delete should have deleted the hold" );
+
+ $number_of_logs = $schema->resultset('ActionLog')->search(
+ { module => 'HOLDS', action => 'DELETE', object => $hold->{ reserve_id } } )->count;
+ is( $number_of_logs, 1, 'With HoldsLogs, Koha::Hold->delete should have been logged' );
+
+ $schema->storage->txn_rollback();
+ };
+