print notice that member returned all books

[koha_fer] / t / db_dependent / CourseReserves.t

diff --git a/t/db_dependent/CourseReserves.t b/t/db_dependent/CourseReserves.t
index d052a44..ddb6ad9 100755 (executable)
--- a/t/db_dependent/CourseReserves.t
+++ b/t/db_dependent/CourseReserves.t
@@ -3,29 +3,37 @@
 # This is to test C4/Members
 # It requires a working Koha database with the sample data
 
-use strict;
-use warnings;
+use Modern::Perl;
 
-use Test::More tests => 16;
-use Data::Dumper;
+use Test::More tests => 21;
 
 BEGIN {
+    use_ok('C4::Biblio');
     use_ok('C4::Context');
-    use_ok('C4::CourseReserves');
+    use_ok('C4::CourseReserves', qw/:all/);
+    use_ok('C4::Items', qw(AddItem));
+    use_ok('MARC::Field');
+    use_ok('MARC::Record');
 }
 
 my $dbh = C4::Context->dbh;
-$dbh->do("TRUNCATE TABLE course_instructors");
-$dbh->do("TRUNCATE TABLE courses");
-$dbh->do("TRUNCATE TABLE course_reserves");
+
+# Start transaction
+$dbh->{AutoCommit} = 0;
+$dbh->{RaiseError} = 1;
 
 my $sth = $dbh->prepare("SELECT * FROM borrowers ORDER BY RAND() LIMIT 10");
 $sth->execute();
 my @borrowers = @{ $sth->fetchall_arrayref( {} ) };
 
-$sth = $dbh->prepare("SELECT * FROM items ORDER BY RAND() LIMIT 10");
-$sth->execute();
-my @items = @{ $sth->fetchall_arrayref( {} ) };
+# Create the item
+my $record = MARC::Record->new();
+$record->append_fields(
+    MARC::Field->new( '952', '0', '0', a => 'CPL', b => 'CPL' )
+);
+my ( $biblionumber, $biblioitemnumber ) = C4::Biblio::AddBiblio($record, '');
+my @iteminfo = C4::Items::AddItem( { homebranch => 'CPL', holdingbranch => 'CPL' }, $biblionumber );
+my $itemnumber = $iteminfo[2];
 
 my $course_id = ModCourse(
     course_name => "Test Course",
@@ -46,7 +54,9 @@ ok( $course->{'course_name'} eq "Test Course",       "GetCourse returned correct
 ok( $course->{'staff_note'}  eq "Test staff note 2", "ModCourse updated course succesfully" );
 
 my $courses = GetCourses();
-ok( $courses->[0]->{'course_name'} eq "Test Course", "GetCourses returns valid array of course data" );
+is( ref($courses), 'ARRAY', "GetCourses returns an array" );
+my @match = map {$_->{course_name} eq 'Test Course'} @$courses;
+ok( scalar(@match) > 0, "GetCourses returns valid array of course data" );
 
 ModCourseInstructors( mode => 'add', course_id => $course_id, borrowernumbers => [ $borrowers[0]->{'borrowernumber'} ] );
 $course = GetCourse($course_id);
@@ -55,11 +65,11 @@ ok( $course->{'instructors'}->[0]->{'borrowernumber'} == $borrowers[0]->{'borrow
 my $course_instructors = GetCourseInstructors($course_id);
 ok( $course_instructors->[0]->{'borrowernumber'} eq $borrowers[0]->{'borrowernumber'}, "GetCourseInstructors returns valid data" );
 
-my $ci_id = ModCourseItem( 'itemnumber' => $items[0]->{'itemnumber'} );
+my $ci_id = ModCourseItem( 'itemnumber' => $itemnumber );
 ok( $ci_id, "ModCourseItem returned valid data" );
 
 my $course_item = GetCourseItem( 'ci_id' => $ci_id );
-ok( $course_item->{'itemnumber'} eq $items[0]->{'itemnumber'}, "GetCourseItem returns valid data" );
+ok( $course_item->{'itemnumber'} eq $itemnumber, "GetCourseItem returns valid data" );
 
 my $cr_id = ModCourseReserve( 'course_id' => $course_id, 'ci_id' => $ci_id );
 ok( $cr_id, "ModCourseReserve returns valid data" );
@@ -70,8 +80,8 @@ ok( $course_reserve->{'cr_id'} eq $cr_id, "GetCourseReserve returns valid data"
 my $course_reserves = GetCourseReserves( 'course_id' => $course_id );
 ok( $course_reserves->[0]->{'ci_id'} eq $ci_id, "GetCourseReserves returns valid data." );
 
-my $info = GetItemReservesInfo( itemnumber => $items[0]->{'itemnumber'} );
-ok( $info->[0]->{'itemnumber'} eq $items[0]->{'itemnumber'}, "GetItemReservesInfo returns valid data." );
+my $info = GetItemCourseReservesInfo( itemnumber => $itemnumber );
+ok( $info->[0]->{'itemnumber'} eq $itemnumber, "GetItemReservesInfo returns valid data." );
 
 DelCourseReserve( 'cr_id' => $cr_id );
 $course_reserve = GetCourseReserve( 'cr_id' => $cr_id );
@@ -81,8 +91,4 @@ DelCourse($course_id);
 $course = GetCourse($course_id);
 ok( !defined( $course->{'course_id'} ), "DelCourse deleted course successfully" );
 
-$dbh->do("TRUNCATE TABLE course_instructors");
-$dbh->do("TRUNCATE TABLE courses");
-$dbh->do("TRUNCATE TABLE course_reserves");
-
-exit;
+$dbh->rollback;