Bug 11229: Make the tests pass even if issues exist in the DB

[koha-ffzg.git] / t / db_dependent / Circulation_transfers.t

diff --git a/t/db_dependent/Circulation_transfers.t b/t/db_dependent/Circulation_transfers.t
index 5328bde..0c92222 100644 (file)
--- a/t/db_dependent/Circulation_transfers.t
+++ b/t/db_dependent/Circulation_transfers.t
@@ -9,7 +9,8 @@ use C4::Circulation;
 use Koha::DateUtils;
 use DateTime::Duration;
 
-use Test::More tests => 19;
+use Test::More tests => 22;
+use Test::Deep;
 
 BEGIN {
     use_ok('C4::Circulation');
@@ -140,13 +141,10 @@ is(CreateBranchTransferLimit(undef,$samplebranch2->{branchcode}),undef,
 #is(CreateBranchTransferLimit(-1,-1,'CODE'),0,"With wrong CreateBranchTransferLimit returns 0 - No transfertlimit added");
 
 #Test GetTransfers
-my $dt_today = dt_from_string( undef, 'sql', undef );
-my $today = $dt_today->strftime("%Y-%m-%d %H:%M:%S");
-
 my @transfers = GetTransfers($item_id1);
-is_deeply(
+cmp_deeply(
     \@transfers,
-    [ $today, $samplebranch1->{branchcode}, $samplebranch2->{branchcode} ],
+    [ re('^\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}$'), $samplebranch1->{branchcode}, $samplebranch2->{branchcode} ],
     "Transfers of the item1"
 );    #NOTE: Only the first transfer is returned
 @transfers = GetTransfers;
@@ -159,17 +157,17 @@ is_deeply( \@transfers, [],
 #Test GetTransfersFromTo
 my @transferfrom1to2 = GetTransfersFromTo( $samplebranch1->{branchcode},
     $samplebranch2->{branchcode} );
-is_deeply(
+cmp_deeply(
     \@transferfrom1to2,
     [
         {
             itemnumber => $item_id1,
-            datesent   => $today,
+            datesent   => re('^\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}$'),
             frombranch => $samplebranch1->{branchcode}
         },
         {
             itemnumber => $item_id2,
-            datesent   => $today,
+            datesent   => re('^\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}$'),
             frombranch => $samplebranch1->{branchcode}
         }
     ],
@@ -200,5 +198,16 @@ is( C4::Circulation::DeleteTransfer($item_id1),
 is(C4::Circulation::DeleteTransfer(),undef,"Without itemid DeleteTransfer returns undef");
 is(C4::Circulation::DeleteTransfer(-1),'0E0',"with a wrong itemid DeleteTranfer returns 0E0");
 
+#Test TransferSlip
+is( C4::Circulation::TransferSlip($samplebranch1->{branchcode}, undef, 5, $samplebranch2->{branchcode}),
+    undef, "No tranferslip if invalid or undef itemnumber or barcode" );
+is( C4::Circulation::TransferSlip($samplebranch1->{branchcode}, $item_id1, 1, $samplebranch2->{branchcode})->{'code'},
+    'TRANSFERSLIP', "Get a transferslip on valid itemnumber and/or barcode" );
+cmp_deeply(
+    C4::Circulation::TransferSlip($samplebranch1->{branchcode}, $item_id1, undef, $samplebranch2->{branchcode}),
+    C4::Circulation::TransferSlip($samplebranch1->{branchcode}, undef, 1, $samplebranch2->{branchcode}),
+    "Barcode and itemnumber for same item both generate same TransferSlip"
+    );
+
 #End transaction
 $dbh->rollback;