Bug 12554: (tests followup) need to mock GetCurrency

[srvgit] / t / db_dependent / Biblio.t

diff --git a/t/db_dependent/Biblio.t b/t/db_dependent/Biblio.t
index 2dd8034..901f761 100755 (executable)
--- a/t/db_dependent/Biblio.t
+++ b/t/db_dependent/Biblio.t
@@ -17,11 +17,11 @@
 
 use Modern::Perl;
 
-use Test::More tests => 3;
+use Test::More tests => 4;
 use Test::MockModule;
-use Data::Dumper;
 
 use MARC::Record;
+use t::lib::Mocks qw( mock_preference );
 
 BEGIN {
     use_ok('C4::Biblio');
@@ -32,14 +32,17 @@ my $dbh = C4::Context->dbh;
 $dbh->{AutoCommit} = 0;
 $dbh->{RaiseError} = 1;
 
-my $global_marcflavour;
 # Mocking variables
-my $original_preference = C4::Context->can( 'preference' );
-my $context             = new Test::MockModule('C4::Context');
+my $context = new Test::MockModule('C4::Context');
 
-mock_preference();
 mock_marcfromkohafield();
 
+my $currency = new Test::MockModule('C4::Budgets');
+$currency->mock( 'GetCurrency', sub {
+    return { symbol   => '$',   isocode  => 'USD',
+             currency => 'USD', active => 1 };
+});
+
 sub run_tests {
 
     # Undef C4::Biblio::inverted_field_map to avoid problems introduced
@@ -47,7 +50,7 @@ sub run_tests {
     undef $C4::Biblio::inverted_field_map;
 
     my $marcflavour = shift;
-    $global_marcflavour = $marcflavour;
+    t::lib::Mocks::mock_preference('marcflavour', $marcflavour);
 
     my $isbn = '0590353403';
     my $title = 'Foundation';
@@ -166,7 +169,7 @@ sub run_tests {
     $record_for_isbn->append_fields( $isbn_field );
     $isbns = GetMarcISBN( $record_for_isbn, $marcflavour );
     is( scalar @$isbns, 1, '(GetMarcISBN) The record contains one ISBN');
-    is( $isbns->[0]->{ marcisbn }, $isbn, '(GetMarcISBN) The record contains our ISBN');
+    is( $isbns->[0], $isbn, '(GetMarcISBN) The record contains our ISBN');
 
     # We add 3 more ISBNs
     $record_for_isbn = MARC::Record->new();
@@ -178,23 +181,13 @@ sub run_tests {
     $isbns = GetMarcISBN( $record_for_isbn, $marcflavour );
     is( scalar @$isbns, 4, '(GetMarcISBN) The record contains 4 ISBNs');
     for my $i (0 .. $#more_isbns) {
-        is( $isbns->[$i]->{ marcisbn }, $more_isbns[$i],
+        is( $isbns->[$i], $more_isbns[$i],
             "(GetMarcISBN) Corretly retrieves ISBN #". ($i + 1));
     }
 
-}
-
-sub mock_preference {
-
-    $context->mock( 'preference', sub {
-        my ( $self, $pref ) = @_;
-        if ( $pref eq 'marcflavour' ) {
-            return $global_marcflavour;
-        } else {
-            &$original_preference(@_);
-        }
-    });
 
+    is( GetMarcPrice( $record_for_isbn, $marcflavour ), 100,
+        "GetMarcPrice returns the correct value");
 }
 
 sub mock_marcfromkohafield {
@@ -203,7 +196,8 @@ sub mock_marcfromkohafield {
         sub {
             my ( $self ) = shift;
 
-            if ( $global_marcflavour eq 'MARC21' ) {
+            if ( C4::Context->preference('marcflavour') eq 'MARC21' ||
+                 C4::Context->preference('marcflavour') eq 'NORMARC' ) {
 
                 return  {
                 '' => {
@@ -214,7 +208,7 @@ sub mock_marcfromkohafield {
                     'biblioitems.biblioitemnumber' => [ '999', 'd' ]
                     }
                 };
-            } elsif ( $global_marcflavour eq 'UNIMARC' ) {
+            } elsif ( C4::Context->preference('marcflavour') eq 'UNIMARC' ) {
 
                 return {
                 '' => {
@@ -243,6 +237,9 @@ sub create_isbn_field {
 
     my $isbn_field = ( $marcflavour eq 'UNIMARC' ) ? '010' : '020';
     my $field = MARC::Field->new( $isbn_field,'','','a' => $isbn);
+    # Add the price subfield
+    my $price_subfield = ( $marcflavour eq 'UNIMARC' ) ? 'd' : 'c' ;
+    $field->add_subfields( $price_subfield => '$100' );
 
     return $field;
 }
@@ -257,16 +254,22 @@ sub create_issn_field {
 }
 
 subtest 'MARC21' => sub {
-    plan tests => 25;
+    plan tests => 26;
     run_tests('MARC21');
     $dbh->rollback;
 };
 
 subtest 'UNIMARC' => sub {
-    plan tests => 25;
+    plan tests => 26;
     run_tests('UNIMARC');
     $dbh->rollback;
 };
 
+subtest 'NORMARC' => sub {
+    plan tests => 26;
+    run_tests('NORMARC');
+    $dbh->rollback;
+};
+
 
 1;