use Modern::Perl;
-use Test::More tests => 12;
+use Test::More tests => 15;
use Test::MockModule;
+use Test::Warn;
use List::MoreUtils qw( uniq );
use MARC::Record;
use Koha::Caches;
use Koha::MarcSubfieldStructures;
+use C4::Linker::Default qw( get_link );
+
BEGIN {
- use_ok('C4::Biblio');
+ use_ok('C4::Biblio', qw( AddBiblio GetMarcFromKohaField BiblioAutoLink GetMarcSubfieldStructure GetMarcSubfieldStructureFromKohaField LinkBibHeadingsToAuthorities GetBiblioData ModBiblio GetMarcISSN GetMarcControlnumber GetMarcISBN GetMarcPrice GetFrameworkCode GetMarcUrls IsMarcStructureInternal GetMarcStructure GetXmlBiblio DelBiblio ));
}
my $schema = Koha::Database->new->schema;
my $dbh = C4::Context->dbh;
Koha::Caches->get_instance->clear_from_cache( "MarcSubfieldStructure-" );
+my $builder = t::lib::TestBuilder->new;
+
+subtest 'AddBiblio' => sub {
+ plan tests => 5;
+
+ my $marcflavour = 'MARC21';
+ t::lib::Mocks::mock_preference( 'marcflavour', $marcflavour );
+ my $record = MARC::Record->new();
+
+ my ( $f, $sf ) = GetMarcFromKohaField('biblioitems.lccn');
+ my $lccn_field = MARC::Field->new( $f, ' ', ' ',
+ $sf => 'ThisisgoingtobetoomanycharactersfortheLCCNfield' );
+ $record->append_fields($lccn_field);
+
+ my $nb_biblios = Koha::Biblios->count;
+ my ( $biblionumber, $biblioitemnumber );
+ warnings_like { ( $biblionumber, $biblioitemnumber ) = C4::Biblio::AddBiblio( $record, '' ) }
+ [ qr/Data too long for column 'lccn'/, qr/Data too long for column 'lccn'/ ],
+ "expected warnings when adding too long LCCN";
+ is( $biblionumber, undef,
+ 'AddBiblio returns undef for biblionumber if something went wrong' );
+ is( $biblioitemnumber, undef,
+ 'AddBiblio returns undef for biblioitemnumber if something went wrong'
+ );
+ is( Koha::Biblios->count, $nb_biblios,
+ 'No biblio should have been added if something went wrong' );
+
+ t::lib::Mocks::mock_preference( 'AutoLinkBiblios', $marcflavour );
+ t::lib::Mocks::mock_preference( 'AutoCreateAuthorities', $marcflavour );
+ t::lib::Mocks::mock_preference( 'autoControlNumber', "OFF" );
+
+ my $mock_biblio = Test::MockModule->new("C4::Biblio");
+ $mock_biblio->mock( BiblioAutoLink => sub {
+ my $record = shift;
+ my $frameworkcode = shift;
+ warn "My biblionumber is ".$record->subfield('999','c')." and my frameworkcode is $frameworkcode";
+ });
+ warning_like { $builder->build_sample_biblio(); }
+ qr/My biblionumber is \d+ and my frameworkcode is /, "The biblionumber is correctly passed to BiblioAutoLink";
+
+};
+
subtest 'GetMarcSubfieldStructureFromKohaField' => sub {
plan tests => 25;
is( $retval[0].$retval[1], '399a', 'Including 399a' );
};
+subtest "Authority creation with default linker" => sub {
+ plan tests => 4;
+ # Automatic authority creation
+ t::lib::Mocks::mock_preference('LinkerModule', 'Default');
+ t::lib::Mocks::mock_preference('AutoLinkBiblios', 1);
+ t::lib::Mocks::mock_preference('AutoCreateAuthorities', 1);
+ t::lib::Mocks::mock_preference('marcflavour', 'MARC21');
+ my $linker = C4::Linker::Default->new({});
+ my $authorities_mod = Test::MockModule->new( 'C4::Heading' );
+ $authorities_mod->mock(
+ 'authorities',
+ sub {
+ my $results = [{ authid => 'original' },{ authid => 'duplicate' }];
+ return $results;
+ }
+ );
+ my $marc_record = MARC::Record->new();
+ my $field = MARC::Field->new(655, ' ', ' ','a' => 'Magical realism');
+ $marc_record->append_fields( $field );
+ my ($num_changed,$results) = LinkBibHeadingsToAuthorities($linker, $marc_record, "",undef);
+ is( $num_changed, 0, "We shouldn't link or create a new record");
+ ok( !defined $results->{added}, "If we have multiple matches, we shouldn't create a new record");
+
+ ($num_changed,$results) = LinkBibHeadingsToAuthorities($linker, $marc_record, "",undef);
+ is( $num_changed, 0, "We shouldn't link or create a new record using cached result");
+ ok( !defined $results->{added}, "If we have multiple matches, we shouldn't create a new record on second instance");
+};
+
+
+
# Mocking variables
-my $biblio_module = new Test::MockModule('C4::Biblio');
+my $biblio_module = Test::MockModule->new('C4::Biblio');
$biblio_module->mock(
'GetMarcSubfieldStructure',
sub {
}
);
-my $currency = new Test::MockModule('Koha::Acquisition::Currencies');
+my $currency = Test::MockModule->new('Koha::Acquisition::Currencies');
$currency->mock(
'get_active',
sub {
my $marcflavour = shift;
t::lib::Mocks::mock_preference('marcflavour', $marcflavour);
+ # Authority tests don't interact well with Elasticsearch at the moment due to the fact that there's currently no way to
+ # roll back ES index changes.
+ t::lib::Mocks::mock_preference('SearchEngine', 'Zebra');
+ t::lib::Mocks::mock_preference('autoControlNumber', 'OFF');
+
+ t::lib::Mocks::mock_preference( 'RealTimeHoldsQueue', 0 );
my $isbn = '0590353403';
my $title = 'Foundation';
is( $data->{ title }, undef,
'(GetBiblioData) Title field is empty in fresh biblio.');
+ my $biblio = Koha::Biblios->find($biblionumber);
+
my ( $isbn_field, $isbn_subfield ) = get_isbn_field();
- my $marc = GetMarcBiblio({ biblionumber => $biblionumber });
+ my $marc = $biblio->metadata->record;
is( $marc->subfield( $isbn_field, $isbn_subfield ), $isbn, );
# Add title
is( $data->{ title }, $title,
'ModBiblio correctly added the title field, and GetBiblioData.');
is( $data->{ isbn }, $isbn, '(ModBiblio) ISBN is still there after ModBiblio.');
- $marc = GetMarcBiblio({ biblionumber => $biblionumber });
+ $marc = $biblio->get_from_storage->metadata->record;
my ( $title_field, $title_subfield ) = get_title_field();
is( $marc->subfield( $title_field, $title_subfield ), $title, );
is( GetMarcPrice( $record_for_isbn, $marcflavour ), 100,
"GetMarcPrice returns the correct value");
- my $newincbiblioitemnumber=$biblioitemnumber+1;
- $dbh->do("UPDATE biblioitems SET biblioitemnumber = ? WHERE biblionumber = ?;", undef, $newincbiblioitemnumber, $biblionumber );
- my $updatedrecord = GetMarcBiblio({
- biblionumber => $biblionumber,
- embed_items => 0 });
my $frameworkcode = GetFrameworkCode($biblionumber);
+ my $updatedrecord = $biblio->metadata->record;
my ( $biblioitem_tag, $biblioitem_subfield ) = GetMarcFromKohaField( "biblioitems.biblioitemnumber" );
die qq{No biblioitemnumber tag for framework "$frameworkcode"} unless $biblioitem_tag;
my $biblioitemnumbertotest;
} else {
$biblioitemnumbertotest = $updatedrecord->field($biblioitem_tag)->subfield($biblioitem_subfield);
}
- is ($newincbiblioitemnumber, $biblioitemnumbertotest, 'Check newincbiblioitemnumber');
-
- # test for GetMarcNotes
- my $a1= GetMarcNotes( $marc_record, $marcflavour );
- my $field2 = MARC::Field->new( $marcflavour eq 'UNIMARC'? 300: 555, 0, '', a=> 'Some text', u=> 'http://url-1.com', u=> 'nohttp://something_else' );
- $marc_record->append_fields( $field2 );
- my $a2= GetMarcNotes( $marc_record, $marcflavour );
- is( ( $marcflavour eq 'UNIMARC' && @$a2 == @$a1 + 1 ) ||
- ( $marcflavour ne 'UNIMARC' && @$a2 == @$a1 + 3 ), 1,
- 'Check the number of returned notes of GetMarcNotes' );
# test for GetMarcUrls
$marc_record->append_fields(
'GetMarcUrls prefixed a MARC21 URL with http://' );
# Automatic authority creation
- t::lib::Mocks::mock_preference('BiblioAddsAuthorities', 1);
+ t::lib::Mocks::mock_preference('AutoLinkBiblios', 1);
t::lib::Mocks::mock_preference('AutoCreateAuthorities', 1);
my $authorities_mod = Test::MockModule->new( 'C4::Heading' );
$authorities_mod->mock(
return \@results;
}
);
-
$success = 0;
$field = create_author_field('Author Name');
eval {
my $authid = $field->subfield('9');
ok($authid, 'ModBiblio adds authority id');
- use_ok('C4::AuthoritiesMarc');
+ use_ok('C4::AuthoritiesMarc', qw( GetAuthority ));
my $auth_record = C4::AuthoritiesMarc::GetAuthority($authid);
ok($auth_record, 'Authority record successfully retrieved');
is($field->subfield($author_relator_subfield), undef, 'Authority does not contain relator subfield');
# Reset settings
- t::lib::Mocks::mock_preference('BiblioAddsAuthorities', 0);
+ t::lib::Mocks::mock_preference('AutoLinkBiblios', 0);
t::lib::Mocks::mock_preference('AutoCreateAuthorities', 0);
}
}
subtest 'MARC21' => sub {
- plan tests => 48;
+ plan tests => 46;
run_tests('MARC21');
$schema->storage->txn_rollback;
$schema->storage->txn_begin;
};
subtest 'UNIMARC' => sub {
- plan tests => 48;
+ plan tests => 46;
# Mock the auth type data for UNIMARC
$dbh->do("UPDATE auth_types SET auth_tag_to_report = '106' WHERE auth_tag_to_report = '100'") or die $dbh->errstr;
$schema->storage->txn_begin;
};
-subtest 'NORMARC' => sub {
- plan tests => 48;
- run_tests('NORMARC');
- $schema->storage->txn_rollback;
- $schema->storage->txn_begin;
-};
-
subtest 'IsMarcStructureInternal' => sub {
- plan tests => 8;
+ plan tests => 9;
my $tagslib = GetMarcStructure();
my @internals;
for my $tag ( sort keys %$tagslib ) {
}
}
@internals = uniq @internals;
- is( scalar(@internals), 6, 'expect 6 internals');
+ is( scalar(@internals), 7, 'expect 7 internals');
is( grep( /^lib$/, @internals ), 1, 'check lib' );
is( grep( /^tab$/, @internals ), 1, 'check tab' );
is( grep( /^mandatory$/, @internals ), 1, 'check mandatory' );
is( grep( /^repeatable$/, @internals ), 1, 'check repeatable' );
+ is( grep( /^important$/, @internals ), 1, 'check important' );
is( grep( /^a$/, @internals ), 0, 'no subfield a' );
is( grep( /^ind1_defaultvalue$/, @internals ), 1, 'check indicator 1 default value' );
is( grep( /^ind2_defaultvalue$/, @internals ), 1, 'check indicator 2 default value' );
subtest 'deletedbiblio_metadata' => sub {
plan tests => 2;
+ t::lib::Mocks::mock_preference( 'RealTimeHoldsQueue', 0 );
+
my ($biblionumber, $biblioitemnumber) = AddBiblio(MARC::Record->new, '');
my $biblio_metadata = C4::Biblio::GetXmlBiblio( $biblionumber );
C4::Biblio::DelBiblio( $biblionumber );
};
subtest 'DelBiblio' => sub {
- plan tests => 2;
+
+ plan tests => 5;
+
+ t::lib::Mocks::mock_preference( 'RealTimeHoldsQueue', 0 );
my ($biblionumber, $biblioitemnumber) = C4::Biblio::AddBiblio(MARC::Record->new, '');
my $deleted = C4::Biblio::DelBiblio( $biblionumber );
$deleted = C4::Biblio::DelBiblio( $biblionumber );
is( $deleted, undef, 'DelBiblo should return undef is the record did not exist');
+
+ my $biblio = $builder->build_sample_biblio;
+ my $subscription = $builder->build_object(
+ {
+ class => 'Koha::Subscriptions',
+ value => { biblionumber => $biblio->biblionumber }
+ }
+ );
+ my $serial = $builder->build_object(
+ {
+ class => 'Koha::Serials',
+ value => {
+ biblionumber => $biblio->biblionumber,
+ subscriptionid => $subscription->subscriptionid
+ }
+ }
+ );
+ my $subscription_history = $builder->build_object(
+ {
+ class => 'Koha::Subscription::Histories',
+ value => {
+ biblionumber => $biblio->biblionumber,
+ subscriptionid => $subscription->subscriptionid
+ }
+ }
+ );
+ C4::Biblio::DelBiblio($biblio->biblionumber); # Or $biblio->delete
+ is( $subscription->get_from_storage, undef, 'subscription should be deleted on biblio deletion' );
+ is( $serial->get_from_storage, undef, 'serial should be deleted on biblio deletion' );
+ is( $subscription_history->get_from_storage, undef, 'subscription history should be deleted on biblio deletion' );
};
subtest 'MarcFieldForCreatorAndModifier' => sub {
my $record = MARC::Record->new();
my ($biblionumber) = C4::Biblio::AddBiblio($record, '');
- $record = GetMarcBiblio({biblionumber => $biblionumber});
+ my $biblio = Koha::Biblios->find($biblionumber);
+ $record = $biblio->metadata->record;
is($record->subfield('998', 'a'), 123, '998$a = 123');
is($record->subfield('998', 'b'), 'John Doe', '998$b = John Doe');
is($record->subfield('998', 'c'), 123, '998$c = 123');
$c4_context->mock('userenv', sub { return { number => 321, firstname => 'Jane', surname => 'Doe'}; });
C4::Biblio::ModBiblio($record, $biblionumber, '');
- $record = GetMarcBiblio({biblionumber => $biblionumber});
+ $record = $biblio->get_from_storage->metadata->record;
is($record->subfield('998', 'a'), 123, '998$a = 123');
is($record->subfield('998', 'b'), 'John Doe', '998$b = John Doe');
is($record->subfield('998', 'c'), 321, '998$c = 321');
subtest 'ModBiblio called from linker test' => sub {
plan tests => 2;
my $called = 0;
- t::lib::Mocks::mock_preference('BiblioAddsAuthorities', 1);
+ t::lib::Mocks::mock_preference('AutoLinkBiblios', 1);
my $biblio_mod = Test::MockModule->new( 'C4::Biblio' );
$biblio_mod->mock( 'LinkBibHeadingsToAuthorities', sub {
$called = 1;
C4::Biblio::ModBiblio($record,$biblionumber,'');
is($called,1,"We called to link bibs because not from linker");
$called = 0;
- C4::Biblio::ModBiblio($record,$biblionumber,'',1);
+ C4::Biblio::ModBiblio($record,$biblionumber,'',{ disable_autolink => 1 });
is($called,0,"We didn't call to link bibs because from linker");
};
+subtest "LinkBibHeadingsToAuthorities record generation tests" => sub {
+ plan tests => 12;
+
+ # Set up mocks to ensure authorities are generated
+ my $biblio_mod = Test::MockModule->new( 'C4::Linker::Default' );
+ $biblio_mod->mock( 'get_link', sub {
+ return (undef,undef);
+ });
+ # UNIMARC valid headings are built from the marc_subfield_structure for bibs and
+ # include all subfields as valid, testing with MARC21 should be sufficient for now
+ t::lib::Mocks::mock_preference('marcflavour', 'MARC21');
+ t::lib::Mocks::mock_preference('AutoCreateAuthorities', '1');
+
+ my $linker = C4::Linker::Default->new();
+ my $biblio = $builder->build_sample_biblio();
+ my $record = $biblio->metadata->record;
+
+ # Generate a record including all valid subfields and an invalid one 'e'
+ my $field = MARC::Field->new('650','','','a' => 'Beach city', 'b' => 'Weirdness', 'v' => 'Fiction', 'x' => 'Books', 'y' => '21st Century', 'z' => 'Fish Stew Pizza', 'e' => 'Depicted');
+
+ $record->append_fields($field);
+ my ( $num_headings_changed, $results ) = LinkBibHeadingsToAuthorities($linker, $record, "",undef,650);
+
+ is( $num_headings_changed, 1, 'We changed the one we passed' );
+ is_deeply( $results->{added},
+ {"Beach city Weirdness--Fiction--Books--21st Century--Fish Stew Pizza" => 1 },
+ "We added an authority record for the heading"
+ );
+
+ # Now we check the authority record itself
+ my $authority = GetAuthority( $record->subfield('650','9') );
+ is( $authority->field('150')->as_string(),
+ "Beach city Weirdness Fiction Books 21st Century Fish Stew Pizza",
+ "The generated record contains the correct subfields"
+ );
+
+ #Add test for this case using verbose
+ $record->field('650')->delete_subfield('9');
+ ( $num_headings_changed, $results ) = LinkBibHeadingsToAuthorities($linker, $record, "",undef, 650, 1);
+ is( $num_headings_changed, 1, 'We changed the one we passed' );
+ is( $results->{details}->[0]->{status}, 'CREATED', "We added an authority record for the heading using verbose");
+
+ # Now we check the authority record itself
+ $authority = GetAuthority($results->{details}->[0]->{authid});
+
+ is( $authority->field('150')->as_string(),
+ "Beach city Weirdness Fiction Books 21st Century Fish Stew Pizza",
+ "The generated record contains the correct subfields when using verbose"
+ );
+
+ # Example series link with volume and punctuation
+ $field = MARC::Field->new('800','','','a' => 'Tolkien, J. R. R.', 'q' => '(John Ronald Reuel),', 'd' => '1892-1973.', 't' => 'Lord of the rings ;', 'v' => '1');
+ $record->append_fields($field);
+
+ ( $num_headings_changed, $results ) = LinkBibHeadingsToAuthorities($linker, $record, "",undef, 800);
+
+ is( $num_headings_changed, 1, 'We changed the one we passed' );
+ is_deeply( $results->{added},
+ {"Tolkien, J. R. R. (John Ronald Reuel), 1892-1973. Lord of the rings ;" => 1 },
+ "We added an authority record for the heading"
+ );
+
+ # Now we check the authority record itself
+ $authority = GetAuthority( $record->subfield('800','9') );
+ is( $authority->field('100')->as_string(),
+ "Tolkien, J. R. R. (John Ronald Reuel), 1892-1973. Lord of the rings",
+ "The generated record contains the correct subfields"
+ );
+
+ # The same example With verbose
+ $record->field('800')->delete_subfield('9');
+ ( $num_headings_changed, $results ) = LinkBibHeadingsToAuthorities($linker, $record, "",undef, 800, 1);
+ is( $num_headings_changed, 1, 'We changed the one we passed' );
+ is( $results->{details}->[0]->{status}, 'CREATED', "We added an authority record for the heading using verbose");
+
+ # Now we check the authority record itself
+ $authority = GetAuthority($results->{details}->[0]->{authid});
+ is( $authority->field('100')->as_string(),
+ "Tolkien, J. R. R. (John Ronald Reuel), 1892-1973. Lord of the rings",
+ "The generated record contains the correct subfields"
+ );
+};
+
+subtest 'autoControlNumber tests' => sub {
+
+ plan tests => 3;
+
+ t::lib::Mocks::mock_preference('autoControlNumber', 'OFF');
+
+ my $record = MARC::Record->new();
+ my ($biblio_id) = C4::Biblio::AddBiblio($record, '');
+ my $biblio = Koha::Biblios->find($biblio_id);
+
+ $record = $biblio->metadata->record;
+ is($record->field('001'), undef, '001 not set when pref is off');
+
+ t::lib::Mocks::mock_preference('autoControlNumber', 'biblionumber');
+ C4::Biblio::ModBiblio($record, $biblio_id, "", { skip_record_index => 1, disable_autolink => 1 });
+ $biblio->discard_changes;
+ $record = $biblio->metadata->record;
+ is($record->field('001')->as_string(), $biblio_id, '001 set to biblionumber when pref set and field is blank');
+
+ $record->field('001')->update('Not biblionumber');
+ C4::Biblio::ModBiblio($record, $biblio_id, "", { skip_record_index => 1, disable_autolink => 1 });
+ $biblio->discard_changes;
+ $record = $biblio->metadata->record;
+ is($record->field('001')->as_string(), 'Not biblionumber', '001 not set to biblionumber when pref set and field exists');
+
+};
+
+
# Cleanup
Koha::Caches->get_instance->clear_from_cache( "MarcSubfieldStructure-" );
$schema->storage->txn_rollback;
projects / koha-ffzg.git / blobdiff