Bug 31555: change holds GET permission to place_holds

[koha-ffzg.git] / t / db_dependent / Biblio.t

diff --git a/t/db_dependent/Biblio.t b/t/db_dependent/Biblio.t
index 2037a6b..67cba63 100755 (executable)
--- a/t/db_dependent/Biblio.t
+++ b/t/db_dependent/Biblio.t
@@ -68,8 +68,9 @@ subtest 'AddBiblio' => sub {
     is( Koha::Biblios->count, $nb_biblios,
         'No biblio should have been added if something went wrong' );
 
-    t::lib::Mocks::mock_preference( 'BiblioAddsAuthorities', $marcflavour );
+    t::lib::Mocks::mock_preference( 'AutoLinkBiblios', $marcflavour );
     t::lib::Mocks::mock_preference( 'AutoCreateAuthorities', $marcflavour );
+    t::lib::Mocks::mock_preference( 'autoControlNumber', "OFF" );
 
     my $mock_biblio = Test::MockModule->new("C4::Biblio");
     $mock_biblio->mock( BiblioAutoLink => sub {
@@ -170,7 +171,7 @@ subtest "Authority creation with default linker" => sub {
     plan tests => 4;
     # Automatic authority creation
     t::lib::Mocks::mock_preference('LinkerModule', 'Default');
-    t::lib::Mocks::mock_preference('BiblioAddsAuthorities', 1);
+    t::lib::Mocks::mock_preference('AutoLinkBiblios', 1);
     t::lib::Mocks::mock_preference('AutoCreateAuthorities', 1);
     t::lib::Mocks::mock_preference('marcflavour', 'MARC21');
     my $linker = C4::Linker::Default->new({});
@@ -448,7 +449,7 @@ sub run_tests {
         'GetMarcUrls prefixed a MARC21 URL with http://' );
 
     # Automatic authority creation
-    t::lib::Mocks::mock_preference('BiblioAddsAuthorities', 1);
+    t::lib::Mocks::mock_preference('AutoLinkBiblios', 1);
     t::lib::Mocks::mock_preference('AutoCreateAuthorities', 1);
     my $authorities_mod = Test::MockModule->new( 'C4::Heading' );
     $authorities_mod->mock(
@@ -492,7 +493,7 @@ sub run_tests {
     is($field->subfield($author_relator_subfield), undef, 'Authority does not contain relator subfield');
 
     # Reset settings
-    t::lib::Mocks::mock_preference('BiblioAddsAuthorities', 0);
+    t::lib::Mocks::mock_preference('AutoLinkBiblios', 0);
     t::lib::Mocks::mock_preference('AutoCreateAuthorities', 0);
 }
 
@@ -727,7 +728,7 @@ subtest 'MarcFieldForCreatorAndModifier' => sub {
 subtest 'ModBiblio called from linker test' => sub {
     plan tests => 2;
     my $called = 0;
-    t::lib::Mocks::mock_preference('BiblioAddsAuthorities', 1);
+    t::lib::Mocks::mock_preference('AutoLinkBiblios', 1);
     my $biblio_mod = Test::MockModule->new( 'C4::Biblio' );
     $biblio_mod->mock( 'LinkBibHeadingsToAuthorities', sub {
         $called = 1;
@@ -825,23 +826,28 @@ subtest "LinkBibHeadingsToAuthorities record generation tests" => sub {
 };
 
 subtest 'autoControlNumber tests' => sub {
+
     plan tests => 3;
 
     t::lib::Mocks::mock_preference('autoControlNumber', 'OFF');
 
     my $record = MARC::Record->new();
-    my ($biblionumber) = C4::Biblio::AddBiblio($record, '');
-    $record = GetMarcBiblio({biblionumber => $biblionumber});
+    my ($biblio_id) = C4::Biblio::AddBiblio($record, '');
+    my $biblio = Koha::Biblios->find($biblio_id);
+
+    $record = $biblio->metadata->record;
     is($record->field('001'), undef, '001 not set when pref is off');
 
     t::lib::Mocks::mock_preference('autoControlNumber', 'biblionumber');
-    C4::Biblio::ModBiblio($record, $biblionumber, "", 1);
-    $record = GetMarcBiblio({biblionumber => $biblionumber});
-    is($record->field('001')->as_string(), $biblionumber, '001 set to biblionumber when pref set and field is blank');
+    C4::Biblio::ModBiblio($record, $biblio_id, "", { skip_record_index => 1, disable_autolink => 1 });
+    $biblio->discard_changes;
+    $record = $biblio->metadata->record;
+    is($record->field('001')->as_string(), $biblio_id, '001 set to biblionumber when pref set and field is blank');
 
     $record->field('001')->update('Not biblionumber');
-    C4::Biblio::ModBiblio($record, $biblionumber, "", 1);
-    $record = GetMarcBiblio({biblionumber => $biblionumber});
+    C4::Biblio::ModBiblio($record, $biblio_id, "", { skip_record_index => 1, disable_autolink => 1 });
+    $biblio->discard_changes;
+    $record = $biblio->metadata->record;
     is($record->field('001')->as_string(), 'Not biblionumber', '001 not set to biblionumber when pref set and field exists');
 
 };