Bug 17600: Standardize our EXPORT_OK

[srvgit] / t / db_dependent / Biblio / TransformKohaToMarc.t

diff --git a/t/db_dependent/Biblio/TransformKohaToMarc.t b/t/db_dependent/Biblio/TransformKohaToMarc.t
old mode 100644 (file)
new mode 100755 (executable)
index f1b203b..d2efaa6
--- a/t/db_dependent/Biblio/TransformKohaToMarc.t
+++ b/t/db_dependent/Biblio/TransformKohaToMarc.t
@@ -8,10 +8,11 @@ use t::lib::TestBuilder;
 use Koha::Database;
 use Koha::Caches;
 use Koha::MarcSubfieldStructures;
-use C4::Biblio;
+use C4::Biblio qw( TransformKohaToMarc );
 
 my $schema  = Koha::Database->new->schema;
 $schema->storage->txn_begin;
+our $builder = t::lib::TestBuilder->new;
 
 # Create/overwrite some Koha to MARC mappings in default framework
 Koha::MarcSubfieldStructures->search({ frameworkcode => '', tagfield => '300', tagsubfield => 'a' })->delete;
@@ -77,14 +78,17 @@ subtest "Working with control fields" => sub {
     is( $record->field('001')->data, 'all', 'Verify field 001' );
 };
 
-subtest "Add test for no_split option" => sub {
-    plan tests => 4;
+subtest "Add tests for _check_split" => sub {
+    plan tests => 8;
 
     Koha::MarcSubfieldStructures->search({ frameworkcode => '', tagfield => '952', tagsubfield => 'a' })->delete;
     Koha::MarcSubfieldStructure->new({ frameworkcode => '', tagfield => '952', tagsubfield => 'a', kohafield => 'items.fld1' })->store;
     Koha::MarcSubfieldStructures->search({ frameworkcode => '', tagfield => '952', tagsubfield => 'b' })->delete;
     Koha::MarcSubfieldStructure->new({ frameworkcode => '', tagfield => '952', tagsubfield => 'b', kohafield => 'items.fld1' })->store;
     Koha::Caches->get_instance->clear_from_cache( "MarcSubfieldStructure-" );
+    # add 952a repeatable in another framework
+    my $fw =  $builder->build({ source => 'BiblioFramework' })->{frameworkcode};
+    Koha::MarcSubfieldStructure->new({ frameworkcode => $fw, tagfield => '952', tagsubfield => 'a', repeatable => 1, kohafield => 'items.fld1' })->store;
 
     # Test single value in fld1
     my @cols = ( 'items.fld1' => '01' );
@@ -92,11 +96,20 @@ subtest "Add test for no_split option" => sub {
     is( $record->subfield( '952', 'a' ), '01', 'Check single in 952a' );
     is( $record->subfield( '952', 'b' ), '01', 'Check single in 952b' );
 
-    # Test glued (composite) value in fld1
+    # Test glued (composite) value in fld1 with no_split parameter
     @cols = ( 'items.fld1' => '01 | 02' );
     $record = C4::Biblio::TransformKohaToMarc( { @cols }, { no_split => 1 } );
     is( $record->subfield( '952', 'a' ), '01 | 02', 'Check composite in 952a' );
     is( $record->subfield( '952', 'b' ), '01 | 02', 'Check composite in 952b' );
+    # Test without no_split (subfield is not repeatable)
+    $record = C4::Biblio::TransformKohaToMarc( { @cols } );
+    is( $record->subfield( '952', 'a' ), '01 | 02', 'Check composite in 952a' );
+    # Test with other framework (repeatable)
+    Koha::Caches->get_instance->clear_from_cache( "MarcSubfieldStructure-". $fw );
+    $record =  C4::Biblio::TransformKohaToMarc( { @cols }, { framework => $fw } );
+    is( ($record->subfield( '952', 'a' ))[0], '01', "Framework $fw first 952a" );
+    is( ($record->subfield( '952', 'a' ))[1], '02', "Framework $fw second 952a" );
+    is( ref(Koha::Caches->get_instance->get_from_cache( "MarcSubfieldStructure-". $fw )), 'HASH', 'We did hit the cache' );
 };
 
 # Cleanup