use Modern::Perl;
use CGI qw ( -utf8 );
+
+use Test::MockObject;
use Test::MockModule;
use List::MoreUtils qw/all any none/;
-use Test::More tests => 11;
+use Test::More tests => 17;
use Test::Warn;
+use t::lib::Mocks;
+use t::lib::TestBuilder;
+
+use C4::Auth;
use C4::Members;
use Koha::AuthUtils qw/hash_password/;
+use Koha::Database;
+use Koha::Patrons;
+use Koha::Auth::TwoFactorAuth;
BEGIN {
- use_ok('C4::Auth');
+ use_ok('C4::Auth', qw( checkauth haspermission track_login_daily checkpw get_template_and_user checkpw_hash ));
}
-my $dbh = C4::Context->dbh;
+my $schema = Koha::Database->schema;
+my $builder = t::lib::TestBuilder->new;
+
+# FIXME: SessionStorage defaults to mysql, but it seems to break transaction
+# handling
+t::lib::Mocks::mock_preference( 'SessionStorage', 'tmp' );
+t::lib::Mocks::mock_preference( 'GDPR_Policy', '' ); # Disabled
+
+# To silence useless warnings
+$ENV{REMOTE_ADDR} = '127.0.0.1';
+
+$schema->storage->txn_begin;
+
+subtest 'checkauth() tests' => sub {
+
+ plan tests => 8;
+
+ my $patron = $builder->build_object({ class => 'Koha::Patrons', value => { flags => undef } });
+
+ # Mock a CGI object with real userid param
+ my $cgi = Test::MockObject->new();
+ $cgi->mock(
+ 'param',
+ sub {
+ my $var = shift;
+ if ( $var eq 'userid' ) { return $patron->userid; }
+ }
+ );
+ $cgi->mock( 'cookie', sub { return; } );
+ $cgi->mock( 'request_method', sub { return 'POST' } );
+
+ my $authnotrequired = 1;
+ my ( $userid, $cookie, $sessionID, $flags ) = C4::Auth::checkauth( $cgi, $authnotrequired );
+
+ is( $userid, undef, 'checkauth() returns undef for userid if no logged in user (Bug 18275)' );
+
+ my $db_user_id = C4::Context->config('user');
+ my $db_user_pass = C4::Context->config('pass');
+ $cgi = Test::MockObject->new();
+ $cgi->mock( 'cookie', sub { return; } );
+ $cgi->mock( 'param', sub {
+ my ( $self, $param ) = @_;
+ if ( $param eq 'userid' ) { return $db_user_id; }
+ elsif ( $param eq 'password' ) { return $db_user_pass; }
+ else { return; }
+ });
+ $cgi->mock( 'request_method', sub { return 'POST' } );
+ ( $userid, $cookie, $sessionID, $flags ) = C4::Auth::checkauth( $cgi, $authnotrequired );
+ is ( $userid, undef, 'If DB user is used, it should not be logged in' );
+
+ my $is_allowed = C4::Auth::haspermission( $db_user_id, { can_do => 'everything' } );
+
+ # FIXME This belongs to t/db_dependent/Auth/haspermission.t but we do not want to c/p the pervious mock statements
+ ok( !$is_allowed, 'DB user should not have any permissions');
+
+ subtest 'Prevent authentication when sending credential via GET' => sub {
+
+ plan tests => 2;
+
+ my $patron = $builder->build_object(
+ { class => 'Koha::Patrons', value => { flags => 1 } } );
+ my $password = 'password';
+ t::lib::Mocks::mock_preference( 'RequireStrongPassword', 0 );
+ $patron->set_password( { password => $password } );
+ $cgi = Test::MockObject->new();
+ $cgi->mock( 'cookie', sub { return; } );
+ $cgi->mock(
+ 'param',
+ sub {
+ my ( $self, $param ) = @_;
+ if ( $param eq 'userid' ) { return $patron->userid; }
+ elsif ( $param eq 'password' ) { return $password; }
+ else { return; }
+ }
+ );
+
+ $cgi->mock( 'request_method', sub { return 'POST' } );
+ ( $userid, $cookie, $sessionID, $flags ) = C4::Auth::checkauth( $cgi, 'authrequired' );
+ is( $userid, $patron->userid, 'If librarian user is used and password with POST, they should be logged in' );
+
+ $cgi->mock( 'request_method', sub { return 'GET' } );
+ ( $userid, $cookie, $sessionID, $flags ) = C4::Auth::checkauth( $cgi, 'authrequired' );
+ is( $userid, undef, 'If librarian user is used and password with GET, they should not be logged in' );
+ };
+
+ subtest 'Template params tests (password_expired)' => sub {
+
+ plan tests => 1;
-# Start transaction
-$dbh->{AutoCommit} = 0;
-$dbh->{RaiseError} = 1;
+ my $password_expired;
+
+ my $patron_class = Test::MockModule->new('Koha::Patron');
+ $patron_class->mock( 'password_expired', sub { return $password_expired; } );
+
+ my $patron = $builder->build_object({ class => 'Koha::Patrons', value => { flags => 1 } });
+ my $password = 'password';
+ t::lib::Mocks::mock_preference( 'RequireStrongPassword', 0 );
+ $patron->set_password( { password => $password } );
+
+ my $cgi_mock = Test::MockModule->new('CGI')->mock( 'request_method', 'POST' );
+ my $cgi = CGI->new;
+ $cgi->param( -name => 'userid', -value => $patron->userid );
+ $cgi->param( -name => 'password', -value => $password );
+
+ my $auth = Test::MockModule->new( 'C4::Auth' );
+ # Tests will fail if we hit safe_exit
+ $auth->mock( 'safe_exit', sub { return } );
+
+ my ( $userid, $cookie, $sessionID, $flags );
+
+ {
+ t::lib::Mocks::mock_preference( 'DumpTemplateVarsOpac', 1 );
+ # checkauth will redirect and safe_exit if not authenticated and not authorized
+ local *STDOUT;
+ my $stdout;
+ open STDOUT, '>', \$stdout;
+
+ # Password has expired
+ $password_expired = 1;
+ C4::Auth::checkauth( $cgi, 0, { catalogue => 1 } );
+ like( $stdout, qr{'password_has_expired' => 1}, 'password_has_expired is set to 1' );
+
+ close STDOUT;
+ };
+ };
+
+ subtest 'While still logged in, relogin with another user' => sub {
+ plan tests => 6;
+
+ my $patron = $builder->build_object({ class => 'Koha::Patrons', value => {} });
+ my $patron2 = $builder->build_object({ class => 'Koha::Patrons', value => {} });
+ # Create 'former' session
+ my $session = C4::Auth::get_session();
+ $session->param( 'number', $patron->id );
+ $session->param( 'id', $patron->userid );
+ $session->param( 'ip', '1.2.3.4' );
+ $session->param( 'lasttime', time() );
+ $session->param( 'interface', 'opac' );
+ $session->flush;
+ my $sessionID = $session->id;
+ C4::Context->_new_userenv($sessionID);
+
+ my ( $return ) = C4::Auth::check_cookie_auth( $sessionID, undef, { skip_version_check => 1, remote_addr => '1.2.3.4' } );
+ is( $return, 'ok', 'Former session in shape now' );
+
+ my $mock1 = Test::MockModule->new('C4::Auth');
+ $mock1->mock( 'safe_exit', sub {} );
+ my $mock2 = Test::MockModule->new('CGI');
+ $mock2->mock( 'request_method', 'POST' );
+ $mock2->mock( 'cookie', sub { return $sessionID; } ); # oversimplified..
+ my $cgi = CGI->new;
+ my $password = 'Incr3d1blyZtr@ng93$';
+ $patron2->set_password({ password => $password });
+ $cgi->param( -name => 'userid', -value => $patron2->userid );
+ $cgi->param( -name => 'password', -value => $password );
+ $cgi->param( -name => 'koha_login_context', -value => 1 );
+ my ( @return, $stdout );
+ {
+ local *STDOUT;
+ local %ENV;
+ $ENV{REMOTE_ADDR} = '1.2.3.4';
+ open STDOUT, '>', \$stdout;
+ @return = C4::Auth::checkauth( $cgi, 0, {} );
+ close STDOUT;
+ }
+ # Note: We can test return values from checkauth here since we mocked the safe_exit after the Redirect 303
+ is( $return[0], $patron2->userid, 'Login of patron2 approved' );
+ isnt( $return[2], $sessionID, 'Did not return previous session ID' );
+ ok( $return[2], 'New session ID not empty' );
+
+ # Similar situation: Relogin with former session of $patron, new user $patron2 has no permissions
+ $patron2->flags(undef)->store;
+ $session->param( 'number', $patron->id );
+ $session->param( 'id', $patron->userid );
+ $session->param( 'interface', 'intranet' );
+ $session->flush;
+ $sessionID = $session->id;
+ C4::Context->_new_userenv($sessionID);
+ $cgi->param( -name => 'userid', -value => $patron2->userid );
+ $cgi->param( -name => 'password', -value => $password );
+ $cgi->param( -name => 'koha_login_context', -value => 1 );
+ {
+ local *STDOUT;
+ local %ENV;
+ $ENV{REMOTE_ADDR} = '1.2.3.4';
+ $stdout = q{};
+ open STDOUT, '>', \$stdout;
+ @return = C4::Auth::checkauth( $cgi, 0, { catalogue => 1 }, 'intranet' ); # patron2 has no catalogue perm
+ close STDOUT;
+ }
+ like( $stdout, qr/You do not have permission to access this page/, 'No permission response' );
+ is( @return, 0, 'checkauth returned failure' );
+ };
+
+ subtest 'Two-factor authentication' => sub {
+ plan tests => 18;
+
+ my $patron = $builder->build_object(
+ { class => 'Koha::Patrons', value => { flags => 1 } } );
+ my $password = 'password';
+ $patron->set_password( { password => $password } );
+ $cgi = Test::MockObject->new();
+
+ my $otp_token;
+ our ( $logout, $sessionID, $verified );
+ $cgi->mock(
+ 'param',
+ sub {
+ my ( $self, $param ) = @_;
+ if ( $param eq 'userid' ) { return $patron->userid; }
+ elsif ( $param eq 'password' ) { return $password; }
+ elsif ( $param eq 'otp_token' ) { return $otp_token; }
+ elsif ( $param eq 'logout.x' ) { return $logout; }
+ else { return; }
+ }
+ );
+ $cgi->mock( 'request_method', sub { return 'POST' } );
+ $cgi->mock( 'cookie', sub { return $sessionID } );
+ my $two_factor_auth = Test::MockModule->new( 'Koha::Auth::TwoFactorAuth' );
+ $two_factor_auth->mock( 'verify', sub {$verified} );
+
+ my ( $userid, $cookie, $flags );
+ ( $userid, $cookie, $sessionID, $flags ) = C4::Auth::checkauth( $cgi, 'authrequired', undef, 'intranet' );
+
+ sub logout {
+ my $cgi = shift;
+ $logout = 1;
+ undef $sessionID;
+ C4::Auth::checkauth( $cgi, 'authrequired', undef, 'intranet' );
+ $logout = 0;
+ }
+
+ t::lib::Mocks::mock_preference( 'TwoFactorAuthentication', 'disabled' );
+ $patron->auth_method('password')->store;
+ ( $userid, $cookie, $sessionID, $flags ) = C4::Auth::checkauth( $cgi, 'authrequired', undef, 'intranet' );
+ is( $userid, $patron->userid, 'Succesful login' );
+ is( C4::Auth::get_session($sessionID)->param('waiting-for-2FA'), undef, 'Second auth not required' );
+ logout($cgi);
+
+ $patron->auth_method('two-factor')->store;
+ ( $userid, $cookie, $sessionID, $flags ) = C4::Auth::checkauth( $cgi, 'authrequired', undef, 'intranet' );
+ is( $userid, $patron->userid, 'Succesful login' );
+ is( C4::Auth::get_session($sessionID)->param('waiting-for-2FA'), undef, 'Second auth not required' );
+ logout($cgi);
+
+ t::lib::Mocks::mock_preference( 'TwoFactorAuthentication', 'enabled' );
+ t::lib::Mocks::mock_config('encryption_key', '1234tH1s=t&st');
+ $patron->auth_method('password')->store;
+ ( $userid, $cookie, $sessionID, $flags ) = C4::Auth::checkauth( $cgi, 'authrequired', undef, 'intranet' );
+ is( $userid, $patron->userid, 'Succesful login' );
+ is( C4::Auth::get_session($sessionID)->param('waiting-for-2FA'), undef, 'Second auth not required' );
+ logout($cgi);
+
+ $patron->encode_secret('one_secret');
+ $patron->auth_method('two-factor');
+ $patron->store;
+ ( $userid, $cookie, $sessionID, $flags ) = C4::Auth::checkauth( $cgi, 'authrequired', undef, 'intranet' );
+ is( $userid, $patron->userid, 'Succesful login' );
+ my $session = C4::Auth::get_session($sessionID);
+ is( C4::Auth::get_session($sessionID)->param('waiting-for-2FA'), 1, 'Second auth required' );
+
+ # Wrong OTP token
+ $otp_token = "wrong";
+ $verified = 0;
+ $patron->auth_method('two-factor')->store;
+ ( $userid, $cookie, $sessionID, $flags ) = C4::Auth::checkauth( $cgi, 'authrequired', undef, 'intranet' );
+ is( $userid, $patron->userid, 'Succesful login' );
+ is( C4::Auth::get_session($sessionID)->param('waiting-for-2FA'), 1, 'Second auth still required after wrong OTP token' );
+
+ $otp_token = "good";
+ $verified = 1;
+ ( $userid, $cookie, $sessionID, $flags ) = C4::Auth::checkauth( $cgi, 'authrequired', undef, 'intranet' );
+ is( $userid, $patron->userid, 'Succesful login' );
+ is( C4::Auth::get_session($sessionID)->param('waiting-for-2FA'), 0, 'Second auth no longer required if OTP token has been verified' );
+ logout($cgi);
+
+ t::lib::Mocks::mock_preference( 'TwoFactorAuthentication', 'enforced' );
+ $patron->auth_method('password')->store;
+ ( $userid, $cookie, $sessionID, $flags ) = C4::Auth::checkauth( $cgi, 'authrequired', undef, 'intranet' );
+ is( $userid, $patron->userid, 'Succesful login' );
+ is( C4::Auth::get_session($sessionID)->param('waiting-for-2FA-setup'), 1, 'Setup 2FA required' );
+ logout($cgi);
+
+ ( $userid, $cookie, $sessionID, $flags ) = C4::Auth::checkauth( $cgi, 'authrequired', undef, 'opac' );
+ is( $userid, $patron->userid, 'Succesful login at the OPAC' );
+ is( C4::Auth::get_session($sessionID)->param('waiting-for-2FA'), undef, 'No second auth required at the OPAC' );
+
+ #
+ t::lib::Mocks::mock_preference( 'TwoFactorAuthentication', 'disabled' );
+ $session = C4::Auth::get_session($sessionID);
+ $session->param('waiting-for-2FA', 1);
+ $session->flush;
+ my ($auth_status, undef ) = C4::Auth::check_cookie_auth($sessionID, undef );
+ is( $auth_status, 'ok', 'User authenticated, pref was disabled, access OK' );
+ $session->param('waiting-for-2FA', 0);
+ $session->param('waiting-for-2FA-setup', 1);
+ $session->flush;
+ ($auth_status, undef ) = C4::Auth::check_cookie_auth($sessionID, undef );
+ is( $auth_status, 'ok', 'User waiting for 2FA setup, pref was disabled, access OK' );
+ };
+
+ subtest 'loggedinlibrary permission tests' => sub {
+
+ plan tests => 3;
+ my $staff_user = $builder->build_object(
+ { class => 'Koha::Patrons', value => { flags => 536870916 } } );
+
+ my $branch = $builder->build_object({ class => 'Koha::Libraries' });
+
+ my $password = 'password';
+ t::lib::Mocks::mock_preference( 'RequireStrongPassword', 0 );
+ $staff_user->set_password( { password => $password } );
+ my $cgi = Test::MockObject->new();
+ $cgi->mock( 'cookie', sub { return; } );
+ $cgi->mock(
+ 'param',
+ sub {
+ my ( $self, $param ) = @_;
+ if ( $param eq 'userid' ) { return $staff_user->userid; }
+ elsif ( $param eq 'password' ) { return $password; }
+ elsif ( $param eq 'branch' ) { return $branch->branchcode; }
+ else { return; }
+ }
+ );
+
+ $cgi->mock( 'request_method', sub { return 'POST' } );
+ my ( $userid, $cookie, $sessionID, $flags ) = C4::Auth::checkauth( $cgi, 'authrequired' );
+ my $sesh = C4::Auth::get_session($sessionID);
+ is( $sesh->param('branch'), $branch->branchcode, "If user has permission, they should be able to choose a branch" );
+
+ $staff_user->flags(4)->store->discard_changes;
+ ( $userid, $cookie, $sessionID, $flags ) = C4::Auth::checkauth( $cgi, 'authrequired' );
+ $sesh = C4::Auth::get_session($sessionID);
+ is( $sesh->param('branch'), $staff_user->branchcode, "If user has not permission, they should not be able to choose a branch" );
+
+ $staff_user->flags(1)->store->discard_changes;
+ ( $userid, $cookie, $sessionID, $flags ) = C4::Auth::checkauth( $cgi, 'authrequired' );
+ $sesh = C4::Auth::get_session($sessionID);
+ is( $sesh->param('branch'), $branch->branchcode, "If user is superlibrarian, they should be able to choose a branch" );
+
+ };
+ C4::Context->_new_userenv; # For next tests
+};
+
+subtest 'track_login_daily tests' => sub {
+
+ plan tests => 5;
+
+ my $patron = $builder->build_object({ class => 'Koha::Patrons' });
+ my $userid = $patron->userid;
+
+ $patron->lastseen( undef );
+ $patron->store();
+
+ my $cache = Koha::Caches->get_instance();
+ my $cache_key = "track_login_" . $patron->userid;
+ $cache->clear_from_cache($cache_key);
+
+ t::lib::Mocks::mock_preference( 'TrackLastPatronActivity', '1' );
+
+ is( $patron->lastseen, undef, 'Patron should have not last seen when newly created' );
+
+ C4::Auth::track_login_daily( $userid );
+ $patron->_result()->discard_changes();
+ isnt( $patron->lastseen, undef, 'Patron should have last seen set when TrackLastPatronActivity = 1' );
+
+ sleep(1); # We need to wait a tiny bit to make sure the timestamp will be different
+ my $last_seen = $patron->lastseen;
+ C4::Auth::track_login_daily( $userid );
+ $patron->_result()->discard_changes();
+ is( $patron->lastseen, $last_seen, 'Patron last seen should still be unchanged' );
+
+ $cache->clear_from_cache($cache_key);
+ C4::Auth::track_login_daily( $userid );
+ $patron->_result()->discard_changes();
+ isnt( $patron->lastseen, $last_seen, 'Patron last seen should be changed if we cleared the cache' );
+
+ t::lib::Mocks::mock_preference( 'TrackLastPatronActivity', '0' );
+ $patron->lastseen( undef )->store;
+ $cache->clear_from_cache($cache_key);
+ C4::Auth::track_login_daily( $userid );
+ $patron->_result()->discard_changes();
+ is( $patron->lastseen, undef, 'Patron should still have last seen unchanged when TrackLastPatronActivity = 0' );
+
+};
+
+subtest 'no_set_userenv parameter tests' => sub {
+
+ plan tests => 7;
+
+ my $library = $builder->build_object( { class => 'Koha::Libraries' } );
+ my $patron = $builder->build_object( { class => 'Koha::Patrons' } );
+ my $password = 'password';
+
+ t::lib::Mocks::mock_preference( 'RequireStrongPassword', 0 );
+ $patron->set_password({ password => $password });
+
+ ok( checkpw( $patron->userid, $password, undef, undef, 1 ), 'checkpw returns true' );
+ is( C4::Context->userenv, undef, 'Userenv should be undef as required' );
+ C4::Context->_new_userenv('DUMMY SESSION');
+ C4::Context->set_userenv(0,0,0,'firstname','surname', $library->branchcode, 'Library 1', 0, '', '');
+ is( C4::Context->userenv->{branch}, $library->branchcode, 'Userenv gives correct branch' );
+ ok( checkpw( $patron->userid, $password, undef, undef, 1 ), 'checkpw returns true' );
+ is( C4::Context->userenv->{branch}, $library->branchcode, 'Userenv branch is preserved if no_set_userenv is true' );
+ ok( checkpw( $patron->userid, $password, undef, undef, 0 ), 'checkpw still returns true' );
+ isnt( C4::Context->userenv->{branch}, $library->branchcode, 'Userenv branch is overwritten if no_set_userenv is false' );
+};
+
+subtest 'checkpw lockout tests' => sub {
+
+ plan tests => 5;
+
+ my $library = $builder->build_object( { class => 'Koha::Libraries' } );
+ my $patron = $builder->build_object( { class => 'Koha::Patrons' } );
+ my $password = 'password';
+ t::lib::Mocks::mock_preference( 'RequireStrongPassword', 0 );
+ t::lib::Mocks::mock_preference( 'FailedLoginAttempts', 1 );
+ $patron->set_password({ password => $password });
+
+ my ( $checkpw, undef, undef ) = checkpw( $patron->cardnumber, $password, undef, undef, 1 );
+ ok( $checkpw, 'checkpw returns true with right password when logging in via cardnumber' );
+ ( $checkpw, undef, undef ) = checkpw( $patron->userid, "wrong_password", undef, undef, 1 );
+ is( $checkpw, 0, 'checkpw returns false when given wrong password' );
+ $patron = $patron->get_from_storage;
+ is( $patron->account_locked, 1, "Account is locked from failed login");
+ ( $checkpw, undef, undef ) = checkpw( $patron->userid, $password, undef, undef, 1 );
+ is( $checkpw, undef, 'checkpw returns undef with right password when account locked' );
+ ( $checkpw, undef, undef ) = checkpw( $patron->cardnumber, $password, undef, undef, 1 );
+ is( $checkpw, undef, 'checkpw returns undefwith right password when logging in via cardnumber if account locked' );
+
+};
# get_template_and_user tests
-{ # Tests for the language URL parameter
+subtest 'get_template_and_user' => sub { # Tests for the language URL parameter
sub MockedCheckauth {
my ($query,$authnotrequired,$flagsrequired,$type) = @_;
# we don't need to bother about permissions for this test
my $flags = {
superlibrarian => 1, acquisition => 0,
- borrow => 0, borrowers => 0,
+ borrowers => 0,
catalogue => 1, circulate => 0,
coursereserves => 0, editauthorities => 0,
- editcatalogue => 0, management => 0,
+ editcatalogue => 0,
parameters => 0, permissions => 0,
plugins => 0, reports => 0,
reserveforothers => 0, serials => 0,
-HttpOnly => 1
);
- return ( $userid, $session_cookie, $sessionID, $flags );
+ return ( $userid, [ $session_cookie ], $sessionID, $flags );
}
# Mock checkauth, build the scenario
- my $auth = new Test::MockModule( 'C4::Auth' );
+ my $auth = Test::MockModule->new( 'C4::Auth' );
$auth->mock( 'checkauth', \&MockedCheckauth );
# Make sure 'EnableOpacSearchHistory' is set
- C4::Context->set_preference('EnableOpacSearchHistory',1);
+ t::lib::Mocks::mock_preference('EnableOpacSearchHistory',1);
# Enable es-ES for the OPAC and staff interfaces
- C4::Context->set_preference('opaclanguages','en,es-ES');
- C4::Context->set_preference('language','en,es-ES');
+ t::lib::Mocks::mock_preference('OPACLanguages','en,es-ES');
+ t::lib::Mocks::mock_preference('language','en,es-ES');
# we need a session cookie
$ENV{"SERVER_PORT"} = 80;
$ENV{"HTTP_COOKIE"} = 'CGISESSID=nirvana';
- my $query = new CGI;
+ my $query = CGI->new;
$query->param('language','es-ES');
my ( $template, $loggedinuser, $cookies ) = get_template_and_user(
../../../../../../../../../../../../../../../etc/passwd
test/../../../../../../../../../../../../../../etc/passwd
/etc/passwd
+ test/does_not_finished_by_tt_t
)
) {
eval {
}
);
};
- like ( $@, qr(^bad template path), 'The file $template_name should not be accessible' );
+ like ( $@, qr(bad template path), "The file $template_name should not be accessible" );
}
-}
+ ( $template, $loggedinuser, $cookies ) = get_template_and_user(
+ {
+ template_name => 'errors/errorpage.tt',
+ query => $query,
+ type => "intranet",
+ authnotrequired => 1,
+ flagsrequired => { catalogue => 1 },
+ }
+ );
+ my $file_exists = ( -f $template->{filename} ) ? 1 : 0;
+ is ( $file_exists, 1, 'The file errors/errorpage.tt should be accessible (contains integers)' );
+
+ # Regression test for env opac search limit override
+ $ENV{"OPAC_SEARCH_LIMIT"} = "branch:CPL";
+ $ENV{"OPAC_LIMIT_OVERRIDE"} = 1;
+
+ ( $template, $loggedinuser, $cookies) = get_template_and_user(
+ {
+ template_name => 'opac-main.tt',
+ query => $query,
+ type => 'opac',
+ authnotrequired => 1,
+ }
+ );
+ is($template->{VARS}->{'opac_name'}, "CPL", "Opac name was set correctly");
+ is($template->{VARS}->{'opac_search_limit'}, "branch:CPL", "Search limit was set correctly");
+
+ $ENV{"OPAC_SEARCH_LIMIT"} = "branch:multibranch-19";
+
+ ( $template, $loggedinuser, $cookies) = get_template_and_user(
+ {
+ template_name => 'opac-main.tt',
+ query => $query,
+ type => 'opac',
+ authnotrequired => 1,
+ }
+ );
+ is($template->{VARS}->{'opac_name'}, "multibranch-19", "Opac name was set correctly");
+ is($template->{VARS}->{'opac_search_limit'}, "branch:multibranch-19", "Search limit was set correctly");
+
+ delete $ENV{"HTTP_COOKIE"};
+};
# Check that there is always an OPACBaseURL set.
my $input = CGI->new();
ok(C4::Auth::checkpw_hash('password', $hash1), 'password validates with first hash');
ok(C4::Auth::checkpw_hash('password', $hash2), 'password validates with second hash');
-$dbh->rollback;
+subtest 'Check value of login_attempts in checkpw' => sub {
+ plan tests => 11;
+
+ t::lib::Mocks::mock_preference('FailedLoginAttempts', 3);
+
+ # Only interested here in regular login
+ $C4::Auth::cas = 0;
+ $C4::Auth::ldap = 0;
+
+ my $patron = $builder->build_object({ class => 'Koha::Patrons' });
+ $patron->login_attempts(2);
+ $patron->password('123')->store; # yes, deliberately not hashed
+
+ is( $patron->account_locked, 0, 'Patron not locked' );
+ my @test = checkpw( $patron->userid, '123', undef, 'opac', 1 );
+ # Note: 123 will not be hashed to 123 !
+ is( $test[0], 0, 'checkpw should have failed' );
+ $patron->discard_changes; # refresh
+ is( $patron->login_attempts, 3, 'Login attempts increased' );
+ is( $patron->account_locked, 1, 'Check locked status' );
+
+ # And another try to go over the limit: different return value!
+ @test = checkpw( $patron->userid, '123', undef, 'opac', 1 );
+ is( @test, 0, 'checkpw failed again and returns nothing now' );
+ $patron->discard_changes; # refresh
+ is( $patron->login_attempts, 3, 'Login attempts not increased anymore' );
+
+ # Administrative lockout cannot be undone?
+ # Pass the right password now (or: add a nice mock).
+ my $auth = Test::MockModule->new( 'C4::Auth' );
+ $auth->mock( 'checkpw_hash', sub { return 1; } ); # not for production :)
+ $patron->login_attempts(0)->store;
+ @test = checkpw( $patron->userid, '123', undef, 'opac', 1 );
+ is( $test[0], 1, 'Build confidence in the mock' );
+ $patron->login_attempts(-1)->store;
+ is( $patron->account_locked, 1, 'Check administrative lockout' );
+ @test = checkpw( $patron->userid, '123', undef, 'opac', 1 );
+ is( @test, 0, 'checkpw gave red' );
+ $patron->discard_changes; # refresh
+ is( $patron->login_attempts, -1, 'Still locked out' );
+ t::lib::Mocks::mock_preference('FailedLoginAttempts', ''); # disable
+ is( $patron->account_locked, 1, 'Check administrative lockout without pref' );
+};
+
+subtest 'Check value of login_attempts in checkpw' => sub {
+ plan tests => 2;
+
+ t::lib::Mocks::mock_preference('FailedLoginAttempts', 3);
+ my $patron = $builder->build_object({ class => 'Koha::Patrons' });
+ $patron->set_password({ password => '123', skip_validation => 1 });
+
+ my @test = checkpw( $patron->userid, '123', undef, 'opac', 1 );
+ is( $test[0], 1, 'Patron authenticated correctly' );
+
+ $patron->password_expiration_date('2020-01-01')->store;
+ @test = checkpw( $patron->userid, '123', undef, 'opac', 1 );
+ is( $test[0], -2, 'Patron returned as expired correctly' );
+
+};
+
+subtest '_timeout_syspref' => sub {
+
+ plan tests => 6;
+
+ t::lib::Mocks::mock_preference('timeout', "100");
+ is( C4::Auth::_timeout_syspref, 100, );
+
+ t::lib::Mocks::mock_preference('timeout', "2d");
+ is( C4::Auth::_timeout_syspref, 2*86400, );
+
+ t::lib::Mocks::mock_preference('timeout', "2D");
+ is( C4::Auth::_timeout_syspref, 2*86400, );
+
+ t::lib::Mocks::mock_preference('timeout', "10h");
+ is( C4::Auth::_timeout_syspref, 10*3600, );
+
+ t::lib::Mocks::mock_preference('timeout', "10x");
+ warning_is
+ { is( C4::Auth::_timeout_syspref, 600, ); }
+ "The value of the system preference 'timeout' is not correct, defaulting to 600",
+ 'Bad values throw a warning and fallback to 600';
+};
+
+subtest 'check_cookie_auth' => sub {
+ plan tests => 4;
+
+ t::lib::Mocks::mock_preference('timeout', "1d"); # back to default
+
+ my $patron = $builder->build_object({ class => 'Koha::Patrons', value => { flags => 1 } });
+
+ # Mock a CGI object with real userid param
+ my $cgi = Test::MockObject->new();
+ $cgi->mock(
+ 'param',
+ sub {
+ my $var = shift;
+ if ( $var eq 'userid' ) { return $patron->userid; }
+ }
+ );
+ $cgi->mock('multi_param', sub {return q{}} );
+ $cgi->mock( 'cookie', sub { return; } );
+ $cgi->mock( 'request_method', sub { return 'POST' } );
+
+ $ENV{REMOTE_ADDR} = '127.0.0.1';
+
+ # Setting authnotrequired=1 or we wont' hit the return but the end of the sub that prints headers
+ my ( $userid, $cookie, $sessionID, $flags ) = C4::Auth::checkauth( $cgi, 1 );
+
+ my ($auth_status, $session) = C4::Auth::check_cookie_auth($sessionID);
+ isnt( $auth_status, 'ok', 'check_cookie_auth should not return ok if the user has not been authenticated before if no permissions needed' );
+ is( $auth_status, 'anon', 'check_cookie_auth should return anon if the user has not been authenticated before and no permissions needed' );
+
+ ( $userid, $cookie, $sessionID, $flags ) = C4::Auth::checkauth( $cgi, 1 );
+
+ ($auth_status, $session) = C4::Auth::check_cookie_auth($sessionID, {catalogue => 1});
+ isnt( $auth_status, 'ok', 'check_cookie_auth should not return ok if the user has not been authenticated before and permissions needed' );
+ is( $auth_status, 'anon', 'check_cookie_auth should return anon if the user has not been authenticated before and permissions needed' );
+
+ #FIXME We should have a test to cover 'failed' status when a user has logged in, but doesn't have permission
+};
+
+subtest 'checkauth & check_cookie_auth' => sub {
+ plan tests => 31;
+
+ # flags = 4 => { catalogue => 1 }
+ my $patron = $builder->build_object({ class => 'Koha::Patrons', value => { flags => 4 } });
+ my $password = 'password';
+ t::lib::Mocks::mock_preference( 'RequireStrongPassword', 0 );
+ $patron->set_password( { password => $password } );
+
+ my $cgi_mock = Test::MockModule->new('CGI');
+ $cgi_mock->mock( 'request_method', sub { return 'POST' } );
+
+ my $cgi = CGI->new;
+
+ my $auth = Test::MockModule->new( 'C4::Auth' );
+ # Tests will fail if we hit safe_exit
+ $auth->mock( 'safe_exit', sub { return } );
+
+ my ( $userid, $cookie, $sessionID, $flags );
+ {
+ # checkauth will redirect and safe_exit if not authenticated and not authorized
+ local *STDOUT;
+ my $stdout;
+ open STDOUT, '>', \$stdout;
+ C4::Auth::checkauth($cgi, 0, {catalogue => 1});
+ like( $stdout, qr{<title>\s*Log in to your account} );
+ $sessionID = ( $stdout =~ m{Set-Cookie: CGISESSID=((\d|\w)+);} ) ? $1 : undef;
+ ok($sessionID);
+ close STDOUT;
+ };
+
+ my $first_sessionID = $sessionID;
+
+ $ENV{"HTTP_COOKIE"} = "CGISESSID=$sessionID";
+ # Not authenticated yet, checkauth didn't return the session
+ {
+ local *STDOUT;
+ my $stdout;
+ open STDOUT, '>', \$stdout;
+ ( $userid, $cookie, $sessionID, $flags ) = C4::Auth::checkauth($cgi, 0, {catalogue => 1} );
+ close STDOUT;
+ }
+ is( $sessionID, undef);
+ is( $userid, undef);
+
+ # Sending undefined fails obviously
+ my ( $auth_status, $session ) = C4::Auth::check_cookie_auth($sessionID, {catalogue => 1} );
+ is( $auth_status, 'failed' );
+ is( $session, undef );
+
+ # Simulating the login form submission
+ $cgi->param('userid', $patron->userid);
+ $cgi->param('password', $password);
+
+ # Logged in!
+ ( $userid, $cookie, $sessionID, $flags ) = C4::Auth::checkauth($cgi, 0, {catalogue => 1});
+ is( $sessionID, $first_sessionID );
+ is( $userid, $patron->userid );
+
+ ( $auth_status, $session ) = C4::Auth::check_cookie_auth($sessionID, {catalogue => 1});
+ is( $auth_status, 'ok' );
+ is( $session->id, $first_sessionID );
+
+ # Logging out!
+ $cgi->param('logout.x', 1);
+ $cgi->delete( 'userid', 'password' );
+ {
+ local *STDOUT;
+ my $stdout;
+ open STDOUT, '>', \$stdout;
+ ( $userid, $cookie, $sessionID, $flags ) = C4::Auth::checkauth($cgi, 0, {catalogue => 1});
+ close STDOUT;
+ }
+ is( $sessionID, undef );
+ is( $ENV{"HTTP_COOKIE"}, "CGISESSID=$first_sessionID", 'HTTP_COOKIE not unset' );
+ ( $auth_status, $session) = C4::Auth::check_cookie_auth( $first_sessionID, {catalogue => 1} );
+ is( $auth_status, "expired");
+ is( $session, undef );
+
+ {
+ # Trying to access without sessionID
+ $cgi = CGI->new;
+ ( $auth_status, $session) = C4::Auth::check_cookie_auth(undef, {catalogue => 1});
+ is( $auth_status, 'failed' );
+ is( $session, undef );
+
+ # This will fail on permissions
+ undef $ENV{"HTTP_COOKIE"};
+ {
+ local *STDOUT;
+ my $stdout;
+ open STDOUT, '>', \$stdout;
+ ( $userid, $cookie, $sessionID, $flags ) = C4::Auth::checkauth($cgi, 0, {catalogue => 1} );
+ close STDOUT;
+ }
+ is( $userid, undef );
+ is( $sessionID, undef );
+ }
+
+ {
+ # First logging in
+ $cgi = CGI->new;
+ $cgi->param('userid', $patron->userid);
+ $cgi->param('password', $password);
+ ( $userid, $cookie, $sessionID, $flags ) = C4::Auth::checkauth($cgi, 0, {catalogue => 1});
+ is( $userid, $patron->userid );
+ $first_sessionID = $sessionID;
+
+ # Patron does not have the borrowers permission
+ # $ENV{"HTTP_COOKIE"} = "CGISESSID=$sessionID"; # not needed, we use $cgi here
+ {
+ local *STDOUT;
+ my $stdout;
+ open STDOUT, '>', \$stdout;
+ ( $userid, $cookie, $sessionID, $flags ) = C4::Auth::checkauth($cgi, 0, {borrowers => 1} );
+ close STDOUT;
+ }
+ is( $userid, undef );
+ is( $sessionID, undef );
+
+ # When calling check_cookie_auth, the session will be deleted
+ ( $auth_status, $session) = C4::Auth::check_cookie_auth( $first_sessionID, { borrowers => 1 } );
+ is( $auth_status, "failed" );
+ is( $session, undef );
+ ( $auth_status, $session) = C4::Auth::check_cookie_auth( $first_sessionID, { borrowers => 1 } );
+ is( $auth_status, 'expired', 'Session no longer exists' );
+
+ # NOTE: It is not what the UI is doing.
+ # From the UI we are allowed to hit an unauthorized page then reuse the session to hit back authorized area.
+ # It is because check_cookie_auth is ALWAYS called from checkauth WITHOUT $flagsrequired
+ # It then return "ok", when the previous called got "failed"
+
+ # Try reusing the deleted session: since it does not exist, we should get a new one now when passing correct permissions
+ $cgi->cookie( -name => 'CGISESSID', value => $first_sessionID );
+ ( $userid, $cookie, $sessionID, $flags ) = C4::Auth::checkauth($cgi, 0, {catalogue => 1});
+ is( $userid, $patron->userid );
+ isnt( $sessionID, undef, 'Check if we have a sessionID' );
+ isnt( $sessionID, $first_sessionID, 'New value expected' );
+ ( $auth_status, $session) = C4::Auth::check_cookie_auth( $sessionID, {catalogue => 1} );
+ is( $auth_status, "ok" );
+ is( $session->id, $sessionID, 'Same session' );
+ # Two additional tests on userenv
+ is( $C4::Context::context->{activeuser}, $session->id, 'Check if environment has been setup for session' );
+ is( C4::Context->userenv->{id}, $userid, 'Check userid in userenv' );
+ }
+};
+
+subtest 'Userenv clearing in check_cookie_auth' => sub {
+ # Note: We did already test userenv for a logged-in user in previous subtest
+ plan tests => 9;
+
+ t::lib::Mocks::mock_preference( 'timeout', 600 );
+ my $cgi = CGI->new;
+
+ # Create a new anonymous session by passing a fake session ID
+ $cgi->cookie( -name => 'CGISESSID', -value => 'fake_sessionID' );
+ my ($userid, $cookie, $sessionID, $flags ) = C4::Auth::checkauth($cgi, 1);
+ my ( $auth_status, $session) = C4::Auth::check_cookie_auth( $sessionID );
+ is( $auth_status, 'anon', 'Should be anonymous' );
+ is( $C4::Context::context->{activeuser}, $session->id, 'Check activeuser' );
+ is( defined C4::Context->userenv, 1, 'There should be a userenv' );
+ is( C4::Context->userenv->{id}, q{}, 'userid should be empty string' );
+
+ # Make the session expire now, check_cookie_auth will delete it
+ $session->param('lasttime', time() - 1200 );
+ $session->flush;
+ ( $auth_status, $session) = C4::Auth::check_cookie_auth( $sessionID );
+ is( $auth_status, 'expired', 'Should be expired' );
+ is( C4::Context->userenv, undef, 'Environment should be cleared too' );
+
+ # Show that we clear the userenv again: set up env and check deleted session
+ C4::Context->_new_userenv( $sessionID );
+ C4::Context->set_userenv; # empty
+ is( defined C4::Context->userenv, 1, 'There should be an empty userenv again' );
+ ( $auth_status, $session) = C4::Auth::check_cookie_auth( $sessionID );
+ is( $auth_status, 'expired', 'Should be expired already' );
+ is( C4::Context->userenv, undef, 'Environment should be cleared again' );
+};
+
+subtest 'create_basic_session tests' => sub {
+ plan tests => 13;
+
+ my $patron = $builder->build_object({ class => 'Koha::Patrons' });
+
+ my $session = C4::Auth::create_basic_session({ patron => $patron, interface => 'opac' });
+
+ isnt($session->id, undef, 'A new sessionID was created');
+ is( $session->param('number'), $patron->borrowernumber, 'Session parameter number matches' );
+ is( $session->param('id'), $patron->userid, 'Session parameter id matches' );
+ is( $session->param('cardnumber'), $patron->cardnumber, 'Session parameter cardnumber matches' );
+ is( $session->param('firstname'), $patron->firstname, 'Session parameter firstname matches' );
+ is( $session->param('surname'), $patron->surname, 'Session parameter surname matches' );
+ is( $session->param('branch'), $patron->branchcode, 'Session parameter branch matches' );
+ is( $session->param('branchname'), $patron->library->branchname, 'Session parameter branchname matches' );
+ is( $session->param('flags'), $patron->flags, 'Session parameter flags matches' );
+ is( $session->param('emailaddress'), $patron->email, 'Session parameter emailaddress matches' );
+ is( $session->param('ip'), $session->remote_addr(), 'Session parameter ip matches' );
+ is( $session->param('interface'), 'opac', 'Session parameter interface matches' );
+
+ $session = C4::Auth::create_basic_session({ patron => $patron, interface => 'staff' });
+ is( $session->param('interface'), 'intranet', 'Staff interface gets converted to intranet' );
+};
+
+$schema->storage->txn_rollback;
projects / koha-ffzg.git / blobdiff