Bug 9811: Remove useless orderby management

[koha_fer] / t / Letters.t

diff --git a/t/Letters.t b/t/Letters.t
index b269e86..18ae129 100755 (executable)
--- a/t/Letters.t
+++ b/t/Letters.t
@@ -1,17 +1,26 @@
 #!/usr/bin/perl
-#
-# This Koha test module is a stub!
-# Add more tests here!!!
 
-use strict;
-use warnings;
-use Test::MockModule;
-use Test::More tests => 2;
+# This file is part of Koha.
+#
+# Koha is free software; you can redistribute it and/or modify it
+# under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# Koha is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with Koha; if not, see <http://www.gnu.org/licenses>.
 
-BEGIN {
-    use_ok('C4::Letters');
-}
+use Modern::Perl;
 
+use DBI;
+use Test::MockModule;
+use Test::More tests => 5;
+use t::lib::Mocks;
 my $module = new Test::MockModule('C4::Context');
 $module->mock(
     '_new_dbh',
@@ -27,10 +36,26 @@ my $mock_letters = [
     [ 'bleh',   'ISSN', 'NSSI',       'page', 0,         'blue',  'blehbleh' ]
 ];
 
+use_ok('C4::Letters');
+
 my $dbh = C4::Context->dbh();
 
 $dbh->{mock_add_resultset} = $mock_letters;
 
 my $letters = C4::Letters::GetLetters();
 
-is( $letters->{ISBN}, 'book', 'HASH ref of ISBN is book' );
+my ( $ISBN_letter ) = grep {$_->{code} eq 'ISBN'} @$letters;
+is( $ISBN_letter->{name}, 'book', 'letter name for "ISBN" letter is book' );
+is( scalar( @$letters ), 2, 'GetLetters returns the 2 inserted letters' );
+
+# Regression test for bug 10843
+# $dt->add takes a scalar, not undef
+my $letter;
+t::lib::Mocks::mock_preference('ReservesMaxPickUpDelay', undef);
+$letter = C4::Letters::_parseletter( undef, 'reserves', {waitingdate => "2013-01-01"} );
+is( ref($letter), 'HASH');
+t::lib::Mocks::mock_preference('ReservesMaxPickUpDelay', 1);
+$letter = C4::Letters::_parseletter( undef, 'reserves', {waitingdate => "2013-01-01"} );
+is( ref($letter), 'HASH');
+
+1;