Bug 15150: Make t/ tests skip if Test::DBIx::Class absent

[koha-ffzg.git] / t / Koha.t

diff --git a/t/Koha.t b/t/Koha.t
index 31365e6..3593368 100755 (executable)
--- a/t/Koha.t
+++ b/t/Koha.t
@@ -1,43 +1,67 @@
 #!/usr/bin/perl
-use strict;
-use warnings;
+
+# This file is part of Koha.
+#
+# Koha is free software; you can redistribute it and/or modify it
+# under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# Koha is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with Koha; if not, see <http://www.gnu.org/licenses>.
+
+use Modern::Perl;
 
 use C4::Context;
-use Test::More tests => 16;
+use Test::More;
 use Test::MockModule;
-use DBD::Mock;
 
-use_ok('C4::Koha');
+use Module::Load::Conditional qw/check_install/;
 
-my $module_context = new Test::MockModule('C4::Context');
-$module_context->mock(
-    '_new_dbh',
-    sub {
-        my $dbh = DBI->connect( 'DBI:Mock:', '', '' )
-          || die "Cannot create handle: $DBI::errstr\n";
-        return $dbh;
+BEGIN {
+    if ( check_install( module => 'Test::DBIx::Class' ) ) {
+        plan tests => 30;
+    } else {
+        plan skip_all => "Need Test::DBIx::Class"
     }
-);
-
-SKIP: {
-
-    skip "DBD::Mock is too old", 3
-        unless $DBD::Mock::VERSION >= 1.45;
+}
 
-    my @loc_results = (['category'],['LOC']);
-    my @empty_results = ([]);
-    my @relterms_results = (['category'],['RELTERMS']);
-
-    my $dbh = C4::Context->dbh();
-
-    $dbh->{mock_add_resultset} = \@loc_results;
-    is ( IsAuthorisedValueCategory('LOC'), 1, 'LOC is a valid authorized value category');
-    $dbh->{mock_add_resultset} = \@empty_results;
-    is ( IsAuthorisedValueCategory('something'), 0, 'something is not a valid authorized value category');
-    $dbh->{mock_add_resultset} = \@relterms_results;
-    is ( IsAuthorisedValueCategory('RELTERMS'), 1, 'RELTERMS is a valid authorized value category');
+use_ok('C4::Koha');
 
-} # End SKIP block
+use Test::DBIx::Class {
+    schema_class => 'Koha::Schema',
+    connect_info => ['dbi:SQLite:dbname=:memory:','',''],
+    connect_opts => { name_sep => '.', quote_char => '`', },
+    fixture_class => '::Populate',
+}, 'AuthorisedValue' ;
+
+sub fixtures {
+    my ( $data ) = @_;
+    fixtures_ok [
+        AuthorisedValue => [
+            [ 'category', 'authorised_value' ],
+            @$data,
+        ],
+    ], 'add fixtures';
+}
+
+my $db = Test::MockModule->new('Koha::Database');
+$db->mock( _new_schema => sub { return Schema(); } );
+
+my $authorised_values = [
+    ['LOC', 'LOC'],
+    ['RELTERMS', 'RELTERMS'],
+];
+fixtures($authorised_values);
+
+is ( IsAuthorisedValueCategory('LOC'), 1, 'LOC is a valid authorized value category');
+is ( IsAuthorisedValueCategory('something'), 0, 'something is not a valid authorized value category');
+is ( IsAuthorisedValueCategory('RELTERMS'), 1, 'RELTERMS is a valid authorized value category');
 
 #
 # test that &slashifyDate returns correct (non-US) date
@@ -74,5 +98,25 @@ eval {
 };
 ok($@ eq '', 'NormalizeISBN does not throw exception when parsing invalid ISBN (bug 12243)');
 
+eval {
+    $isbn = C4::Koha::NormalizeISBN({ isbn => '979-10-90085-00-8', format => 'ISBN-10', strip_hyphens => 1 });
+};
+ok($@ eq '', 'NormalizeISBN does not throw exception when converting to ISBN10 an ISBN starting with 979 (bug 13167)');
+ok(!defined $isbn, 'NormalizeISBN returns undef when converting to ISBN10 an ISBN starting with 979 (bug 13167)');
+
 @isbns = GetVariationsOfISBNs('abc');
 is(scalar(@isbns), 0, 'zero variations returned of invalid ISBN');
+
+is( C4::Koha::GetNormalizedISBN('9780062059994 (hardcover bdg.) | 0062059998 (hardcover bdg.)'), '0062059998', 'Test GetNormalizedISBN' );
+is( C4::Koha::GetNormalizedISBN('9780385753067 (trade) | 0385753063 (trade) | 9780385753074 (lib. bdg.) | 0385753071 (lib. bdg.)'), '0385753063', 'Test GetNormalizedISBN' );
+is( C4::Koha::GetNormalizedISBN('9781432829162 (hardcover) | 1432829165 (hardcover)'), '1432829165', 'Test GetNormalizedISBN' );
+is( C4::Koha::GetNormalizedISBN('9780062063625 (hardcover) | 9780062063632 | 0062063634'), '0062063626', 'Test GetNormalizedISBN' );
+is( C4::Koha::GetNormalizedISBN('9780062059932 (hardback)'), '0062059939', 'Test GetNormalizedISBN' );
+is( C4::Koha::GetNormalizedISBN('9780316370318 (hardback) | 9780316376266 (special edition hardcover) | 9780316405454 (international paperback edition)'), '0316370312', 'Test GetNormalizedISBN' );
+is( C4::Koha::GetNormalizedISBN('9781595148032 (hbk.) | 1595148035 (hbk.)') , '1595148035', 'Test GetNormalizedISBN' );
+is( C4::Koha::GetNormalizedISBN('9780062349859 | 0062349856 | 9780062391308 | 0062391305'), '0062349856', 'Test GetNormalizedISBN' );
+is( C4::Koha::GetNormalizedISBN('9781250075345 (hardcover) | 1250075343 (hardcover) | 9781250049872 (trade pbk.) | 1250049873 (trade pbk.)'), '1250075343', 'Test GetNormalizedISBN' );
+is( C4::Koha::GetNormalizedISBN('9781250067128 | 125006712X'), '125006712X', 'Test GetNormalizedISBN' );
+is( C4::Koha::GetNormalizedISBN('9780373211463 | 0373211465'), '0373211465', 'Test GetNormalizedISBN' );
+
+1;