Bug 9811: Remove useless orderby management

[koha_fer] / t / Koha.t

diff --git a/t/Koha.t b/t/Koha.t
index 025ab98..31365e6 100755 (executable)
--- a/t/Koha.t
+++ b/t/Koha.t
@@ -2,10 +2,43 @@
 use strict;
 use warnings;
 
-use Test::More tests => 8;
+use C4::Context;
+use Test::More tests => 16;
+use Test::MockModule;
+use DBD::Mock;
 
 use_ok('C4::Koha');
 
+my $module_context = new Test::MockModule('C4::Context');
+$module_context->mock(
+    '_new_dbh',
+    sub {
+        my $dbh = DBI->connect( 'DBI:Mock:', '', '' )
+          || die "Cannot create handle: $DBI::errstr\n";
+        return $dbh;
+    }
+);
+
+SKIP: {
+
+    skip "DBD::Mock is too old", 3
+        unless $DBD::Mock::VERSION >= 1.45;
+
+    my @loc_results = (['category'],['LOC']);
+    my @empty_results = ([]);
+    my @relterms_results = (['category'],['RELTERMS']);
+
+    my $dbh = C4::Context->dbh();
+
+    $dbh->{mock_add_resultset} = \@loc_results;
+    is ( IsAuthorisedValueCategory('LOC'), 1, 'LOC is a valid authorized value category');
+    $dbh->{mock_add_resultset} = \@empty_results;
+    is ( IsAuthorisedValueCategory('something'), 0, 'something is not a valid authorized value category');
+    $dbh->{mock_add_resultset} = \@relterms_results;
+    is ( IsAuthorisedValueCategory('RELTERMS'), 1, 'RELTERMS is a valid authorized value category');
+
+} # End SKIP block
+
 #
 # test that &slashifyDate returns correct (non-US) date
 #
@@ -28,4 +61,18 @@ is(C4::Koha::_isbn_cleanup('0-590-35340-3'), '0590353403', '_isbn_cleanup remove
 is(C4::Koha::_isbn_cleanup('0590353403 (pbk.)'), '0590353403', '_isbn_cleanup removes parenthetical');
 is(C4::Koha::_isbn_cleanup('978-0-321-49694-2'), '0321496949', '_isbn_cleanup converts ISBN-13 to ISBN-10');
 
+is(C4::Koha::NormalizeISBN({ isbn => '978-0-321-49694-2 (pbk.)', format => 'ISBN-10', strip_hyphens => 1 }), '0321496949', 'Test NormalizeISBN with all features enabled' );
+
+my @isbns = qw/ 978-0-321-49694-2 0-321-49694-9 978-0-321-49694-2 0321496949 9780321496942/;
+is( join('|', @isbns), join('|', GetVariationsOfISBN('978-0-321-49694-2 (pbk.)')), 'GetVariationsOfISBN returns all variations' );
+
+is( join('|', @isbns), join('|', GetVariationsOfISBNs('978-0-321-49694-2 (pbk.)')), 'GetVariationsOfISBNs returns all variations' );
+
+my $isbn;
+eval {
+    $isbn = C4::Koha::NormalizeISBN({ isbn => '0788893777 (2 DVD 45th ed)', format => 'ISBN-10', strip_hyphens => 1 });
+};
+ok($@ eq '', 'NormalizeISBN does not throw exception when parsing invalid ISBN (bug 12243)');
 
+@isbns = GetVariationsOfISBNs('abc');
+is(scalar(@isbns), 0, 'zero variations returned of invalid ISBN');