Bug 27858: (follow-up) Consistency in stringified exception

[koha-ffzg.git] / t / Koha / Exceptions.t

diff --git a/t/Koha/Exceptions.t b/t/Koha/Exceptions.t
index 1a01943..908f654 100755 (executable)
--- a/t/Koha/Exceptions.t
+++ b/t/Koha/Exceptions.t
@@ -200,7 +200,7 @@ subtest 'Koha::Exceptions::Object::NotInstantiated tests' => sub {
 
 subtest 'Koha::Exceptions::Patron::Attribute::* tests' => sub {
 
-    plan tests => 5;
+    plan tests => 13;
 
     use_ok("Koha::Exceptions::Patron::Attribute");
 
@@ -218,11 +218,70 @@ subtest 'Koha::Exceptions::Patron::Attribute::* tests' => sub {
         'Exception is thrown :-D';
 
     # stringify the exception
-    is( "$@", "Tried to add more than one non-repeatable attributes. code=$code attribute=$attribute", 'Exception stringified correctly' );
+    is(
+        "$@",
+        "Tried to add more than one non-repeatable attributes. type=$code value=$attribute",
+        'Exception stringified correctly'
+    );
 
     throws_ok
         { Koha::Exceptions::Patron::Attribute::NonRepeatable->throw( "Manual message exception" ) }
         'Koha::Exceptions::Patron::Attribute::NonRepeatable',
         'Exception is thrown :-D';
-    is( "$@", 'Manual message exception', 'Exception not stringified if manually passed' );
+
+    is(
+        "$@",
+        'Manual message exception',
+        'Exception not stringified if manually passed'
+    );
+
+    throws_ok
+        { Koha::Exceptions::Patron::Attribute::UniqueIDConstraint->throw(
+            attribute => $mocked_attribute ); }
+        'Koha::Exceptions::Patron::Attribute::UniqueIDConstraint',
+        'Exception is thrown :-D';
+
+    # stringify the exception
+    is(
+        "$@",
+        "Your action breaks a unique constraint on the attribute. type=$code value=$attribute",
+        'Exception stringified correctly'
+    );
+
+    throws_ok
+        { Koha::Exceptions::Patron::Attribute::UniqueIDConstraint->throw( "Manual message exception" ) }
+        'Koha::Exceptions::Patron::Attribute::UniqueIDConstraint',
+        'Exception is thrown :-D';
+
+    is(
+        "$@",
+        'Manual message exception',
+        'Exception not stringified if manually passed'
+    );
+
+    my $type = "SOME_TYPE";
+
+    throws_ok
+        { Koha::Exceptions::Patron::Attribute::InvalidType->throw(
+            type => $type ); }
+        'Koha::Exceptions::Patron::Attribute::InvalidType',
+        'Exception is thrown :-D';
+
+    # stringify the exception
+    is(
+        "$@",
+        "Tried to use an invalid attribute type. type=$type",
+        'Exception stringified correctly'
+    );
+
+    throws_ok
+        { Koha::Exceptions::Patron::Attribute::InvalidType->throw( "Manual message exception" ) }
+        'Koha::Exceptions::Patron::Attribute::InvalidType',
+        'Exception is thrown :-D';
+
+    is(
+        "$@",
+        'Manual message exception',
+        'Exception not stringified if manually passed'
+    );
 };