Bug 24606: (QA follow-up) Fix Template.t

[srvgit] / t / Circulation_barcodedecode.t

diff --git a/t/Circulation_barcodedecode.t b/t/Circulation_barcodedecode.t
old mode 100644 (file)
new mode 100755 (executable)
index f397cc9..d5f31c9
--- a/t/Circulation_barcodedecode.t
+++ b/t/Circulation_barcodedecode.t
@@ -17,58 +17,53 @@
 
 use Modern::Perl;
 
-use Test::More tests => 26;
+use Test::More tests => 29;
+use Test::Warn;
+
+use C4::Context;
 use t::lib::Mocks;
 
-C4::Context->_new_userenv(123456);
-C4::Context->set_userenv(1,'kmkale' , 1, 'km', 'kale' , 'IMS', 'IMS Branch DEscription', 0, 'kmkale@anantcorp.com');
+use_ok('C4::Circulation', qw( barcodedecode ));
 
-BEGIN {
-    # Mock the DB connexion and C4::Context
-    my $context = t::lib::Mocks::mock_dbh;
-    use_ok('C4::Circulation');
-}
+t::lib::Mocks::mock_userenv({ branchcode => 'IMS' });
 
 our %inputs = (
     cuecat     => ["26002315", '.C3nZC3nZC3nYD3b6ENnZCNnY.fHmc.C3D1Dxr2C3nZE3n7.', ".C3nZC3nZC3nYD3b6ENnZCNnY.fHmc.C3D1Dxr2C3nZE3n7.\r\n",
                     'q.C3nZC3nZC3nWDNzYDxf2CNnY.fHmc.C3DWC3nZCNjXD3nW.', '.C3nZC3nZC3nWCxjWE3D1C3nX.cGf2.ENr7C3v7D3T3ENj3C3zYDNnZ.' ],
-    whitespace => [" 26002315", "26002315 ", "\n\t26002315\n"],
+    whitespace => [" 26002315", "26002315 ", "\n\t26002315\n", "whitespace removed"],
     'T-prefix' => [qw(T0031472 T32)],
     'libsuite8' => ['b000126', 'b12', 'B0126', 'IMS-B-126', 'ims-b-126','CD0000024','00123','11998'],
     EAN13      => [qw(892685001928 695152)],
-    other      => [qw(26002315 T0031472 T32 Alphanum123), "Alpha Num 345"],
+    other      => [qw(26002315 T0031472 T32 Alphanum123), "Alpha Num 345", " side spaces removed \n"],
 );
 our %outputs = (
     cuecat     => ["26002315", "046675000808", "046675000808", "043000112403", "978068484914051500"],
-    whitespace => [qw(26002315 26002315 26002315)],
+    whitespace => [qw(26002315 26002315 26002315 whitespaceremoved)],
     'T-prefix' => [qw(T0031472 T0000002         )],
     'libsuite8' => ['IMS-b-126', 'IMS-b-12', 'IMS-B-126', 'IMS-B-126', 'ims-b-126','IMS-CD-24','IMS-b-123','IMS-b-11998'],
     EAN13      => [qw(0892685001928 0000000695152)],
-    other      => [qw(26002315 T0031472 T32 Alphanum123), "Alpha Num 345"],
+    other      => [qw(26002315 T0031472 T32 Alphanum123), "Alpha Num 345", "side spaces removed"],
 );
-    
+
 my @filters = sort keys %inputs;
 foreach my $filter (@filters) {
     foreach my $datum (@{$inputs{$filter}}) {
-        my $expect = shift @{$outputs{$filter}} or die "Internal Test Error: missing expected output for filter '$filter' on input '$datum'";
+        my $expect = shift @{$outputs{$filter}}
+            or die "Internal Test Error: missing expected output for filter '$filter' on input '$datum'";
         my $output = C4::Circulation::barcodedecode($datum, $filter);
         ok($output eq $expect, sprintf("%12s: %20s => %15s", $filter, "'$datum'", "'$expect'")); 
         ($output eq $expect) or diag  "Bad output: '$output'";
     }
 }
 
-__END__
-
-=head2 C4::Circulation::barcodedecode()
-
-This tests avoids being dependent on the database by using the optional
-second argument to barcodedecode.
+warnings_are
+    { C4::Circulation::barcodedecode(undef); }
+    [],
+    'No warnings with undef barcode';
 
-T-prefix style is derived from zero-padded "Follett Classic Code 3 of 9".  From:
-    www.fsc.follett.com/_file/File/pdf/Barcode%20Symbology%20Q%20%20A%203_05.pdf
- 
- ~ 1 to 7 characters
- ~ T, P or X followed by numeric characters
- ~ No checkdigit
+# T-prefix style is derived from zero-padded "Follett Classic Code 3 of 9".  From:
+#     www.fsc.follett.com/_file/File/pdf/Barcode%20Symbology%20Q%20%20A%203_05.pdf
+#  ~ 1 to 7 characters
+#  ~ T, P or X followed by numeric characters
+#  ~ No checkdigit
 
-=cut