Bug 27266: (follow-up) Remove instances of GetMarcAuthors

[srvgit] / t / Biblio.t

diff --git a/t/Biblio.t b/t/Biblio.t
index 0e709af..40b22ed 100755 (executable)
--- a/t/Biblio.t
+++ b/t/Biblio.t
@@ -21,34 +21,10 @@ use Test::More;
 use Test::MockModule;
 use Test::Warn;
 
-use Module::Load::Conditional qw/check_install/;
-
-BEGIN {
-    if ( check_install( module => 'Test::DBIx::Class' ) ) {
-        plan tests => 46;
-    } else {
-        plan skip_all => "Need Test::DBIx::Class"
-    }
-}
-
-use_ok('C4::Biblio');
-
-use Test::DBIx::Class {
-    schema_class => 'Koha::Schema',
-    connect_info => ['dbi:SQLite:dbname=:memory:','',''],
-    connect_opts => { name_sep => '.', quote_char => '`', },
-    fixture_class => '::Populate',
-}, 'Biblio' ;
-
-sub fixtures {
-    my ( $data ) = @_;
-    fixtures_ok [
-        Biblio => [
-            [ qw/ biblionumber datecreated timestamp  / ],
-            @$data,
-        ],
-    ], 'add fixtures';
-}
+plan tests => 37;
+
+
+use_ok('C4::Biblio', qw( AddBiblio ModBiblio BiblioAutoLink LinkBibHeadingsToAuthorities GetMarcPrice GetMarcQuantity GetMarcControlnumber GetMarcISBN GetMarcISSN GetMarcSubjects GetMarcUrls GetMarcSeries TransformMarcToKoha ModBiblioMarc RemoveAllNsb GetMarcBiblio UpdateTotalIssues ));
 
 my $db = Test::MockModule->new('Koha::Database');
 $db->mock( _new_schema => sub { return Schema(); } );
@@ -76,24 +52,12 @@ warning_is { $ret = BiblioAutoLink(undef, q{}) }
 
 is( $ret, 0, 'BiblioAutoLink returns zero if not passed rec');
 
-warning_is { $ret = GetRecordValue('100', undef, q{}) }
-           { carped => 'GetRecordValue called with undefined record'},
-           "GetRecordValue returns carped warning on undef record";
-
-ok( !defined $ret, 'GetRecordValue returns undef if not passed rec');
-
 warning_is { @arr = LinkBibHeadingsToAuthorities(q{}, q{}) }
            { carped => 'LinkBibHeadingsToAuthorities called on undefined bib record'},
            "LinkBibHeadingsToAuthorities returns carped warning on undef record";
 
 is($arr[0], 0, 'LinkBibHeadingsToAuthorities correct error return');
 
-warning_is { $ret = GetCOinSBiblio() }
-           { carped => 'GetCOinSBiblio called with undefined record'},
-           "GetCOinSBiblio returns carped warning on undef record";
-
-ok( !defined $ret, 'GetCOinSBiblio returns undef if not passed rec');
-
 warning_is { $ret = GetMarcPrice(undef, 'MARC21') }
            { carped => 'GetMarcPrice called on undefined record'},
            "GetMarcPrice returns carped warning on undef record";
@@ -124,24 +88,12 @@ warning_is { $ret = GetMarcISSN() }
 
 ok( !defined $ret, 'GetMarcISSN returns undef if not passed rec');
 
-warning_is { $ret = GetMarcNotes() }
-           { carped => 'GetMarcNotes called on undefined record'},
-           "GetMarcNotes returns carped warning on undef record";
-
-ok( !defined $ret, 'GetMarcNotes returns undef if not passed rec');
-
 warning_is { $ret = GetMarcSubjects() }
            { carped => 'GetMarcSubjects called on undefined record'},
            "GetMarcSubjects returns carped warning on undef record";
 
 ok( !defined $ret, 'GetMarcSubjects returns undef if not passed rec');
 
-warning_is { $ret = GetMarcAuthors() }
-           { carped => 'GetMarcAuthors called on undefined record'},
-           "GetMarcAuthors returns carped warning on undef record";
-
-ok( !defined $ret, 'GetMarcAuthors returns undef if not passed rec');
-
 warning_is { $ret = GetMarcUrls() }
            { carped => 'GetMarcUrls called on undefined record'},
            "GetMarcUrls returns carped warning on undef record";
@@ -154,15 +106,9 @@ warning_is { $ret = GetMarcSeries() }
 
 ok( !defined $ret, 'GetMarcSeries returns undef if not passed rec');
 
-warning_is { $ret = GetMarcHosts() }
-           { carped => 'GetMarcHosts called on undefined record'},
-           "GetMarcHosts returns carped warning on undef record";
-
-ok( !defined $ret, 'GetMarcHosts returns undef if not passed rec');
-
 my $hash_ref;
 
-warning_is { $hash_ref = TransformMarcToKoha(undef, undef) }
+warning_is { $hash_ref = TransformMarcToKoha( undef) }
            { carped => 'TransformMarcToKoha called with undefined record'},
            "TransformMarcToKoha returns carped warning on undef record";
 
@@ -185,6 +131,10 @@ warning_is { $ret = RemoveAllNsb() }
 ok( !defined $ret, 'RemoveAllNsb returns undef if not passed rec');
 
 warning_is { $ret = GetMarcBiblio() }
+           { carped => 'GetMarcBiblio called without parameters'},
+           "GetMarcBiblio returns carped warning on no parameters";
+
+warning_is { $ret = GetMarcBiblio({ biblionumber => undef }) }
            { carped => 'GetMarcBiblio called with undefined biblionumber'},
            "GetMarcBiblio returns carped warning on undef biblionumber";
 
@@ -196,5 +146,3 @@ warnings_like { $ret = UpdateTotalIssues() }
     "UpdateTotalIssues returns carped warnings if biblio record does not exist";
 
 ok( !defined $ret, 'UpdateTotalIssues returns carped warning if biblio record does not exist');
-
-1;