Bug 3150: (QA follow-up) Remove unused variables

[koha-ffzg.git] / svc / checkouts

diff --git a/svc/checkouts b/svc/checkouts
index 852827e..b8e84f4 100755 (executable)
--- a/svc/checkouts
+++ b/svc/checkouts
@@ -23,18 +23,22 @@ use CGI;
 use JSON qw(to_json);
 
 use C4::Auth qw(check_cookie_auth haspermission);
-use C4::Circulation qw(GetIssuingCharges CanBookBeRenewed GetRenewCount GetSoonestRenewDate);
+use C4::Circulation qw(GetIssuingCharges CanBookBeRenewed GetRenewCount );
 use C4::Overdues qw(GetFine);
 use C4::Context;
 
 use Koha::AuthorisedValues;
 use Koha::DateUtils qw( dt_from_string output_pref );
+use Koha::Items;
 use Koha::ItemTypes;
 
 my $input = CGI->new;
 
-my ( $auth_status, $session ) =
-  check_cookie_auth( $input->cookie('CGISESSID'));
+my ( $auth_status, $session ) = check_cookie_auth( $input->cookie('CGISESSID'));
+if( $auth_status ne 'ok' ) {
+    print CGI::header( '-status' => '401' );
+    exit 0;
+}
 
 my $userid   = $session->param('id');
 
@@ -150,13 +154,13 @@ while ( my $c = $sth->fetchrow_hashref() ) {
     my ($charge) = GetIssuingCharges( $c->{itemnumber}, $c->{borrowernumber} );
     my $fine = GetFine( $c->{itemnumber}, $c->{borrowernumber} );
 
-    my ( $can_renew, $can_renew_error ) =
+    my ( $can_renew, $can_renew_error, $info ) =
       CanBookBeRenewed( $c->{borrowernumber}, $c->{itemnumber} );
     my $can_renew_date =
       $can_renew_error && $can_renew_error eq 'too_soon'
       ? output_pref(
         {
-            dt => GetSoonestRenewDate( $c->{borrowernumber}, $c->{itemnumber} ),
+            dt => $info->{soonest_renew_date},
             as_due_date => 1
         }
       )
@@ -212,20 +216,22 @@ while ( my $c = $sth->fetchrow_hashref() ) {
 
     my $item = Koha::Items->find( $c->{itemnumber} );
     my $recalled = 0;
-    my $recall = undef;
-    $recall = $item->check_recalls if $item->can_be_waiting_recall;
-    if ( defined $recall ) {
-        if ( $recall->item_level_recall ) {
-            if ( $recall->itemnumber == $c->{itemnumber} ) {
-                # item-level recall on this item
-                $recalled = 1;
+    if ( C4::Context->preference('UseRecalls') ) {
+        my $recall = undef;
+        $recall = $item->check_recalls if $item->can_be_waiting_recall;
+        if ( defined $recall ) {
+            if ( $recall->item_level ) {
+                if ( $recall->item_id == $c->{itemnumber} ) {
+                    # item-level recall on this item
+                    $recalled = 1;
+                } else {
+                    $recalled = 0;
+                }
             } else {
-                $recalled = 0;
-            }
-        } else {
-            # biblio-level recall, but don't want to mark recalled if the recall has been allocated a different item
-            if ( !$recall->waiting ) {
-                $recalled = 1;
+                # biblio-level recall, but don't want to mark recalled if the recall has been allocated a different item
+                if ( !$recall->waiting ) {
+                    $recalled = 1;
+                }
             }
         }
     }