Bug 27136: (QA follow-up) Fix entries for multiple und undetermined language(s)

[koha-ffzg.git] / reviews / reviewswaiting.pl

diff --git a/reviews/reviewswaiting.pl b/reviews/reviewswaiting.pl
index 452b54c..6d50443 100755 (executable)
--- a/reviews/reviewswaiting.pl
+++ b/reviews/reviewswaiting.pl
@@ -18,22 +18,20 @@
 use Modern::Perl;
 
 use CGI qw ( -utf8 );
-use C4::Auth;
-use C4::Output;
+use C4::Auth qw( get_template_and_user );
+use C4::Output qw( pagination_bar output_html_with_http_headers );
 use C4::Context;
-use C4::Members;
-use C4::Biblio;
+use Koha::Biblios;
+use Koha::Patrons;
 use Koha::Reviews;
 
-my $query = new CGI;
+my $query = CGI->new;
 my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
     {
         template_name   => "reviews/reviewswaiting.tt",
         query           => $query,
         type            => "intranet",
-        authnotrequired => 0,
         flagsrequired   => { tools => 'moderate_comments' },
-        debug           => 1,
     }
 );
 
@@ -42,7 +40,7 @@ my $status   = $query->param('status') || 0;
 my $reviewid = $query->param('reviewid');
 my $page     = $query->param('page') || 1;
 my $count    = C4::Context->preference('numSearchResults') || 20;
-my $total    = Koha::Reviews->search({ approved => $status })->count;
+my $total    = Koha::Reviews->search_limited({ approved => $status })->count;
 
 if ( $op eq 'approve' ) {
     my $review = Koha::Reviews->find( $reviewid );
@@ -57,7 +55,7 @@ elsif ( $op eq 'delete' ) {
     $review->delete if $review;
 }
 
-my $reviews = Koha::Reviews->search(
+my $reviews = Koha::Reviews->search_limited(
     { approved => $status },
     {
         rows => $count,
@@ -66,14 +64,16 @@ my $reviews = Koha::Reviews->search(
     }
 )->unblessed;
 
-foreach ( @$reviews ) {
-    my $borrowernumber = $_->{borrowernumber};
-    my $borrowerData   = GetMember('borrowernumber' => $borrowernumber);
-    my $biblioData     = GetBiblioData($_->{biblionumber});
+for my $review ( @$reviews ) {
+    my $biblio         = Koha::Biblios->find( $review->{biblionumber} );
     # setting some borrower info into this hash
-    $_->{bibliotitle} = $biblioData->{'title'};
-    $_->{surname}     = $borrowerData->{'surname'};
-    $_->{firstname}   = $borrowerData->{'firstname'};
+    $review->{bibliotitle} = $biblio->title;
+
+    my $borrowernumber = $review->{borrowernumber};
+    my $patron = Koha::Patrons->find( $borrowernumber);
+    if ( $patron ) {
+        $review->{patron} = $patron;
+    }
 }
 
 my $url = "/cgi-bin/koha/reviews/reviewswaiting.pl?status=$status";