use Modern::Perl;
use CGI qw ( -utf8 );
-use List::MoreUtils qw/uniq/;
-use Date::Calc qw/Date_to_Days/;
-use C4::Output;
-use C4::Auth;
-use C4::Reserves;
-use C4::Biblio;
-use C4::Items;
-use C4::Koha;
-use C4::Serials;
-use C4::Circulation;
-use Koha::DateUtils;
+use List::MoreUtils qw( uniq );
+use Date::Calc qw( Date_to_Days );
+use C4::Output qw( output_html_with_http_headers );
+use C4::Auth qw( get_template_and_user );
+use C4::Reserves qw( RevertWaitingStatus AlterPriority ToggleLowestPriority ToggleSuspend CanBookBeReserved GetMaxPatronHoldsForRecord ItemsAnyAvailableAndNotRestricted CanItemBeReserved IsAvailableForItemLevelRequest );
+use C4::Items qw( get_hostitemnumbers_of );
+use C4::Koha qw( getitemtypeimagelocation );
+use C4::Serials qw( CountSubscriptionFromBiblionumber );
+use C4::Circulation qw( GetTransfers _GetCircControlBranch GetBranchItemRule );
+use Koha::DateUtils qw( dt_from_string output_pref );
use C4::Utils::DataTables::Members;
-use C4::Members;
-use C4::Search; # enabled_staff_search_views
+use C4::Search qw( enabled_staff_search_views );
use Koha::Biblios;
-use Koha::DateUtils;
+use Koha::DateUtils qw( dt_from_string output_pref );
use Koha::Checkouts;
use Koha::Holds;
use Koha::CirculationRules;
}
my $multi_hold = @biblionumbers > 1;
-$template->param(multi_hold => $multi_hold);
+$template->param(
+ multi_hold => $multi_hold,
+);
# If we have the borrowernumber because we've performed an action, then we
# don't want to try to place another reserve.
);
}
+unless ( $club_hold or $borrowernumber_hold ) {
+ $template->param( clubcount => Koha::Clubs->search->count );
+}
+
$template->param(
messageborrower => $messageborrower,
messageclub => $messageclub
# FIXME launch another time GetMember perhaps until (Joubu: Why?)
my $patron = Koha::Patrons->find( $borrowernumber_hold );
+if ( $patron && $multi_hold ) {
+ my @multi_pickup_locations =
+ Koha::Biblios->search( { biblionumber => \@biblionumbers } )
+ ->pickup_locations( { patron => $patron } );
+ $template->param( multi_pickup_locations => \@multi_pickup_locations );
+}
+
my $logged_in_patron = Koha::Patrons->find( $borrowernumber );
my $wants_check;
my %biblioloopiter = ();
my $biblio = Koha::Biblios->find( $biblionumber );
+ unless ($biblio) {
+ $biblioloopiter{noitems} = 1;
+ $template->param('nobiblio' => 1);
+ last;
+ }
my $force_hold_level;
if ( $patron ) {
unless ( $items->count ) {
# FIXME Then why do we continue?
- $template->param('noitems' => 1);
+ $template->param('noitems' => 1) unless ( $multi_hold );
$biblioloopiter{noitems} = 1;
}
- ## Here we go backwards again to create hash of biblioitemnumber to itemnumbers,
- ## when by definition all of the itemnumber have the same biblioitemnumber
+ ## Here we go backwards again to create hash of biblioitemnumber to itemnumbers
+ ## this is important when we have analytic items which may be on another record
my ( $iteminfos_of );
while ( my $item = $items->next ) {
$item = $item->unblessed;
$iteminfos_of->{$itemnumber} = $item;
}
- ## Should be same as biblionumber
my @biblioitemnumbers = keys %itemnumbers_of_biblioitem;
my $biblioiteminfos_of = {
( $biblioitem->{biblioitemnumber} => $biblioitem )
} @{ Koha::Biblioitems->search(
{ biblioitemnumber => { -in => \@biblioitemnumbers } },
- { select => ['biblioitemnumber', 'publicationyear', 'itemtype']}
+ { select => ['biblionumber', 'biblioitemnumber', 'publicationyear', 'itemtype']}
)->unblessed
}
};
# it's complicated logic to analyse.
# (before this loop was inside that sub loop so it was O(n^2) )
my $items_any_available;
-
- $items_any_available = ItemsAnyAvailableAndNotRestricted( { biblionumber => $biblioitemnumber, patron => $patron })
+ $items_any_available = ItemsAnyAvailableAndNotRestricted( { biblionumber => $biblioitem->{biblionumber}, patron => $patron })
if $patron;
foreach my $itemnumber ( @{ $itemnumbers_of_biblioitem{$biblioitemnumber} } ) {
$item->{'holdallowed'} = $branchitemrule->{'holdallowed'};
- my $reserves_control_branch = $pickup || C4::Reserves::GetReservesControlBranch( $item, $patron_unblessed );
- my $can_item_be_reserved = CanItemBeReserved( $patron->borrowernumber, $itemnumber, $reserves_control_branch )->{status};
+ my $can_item_be_reserved = CanItemBeReserved( $patron->borrowernumber, $itemnumber )->{status};
$item->{not_holdable} = $can_item_be_reserved unless ( $can_item_be_reserved eq 'OK' );
$item->{item_level_holds} = Koha::CirculationRules->get_opacitemholds_policy( { item => $item_object, patron => $patron } );
&& IsAvailableForItemLevelRequest($item_object, $patron, undef, $items_any_available)
)
{
- $item->{available} = 1;
- $num_available++;
-
- if ( $branchitemrule->{'hold_fulfillment_policy'} eq 'any' )
- {
- $item->{any_pickup_location} = 1;
+ # Send the pickup locations count to the UI, the pickup locations will be pulled using the API
+ my $pickup_locations = $item_object->pickup_locations({ patron => $patron });
+ $item->{pickup_locations_count} = $pickup_locations->count;
+ if ( $item->{pickup_locations_count} > 0 ) {
+ $num_available++;
+ $item->{available} = 1;
+ # pass the holding branch for use as default
+ my $default_pickup_location = $pickup_locations->search({ branchcode => $item->{holdingbranch} })->next;
+ $item->{default_pickup_location} = $default_pickup_location;
}
else {
- my @pickup_locations = $item_object->pickup_locations({ patron => $patron });
-
- $item->{pickup_locations} = join( ', ', map { $_->branchname } @pickup_locations );
+ $item->{available} = 0;
+ $item->{not_holdable} = "no_valid_pickup_location";
}
push( @available_itemtypes, $item->{itype} );
$template->param( reserveloop => \@reserveloop );
}
+ if ( $patron ) {
+ # Add the valid pickup locations
+ my @pickup_locations = $biblio->pickup_locations({ patron => $patron });
+ $biblioloopiter{pickup_locations} = \@pickup_locations;
+ $biblioloopiter{pickup_locations_codes} = [ map { $_->branchcode } @pickup_locations ];
+ }
+
push @biblioloop, \%biblioloopiter;
}
$template->param( biblioloop => \@biblioloop );
-$template->param( biblionumbers => $biblionumbers );
$template->param( no_reserves_allowed => $no_reserves_allowed );
+$template->param( biblionumbers => join('/', @biblionumbers) );
$template->param( exceeded_maxreserves => $exceeded_maxreserves );
$template->param( exceeded_holds_per_record => $exceeded_holds_per_record );
$template->param( subscriptionsnumber => CountSubscriptionFromBiblionumber($biblionumber));