use C4::Auth;
use C4::Context;
-use C4::Branch; # GetBranches
use C4::Koha;
-use C4::Dates;
use C4::Acquisition;
use C4::Output;
use C4::Reports;
use C4::Circulation;
use C4::Members::AttributeTypes;
-use C4::Dates qw/format_date format_date_in_iso/;
+
+use Koha::AuthorisedValues;
+use Koha::DateUtils;
+use Koha::Libraries;
+use Koha::Patron::Categories;
+
use Date::Calc qw(
Today
Add_Delta_YM
=head1 DESCRIPTION
-=over 2
-
=cut
my $input = new CGI;
my $fullreportname = "reports/borrowers_stats.tt";
my $line = $input->param("Line");
my $column = $input->param("Column");
-my @filters = $input->param("Filter");
-$filters[3]=format_date_in_iso($filters[3]);
-$filters[4]=format_date_in_iso($filters[4]);
+my @filters = $input->multi_param("Filter");
+$filters[3] = eval { output_pref( { dt => dt_from_string( $filters[3]), dateonly => 1, dateformat => 'iso' } ); }
+ if ( $filters[3] );
+$filters[4] = eval { output_pref ({ dt => dt_from_string( $filters[4]), dateonly => 1, dateformat => 'iso' } ); }
+ if ( $filters[4] );
my $digits = $input->param("digits");
our $period = $input->param("period");
my $borstat = $input->param("status");
my $basename = $input->param("basename");
our $sep = $input->param("sep");
$sep = "\t" if ($sep and $sep eq 'tabulation');
-my $selected_branch; # = $input->param("?");
-
-our $branches = GetBranches;
my ($template, $borrowernumber, $cookie)
= get_template_and_user({template_name => $fullreportname,
} else {
my $dbh = C4::Context->dbh;
my $req;
- $template->param( CAT_LOOP => &catcode_aref);
- my @branchloop;
- foreach (sort {$branches->{$a}->{branchname} cmp $branches->{$b}->{branchname}} keys %$branches) {
- my $line = {branchcode => $_, branchname => $branches->{$_}->{branchname} || 'UNKNOWN'};
- $line->{selected} = 'selected' if ($selected_branch and $selected_branch eq $_);
- push @branchloop, $line;
- }
- $template->param(BRANCH_LOOP => \@branchloop);
+ my $patron_categories = Koha::Patron::Categories->search({}, {order_by => ['description']});
+ $template->param( patron_categories => $patron_categories );
$req = $dbh->prepare("SELECT DISTINCTROW zipcode FROM borrowers WHERE zipcode IS NOT NULL AND zipcode <> '' ORDER BY zipcode");
$req->execute;
$template->param( ZIP_LOOP => $req->fetchall_arrayref({}));
}
output_html_with_http_headers $input, $cookie, $template->output;
-sub catcode_aref {
- my $req = C4::Context->dbh->prepare("SELECT categorycode, description FROM categories ORDER BY description");
- $req->execute;
- return $req->fetchall_arrayref({});
-}
-sub catcodes_hash {
- my %cathash;
- my $catcodes = &catcode_aref;
- foreach (@$catcodes) {
- $cathash{$_->{categorycode}} = ($_->{description} || 'NO_DESCRIPTION') . " ($_->{categorycode})";
- }
- return %cathash;
-}
-
sub calculate {
my ($line, $column, $digits, $status, $activity, $filters, $attr_filters) = @_;
my %cell;
if ( @$filters[$i] ) {
if ($i == 3 or $i == 4) {
- $cell{filter} = format_date(@$filters[$i]);
+ $cell{filter} = eval { output_pref( { dt => dt_from_string( @$filters[$i] ), dateonly => 1 }); }
+ if ( @$filters[$i] );
} else {
$cell{filter} = @$filters[$i];
}
if ( $i == 0) { $cell{crit} = "Cat code"; }
- elsif ( $i == 1 ) { $cell{crit} = "Zip code"; }
+ elsif ( $i == 1 ) { $cell{crit} = "ZIP/Postal code"; }
elsif ( $i == 2 ) { $cell{crit} = "Branch code"; }
elsif ( $i == 3 ||
$i == 4 ) { $cell{crit} = "Date of birth"; }
}
}
+ my @branchcodes = map { $_->branchcode } Koha::Libraries->search;
($status ) and push @loopfilter,{crit=>"Status", filter=>$status };
($activity) and push @loopfilter,{crit=>"Activity",filter=>$activity};
- push @loopfilter,{debug=>1, crit=>"Branches",filter=>join(" ", sort keys %$branches)};
+ push @loopfilter,{debug=>1, crit=>"Branches",filter=>join(" ", sort @branchcodes)};
push @loopfilter,{debug=>1, crit=>"(line, column)", filter=>"($line,$column)"};
# year of activity
my ( $period_year, $period_month, $period_day )=Add_Delta_YM( Today(),-$period, 0);
} else {
$linefield = $line;
}
-
- my %cathash = ($line eq 'categorycode' or $column eq 'categorycode') ? &catcodes_hash : ();
- push @loopfilter, {debug=>1, crit=>"\%cathash", filter=>join(", ", map {$cathash{$_}} sort keys %cathash)};
+ my $patron_categories = Koha::Patron::Categories->search({}, {order_by => ['categorycode']});
+ push @loopfilter,
+ {
+ debug => 1,
+ crit => "Patron category",
+ filter => join( ", ", map { $_->categorycode . ' (' . ( $_->description || 'NO_DESCRIPTION' ) . ')' } $patron_categories->as_list ),
+ };
my $strsth;
my @strparams; # bind parameters for the query
my %cell;
if ($celvalue) {
$cell{rowtitle} = $celvalue;
- # $cell{rowtitle_display} = ($linefield eq 'branchcode') ? $branches->{$celvalue}->{branchname} : $celvalue;
- $cell{rowtitle_display} = ($cathash{$celvalue} || "$celvalue\*") if ($line eq 'categorycode');
+ $cell{rowtitle_display} = ($patron_categories->find($celvalue)->description || "$celvalue\*") if ($line eq 'categorycode');
}
$cell{totalrow} = 0;
push @loopline, \%cell;
if (defined $celvalue) {
$cell{coltitle} = $celvalue;
# $cell{coltitle_display} = ($colfield eq 'branchcode') ? $branches->{$celvalue}->{branchname} : $celvalue;
- $cell{coltitle_display} = $cathash{$celvalue} if ($column eq 'categorycode');
+ $cell{coltitle_display} = $patron_categories->find($celvalue)->description if ($column eq 'categorycode');
}
push @loopcol, \%cell;
}
}
}
$strcalc .= " AND borrowernumber in (select distinct(borrowernumber) from old_issues where issuedate > '" . $newperioddate . "')" if ($activity eq 'active');
- $strcalc .= " AND borrowernumber not in (select distinct(borrowernumber) from old_issues where issuedate > '" . $newperioddate . "')" if ($activity eq 'nonactive');
+ $strcalc .= " AND borrowernumber not in (select distinct(borrowernumber) from old_issues where issuedate > '" . $newperioddate . "' AND borrowernumber IS NOT NULL)" if ($activity eq 'nonactive');
$strcalc .= " AND $status='1' " if ($status);
$strcalc .= " GROUP BY ";
my @attribute_loop;
foreach my $class ( sort keys %items_by_class ) {
- my $lib = GetAuthorisedValueByCode( 'PA_CLASS', $class ) || $class;
+ my $av = Koha::AuthorisedValues->search({ category => 'PA_CLASS', authorised_value => $class });
+ my $lib = $av->count ? $av->next->lib : $class;
push @attribute_loop, {
class => $class,
items => $items_by_class{$class},