Bug 31095: Add restrictions accessor to Koha::Patron

[koha-ffzg.git] / patroncards / image-manage.pl

diff --git a/patroncards/image-manage.pl b/patroncards/image-manage.pl
index c658114..3a63656 100755 (executable)
--- a/patroncards/image-manage.pl
+++ b/patroncards/image-manage.pl
@@ -1,20 +1,15 @@
 #!/usr/bin/perl
 
-use warnings;
-use strict;
+use Modern::Perl;
 
 use CGI qw ( -utf8 );
 use Graphics::Magick;
-use POSIX qw(ceil);
-use autouse 'Data::Dumper' => qw(Dumper);
 
 use C4::Context;
-use C4::Auth;
-use C4::Output;
-use C4::Debug;
-use C4::Creators;
-use C4::Patroncards;
-use Data::Dumper;
+use C4::Auth qw( get_template_and_user );
+use C4::Output qw( output_html_with_http_headers );
+use C4::Creators qw( html_table );
+use C4::Patroncards qw( get_image put_image rm_image );
 
 my $cgi = CGI->new;
 
@@ -22,16 +17,21 @@ my ($template, $loggedinuser, $cookie) = get_template_and_user({
                     template_name       => "patroncards/image-manage.tt",
                     query               => $cgi,
                     type                => "intranet",
-                    authnotrequired     => 0,
-                    flagsrequired       => {tools => 'batch_upload_patron_images'}, # FIXME: establish flag for patron card creator
-                    debug               => 0,
+                    flagsrequired       => {tools => 'label_creator'},
                     });
 
 my $file_name = $cgi->param('uploadfile') || '';
 my $image_name = $cgi->param('image_name') || $file_name;
 my $upload_file = $cgi->upload('uploadfile') || '';
 my $op = $cgi->param('op') || 'none';
-my @image_ids = $cgi->multi_param('image_id') if $cgi->param('image_id');
+my @image_ids = $cgi->multi_param('image_id');
+
+my @errors = ( 'pdferr', 'errnocards', 'errba', 'errpl', 'errpt', 'errlo', 'errtpl', );
+foreach my $param (@errors) {
+    my $error = $cgi->param($param) ? 1 : 0;
+    $template->param( 'error_' . $param => $error )
+      if $error;
+}
 
 my $source_file = "$file_name"; # otherwise we end up with what amounts to a pointer to a filehandle rather than a user-friendly filename
 
@@ -49,15 +49,10 @@ my $errstr = '';        # NOTE: For error codes see error-messages.inc
 
 if ($op eq 'upload') {
     # Checking for duplicate image name
-    my $duplicate;
     my $dbh = C4::Context->dbh;
     my $query = "SELECT COUNT(*) FROM creator_images WHERE image_name=?";
-    my $sth = $dbh->prepare($query);
-    $sth->execute($image_name);
-    my $count = $sth->fetchrow_arrayref;
-    if ( $count->[0] > 0 ) {
-        $duplicate = 1;
-        warn sprintf('Image name already exists.');
+    my ( $exists ) = $dbh->selectrow_array( $query, undef, $image_name );
+    if ( $exists ) {
         $errstr = 304;
         $template->param(
             IMPORT_SUCCESSFUL => 0,
@@ -66,8 +61,7 @@ if ($op eq 'upload') {
             TABLE => $table,
             error => $errstr,
         );
-    }
-    unless ($duplicate) {
+    } else {
         if (!$upload_file) {
             warn sprintf('An error occurred while attempting to upload file %s.', $source_file);
             $errstr = 301;
@@ -96,7 +90,7 @@ if ($op eq 'upload') {
             else {
                 my $errstr = '';
                 my $size = $image->Get('filesize');
-                $errstr =  302 if $size > 500000;
+                $errstr =  302 if $size > 2097152;
                 $image->Set(magick => 'png'); # convert all images to png as this is a lossless format which is important for resizing operations later on
                 my $err = put_image($image_name, $image->ImageToBlob()) || '0';
                 $errstr = 101 if $err == 1;
@@ -200,11 +194,18 @@ Copyright 2009 Foundations Bible College.
 
 This file is part of Koha.
 
-Koha is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software
-Foundation; either version 2 of the License, or (at your option) any later version.
+Koha is free software; you can redistribute it and/or modify it
+under the terms of the GNU General Public License as published by
+the Free Software Foundation; either version 3 of the License, or
+(at your option) any later version.
+
+Koha is distributed in the hope that it will be useful, but
+WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+GNU General Public License for more details.
 
-You should have received a copy of the GNU General Public License along with Koha; if not, write to the Free Software Foundation, Inc., 51 Franklin Street,
-Fifth Floor, Boston, MA 02110-1301 USA.
+You should have received a copy of the GNU General Public License
+along with Koha; if not, see <http://www.gnu.org/licenses>.
 
 =head1 DISCLAIMER OF WARRANTY