Bug 20912: (QA follow-up) The default rule already has renewalsallowed=0

[srvgit] / patroncards / edit-profile.pl

diff --git a/patroncards/edit-profile.pl b/patroncards/edit-profile.pl
index 415cd8c..d84fb19 100755 (executable)
--- a/patroncards/edit-profile.pl
+++ b/patroncards/edit-profile.pl
@@ -18,8 +18,7 @@
 # You should have received a copy of the GNU General Public License
 # along with Koha; if not, see <http://www.gnu.org/licenses>.
 
-use strict;
-use warnings;
+use Modern::Perl;
 
 use CGI qw ( -utf8 );
 
@@ -50,17 +49,17 @@ my $units = get_unit_values();
 
 if ($op eq 'edit') {
     $profile = C4::Patroncards::Profile->retrieve(profile_id => $profile_id);
-    $template_list = get_all_templates(table_name => 'creator_templates', field_list => 'template_id,template_code, profile_id');
+    $template_list = get_all_templates({ fields => [ qw( template_id template_code profile_id ) ] });
 }
 elsif ($op eq 'save') {
     my @params = (
-        printer_name        => $cgi->param('printer_name'),
-        paper_bin           => $cgi->param('paper_bin'),
-        offset_horz         => $cgi->param('offset_horz'),
-        offset_vert         => $cgi->param('offset_vert'),
-        creep_horz          => $cgi->param('creep_horz'),
-        creep_vert          => $cgi->param('creep_vert'),
-        units               => $cgi->param('units'),
+        printer_name        => scalar $cgi->param('printer_name'),
+        paper_bin           => scalar $cgi->param('paper_bin'),
+        offset_horz         => scalar $cgi->param('offset_horz'),
+        offset_vert         => scalar $cgi->param('offset_vert'),
+        creep_horz          => scalar $cgi->param('creep_horz'),
+        creep_vert          => scalar $cgi->param('creep_vert'),
+        units               => scalar $cgi->param('units'),
     );
     if ($profile_id) {   # if a label_id was passed in, this is an update to an existing layout
         $profile = C4::Patroncards::Profile->retrieve(profile_id => $profile_id);
@@ -88,7 +87,10 @@ foreach my $unit (@$units) {
     }
 }
 
-$template->param(profile_id => $profile->get_attr('profile_id')) if $profile->get_attr('profile_id') > 0;
+# if new layout, there will be no profile id, so shouldn't look for it
+if ( $profile_id && $profile->get_attr('profile_id') > 0 ) {
+    $template->param( profile_id => $profile->get_attr('profile_id') );
+}
 
 $template->param(
     label_template      => $label_template[0]->{'template_code'} || '',