Bugfix: Fixing issues with the patron card pdf rendering code

[koha_fer] / patroncards / edit-batch.pl

diff --git a/patroncards/edit-batch.pl b/patroncards/edit-batch.pl
index 9c3a57d..3db898c 100755 (executable)
--- a/patroncards/edit-batch.pl
+++ b/patroncards/edit-batch.pl
@@ -105,16 +105,21 @@ elsif ($op eq 'de_duplicate') {
         exit;
     }
 }
-elsif ($op = 'edit') {
+elsif ($op eq 'edit') {
     $batch = C4::Patroncards::Batch->retrieve(batch_id => $batch_id);
 }
 elsif ($op eq 'new') {
+    if ($branch_code eq '') {
+        warn sprintf('Batch edit interface called with an invalid/non-existent branch code: %s',$branch_code ? $branch_code : 'NULL');
+        print $cgi->redirect("manage.pl?card_element=batch&error=203");
+        exit;
+    }
     $batch = C4::Patroncards::Batch->new(branch_code => $branch_code);
     $batch_id = $batch->get_attr('batch_id');
 }
 else {
     warn sprintf('Batch edit interface called an unsupported operation: %s',$op);
-    print $cgi->redirect("manage.pl?card_element=batch&error=202") if $err;
+    print $cgi->redirect("manage.pl?card_element=batch&error=202");
     exit;
 }