Bug 3150: (QA follow-up) Tidy scripts

[srvgit] / opac / opac-sendbasket.pl

diff --git a/opac/opac-sendbasket.pl b/opac/opac-sendbasket.pl
index b7ac930..a273e14 100755 (executable)
--- a/opac/opac-sendbasket.pl
+++ b/opac/opac-sendbasket.pl
@@ -25,7 +25,7 @@ use Carp qw( carp );
 use Try::Tiny qw( catch try );
 
 use C4::Biblio qw(
-    GetMarcSubjects
+  GetMarcSubjects
 );
 use C4::Auth qw( get_template_and_user );
 use C4::Output qw( output_html_with_http_headers );
@@ -37,83 +37,87 @@ use Koha::Token;
 
 my $query = CGI->new;
 
-my ( $template, $borrowernumber, $cookie ) = get_template_and_user (
+my ( $template, $borrowernumber, $cookie ) = get_template_and_user(
     {
-        template_name   => "opac-sendbasketform.tt",
-        query           => $query,
-        type            => "opac",
+        template_name => "opac-sendbasketform.tt",
+        query         => $query,
+        type          => "opac",
     }
 );
 
-my $bib_list     = $query->param('bib_list') || '';
-my $email_add    = $query->param('email_add');
+my $bib_list  = $query->param('bib_list') || '';
+my $email_add = $query->param('email_add');
 
-if ( $email_add ) {
-    die "Wrong CSRF token" unless Koha::Token->new->check_csrf({
-        session_id => scalar $query->cookie('CGISESSID'),
-        token  => scalar $query->param('csrf_token'),
-    });
+if ($email_add) {
+    die "Wrong CSRF token"
+      unless Koha::Token->new->check_csrf(
+        {
+            session_id => scalar $query->cookie('CGISESSID'),
+            token      => scalar $query->param('csrf_token'),
+        }
+      );
 
-    my $patron = Koha::Patrons->find( $borrowernumber );
+    my $patron     = Koha::Patrons->find($borrowernumber);
     my $user_email = $patron->first_valid_email_address;
 
-    my $comment    = $query->param('comment');
+    my $comment = $query->param('comment');
 
     my @bibs = split( /\//, $bib_list );
     my $iso2709;
-    foreach my $bib ( @bibs ) {
-        my $biblio = Koha::Biblios->find( $bib ) or next;
+    foreach my $bib (@bibs) {
+        my $biblio = Koha::Biblios->find($bib) or next;
         $iso2709 .= $biblio->metadata->record->as_usmarc();
-    };
+    }
 
     if ( !defined $iso2709 ) {
         carp "Error sending mail: empty basket";
         $template->param( error => 1 );
-    } elsif ( !defined $user_email or $user_email eq '' ) {
+    }
+    elsif ( !defined $user_email or $user_email eq '' ) {
         carp "Error sending mail: sender's email address is invalid";
         $template->param( error => 1 );
-    } else {
-        my %loops = (
-            biblio => \@bibs,
-        );
+    }
+    else {
+        my %loops = ( biblio => \@bibs, );
 
-        my %substitute = (
-            comment => $comment,
-        );
+        my %substitute = ( comment => $comment, );
 
         my $letter = C4::Letters::GetPreparedLetter(
-            module => 'catalogue',
+            module      => 'catalogue',
             letter_code => 'CART',
-            lang => $patron->lang,
-            tables => {
+            lang        => $patron->lang,
+            tables      => {
                 borrowers => $borrowernumber,
             },
             message_transport_type => 'email',
-            loops => \%loops,
-            substitute => \%substitute,
+            loops                  => \%loops,
+            substitute             => \%substitute,
         );
 
         my $attachment = {
             filename => 'basket.iso2709',
-            type => 'application/octet-stream',
-            content => Encode::encode("UTF-8", $iso2709),
+            type     => 'application/octet-stream',
+            content  => Encode::encode( "UTF-8", $iso2709 ),
         };
 
-        my $message_id = C4::Letters::EnqueueLetter({
-            letter => $letter,
-            message_transport_type => 'email',
-            to_address => $email_add,
-            reply_address => $user_email,
-            attachments => [$attachment],
-        });
+        my $message_id = C4::Letters::EnqueueLetter(
+            {
+                letter                 => $letter,
+                message_transport_type => 'email',
+                to_address             => $email_add,
+                reply_address          => $user_email,
+                attachments            => [$attachment],
+            }
+        );
 
-        C4::Letters::SendQueuedMessages({ message_id => $message_id });
+        C4::Letters::SendQueuedMessages( { message_id => $message_id } );
 
         $template->param( SENT => 1 );
     }
 
     $template->param( email_add => $email_add );
-    output_html_with_http_headers $query, $cookie, $template->output, undef, { force_no_caching => 1 };
+    output_html_with_http_headers $query, $cookie, $template->output, undef,
+      { force_no_caching => 1 };
 }
 else {
     my $new_session_id = $query->cookie('CGISESSID');
@@ -122,8 +126,9 @@ else {
         url            => "/cgi-bin/koha/opac-sendbasket.pl",
         suggestion     => C4::Context->preference("suggestion"),
         virtualshelves => C4::Context->preference("virtualshelves"),
-        csrf_token => Koha::Token->new->generate_csrf(
-            { session_id => $new_session_id, } ),
+        csrf_token =>
+          Koha::Token->new->generate_csrf( { session_id => $new_session_id, } ),
     );
-    output_html_with_http_headers $query, $cookie, $template->output, undef, { force_no_caching => 1 };
+    output_html_with_http_headers $query, $cookie, $template->output, undef,
+      { force_no_caching => 1 };
 }