#!/usr/bin/perl
+
# Copyright Katipo Communications 2002
# Copyright Koha Development team 2012
#
use Modern::Perl;
use CGI qw ( -utf8 );
-use C4::Auth; # checkauth, getborrowernumber.
-use C4::Koha;
-use C4::Circulation;
-use C4::Reserves;
-use C4::Biblio;
-use C4::Items;
-use C4::Output;
+use C4::Auth qw( get_template_and_user );
+use C4::Koha qw( getitemtypeimagelocation getitemtypeimagesrc );
+use C4::Circulation qw( GetBranchItemRule GetTransfers );
+use C4::Reserves qw( CanItemBeReserved CanBookBeReserved AddReserve GetReservesControlBranch ItemsAnyAvailableAndNotRestricted IsAvailableForItemLevelRequest );
+use C4::Biblio qw( GetBiblioData GetFrameworkCode );
+use C4::Output qw( output_html_with_http_headers );
use C4::Context;
use C4::Members;
use C4::Overdues;
-use C4::Debug;
-use Koha::DateUtils;
+
+use Koha::AuthorisedValues;
+use Koha::Biblios;
+use Koha::DateUtils qw( dt_from_string output_pref );
+use Koha::CirculationRules;
+use Koha::Items;
+use Koha::ItemTypes;
+use Koha::Checkouts;
use Koha::Libraries;
use Koha::Patrons;
-use Date::Calc qw/Today Date_to_Days/;
-use List::MoreUtils qw/uniq/;
+use List::MoreUtils qw( uniq );
my $maxreserves = C4::Context->preference("maxreserves");
-my $query = new CGI;
+my $query = CGI->new;
-# if RequestOnOpac (for placing holds) is disabled, leave immediately
-if ( ! C4::Context->preference('RequestOnOpac') ) {
+# if OPACHoldRequests (for placing holds) is disabled, leave immediately
+if ( ! C4::Context->preference('OPACHoldRequests') ) {
print $query->redirect("/cgi-bin/koha/errors/404.pl");
exit;
}
template_name => "opac-reserve.tt",
query => $query,
type => "opac",
- authnotrequired => 0,
- debug => 1,
}
);
m/priority/ and $show_priority = 1;
}
-sub get_out {
- output_html_with_http_headers(shift,shift,shift); # $query, $cookie, $template->output;
- exit;
-}
-
-# get borrower information ....
-my ( $borr ) = GetMember( borrowernumber => $borrowernumber );
-my $patron = Koha::Patrons->find( $borrowernumber );
+my $patron = Koha::Patrons->find( $borrowernumber, { prefetch => ['categorycode'] } );
+my $category = $patron->category;
my $can_place_hold_if_available_at_pickup = C4::Context->preference('OPACHoldsIfAvailableAtPickup');
unless ( $can_place_hold_if_available_at_pickup ) {
- my @patron_categories = split '\|', C4::Context->preference('OPACHoldsIfAvailableAtPickupExceptions');
+ my @patron_categories = split ',', C4::Context->preference('OPACHoldsIfAvailableAtPickupExceptions');
if ( @patron_categories ) {
- $can_place_hold_if_available_at_pickup = grep /$borr->{categorycode}/, @patron_categories;
+ my $categorycode = $patron->categorycode;
+ $can_place_hold_if_available_at_pickup = grep { $_ eq $categorycode } @patron_categories;
}
}
# check if this user can place a reserve, -1 means use sys pref, 0 means dont block, 1 means block
-if ( $patron->category->effective_BlockExpiredPatronOpacActions ) {
+if ( $category->effective_BlockExpiredPatronOpacActions ) {
if ( $patron->is_expired ) {
# cannot reserve, their card has expired and the rules set mean this is not allowed
$template->param( message => 1, expired_patron => 1 );
- get_out( $query, $cookie, $template->output );
+ output_html_with_http_headers $query, $cookie, $template->output, undef, { force_no_caching => 1 };
+ exit;
}
}
# Pass through any reserve charge
-my $reservefee = $patron->category->reservefee;
+my $reservefee = $category->reservefee;
if ( $reservefee > 0){
- $template->param( RESERVE_CHARGE => sprintf("%.2f",$reservefee));
+ $template->param( RESERVE_CHARGE => $reservefee);
}
-my $itemTypes = GetItemTypes();
+my $itemtypes = { map { $_->{itemtype} => $_ } @{ Koha::ItemTypes->search_with_localization->unblessed } };
# There are two ways of calling this script, with a single biblio num
# or multiple biblio nums.
if ((! $biblionumbers) && (! $query->param('place_reserve'))) {
$template->param(message=>1, no_biblionumber=>1);
- &get_out($query, $cookie, $template->output);
+ output_html_with_http_headers $query, $cookie, $template->output, undef, { force_no_caching => 1 };
+ exit;
}
# Pass the numbers to the page so they can be fed back
if (($#biblionumbers < 0) && (! $query->param('place_reserve'))) {
# TODO: New message?
$template->param(message=>1, no_biblionumber=>1);
- &get_out($query, $cookie, $template->output);
+ output_html_with_http_headers $query, $cookie, $template->output, undef, { force_no_caching => 1 };
+ exit;
}
# pass the pickup branch along....
-my $branch = $query->param('branch') || $borr->{'branchcode'} || C4::Context->userenv->{branch} || '' ;
+my $branch = $query->param('branch') || $patron->branchcode || C4::Context->userenv->{branch} || '' ;
$template->param( branch => $branch );
-# Is the person allowed to choose their branch
-my $OPACChooseBranch = (C4::Context->preference("OPACAllowUserToChooseBranch")) ? 1 : 0;
-
-$template->param( choose_branch => $OPACChooseBranch);
-
#
#
# Build hashes of the requested biblio(item)s and items.
#
my %biblioDataHash; # Hash of biblionumber to biblio/biblioitems record.
-my %itemInfoHash; # Hash of itemnumber to item info.
foreach my $biblioNumber (@biblionumbers) {
my $biblioData = GetBiblioData($biblioNumber);
$biblioDataHash{$biblioNumber} = $biblioData;
- my @itemInfos = GetItemsInfo($biblioNumber);
+ my $biblio = Koha::Biblios->find( $biblioNumber );
+ next unless $biblio;
- my $marcrecord= GetMarcBiblio($biblioNumber);
+ my $marcrecord = $biblio->metadata->record;
- # flag indicating existence of at least one item linked via a host record
- my $hostitemsflag;
- # adding items linked via host biblios
- my @hostitemInfos = GetHostItemsInfo($marcrecord);
- if (@hostitemInfos){
- $hostitemsflag =1;
- push (@itemInfos,@hostitemInfos);
- }
+ my $items = Koha::Items->search_ordered(
+ [
+ biblionumber => $biblioNumber,
+ 'me.itemnumber' => {
+ -in => [
+ $biblio->host_items->get_column('itemnumber')
+ ]
+ }
+ ],
+ { prefetch => [ 'issue', 'homebranch', 'holdingbranch' ] }
+ )->filter_by_visible_in_opac({ patron => $patron });
- $biblioData->{itemInfos} = \@itemInfos;
- foreach my $itemInfo (@itemInfos) {
- $itemInfoHash{$itemInfo->{itemnumber}} = $itemInfo;
- }
+ $biblioData->{items} = [$items->as_list]; # FIXME Potentially a lot in memory here!
# Compute the priority rank.
- my $reserves = GetReservesFromBiblionumber({ biblionumber => $biblioNumber, all_dates => 1 });
- my $rank = scalar( @$reserves );
+ $biblioData->{object} = $biblio;
+ my $holds = $biblio->holds;
+ my $rank = $holds->count;
$biblioData->{reservecount} = 1; # new reserve
- foreach my $res (@{$reserves}) {
- my $found = $res->{found};
- if ( $found && $found eq 'W' ) {
+ while ( my $hold = $holds->next ) {
+ if ( $hold->is_waiting ) {
$rank--;
}
else {
if ( $query->param('place_reserve') ) {
my $reserve_cnt = 0;
if ($maxreserves) {
- $reserve_cnt = GetReservesFromBorrowernumber( $borrowernumber );
+ $reserve_cnt = $patron->holds->count;
}
# List is composed of alternating biblio/item/branch
my $selectionCount = @selectedItems;
if (($selectionCount == 0) || (($selectionCount % 3) != 0)) {
$template->param(message=>1, bad_data=>1);
- &get_out($query, $cookie, $template->output);
+ output_html_with_http_headers $query, $cookie, $template->output, undef, { force_no_caching => 1 };
+ exit;
}
my $failed_holds = 0;
my $canreserve = 0;
my $singleBranchMode = Koha::Libraries->search->count == 1;
- if ( $singleBranchMode || !$OPACChooseBranch )
+ if ( $singleBranchMode || ! C4::Context->preference("OPACAllowUserToChooseBranch") )
{ # single branch mode or disabled user choosing
- $branch = $borr->{'branchcode'};
+ $branch = $patron->branchcode;
+ }
+
+ # FIXME We shouldn't need to fetch the item here
+ my $item = $itemNum ? Koha::Items->find( $itemNum ) : undef;
+ # When choosing a specific item, the default pickup library should be dictated by the default hold policy
+ if ( ! C4::Context->preference("OPACAllowUserToChooseBranch") && $item ) {
+ my $type = $item->effective_itemtype;
+ my $rule = GetBranchItemRule( $patron->branchcode, $type );
+
+ if ( $rule->{hold_fulfillment_policy} eq 'any' || $rule->{hold_fulfillment_policy} eq 'patrongroup' ) {
+ $branch = $patron->branchcode;
+ } elsif ( $rule->{hold_fulfillment_policy} eq 'holdgroup' ){
+ $branch = $item->homebranch;
+ } else {
+ my $policy = $rule->{hold_fulfillment_policy};
+ $branch = $item->$policy;
+ }
}
#item may belong to a host biblio, if yes change biblioNum to hosts bilbionumber
- if ( $itemNum ne '' ) {
- my $hostbiblioNum = GetBiblionumberFromItemnumber($itemNum);
+ if ( $item ) {
+ my $hostbiblioNum = $item->biblio->biblionumber;
if ( $hostbiblioNum ne $biblioNum ) {
$biblioNum = $hostbiblioNum;
}
$startdate = $query->param("reserve_date_$biblioNum");
}
- my $expiration_date = $query->param("expiration_date_$biblioNum");
+ my $patron_expiration_date = $query->param("expiration_date_$biblioNum");
+
+ my $itemtype = $query->param('itemtype') || undef;
+ $itemtype = undef if $itemNum;
- # If a specific item was selected and the pickup branch is the same as the
- # holdingbranch, force the value $rank and $found.
my $rank = $biblioData->{rank};
- if ( $itemNum ne '' ) {
- $canreserve = 1 if CanItemBeReserved( $borrowernumber, $itemNum ) eq 'OK';
- $rank = '0' unless C4::Context->preference('ReservesNeedReturns');
- my $item = GetItem($itemNum);
- if ( $item->{'holdingbranch'} eq $branch ) {
- $found = 'W'
- unless C4::Context->preference('ReservesNeedReturns');
- }
+ my $patron = Koha::Patrons->find( $borrowernumber );
+ if ( $item ) {
+ $canreserve = 1 if CanItemBeReserved( $patron, $item, $branch )->{status} eq 'OK';
}
else {
- $canreserve = 1 if CanBookBeReserved( $borrowernumber, $biblioNum ) eq 'OK';
+ $canreserve = 1
+ if CanBookBeReserved( $borrowernumber, $biblioNum, $branch, { itemtype => $itemtype } )->{status} eq 'OK';
# Inserts a null into the 'itemnumber' field of 'reserves' table.
$itemNum = undef;
unless ( $can_place_hold_if_available_at_pickup ) {
my $items_in_this_library = Koha::Items->search({ biblionumber => $biblioNum, holdingbranch => $branch });
my $nb_of_items_issued = $items_in_this_library->search({ 'issue.itemnumber' => { not => undef }}, { join => 'issue' })->count;
- if ( $items_in_this_library->count > $nb_of_items_issued ) {
+ my $nb_of_items_unavailable = $items_in_this_library->search({ -or => { lost => { '!=' => 0 }, damaged => { '!=' => 0 }, } });
+ if ( $items_in_this_library->count > $nb_of_items_issued + $nb_of_items_unavailable ) {
$canreserve = 0
}
}
- my $itemtype = $query->param('itemtype') || undef;
- $itemtype = undef if $itemNum;
-
# Here we actually do the reserveration. Stage 3.
if ($canreserve) {
my $reserve_id = AddReserve(
- $branch, $borrowernumber, $biblioNum,
- [$biblioNum], $rank, $startdate,
- $expiration_date, $notes, $biblioData->{title},
- $itemNum, $found, $itemtype,
+ {
+ branchcode => $branch,
+ borrowernumber => $borrowernumber,
+ biblionumber => $biblioNum,
+ priority => $rank,
+ reservation_date => $startdate,
+ expiration_date => $patron_expiration_date,
+ notes => $notes,
+ title => $biblioData->{title},
+ itemnumber => $itemNum,
+ found => $found,
+ itemtype => $itemtype,
+ }
);
$failed_holds++ unless $reserve_id;
++$reserve_cnt;
my $noreserves = 0;
my $maxoutstanding = C4::Context->preference("maxoutstanding");
$template->param( noreserve => 1 ) unless $maxoutstanding;
-my ( $amountoutstanding ) = GetMemberAccountRecords($borrowernumber);
+my $amountoutstanding = $patron->account->balance;
if ( $amountoutstanding && ($amountoutstanding > $maxoutstanding) ) {
my $amount = sprintf "%.02f", $amountoutstanding;
$template->param( message => 1 );
$template->param( too_much_oweing => $amount );
}
-if ( $borr->{gonenoaddress} && ($borr->{gonenoaddress} == 1) ) {
+if ( $patron->gonenoaddress && ($patron->gonenoaddress == 1) ) {
$noreserves = 1;
$template->param(
message => 1,
);
}
-if ( $borr->{lost} && ($borr->{lost} == 1) ) {
+if ( $patron->lost && ($patron->lost == 1) ) {
$noreserves = 1;
$template->param(
message => 1,
);
}
-if ( Koha::Patrons->find( $borrowernumber )->is_debarred ) {
+if ( $patron->is_debarred ) {
$noreserves = 1;
$template->param(
message => 1,
debarred => 1,
- debarred_comment => $borr->{debarredcomment},
- debarred_date => $borr->{debarred},
+ debarred_comment => $patron->debarredcomment,
+ debarred_date => $patron->debarred,
);
}
-my @reserves = GetReservesFromBorrowernumber( $borrowernumber );
-my $reserves_count = scalar(@reserves);
-$template->param( RESERVES => \@reserves );
+my $holds = $patron->holds;
+my $reserves_count = $holds->count;
+$template->param( RESERVES => $holds->unblessed );
if ( $maxreserves && ( $reserves_count >= $maxreserves ) ) {
$template->param( message => 1 );
$noreserves = 1;
- $template->param( too_many_reserves => scalar(@reserves));
+ $template->param( too_many_reserves => $holds->count );
}
unless ( $noreserves ) {
# and items for each biblionumber.
#
#
-my $notforloan_label_of = get_notforloan_label_of();
my $biblioLoop = [];
my $numBibsAvailable = 0;
my $itemdata_enumchron = 0;
+my $itemdata_ccode = 0;
my $anyholdable = 0;
my $itemLevelTypes = C4::Context->preference('item-level_itypes');
+my $pickup_locations = Koha::Libraries->search({ pickup_location => 1 });
$template->param('item_level_itypes' => $itemLevelTypes);
+my $patron_unblessed = $patron->unblessed;
foreach my $biblioNum (@biblionumbers) {
- my @not_available_at = ();
- my $record = GetMarcBiblio($biblioNum);
# Init the bib item with the choices for branch pickup
my %biblioLoopIter;
my $biblioData = $biblioDataHash{$biblioNum};
if (! $biblioData) {
$template->param(message=>1, bad_biblionumber=>$biblioNum);
- &get_out($query, $cookie, $template->output);
+ output_html_with_http_headers $query, $cookie, $template->output, undef, { force_no_caching => 1 };
+ exit;
}
+ my @not_available_at = ();
+ my $biblio = $biblioData->{object};
+ foreach my $library ( $pickup_locations->as_list ) {
+ push( @not_available_at, $library->branchcode ) unless $biblio->can_be_transferred({ to => $library });
+ }
+
+ my $frameworkcode = GetFrameworkCode( $biblioData->{biblionumber} );
$biblioLoopIter{biblionumber} = $biblioData->{biblionumber};
$biblioLoopIter{title} = $biblioData->{title};
- $biblioLoopIter{subtitle} = GetRecordValue('subtitle', $record, GetFrameworkCode($biblioData->{biblionumber}));
+ $biblioLoopIter{subtitle} = $biblioData->{'subtitle'};
+ $biblioLoopIter{medium} = $biblioData->{medium};
+ $biblioLoopIter{part_number} = $biblioData->{part_number};
+ $biblioLoopIter{part_name} = $biblioData->{part_name};
$biblioLoopIter{author} = $biblioData->{author};
$biblioLoopIter{rank} = $biblioData->{rank};
$biblioLoopIter{reservecount} = $biblioData->{reservecount};
$biblioLoopIter{already_reserved} = $biblioData->{already_reserved};
- $biblioLoopIter{mandatorynotes}=0; #FIXME: For future use
+ $biblioLoopIter{reqholdnotes}=0; #TODO: For future use
if (!$itemLevelTypes && $biblioData->{itemtype}) {
- $biblioLoopIter{translated_description} = $itemTypes->{$biblioData->{itemtype}}{translated_description};
- $biblioLoopIter{imageurl} = getitemtypeimagesrc() . "/". $itemTypes->{$biblioData->{itemtype}}{imageurl};
+ $biblioLoopIter{translated_description} = $itemtypes->{$biblioData->{itemtype}}{translated_description};
+ $biblioLoopIter{imageurl} = getitemtypeimagesrc() . "/". $itemtypes->{$biblioData->{itemtype}}{imageurl};
}
- foreach my $itemInfo (@{$biblioData->{itemInfos}}) {
- if ($itemLevelTypes && $itemInfo->{itype}) {
- $itemInfo->{translated_description} = $itemTypes->{$itemInfo->{itype}}{translated_description};
- $itemInfo->{imageurl} = getitemtypeimagesrc() . "/". $itemTypes->{$itemInfo->{itype}}{imageurl};
- }
- if (!$itemInfo->{'notforloan'} && !($itemInfo->{'itemnotforloan'} > 0)) {
- $biblioLoopIter{forloan} = 1;
- }
- }
$biblioLoopIter{itemLoop} = [];
my $numCopiesAvailable = 0;
my $numCopiesOPACAvailable = 0;
- foreach my $itemInfo (@{$biblioData->{itemInfos}}) {
- my $itemNum = $itemInfo->{itemnumber};
- my $itemLoopIter = {};
-
- $itemLoopIter->{itemnumber} = $itemNum;
- $itemLoopIter->{barcode} = $itemInfo->{barcode};
- $itemLoopIter->{homeBranchName} = $itemInfo->{homebranch};
- $itemLoopIter->{callNumber} = $itemInfo->{itemcallnumber};
- $itemLoopIter->{enumchron} = $itemInfo->{enumchron};
- $itemLoopIter->{copynumber} = $itemInfo->{copynumber};
+ # iterating through all items first to check if any of them available
+ # to pass this value further inside down to IsAvailableForItemLevelRequest to
+ # it's complicated logic to analyse.
+ # (before this loop was inside that sub loop so it was O(n^2) )
+ my $items_any_available;
+ $items_any_available = ItemsAnyAvailableAndNotRestricted( { biblionumber => $biblioNum, patron => $patron }) if $patron;
+ foreach my $item (@{$biblioData->{items}}) {
+
+ my $item_info = $item->unblessed;
+ $item_info->{holding_branch} = $item->holding_branch;
+ $item_info->{home_branch} = $item->home_branch;
if ($itemLevelTypes) {
- $itemLoopIter->{translated_description} = $itemInfo->{translated_description};
- $itemLoopIter->{itype} = $itemInfo->{itype};
- $itemLoopIter->{imageurl} = $itemInfo->{imageurl};
+ my $itemtype = $item->itemtype;
+ $item_info->{'imageurl'} = getitemtypeimagelocation( 'opac',
+ $itemtypes->{ $itemtype->itemtype }->{'imageurl'} );
+ $item_info->{'translated_description'} =
+ $itemtypes->{ $itemtype->itemtype }->{translated_description};
}
- # If the holdingbranch is different than the homebranch, we show the
- # holdingbranch of the document too.
- if ( $itemInfo->{homebranch} ne $itemInfo->{holdingbranch} ) {
- $itemLoopIter->{holdingBranchName} = $itemInfo->{holdingbranch};
+ # checking for holds
+ my $holds = $item->current_holds;
+ if ( my $first_hold = $holds->next ) {
+ $item_info->{first_hold} = $first_hold;
}
- # If the item is currently on loan, we display its return date and
- # change the background color.
- my $issues= GetItemIssue($itemNum);
- if ( $issues->{'date_due'} ) {
- $itemLoopIter->{dateDue} = output_pref({ dt => dt_from_string($issues->{date_due}, 'sql'), as_due_date => 1 });
- $itemLoopIter->{backgroundcolor} = 'onloan';
- }
+ $item_info->{checkout} = $item->checkout;
- # checking reserve
- my ($reservedate,$reservedfor,$expectedAt,undef,$wait) = GetReservesFromItemnumber($itemNum);
- my $ItemBorrowerReserveInfo = GetMember( borrowernumber => $reservedfor );
-
- # the item could be reserved for this borrower vi a host record, flag this
- $reservedfor //= '';
-
- if ( defined $reservedate ) {
- $itemLoopIter->{backgroundcolor} = 'reserved';
- $itemLoopIter->{reservedate} = output_pref({ dt => dt_from_string($reservedate), dateonly => 1 });
- $itemLoopIter->{ReservedForBorrowernumber} = $reservedfor;
- $itemLoopIter->{ReservedForSurname} = $ItemBorrowerReserveInfo->{'surname'};
- $itemLoopIter->{ReservedForFirstname} = $ItemBorrowerReserveInfo->{'firstname'};
- $itemLoopIter->{ExpectedAtLibrary} = $expectedAt;
- #waiting status
- $itemLoopIter->{waitingdate} = $wait;
- }
-
- $itemLoopIter->{notforloan} = $itemInfo->{notforloan};
- $itemLoopIter->{itemnotforloan} = $itemInfo->{itemnotforloan};
-
- # Management of the notforloan document
- if ( $itemLoopIter->{notforloan} || $itemLoopIter->{itemnotforloan}) {
- $itemLoopIter->{backgroundcolor} = 'other';
- $itemLoopIter->{notforloanvalue} =
- $notforloan_label_of->{ $itemLoopIter->{notforloan} };
- }
-
- # Management of lost or long overdue items
- if ( $itemInfo->{itemlost} ) {
-
- # FIXME localized strings should never be in Perl code
- $itemLoopIter->{message} =
- $itemInfo->{itemlost} == 1 ? "(lost)"
- : $itemInfo->{itemlost} == 2 ? "(long overdue)"
- : "";
- $itemInfo->{backgroundcolor} = 'other';
- }
-
- # Check of the transfered documents
+ # Check of the transferred documents
my ( $transfertwhen, $transfertfrom, $transfertto ) =
- GetTransfers($itemNum);
+ GetTransfers($item->itemnumber);
if ( $transfertwhen && ($transfertwhen ne '') ) {
- $itemLoopIter->{transfertwhen} = output_pref({ dt => dt_from_string($transfertwhen), dateonly => 1 });
- $itemLoopIter->{transfertfrom} = $transfertfrom;
- $itemLoopIter->{transfertto} = $transfertto;
- $itemLoopIter->{nocancel} = 1;
+ $item_info->{transfertwhen} = $transfertwhen;
+ $item_info->{transfertfrom} = $transfertfrom;
+ $item_info->{transfertto} = $transfertto;
+ $item_info->{nocancel} = 1;
}
# if the items belongs to a host record, show link to host record
- if ( $itemInfo->{biblionumber} ne $biblioNum ) {
- $biblioLoopIter{hostitemsflag} = 1;
- $itemLoopIter->{hostbiblionumber} = $itemInfo->{biblionumber};
- $itemLoopIter->{hosttitle} = GetBiblioData( $itemInfo->{biblionumber} )->{title};
+ if ( $item_info->{biblionumber} ne $biblioNum ) {
+ $item_info->{hostbiblionumber} = $item->biblionumber;
+ $item_info->{hosttitle} = Koha::Biblios->find( $item_info->{biblionumber} )->title;
}
- # If there is no loan, return and transfer, we show a checkbox.
- $itemLoopIter->{notforloan} = $itemLoopIter->{notforloan} || 0;
+ my $branch = GetReservesControlBranch( $item_info, $patron_unblessed );
- my $branch = GetReservesControlBranch( $itemInfo, $borr );
-
- my $policy_holdallowed = !$itemLoopIter->{already_reserved};
- $policy_holdallowed &&=
- IsAvailableForItemLevelRequest($itemInfo,$borr) &&
- CanItemBeReserved($borrowernumber,$itemNum) eq 'OK';
+ # items_any_available defined outside of the current loop,
+ # so we avoiding loop inside IsAvailableForItemLevelRequest:
+ my $policy_holdallowed =
+ CanItemBeReserved( $patron, $item )->{status} eq 'OK' &&
+ IsAvailableForItemLevelRequest($item, $patron, undef, $items_any_available);
if ($policy_holdallowed) {
- if ( my $hold_allowed = OPACItemHoldsAllowed( $itemInfo, $borr ) ) {
- $itemLoopIter->{available} = 1;
+ my $opac_hold_policy = Koha::CirculationRules->get_opacitemholds_policy( { item => $item, patron => $patron } );
+ if ( $opac_hold_policy ne 'N' ) { # If Y or F
+ $item_info->{available} = 1;
$numCopiesOPACAvailable++;
- $biblioLoopIter{force_hold} = 1 if $hold_allowed eq 'F';
+ $biblioLoopIter{force_hold} = 1 if $opac_hold_policy eq 'F';
}
$numCopiesAvailable++;
unless ( $can_place_hold_if_available_at_pickup ) {
- my $items_in_this_library = Koha::Items->search({ biblionumber => $itemInfo->{biblionumber}, holdingbranch => $itemInfo->{holdingbranch} });
+ my $items_in_this_library = Koha::Items->search({ biblionumber => $item->biblionumber, holdingbranch => $item->holdingbranch });
my $nb_of_items_issued = $items_in_this_library->search({ 'issue.itemnumber' => { not => undef }}, { join => 'issue' })->count;
if ( $items_in_this_library->count > $nb_of_items_issued ) {
- push @not_available_at, $itemInfo->{holdingbranch};
+ push @not_available_at, $item->holdingbranch;
}
}
}
- $itemLoopIter->{imageurl} = getitemtypeimagelocation( 'opac', $itemTypes->{ $itemInfo->{itype} }{imageurl} );
-
- # Show serial enumeration when needed
- if ($itemLoopIter->{enumchron}) {
+ # Show serial enumeration when needed
+ if ($item_info->{enumchron}) {
$itemdata_enumchron = 1;
}
+ # Show collection when needed
+ if ($item_info->{ccode}) {
+ $itemdata_ccode = 1;
+ }
- push @{$biblioLoopIter{itemLoop}}, $itemLoopIter;
+ push @{$biblioLoopIter{itemLoop}}, $item_info;
}
- $template->param( itemdata_enumchron => $itemdata_enumchron );
+ $template->param(
+ itemdata_enumchron => $itemdata_enumchron,
+ itemdata_ccode => $itemdata_ccode,
+ );
if ($numCopiesAvailable > 0) {
$numBibsAvailable++;
$biblioLoopIter{holdable} = undef;
$biblioLoopIter{itemholdable} = undef;
}
- if(not C4::Context->preference('AllowHoldsOnPatronsPossessions') and CheckIfIssuedToPatron($borrowernumber,$biblioNum)) {
- $biblioLoopIter{holdable} = undef;
- $biblioLoopIter{already_patron_possession} = 1;
- }
-
if ( $biblioLoopIter{holdable} ) {
@not_available_at = uniq @not_available_at;
$biblioLoopIter{not_available_at} = \@not_available_at ;
}
}
- $biblioLoopIter{holdable} &&= CanBookBeReserved($borrowernumber,$biblioNum) eq 'OK';
+ my $status = CanBookBeReserved( $borrowernumber, $biblioNum )->{status};
+ $biblioLoopIter{holdable} &&= $status eq 'OK';
+ $biblioLoopIter{$status} = 1;
+
+ if ( $biblioLoopIter{holdable} and C4::Context->preference('AllowHoldItemTypeSelection') ) {
+ # build the allowed item types loop
+ my $rs = $biblio->items->search_ordered(
+ undef,
+ { select => [ { distinct => 'itype' } ],
+ as => 'item_type'
+ }
+ );
+
+ my @item_types =
+ grep { CanBookBeReserved( $borrowernumber, $biblioNum, $branch, { itemtype => $_ } )->{status} eq 'OK' }
+ $rs->get_column('item_type');
+
+ $biblioLoopIter{allowed_item_types} = \@item_types;
+ }
+
+ if ( $status eq 'recall' ) {
+ $biblioLoopIter{recall} = 1;
+ }
# For multiple holds per record, if a patron has previously placed a hold,
# the patron can only place more holds of the same type. That is, if the
if ($forced_hold_level) {
$biblioLoopIter{force_hold} = 1 if $forced_hold_level eq 'item';
$biblioLoopIter{itemholdable} = 0 if $forced_hold_level eq 'record';
+ $biblioLoopIter{forced_hold_level} = $forced_hold_level;
}
$anyholdable = 1 if $biblioLoopIter{holdable};
}
+unless ($pickup_locations->count) {
+ $numBibsAvailable = 0;
+ $anyholdable = 0;
+ $template->param(
+ message => 1,
+ no_pickup_locations => 1
+ );
+}
if ( $numBibsAvailable == 0 || $anyholdable == 0) {
$template->param( none_available => 1 );
}
+if (scalar @biblionumbers > 1) {
+ $template->param( multi_hold => 1);
+}
+
my $show_notes=C4::Context->preference('OpacHoldNotes');
$template->param(OpacHoldNotes=>$show_notes);
projects / srvgit / blobdiff