Bug 13188: Add PatronSelfModificationMandatoryField system preference

[srvgit] / opac / opac-renew.pl

diff --git a/opac/opac-renew.pl b/opac/opac-renew.pl
index 205f48a..46a2050 100755 (executable)
--- a/opac/opac-renew.pl
+++ b/opac/opac-renew.pl
@@ -2,40 +2,72 @@
 
 #written 18/1/2000 by chris@katipo.co.nz
 # adapted for use in the hlt opac by finlay@katipo.co.nz 29/11/2002
-#script to renew items from the web
+# script to renew items from the web
+# Parts Copyright 2010,2011 Catalyst IT
 
-use strict;
-use warnings;
+# This file is part of Koha.
+#
+# Koha is free software; you can redistribute it and/or modify it
+# under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# Koha is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with Koha; if not, see <http://www.gnu.org/licenses>.
 
-use CGI;
-use C4::Circulation;
-use C4::Auth;
 
-my $query = new CGI;
+use Modern::Perl;
+
+use CGI qw ( -utf8 );
+use C4::Circulation qw( CanBookBeRenewed AddRenewal );
+use C4::Auth qw( get_template_and_user );
+use C4::Context;
+use C4::Members;
+use Koha::Items;
+use Koha::Patrons;
+my $query = CGI->new;
 
 my ( $template, $borrowernumber, $cookie ) = get_template_and_user(
        {
-                 template_name   => "opac-user.tmpl",
-                 query           => $query,
-                 type            => "opac",
-                 authnotrequired => 0,
-                 flagsrequired   => { borrow => 1 },
-                 debug           => 1,
+        template_name   => "opac-user.tt",
+        query           => $query,
+        type            => "opac",
        }
 ); 
-my @items          = $query->param('item');
-$borrowernumber = $query->param('borrowernumber') || $query->param('bornum');
+my @items = $query->multi_param('item');
+
 my $opacrenew = C4::Context->preference("OpacRenewalAllowed");
 
-for my $itemnumber ( @items ) {
-    my ($status,$error) = CanBookBeRenewed( $borrowernumber, $itemnumber );
-    if ( $status == 1 && $opacrenew == 1 ) {
-        AddRenewal( $borrowernumber, $itemnumber );
+my $errorstring = q{};
+my $renewed     = q{};
+
+my $patron = Koha::Patrons->find( $borrowernumber );
+
+if (   $patron->category->effective_BlockExpiredPatronOpacActions
+    && $patron->is_expired )
+{
+    $errorstring = 'card_expired';
+}
+else {
+    my @renewed;
+    for my $itemnumber (@items) {
+        my ( $status, $error ) =
+          CanBookBeRenewed( $borrowernumber, $itemnumber );
+        if ( $status == 1 && $opacrenew == 1 ) {
+            AddRenewal( $borrowernumber, $itemnumber, undef, undef, undef, undef, 0 );
+            push( @renewed, $itemnumber );
+        }
+        else {
+            $errorstring .= $error . "|";
+        }
     }
+    $renewed = join( ':', @renewed );
 }
-# FIXME: else return ERROR to user!!
 
-if ( $query->param('from') eq 'opac_user' ) {
-    print $query->redirect("/cgi-bin/koha/opac-user.pl");
-} 
-# FIXME: ELSE WHAT?  No response at all.  Not very robust.
+print $query->redirect("/cgi-bin/koha/opac-user.pl?renew_error=$errorstring&renewed=$renewed");
+