Bug 18400 - Noisy warns in opac-search.pl during itemtype sorting

[koha-ffzg.git] / opac / opac-alert-subscribe.pl

diff --git a/opac/opac-alert-subscribe.pl b/opac/opac-alert-subscribe.pl
index d26af24..6ed153d 100755 (executable)
--- a/opac/opac-alert-subscribe.pl
+++ b/opac/opac-alert-subscribe.pl
@@ -4,25 +4,25 @@
 #
 # This file is part of Koha.
 #
-# Koha is free software; you can redistribute it and/or modify it under the
-# terms of the GNU General Public License as published by the Free Software
-# Foundation; either version 2 of the License, or (at your option) any later
-# version.
+# Koha is free software; you can redistribute it and/or modify it
+# under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
 #
-# Koha is distributed in the hope that it will be useful, but WITHOUT ANY
-# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
-# A PARTICULAR PURPOSE.  See the GNU General Public License for more details.
+# Koha is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
 #
-# You should have received a copy of the GNU General Public License along with
-# Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
-# Suite 330, Boston, MA  02111-1307 USA
+# You should have received a copy of the GNU General Public License
+# along with Koha; if not, see <http://www.gnu.org/licenses>.
 
-# $Id$
 
 use strict;
-use CGI;
+use warnings;
+
+use CGI qw ( -utf8 );
 use C4::Auth;
-use C4::Date;
 use C4::Output;
 use C4::Context;
 use C4::Koha;
@@ -31,50 +31,64 @@ use C4::Serials;
 
 
 my $query = new CGI;
-my $op    = $query->param('op');
+my $op    = $query->param('op') || '';
 my $dbh   = C4::Context->dbh;
 
 my $sth;
 my ( $template, $loggedinuser, $cookie );
 my $externalid   = $query->param('externalid');
-my $alerttype    = $query->param('alerttype');
+my $alerttype    = $query->param('alerttype') || '';
+my $referer      = $query->param('referer') || 'detail';
 my $biblionumber = $query->param('biblionumber');
 
 ( $template, $loggedinuser, $cookie ) = get_template_and_user(
     {
-        template_name   => "opac-alert-subscribe.tmpl",
+        template_name   => "opac-alert-subscribe.tt",
         query           => $query,
         type            => "opac",
-        authnotrequired => 1,
+        authnotrequired => 0, # user must logged in to request
+                              # subscription notifications
         debug           => 1,
     }
 );
 
 if ( $op eq 'alert_confirmed' ) {
     addalert( $loggedinuser, $alerttype, $externalid );
-    if ( $alerttype eq 'issue' ) {
+    if ( $referer eq 'serial' ) {
         print $query->redirect(
             "opac-serial-issues.pl?biblionumber=$biblionumber");
         exit;
+    } else {
+        print $query->redirect(
+            "opac-detail.pl?biblionumber=$biblionumber");
+        exit;
     }
 }
 elsif ( $op eq 'cancel_confirmed' ) {
     my $alerts = getalert( $loggedinuser, $alerttype, $externalid );
+    warn "CANCEL confirmed : $loggedinuser, $alerttype, $externalid".Data::Dumper::Dumper( $alerts );
     foreach (@$alerts)
     {    # we are supposed to have only 1 result, but just in case...
         delalert( $_->{alertid} );
     }
-    if ( $alerttype eq 'issue' ) {
+    if ( $referer eq 'serial' ) {
         print $query->redirect(
             "opac-serial-issues.pl?biblionumber=$biblionumber");
         exit;
+    } else {
+        print $query->redirect(
+            "opac-detail.pl?biblionumber=$biblionumber");
+        exit;
     }
 
+
 }
 else {
-    if ( $alerttype eq 'issue' ) {    # alert for subscription issues
+    if ( $alerttype eq 'issue' ) { # alert for subscription issues
         my $subscription = &GetSubscription($externalid);
         $template->param(
+            alerttype      => $alerttype,
+            referer        => $referer,
             "typeissue$op" => 1,
             bibliotitle    => $subscription->{bibliotitle},
             notes          => $subscription->{notes},
@@ -82,8 +96,5 @@ else {
             biblionumber   => $biblionumber,
         );
     }
-    else {
-    }
-
 }
 output_html_with_http_headers $query, $cookie, $template->output;