Bug 19532: (RM follow-up) More use of system preference

[koha-ffzg.git] / offline_circ / process_koc.pl

diff --git a/offline_circ/process_koc.pl b/offline_circ/process_koc.pl
index 935440b..2ca6022 100755 (executable)
--- a/offline_circ/process_koc.pl
+++ b/offline_circ/process_koc.pl
@@ -21,16 +21,13 @@
 use Modern::Perl;
 
 use CGI qw ( -utf8 );
-use Carp;
 
-use C4::Output;
-use C4::Auth;
-use C4::Koha;
+use C4::Output qw( output_html_with_http_headers );
+use C4::Auth qw( get_template_and_user );
 use C4::Context;
-use C4::Biblio;
 use C4::Accounts;
-use C4::Circulation;
-use C4::Items;
+use C4::Circulation qw( barcodedecode GetOpenIssue AddRenewal AddIssue MarkIssueReturned );
+use C4::Items qw( ModDateLastSeen );
 use C4::Members;
 use C4::Stats;
 use C4::BackgroundJob;
@@ -39,7 +36,7 @@ use Koha::Account;
 use Koha::Checkouts;
 use Koha::Patrons;
 
-use Date::Calc qw( Add_Delta_Days Date_to_Days );
+use Date::Calc qw( Date_to_Days );
 
 use constant DEBUG => 0;
 
@@ -52,7 +49,6 @@ my ($template, $loggedinuser, $cookie) = get_template_and_user({
     template_name => "offline_circ/process_koc.tt",
     query => $query,
     type => "intranet",
-    authnotrequired => 0,
      flagsrequired   => { circulate => "circulate_remaining_permissions" },
 });
 
@@ -246,7 +242,8 @@ sub arguments_for_command {
 sub kocIssueItem {
     my $circ = shift;
 
-    $circ->{ 'barcode' } = barcodedecode($circ->{'barcode'}) if( $circ->{'barcode'} && C4::Context->preference('itemBarcodeInputFilter'));
+    $circ->{barcode} = barcodedecode( $circ->{barcode} ) if $circ->{barcode};
+
     my $branchcode = C4::Context->userenv->{branch};
     my $patron = Koha::Patrons->find( { cardnumber => $circ->{cardnumber} } );
     my $borrower = $patron->unblessed;
@@ -267,7 +264,7 @@ sub kocIssueItem {
                 undef,                         # branch
                 undef,                         # datedue - let AddRenewal calculate it automatically
                 $circ->{'date'},               # issuedate
-            ) unless ($DEBUG);
+            ) unless (DEBUG);
 
             push @output, {
                 renew => 1,
@@ -326,7 +323,9 @@ sub kocIssueItem {
 
 sub kocReturnItem {
     my ( $circ ) = @_;
-    $circ->{'barcode'} = barcodedecode($circ->{'barcode'}) if( $circ->{'barcode'} && C4::Context->preference('itemBarcodeInputFilter'));
+
+    $circ->{barcode} = barcodedecode( $circ->{barcode} ) if $circ->{barcode};
+
     my $item = Koha::Items->find({ barcode => $circ->{barcode} });
     my $biblio = $item->biblio;
     my $borrowernumber = _get_borrowernumber_from_barcode( $circ->{'barcode'} );
@@ -339,7 +338,7 @@ sub kocReturnItem {
             $patron->privacy
         );
 
-        $item->onloadn(undef)->store;
+        $item->onloan(undef)->store;
         ModDateLastSeen( $item->itemnumber );
 
         push @output,