Bug 32690: (follow-up) Add markup comments

[srvgit] / offline_circ / enqueue_koc.pl

diff --git a/offline_circ/enqueue_koc.pl b/offline_circ/enqueue_koc.pl
index a81aecb..e10df95 100755 (executable)
--- a/offline_circ/enqueue_koc.pl
+++ b/offline_circ/enqueue_koc.pl
@@ -18,25 +18,20 @@
 # along with Koha; if not, see <http://www.gnu.org/licenses>.
 #
 
-use strict;
-use warnings;
+use Modern::Perl;
 
 use CGI qw ( -utf8 );
-use C4::Output;
-use C4::Auth;
-use C4::Koha;
+use C4::Output qw( output_html_with_http_headers );
+use C4::Auth qw( get_template_and_user );
 use C4::Context;
-use C4::Biblio;
 use C4::Accounts;
-use C4::Circulation;
-use C4::Items;
+use C4::Circulation qw( AddOfflineOperation );
 use C4::Members;
 use C4::Stats;
-use Koha::Upload;
+use Koha::Checkouts;
+use Koha::UploadedFiles;
+use Koha::Items;
 
-use Date::Calc qw( Add_Delta_Days Date_to_Days );
-
-use constant DEBUG => 0;
 
 # this is the file version number that we're coded against.
 my $FILE_VERSION = '1.0';
@@ -48,21 +43,19 @@ my ($template, $loggedinuser, $cookie) = get_template_and_user({
     template_name => "offline_circ/enqueue_koc.tt",
     query => $query,
     type => "intranet",
-    authnotrequired => 0,
      flagsrequired   => { circulate => "circulate_remaining_permissions" },
 });
 
-
 my $fileID=$query->param('uploadedfileid');
-my %cookies = parse CGI::Cookie($cookie);
-my $sessionID = $cookies{'CGISESSID'}->value;
+
 ## 'Local' globals.
 our $dbh = C4::Context->dbh();
 
 if ($fileID) {
-    my $upload = Koha::Upload->new->get({ id => $fileID, filehandle => 1 });
-    my $fh = $upload->{fh};
-    my @input_lines = <$fh>;
+    my $upload = Koha::UploadedFiles->find($fileID);
+    my $fh = $upload? $upload->file_handle: undef;
+    my @input_lines = $fh? <$fh>: ();
+    $fh->close if $fh;
 
     my $header_line = shift @input_lines;
     my $file_info   = parse_header_line($header_line);
@@ -188,10 +181,10 @@ sub _get_borrowernumber_from_barcode {
 
     return unless $barcode;
 
-    my $item = GetBiblioFromItemNumber( undef, $barcode );
-    return unless $item->{'itemnumber'};
+    my $item = Koha::Items->find({ barcode => $barcode });
+    return unless $item;
 
-    my $issue = C4::Circulation::GetItemIssue( $item->{'itemnumber'} );
-    return unless $issue->{'borrowernumber'};
-    return $issue->{'borrowernumber'};
+    my $issue = Koha::Checkouts->find( { itemnumber => $item->itemnumber } );
+    return unless $issue;
+    return $issue->borrowernumber;
 }