Bug 11412: fix potential bulkmarcimport crash when searching for duplicates in author...

[koha_fer] / misc / migration_tools / remove_unused_authorities.pl

diff --git a/misc/migration_tools/remove_unused_authorities.pl b/misc/migration_tools/remove_unused_authorities.pl
index 23bf7ce..7920923 100755 (executable)
--- a/misc/migration_tools/remove_unused_authorities.pl
+++ b/misc/migration_tools/remove_unused_authorities.pl
@@ -16,9 +16,9 @@
 # WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
 # A PARTICULAR PURPOSE.  See the GNU General Public License for more details.
 #
-# You should have received a copy of the GNU General Public License along with
-# Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
-# Suite 330, Boston, MA  02111-1307 USA
+# You should have received a copy of the GNU General Public License along
+# with Koha; if not, write to the Free Software Foundation, Inc.,
+# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
 use warnings;
@@ -27,12 +27,13 @@ use C4::Context;
 use C4::AuthoritiesMarc;
 use Getopt::Long;
 
-my ($test,@authtypes);
+my @authtypes;
 my $want_help = 0;
+my $test = 0;
 GetOptions(
-    'aut|authtypecode:s'    => \@authtypes,
-    't'    => \$test,
-    'h|help'        => \$want_help
+    'aut|authtypecode:s' => \@authtypes,
+    't|test'             => \$test,
+    'h|help'             => \$want_help
 );
 
 if ($want_help) {
@@ -40,6 +41,10 @@ if ($want_help) {
     exit 0;
 }
 
+if ($test) {
+    print "testing only, authorities will not be deleted.\n";
+}
+
 my $dbh=C4::Context->dbh;
 @authtypes or @authtypes = qw( NC );
 my $thresholdmin=0;
@@ -62,6 +67,10 @@ while (my $data=$rqselect->fetchrow_hashref){
     $query= "an=".$data->{'authid'};
     # search for biblios mapped
     my ($err,$res,$used) = C4::Search::SimpleSearch($query,0,10);
+    if (defined $err) {
+        warn "error: $err on search $query\n";
+        next;
+    }
     print ".";
     print "$counter\n" unless $counter++ % 100;
     # if found, delete, otherwise, just count
@@ -84,7 +93,7 @@ This script will parse all authoritiestypes given as parameter, and remove autho
 warning : there is no individual confirmation !
 parameters
     --aut|authtypecode TYPE       the list of authtypes to check
-    --t|test                      test mode, don't delete really, just count
+    --test or -t                  test mode, don't delete really, just count
     --help or -h                  show this message.
 
 _USAGE_