Bug 17600: Standardize our EXPORT_OK

[srvgit] / misc / migration_tools / 22_to_30 / move_marc_to_biblioitems.pl

diff --git a/misc/migration_tools/22_to_30/move_marc_to_biblioitems.pl b/misc/migration_tools/22_to_30/move_marc_to_biblioitems.pl
index 883af15..e4429a7 100755 (executable)
--- a/misc/migration_tools/22_to_30/move_marc_to_biblioitems.pl
+++ b/misc/migration_tools/22_to_30/move_marc_to_biblioitems.pl
@@ -1,15 +1,14 @@
 #!/usr/bin/perl
-
+use Modern::Perl;
 # script to shift marc to biblioitems
 # scraped from updatedatabase for dev week by chris@katipo.co.nz
 BEGIN {
     # find Koha's Perl modules
     # test carefully before changing this
-    use FindBin;
+    use FindBin ();
     eval { require "$FindBin::Bin/../../kohalib.pl" };
 }
 use C4::Context;
-use C4::Biblio;
 use MARC::Record;
 use MARC::File::XML ( BinaryEncoding => 'utf8' );
 
@@ -26,7 +25,7 @@ $dbh->do('ALTER TABLE `biblioitems` CHANGE `marc` `marc` LONGBLOB NULL DEFAULT N
 # adding marc xml, just for convenience
 $dbh->do('ALTER TABLE `biblioitems` ADD `marcxml` LONGTEXT CHARACTER SET utf8 COLLATE utf8_general_ci NOT NULL ');
 # moving data from marc_subfield_value to biblio
-$sth = $dbh->prepare('select bibid,biblionumber from marc_biblio');
+my $sth = $dbh->prepare('select bibid,biblionumber from marc_biblio');
 $sth->execute;
 my $sth_update = $dbh->prepare('update biblioitems set marc=?, marcxml=? where biblionumber=?');
 my $totaldone=0;
@@ -46,7 +45,7 @@ while (my ($bibid,$biblionumber) = $sth->fetchrow) {
     $sth_update->execute($record->as_usmarc(),$record->as_xml_record($marcflavour),$biblionumber);
     $totaldone++;
     print ".";
-    print "\r$totaldone / $totaltodo" unless ($totaldone % 100);
+    print "\r$totaldone" unless ($totaldone % 100);
 }
 print "\rdone\n";
 
@@ -149,7 +148,6 @@ sub LocalMARCgetbiblio {
     }
     if (C4::Context->preference('marcflavour')=~/unimarc/i){
       $record->leader('     nac  22     1u 4500');
-      $update=1;
       my $string;
       if ($record->field(100)) {
         $string = substr($record->subfield(100,"a")."                                   ",0,35);