Bug 17600: Standardize our EXPORT_OK

[srvgit] / misc / cronjobs / thirdparty / TalkingTech_itiva_inbound.pl

diff --git a/misc/cronjobs/thirdparty/TalkingTech_itiva_inbound.pl b/misc/cronjobs/thirdparty/TalkingTech_itiva_inbound.pl
index e3a7055..6be0226 100755 (executable)
--- a/misc/cronjobs/thirdparty/TalkingTech_itiva_inbound.pl
+++ b/misc/cronjobs/thirdparty/TalkingTech_itiva_inbound.pl
@@ -4,18 +4,18 @@
 #
 # This file is part of Koha.
 #
-# Koha is free software; you can redistribute it and/or modify it under the
-# terms of the GNU General Public License as published by the Free Software
-# Foundation; either version 2 of the License, or (at your option) any later
-# version.
+# Koha is free software; you can redistribute it and/or modify it
+# under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
 #
-# Koha is distributed in the hope that it will be useful, but WITHOUT ANY
-# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
-# A PARTICULAR PURPOSE.  See the GNU General Public License for more details.
+# Koha is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
 #
-# You should have received a copy of the GNU General Public License along
-# with Koha; if not, write to the Free Software Foundation, Inc.,
-# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+# You should have received a copy of the GNU General Public License
+# along with Koha; if not, see <http://www.gnu.org/licenses>.
 
 use strict;
 use warnings;
@@ -24,13 +24,14 @@ BEGIN {
 
     # find Koha's Perl modules
     # test carefully before changing this
-    use FindBin;
+    use FindBin ();
     eval { require "$FindBin::Bin/../kohalib.pl" };
 }
 
-use Getopt::Long;
-use Pod::Usage;
+use Getopt::Long qw( GetOptions );
+use Pod::Usage qw( pod2usage );
 
+use Koha::Script -cron;
 use C4::Context;
 
 sub usage {
@@ -64,7 +65,7 @@ die pod2usage() if $help;
 
 # initialize the input data, either file or query
 if ( defined $infile ) {
-    my $IN open( $IN, '<', $infile ) || die("Cannot open input file");
+    open( my $IN, '<', $infile ) || die("Cannot open input file");
     print "Opening $infile\n" if ( defined $verbose );
 
     while (<$IN>) {
@@ -76,6 +77,7 @@ if ( defined $infile ) {
         $updated += $result;
         $total++;
     }
+    close($IN);
 }
 else {
     die pod2usage( -verbose => 1 );