Bug 19532: (follow-up) Fixes along recall workflow

[koha-ffzg.git] / misc / cronjobs / delete_items.pl

diff --git a/misc/cronjobs/delete_items.pl b/misc/cronjobs/delete_items.pl
index 81f11c7..2eab937 100755 (executable)
--- a/misc/cronjobs/delete_items.pl
+++ b/misc/cronjobs/delete_items.pl
@@ -1,11 +1,29 @@
 #! /usr/bin/perl
 
-use Getopt::Long;
-use C4::Context;
-use C4::Items;
-use C4::Circulation;
+# This file is part of Koha.
+#
+# Koha is free software; you can redistribute it and/or modify it
+# under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# Koha is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with Koha; if not, see <http://www.gnu.org/licenses>.
+
 use Modern::Perl;
-use Pod::Usage;
+
+use Getopt::Long qw( GetOptions );
+use Pod::Usage qw( pod2usage );
+
+use Koha::Script -cron;
+
+use C4::Context;
+use Koha::Items;
 
 my $dbh = C4::Context->dbh();
 
@@ -19,7 +37,7 @@ my $GLOBAL = {
 };
 
 my $OPTIONS = {
-      criteria => []
+      where => []
     , flags    => {
             verbose   => ''
           , commit    => ''
@@ -30,7 +48,7 @@ my $OPTIONS = {
 };
 
 GetOptions(
-      'criteria=s' => $OPTIONS->{criteria}
+      'where=s'    => $OPTIONS->{where}
     , 'v|verbose'  => sub { $OPTIONS->{flags}->{verbose}   = 1 }
     , 'V|version'  => sub { $OPTIONS->{flags}->{version}   = 1 }
     , 'h|help'     => sub { $OPTIONS->{flags}->{help}      = 1 }
@@ -38,39 +56,35 @@ GetOptions(
     , 'c|commit'   => sub { $OPTIONS->{flags}->{commit}    = 1 } # aka DO-EET!
 );
 
-my @criteria = @{ $OPTIONS->{criteria} };
+my @where = @{ $OPTIONS->{where} };
 
 pod2usage( -verbose => 2 ) if  $OPTIONS->{flags}->{manual};
 pod2usage( -verbose => 1 ) if  $OPTIONS->{flags}->{help};
-pod2usage( -verbose => 1 -msg => 'You must supply at least one --criteria option' ) if  scalar @criteria == 0;
+pod2usage( -verbose => 1 -msg => 'You must supply at least one --where option' ) if scalar @where == 0;
 
 sub verbose {
     say @_ if $OPTIONS->{flags}->{verbose};
 }
 
-my $where_clause = ' where ' . join ( " and ", @criteria );
+my $where_clause = ' where ' . join ( " and ", @where );
 
 verbose "Where statement: $where_clause";
 
+# FIXME Use Koha::Items instead
 $GLOBAL->{sth}->{target_items} = $dbh->prepare( $query->{target_items} . $where_clause  );
 $GLOBAL->{sth}->{target_items}->execute();
 
 DELITEM: while ( my $item = $GLOBAL->{sth}->{target_items}->fetchrow_hashref() ) {
-    my $issue = GetOpenIssue( $item->{itemnumber} );
-    my $holds = GetItemHolds( $item->{biblionumber}, $item->{itemnumber} );
-
-    if( defined $issue ) {
-        verbose "Cannot delete '$item->{itemnumber}' -- item is checked out.";
-        next DELITEM;
-    }
 
-    if( $holds ) {
-        verbose "Cannot delete '$item->{itemnumber}' -- item has open holds.";
-        next DELITEM;
+    my $item_object = Koha::Items->find($item->{itemnumber});
+    my $safe_to_delete = $item_object->safe_to_delete;
+    if( $safe_to_delete )  {
+        $item_object->safe_delete
+            if $OPTIONS->{flags}->{commit};
+        verbose "Deleting '$item->{itemnumber}'";
+    } else {
+        verbose sprintf "Item '%s' not deleted: %s", $item->{itemnumber}, @{$safe_to_delete->messages}[0]->message
     }
-
-    verbose "Deleting '$item->{itemnumber}' ";
-    C4::Items::DelItem( { itemnumber => $item->{itemnumber} } ) if $OPTIONS->{flags}->{commit} ;
 }
 
 =head1 NAME
@@ -81,7 +95,7 @@ delete_items.pl - A batch item deletion tool, which generates a query against th
 
 delete_items.pl [--help|--manual]
 
-delete_items.pl [--verbose] --criteria "I<SQL CONDITIONAL EXPRESSION>" ... [--commit]
+delete_items.pl [--verbose] --where "I<SQL CONDITIONAL EXPRESSION>" ... [--commit]
 
 =cut
 
@@ -99,12 +113,12 @@ Read the manual, with examples.
 
 =item B<--verbose>
 
-Send the "WHERE" clause generated by the collected C<--criteria>
+Send the "WHERE" clause generated by the collected C<--where>
 arguments, as well as items affected to Standard Out.
 
-=item B<--criteria>
+=item B<--where>
 
-The C<--criteria> option may called multiple times. The following argument
+The C<--where> option may called multiple times. The following argument
 must be a syntactically valid SQL statement which is part of the C<WHERE>
 clause querying the items table. These are joined by C<AND>.
 
@@ -121,9 +135,9 @@ No items will be deleted unless the C<--commit> flag is present.
 
   The following is an example of this script:
 
- delete_items.pl --criteria "items.withdrawn ! 0"  --criteria "items.withdrawn_on < $(date --date="13 month ago" --rfc-3339=date)" --commit
+ delete_items.pl --where "items.withdrawn ! 0"  --where "items.withdrawn_on < $(date --date="13 month ago" --rfc-3339=date)" --commit
 
- delete_items.pl --criteria "itemlost >= '1'" --criteria "itemlost <='4'" --criteria "itemlost_on < '2014-04-28'" --commit
+ delete_items.pl --where "itemlost >= '1'" --where "itemlost <='4'" --where "itemlost_on < '2014-04-28'" --commit
 
 =cut