Bug 17600: Standardize our EXPORT_OK

[srvgit] / misc / cronjobs / cart_to_shelf.pl

diff --git a/misc/cronjobs/cart_to_shelf.pl b/misc/cronjobs/cart_to_shelf.pl
index 6991e9e..264e933 100755 (executable)
--- a/misc/cronjobs/cart_to_shelf.pl
+++ b/misc/cronjobs/cart_to_shelf.pl
@@ -4,18 +4,18 @@
 #
 # This file is part of Koha.
 #
-# Koha is free software; you can redistribute it and/or modify it under the
-# terms of the GNU General Public License as published by the Free Software
-# Foundation; either version 2 of the License, or (at your option) any later
-# version.
+# Koha is free software; you can redistribute it and/or modify it
+# under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
 #
-# Koha is distributed in the hope that it will be useful, but WITHOUT ANY
-# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
-# A PARTICULAR PURPOSE.  See the GNU General Public License for more details.
+# Koha is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
 #
-# You should have received a copy of the GNU General Public License along
-# with Koha; if not, write to the Free Software Foundation, Inc.,
-# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+# You should have received a copy of the GNU General Public License
+# along with Koha; if not, see <http://www.gnu.org/licenses>.
 #-----------------------------------
 
 =head1 NAME
@@ -28,24 +28,26 @@ cart_to_shelf.pl  cron script to set items with location of CART to original she
 use strict;
 use warnings;
 
-use C4::Items qw/ CartToShelf /;
+use Koha::Script -cron;
+use C4::Items qw( CartToShelf );
+use C4::Log qw( cronlogaction );
 
 BEGIN {
 
     # find Koha's Perl modules
     # test carefully before changing this
-    use FindBin;
+    use FindBin ();
     eval { require "$FindBin::Bin/../kohalib.pl" };
 }
 use C4::Context;
-use Getopt::Long;
+use Getopt::Long qw( GetOptions );
 
 my $hours = 0;
 
 GetOptions( 'h|hours=s' => \$hours, );
 
 my $usage = << 'ENDUSAGE';
-longoverdue.pl : This cron script will set any item of the location CART ( Shelving Cart ) to it's original shelving location
+cart_to_shelf.pl: This cron script will set any item of the location CART ( Shelving Cart ) to it's original shelving location
                  after the given numer of hours has passed.
 
 This script takes the following parameters :
@@ -63,6 +65,8 @@ unless ($hours) {
     die "ERROR: No --hours (-h) option defined";
 }
 
+cronlogaction();
+
 my $query = "SELECT itemnumber FROM items WHERE location = 'CART' AND TIMESTAMPDIFF(HOUR, items.timestamp, NOW() ) > ?";
 my $sth = C4::Context->dbh->prepare($query);
 $sth->execute($hours);