Bug 17600: Standardize our EXPORT_OK

[srvgit] / members / printslip.pl

diff --git a/members/printslip.pl b/members/printslip.pl
index c89765b..1bb11f6 100755 (executable)
--- a/members/printslip.pl
+++ b/members/printslip.pl
@@ -35,26 +35,14 @@
 use Modern::Perl;
 use CGI qw ( -utf8 );
 use C4::Context;
-use C4::Auth qw/:DEFAULT get_session/;
-use C4::Output;
-use C4::Members;
-use C4::Koha;
-use Koha::DateUtils;
-
-#use Smart::Comments;
-#use Data::Dumper;
-
-use vars qw($debug);
-
-BEGIN {
-       $debug = $ENV{DEBUG} || 0;
-}
+use C4::Auth qw( get_session get_template_and_user );
+use C4::Output qw( output_and_exit_if_error output_and_exit output_html_with_http_headers );
+use C4::Members qw( IssueSlip );
 
 my $input = CGI->new;
 my $sessionID = $input->cookie("CGISESSID");
 my $session = get_session($sessionID);
 
-$debug or $debug = $input->param('debug') || 0;
 my $print = $input->param('print');
 my $error = $input->param('error');
 
@@ -68,7 +56,6 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
         query           => $input,
         type            => "intranet",
         flagsrequired   => $flagsrequired,
-        debug           => 1,
     }
 );
 
@@ -84,22 +71,11 @@ if ( $print eq 'checkinslip' ) {
     my $checkinslip_branch = $session->param('branch') ? $session->param('branch') : $branch;
 
     # get today's checkins
-    my $dtf = Koha::Database->new->schema->storage->datetime_parser;
-    my $today = dt_from_string;
-    my $today_start = $today->clone->set( hour => 0, minute => 0, second => 0 );
-    my $today_end   = $today->clone->set( hour => 23, minute => 59, second => 0 );
-    $today_start = $dtf->format_datetime( $today_start );
-    $today_end   = $dtf->format_datetime( $today_end );
-    my @todays_checkins = $patron->old_checkouts->search({
-        returndate => {
-            '>=' => $today_start,
-            '<=' => $today_end,
-        },
-        branchcode => $checkinslip_branch,
-    });
+    my @itemnumbers = $patron->old_checkouts->search( { branchcode => $checkinslip_branch } )
+      ->filter_by_todays_checkins->get_column('itemnumber');
 
     my %loops = (
-        old_issues => [ map { $_->itemnumber } @todays_checkins ],
+        old_issues => \@itemnumbers,
     );
 
     my $letter = C4::Letters::GetPreparedLetter(