Bug 29758: Get rid of warning in members/boraccount.pl
[srvgit] / members / deletemem.pl
index b68cb54..5faf87d 100755 (executable)
 use Modern::Perl;
 
 use CGI qw ( -utf8 );
+
+use Try::Tiny qw( catch try );
+
 use C4::Context;
-use C4::Output;
-use C4::Auth;
-use C4::Members;
-use Module::Load;
+use C4::Output qw( output_and_exit_if_error output_and_exit output_html_with_http_headers );
+use C4::Auth qw( get_template_and_user );
+use C4::Suggestions;
 use Koha::Patrons;
 use Koha::Token;
+use Koha::Patron::Categories;
 
-if ( C4::Context->preference('NorwegianPatronDBEnable') && C4::Context->preference('NorwegianPatronDBEnable') == 1 ) {
-    load Koha::NorwegianPatronDB, qw( NLMarkForDeletion NLSync );
-}
-
-my $input = new CGI;
+my $input = CGI->new;
 
-my ($template, $borrowernumber, $cookie)
-                = get_template_and_user({template_name => "members/deletemem.tt",
-                                        query => $input,
-                                        type => "intranet",
-                                        authnotrequired => 0,
-                                        flagsrequired => {borrowers => 1},
-                                        debug => 1,
-                                        });
+my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
+    {   template_name => "members/deletemem.tt",
+        query         => $input,
+        type          => "intranet",
+        flagsrequired => { borrowers => 'delete_borrowers' },
+    }
+);
 
 #print $input->header;
 my $member       = $input->param('member');
 
 #Do not delete yourself...
-if ($borrowernumber == $member ) {
+if ( $loggedinuser == $member ) {
     print $input->redirect("/cgi-bin/koha/members/moremember.pl?borrowernumber=$member&error=CANT_DELETE_YOURSELF");
     exit 0; # Exit without error
 }
 
-# Handle deletion from the Norwegian national patron database, if it is enabled
-# If the "deletelocal" parameter is set to "false", the regular deletion will be
-# short circuited, and only a deletion from the national database can be carried
-# out. If "deletelocal" is set to "true", or not set to anything normal
-# deletion will be done.
-my $deletelocal  = $input->param('deletelocal')  eq 'false' ? 0 : 1; # Deleting locally is the default
-if ( C4::Context->preference('NorwegianPatronDBEnable') && C4::Context->preference('NorwegianPatronDBEnable') == 1 ) {
-    if ( $input->param('deleteremote') eq 'true' ) {
-        # Mark for deletion, then try a live sync
-        NLMarkForDeletion( $member );
-        NLSync({ 'borrowernumber' => $member });
-    }
-}
-
-my $issues = GetPendingIssues($member);     # FIXME: wasteful call when really, we only want the count
-my $countissues = scalar(@$issues);
+my $logged_in_user = Koha::Patrons->find( $loggedinuser );
+my $patron         = Koha::Patrons->find( $member );
+output_and_exit_if_error( $input, $cookie, $template, { module => 'members', logged_in_user => $logged_in_user, current_patron => $patron } );
 
-my $patron = Koha::Patrons->find( $member );
-unless ( $patron ) {
-    print $input->redirect("/cgi-bin/koha/circ/circulation.pl?borrowernumber=$member");
-    exit;
-}
-my $flags = C4::Members::patronflags( $patron->unblessed );
+my $debits = $patron->account->outstanding_debits->total_outstanding;
+my $credits = abs $patron->account->outstanding_credits->total_outstanding;
+my $countissues = $patron->checkouts->count;
 my $userenv = C4::Context->userenv;
 
-
 if ($patron->category->category_type eq "S") {
     unless(C4::Auth::haspermission($userenv->{'id'},{'staffaccess'=>1})) {
         print $input->redirect("/cgi-bin/koha/members/moremember.pl?borrowernumber=$member&error=CANT_DELETE_STAFF");
         exit 0; # Exit without error
     }
 } else {
-    unless(C4::Auth::haspermission($userenv->{'id'},{'borrowers'=>1})) {
+    unless(C4::Auth::haspermission($userenv->{'id'},{'borrowers'=>'delete_borrowers'})) {
        print $input->redirect("/cgi-bin/koha/members/moremember.pl?borrowernumber=$member&error=CANT_DELETE");
         exit 0; # Exit without error
     }
@@ -105,64 +85,70 @@ if (C4::Context->preference("IndependentBranches")) {
     }
 }
 
+if ( my $anonymous_patron = C4::Context->preference("AnonymousPatron") ) {
+    if ( $patron->id eq $anonymous_patron ) {
+        print $input->redirect("/cgi-bin/koha/members/moremember.pl?borrowernumber=$member&error=CANT_DELETE_ANONYMOUS_PATRON");
+        exit 0;    # Exit without error
+    }
+}
+
 my $op = $input->param('op') || 'delete_confirm';
 my $dbh = C4::Context->dbh;
-my $is_guarantor = $dbh->selectrow_array("SELECT COUNT(*) FROM borrowers WHERE guarantorid=?", undef, $member);
-if ( $op eq 'delete_confirm' or $countissues > 0 or $flags->{'CHARGES'}  or $is_guarantor or $deletelocal == 0) {
-    $template->param( picture => 1 ) if $patron->image;
-
-    $template->param( adultborrower => 1 ) if $patron->category->category_type =~ /^(A|I)$/;
-
+my $is_guarantor = $patron->guarantee_relationships->count;
+my $countholds = $dbh->selectrow_array("SELECT COUNT(*) FROM reserves WHERE borrowernumber=?", undef, $member);
+
+# Add warning if patron has pending suggestions
+$template->param(
+    pending_suggestions => scalar @{
+    C4::Suggestions::SearchSuggestion(
+            { suggestedby => $member, STATUS => 'ASKED' }
+        )
+    }
+);
+
+$template->param(
+    patron        => $patron,
+    ItemsOnIssues => $countissues,
+    debits        => $debits,
+    credits       => $credits,
+    is_guarantor  => $is_guarantor,
+    ItemsOnHold   => $countholds,
+);
+
+if ( $op eq 'delete_confirm' or $countissues > 0 or $debits or $is_guarantor ) {
     $template->param(
-        # FIXME The patron object should be passed to the template
-        borrowernumber => $patron->borrowernumber,
-        surname => $patron->surname,
-        title => $patron->title,
-        cardnumber => $patron->cardnumber,
-        firstname => $patron->firstname,
-        categorycode => $patron->categorycode,
-        category_type => $patron->category->category_type,
-        categoryname  => $patron->category->description,
-        address => $patron->address,
-        address2 => $patron->address2,
-        city => $patron->city,
-        zipcode => $patron->zipcode,
-        country => $patron->country,
-        phone => $patron->phone,
-        email => $patron->email,
-        branchcode => $patron->branchcode,
+        op         => 'delete_confirm',
+        csrf_token => Koha::Token->new->generate_csrf({ session_id => scalar $input->cookie('CGISESSID') }),
     );
-    if ($countissues >0) {
-        $template->param(ItemsOnIssues => $countissues);
-    }
-    if ($flags->{'CHARGES'} ne '') {
-        $template->param(charges => $flags->{'CHARGES'}->{'amount'});
-    }
-    if ($is_guarantor) {
-        $template->param(guarantees => 1);
-    }
-    if ($deletelocal == 0) {
-        $template->param(keeplocal => 1);
-    }
-    # This is silly written but reflect the same conditions as above
-    if ( not $countissues > 0 and not $flags->{CHARGES} ne '' and not $is_guarantor and not $deletelocal == 0 ) {
-        $template->param(
-            op         => 'delete_confirm',
-            csrf_token => Koha::Token->new->generate_csrf({ session_id => scalar $input->cookie('CGISESSID') }),
-        );
-    }
-} elsif ( $op eq 'delete_confirmed' ) {
 
-    die "Wrong CSRF token"
+} elsif ( $op eq 'delete_confirmed' ) {
+    output_and_exit( $input, $cookie, $template, 'wrong_csrf_token' )
         unless Koha::Token->new->check_csrf( {
             session_id => $input->cookie('CGISESSID'),
             token  => scalar $input->param('csrf_token'),
         });
+
     my $patron = Koha::Patrons->find( $member );
-    $patron->move_to_deleted;
-    $patron->delete;
+
+    try {
+        my $schema = Koha::Database->new->schema;
+        $schema->txn_do(
+            sub {
+                $patron->move_to_deleted;
+                $patron->delete;
+                print $input->redirect( "/cgi-bin/koha/members/members-home.pl" );
+            }
+        );
+    }
+    catch {
+        if ( $_->isa('Koha::Exceptions::Patron::FailedDeleteAnonymousPatron') ) {
+            print $input->redirect("/cgi-bin/koha/members/moremember.pl?borrowernumber=$member&error=CANT_DELETE_ANONYMOUS_PATRON");
+        }
+        else {
+            $_->rethrow;
+        }
+    };
     # TODO Tell the user everything went ok
-    print $input->redirect("/cgi-bin/koha/members/members-home.pl");
     exit 0; # Exit without error
 }