#
# This file is part of Koha.
#
-# Koha is free software; you can redistribute it and/or modify it under the
-# terms of the GNU General Public License as published by the Free Software
-# Foundation; either version 2 of the License, or (at your option) any later
-# version.
+# Koha is free software; you can redistribute it and/or modify it
+# under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
#
-# Koha is distributed in the hope that it will be useful, but WITHOUT ANY
-# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
-# A PARTICULAR PURPOSE. See the GNU General Public License for more details.
+# Koha is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
#
-# You should have received a copy of the GNU General Public License along
-# with Koha; if not, write to the Free Software Foundation, Inc.,
-# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+# You should have received a copy of the GNU General Public License
+# along with Koha; if not, see <http://www.gnu.org/licenses>.
-use strict;
-#use warnings; FIXME - Bug 2505
+use Modern::Perl;
+
+use CGI qw ( -utf8 );
+
+use Try::Tiny qw( catch try );
-use CGI;
use C4::Context;
-use C4::Output;
-use C4::Auth;
-use C4::Members;
-use C4::Branch; # GetBranches
-
-my $input = new CGI;
-
-my ($template, $borrowernumber, $cookie)
- = get_template_and_user({template_name => "members/deletemem.tmpl",
- query => $input,
- type => "intranet",
- authnotrequired => 0,
- flagsrequired => {borrowers => 1},
- debug => 1,
- });
+use C4::Output qw( output_and_exit_if_error output_and_exit output_html_with_http_headers );
+use C4::Auth qw( get_template_and_user );
+use C4::Suggestions;
+use Koha::Patrons;
+use Koha::Token;
+use Koha::Patron::Categories;
+
+my $input = CGI->new;
+
+my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
+ { template_name => "members/deletemem.tt",
+ query => $input,
+ type => "intranet",
+ flagsrequired => { borrowers => 'delete_borrowers' },
+ }
+);
#print $input->header;
-my $member=$input->param('member');
-my $issues = GetPendingIssues($member); # FIXME: wasteful call when really, we only want the count
-my $countissues = scalar(@$issues);
+my $member = $input->param('member');
-my ($bor)=GetMemberDetails($member,'');
-my $flags=$bor->{flags};
-my $userenv = C4::Context->userenv;
+#Do not delete yourself...
+if ( $loggedinuser == $member ) {
+ print $input->redirect("/cgi-bin/koha/members/moremember.pl?borrowernumber=$member&error=CANT_DELETE_YOURSELF");
+ exit 0; # Exit without error
+}
-
+my $logged_in_user = Koha::Patrons->find( $loggedinuser );
+my $patron = Koha::Patrons->find( $member );
+output_and_exit_if_error( $input, $cookie, $template, { module => 'members', logged_in_user => $logged_in_user, current_patron => $patron } );
-if ($bor->{category_type} eq "S") {
+my $debits = $patron->account->outstanding_debits->total_outstanding;
+my $credits = abs $patron->account->outstanding_credits->total_outstanding;
+my $countissues = $patron->checkouts->count;
+my $userenv = C4::Context->userenv;
+
+if ($patron->category->category_type eq "S") {
unless(C4::Auth::haspermission($userenv->{'id'},{'staffaccess'=>1})) {
print $input->redirect("/cgi-bin/koha/members/moremember.pl?borrowernumber=$member&error=CANT_DELETE_STAFF");
- exit 1;
+ exit 0; # Exit without error
}
} else {
- unless(C4::Auth::haspermission($userenv->{'id'},{'borrowers'=>1})) {
+ unless(C4::Auth::haspermission($userenv->{'id'},{'borrowers'=>'delete_borrowers'})) {
print $input->redirect("/cgi-bin/koha/members/moremember.pl?borrowernumber=$member&error=CANT_DELETE");
- exit 1;
+ exit 0; # Exit without error
}
}
-if (C4::Context->preference("IndependantBranches")) {
+if (C4::Context->preference("IndependentBranches")) {
my $userenv = C4::Context->userenv;
- if (($userenv->{flags} % 2 != 1) && $bor->{'branchcode'}){
- unless ($userenv->{branch} eq $bor->{'branchcode'}){
+ if ( !C4::Context->IsSuperLibrarian() && $patron->branchcode){
+ unless ($userenv->{branch} eq $patron->branchcode){
print $input->redirect("/cgi-bin/koha/members/moremember.pl?borrowernumber=$member&error=CANT_DELETE_OTHERLIBRARY");
- exit;
+ exit 0; # Exit without error
}
}
}
-my $dbh = C4::Context->dbh;
-my $sth=$dbh->prepare("Select * from borrowers where guarantorid=?");
-$sth->execute($member);
-my $data=$sth->fetchrow_hashref;
-if ($countissues > 0 or $flags->{'CHARGES'} or $data->{'borrowernumber'}){
- # print $input->header;
-
- my ($picture, $dberror) = GetPatronImage($bor->{'cardnumber'});
- $template->param( picture => 1 ) if $picture;
-
- $template->param(borrowernumber => $member,
- surname => $bor->{'surname'},
- title => $bor->{'title'},
- cardnumber => $bor->{'cardnumber'},
- firstname => $bor->{'firstname'},
- categorycode => $bor->{'categorycode'},
- category_type => $bor->{'category_type'},
- categoryname => $bor->{'description'},
- address => $bor->{'address'},
- address2 => $bor->{'address2'},
- city => $bor->{'city'},
- zipcode => $bor->{'zipcode'},
- country => $bor->{'country'},
- phone => $bor->{'phone'},
- email => $bor->{'email'},
- branchcode => $bor->{'branchcode'},
- branchname => GetBranchName($bor->{'branchcode'}),
- activeBorrowerRelationship => (C4::Context->preference('borrowerRelationship') ne ''),
- );
- if ($countissues >0) {
- $template->param(ItemsOnIssues => $countissues);
+if ( my $anonymous_patron = C4::Context->preference("AnonymousPatron") ) {
+ if ( $patron->id eq $anonymous_patron ) {
+ print $input->redirect("/cgi-bin/koha/members/moremember.pl?borrowernumber=$member&error=CANT_DELETE_ANONYMOUS_PATRON");
+ exit 0; # Exit without error
}
- if ($flags->{'CHARGES'} ne '') {
- $template->param(charges => $flags->{'CHARGES'}->{'amount'});
- }
- if ($data) {
- $template->param(guarantees => 1);
+}
+
+my $op = $input->param('op') || 'delete_confirm';
+my $dbh = C4::Context->dbh;
+my $is_guarantor = $patron->guarantee_relationships->count;
+my $countholds = $dbh->selectrow_array("SELECT COUNT(*) FROM reserves WHERE borrowernumber=?", undef, $member);
+
+# Add warning if patron has pending suggestions
+$template->param(
+ pending_suggestions => scalar @{
+ C4::Suggestions::SearchSuggestion(
+ { suggestedby => $member, STATUS => 'ASKED' }
+ )
}
-output_html_with_http_headers $input, $cookie, $template->output;
+);
+
+$template->param(
+ patron => $patron,
+ ItemsOnIssues => $countissues,
+ debits => $debits,
+ credits => $credits,
+ is_guarantor => $is_guarantor,
+ ItemsOnHold => $countholds,
+);
+
+if ( $op eq 'delete_confirm' or $countissues > 0 or $debits or $is_guarantor ) {
+ $template->param(
+ op => 'delete_confirm',
+ csrf_token => Koha::Token->new->generate_csrf({ session_id => scalar $input->cookie('CGISESSID') }),
+ );
-} else {
- MoveMemberToDeleted($member);
- DelMember($member);
- print $input->redirect("/cgi-bin/koha/members/members-home.pl");
+} elsif ( $op eq 'delete_confirmed' ) {
+ output_and_exit( $input, $cookie, $template, 'wrong_csrf_token' )
+ unless Koha::Token->new->check_csrf( {
+ session_id => $input->cookie('CGISESSID'),
+ token => scalar $input->param('csrf_token'),
+ });
+
+ my $patron = Koha::Patrons->find( $member );
+
+ try {
+ my $schema = Koha::Database->new->schema;
+ $schema->txn_do(
+ sub {
+ $patron->move_to_deleted;
+ $patron->delete;
+ print $input->redirect( "/cgi-bin/koha/members/members-home.pl" );
+ }
+ );
+ }
+ catch {
+ if ( $_->isa('Koha::Exceptions::Patron::FailedDeleteAnonymousPatron') ) {
+ print $input->redirect("/cgi-bin/koha/members/moremember.pl?borrowernumber=$member&error=CANT_DELETE_ANONYMOUS_PATRON");
+ }
+ else {
+ $_->rethrow;
+ }
+ };
+ # TODO Tell the user everything went ok
+ exit 0; # Exit without error
}
-
+output_html_with_http_headers $input, $cookie, $template->output;
projects / srvgit / blobdiff