Bug 32718: Capitalization: Display Order

[koha-ffzg.git] / clubs / templates-add-modify.pl

diff --git a/clubs/templates-add-modify.pl b/clubs/templates-add-modify.pl
index ae46178..f32a6d1 100755 (executable)
--- a/clubs/templates-add-modify.pl
+++ b/clubs/templates-add-modify.pl
@@ -21,10 +21,10 @@ use Modern::Perl;
 
 use CGI;
 
-use C4::Auth;
-use C4::Output;
+use C4::Auth qw( get_template_and_user );
+use C4::Output qw( output_html_with_http_headers );
 
-use Koha::DateUtils qw(dt_from_string);
+use Koha::DateUtils qw( dt_from_string );
 use Koha::Club::Templates;
 use Koha::Club::Template::Fields;
 use Koha::Club::Template::EnrollmentFields;
@@ -32,14 +32,13 @@ use Koha::Club::Template::EnrollmentFields;
 use Koha::Database;
 my $schema = Koha::Database->new()->schema();
 
-my $cgi = new CGI;
+my $cgi = CGI->new;
 
 my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
     {
         template_name   => 'clubs/templates-add-modify.tt',
         query           => $cgi,
         type            => 'intranet',
-        authnotrequired => 0,
         flagsrequired   => { clubs => 'edit_templates' },
     }
 );
@@ -62,12 +61,12 @@ if ( $cgi->param('name') ) {    # Update or create club
     $club_template->set(
         {
             id          => $id                        || undef,
-            name        => $cgi->param('name')        || undef,
-            description => $cgi->param('description') || undef,
-            branchcode  => $cgi->param('branchcode')  || undef,
+            name        => scalar $cgi->param('name')        || undef,
+            description => scalar $cgi->param('description') || undef,
+            branchcode  => scalar $cgi->param('branchcode')  || undef,
             date_updated            => dt_from_string(),
-            is_email_required       => $cgi->param('is_email_required') ? 1 : 0,
-            is_enrollable_from_opac => $cgi->param('is_enrollable_from_opac') ? 1 : 0,
+            is_email_required       => scalar $cgi->param('is_email_required') ? 1 : 0,
+            is_enrollable_from_opac => scalar $cgi->param('is_enrollable_from_opac') ? 1 : 0,
         }
     )->store();
 
@@ -92,7 +91,7 @@ if ( $cgi->param('name') ) {    # Update or create club
           ? Koha::Club::Template::Fields->find($field_id)
           : Koha::Club::Template::Field->new();
 
-        if ( grep( /^$field_id$/, @field_delete ) ) {
+        if ( grep { $_ eq $field_id } @field_delete ) {
             $field->delete();
         }
         else {
@@ -126,7 +125,7 @@ if ( $cgi->param('name') ) {    # Update or create club
           ? Koha::Club::Template::EnrollmentFields->find($field_id)
           : Koha::Club::Template::EnrollmentField->new();
 
-        if ( grep( /^$field_id$/, @field_delete ) ) {
+        if ( grep { $_ eq $field_id } @field_delete ) {
             $field->delete();
         }
         else {