=cut
-use strict;
-use warnings;
+use Modern::Perl;
-use Carp 'verbose';
-$SIG{ __DIE__ } = sub { Carp::confess( @_ ) };
+# FIXME There are weird things going on with $patron and $borrowernumber in this script
use CGI qw ( -utf8 );
use DateTime;
+
+use C4::Auth qw( get_template_and_user get_session haspermission );
+use C4::Output qw( output_html_with_http_headers );
+use C4::Circulation qw( barcodedecode GetBranchItemRule AddReturn updateWrongTransfer LostItem );
+use C4::Reserves qw( ModReserve ModReserveAffect GetOtherReserves );
+use C4::Circulation qw( barcodedecode GetBranchItemRule AddReturn updateWrongTransfer LostItem );
use C4::Context;
-use C4::Auth qw/:DEFAULT get_session/;
-use C4::Output;
-use C4::Circulation;
-use C4::Print;
-use C4::Reserves;
-use C4::Biblio;
-use C4::Items;
-use C4::Members;
+use C4::Items qw( ModItemTransfer );
use C4::Members::Messaging;
-use C4::Branch; # GetBranches GetBranchName
-use C4::Koha; # FIXME : is it still useful ?
+use C4::Members;
+use C4::Output qw( output_html_with_http_headers );
+use C4::Reserves qw( ModReserve ModReserveAffect GetOtherReserves );
use C4::RotatingCollections;
-use Koha::DateUtils;
+use Koha::AuthorisedValues;
+use Koha::BiblioFrameworks;
use Koha::Calendar;
+use Koha::Checkouts;
+use Koha::DateUtils qw( dt_from_string output_pref );
+use Koha::Holds;
+use Koha::Items;
+use Koha::Item::Transfers;
+use Koha::Patrons;
-my $query = new CGI;
+my $query = CGI->new;
#getting the template
-my ( $template, $librarian, $cookie ) = get_template_and_user(
+my ( $template, $librarian, $cookie, $flags ) = get_template_and_user(
{
template_name => "circ/returns.tt",
query => $query,
type => "intranet",
- authnotrequired => 0,
flagsrequired => { circulate => "circulate_remaining_permissions" },
}
);
my $sessionID = $query->cookie("CGISESSID");
my $session = get_session($sessionID);
-if ($session->param('branch') eq 'NO_LIBRARY_SET'){
- # no branch set we can't return
- print $query->redirect("/cgi-bin/koha/circ/selectbranchprinter.pl");
- exit;
-}
+my $desk_id = C4::Context->userenv->{"desk_id"} || '';
# Print a reserve slip on this page
if ( $query->param('print_slip') ) {
$template->param(
print_slip => 1,
- borrowernumber => scalar $query->param('borrowernumber'),
- biblionumber => scalar $query->param('biblionumber'),
+ reserve_id => scalar $query->param('reserve_id'),
);
}
#####################
#Global vars
-my $branches = GetBranches();
-my $printers = GetPrinters();
my $userenv = C4::Context->userenv;
my $userenv_branch = $userenv->{'branch'} // '';
-my $printer = $userenv->{'branchprinter'} // '';
my $forgivemanualholdsexpire = $query->param('forgivemanualholdsexpire');
-my $overduecharges = (C4::Context->preference('finesMode') && C4::Context->preference('finesMode') ne 'off');
-#
-# Some code to handle the error if there is no branch or printer setting.....
-#
+my $overduecharges = (C4::Context->preference('finesMode') && C4::Context->preference('finesMode') eq 'production');
# Set up the item stack ....
my %returneditems;
############
# Deal with the requests....
-
-if ($query->param('WT-itemNumber')){
- updateWrongTransfer ($query->param('WT-itemNumber'),$query->param('WT-waitingAt'),$query->param('WT-From'));
-}
-
-if ( $query->param('resbarcode') ) {
- my $item = $query->param('itemnumber');
+my $itemnumber = $query->param('itemnumber');
+if ( $query->param('reserve_id') ) {
my $borrowernumber = $query->param('borrowernumber');
- my $resbarcode = $query->param('resbarcode');
+ my $reserve_id = $query->param('reserve_id');
my $diffBranchReturned = $query->param('diffBranch');
- my $iteminfo = GetBiblioFromItemNumber($item);
my $cancel_reserve = $query->param('cancel_reserve');
# fix up item type for display
- $iteminfo->{'itemtype'} = C4::Context->preference('item-level_itypes') ? $iteminfo->{'itype'} : $iteminfo->{'itemtype'};
+ my $item = Koha::Items->find( $itemnumber );
+ my $biblio = $item->biblio;
if ( $cancel_reserve ) {
- CancelReserve({ borrowernumber => $borrowernumber, itemnumber => $item, charge_cancel_fee => !$forgivemanualholdsexpire });
+ my $hold = Koha::Holds->find( $reserve_id );
+ if ( $hold ) {
+ $hold->cancel( { charge_cancel_fee => !$forgivemanualholdsexpire } );
+ } # FIXME else?
} else {
my $diffBranchSend = ($userenv_branch ne $diffBranchReturned) ? $diffBranchReturned : undef;
# diffBranchSend tells ModReserveAffect whether document is expected in this library or not,
# i.e., whether to apply waiting status
- ModReserveAffect( $item, $borrowernumber, $diffBranchSend);
+ ModReserveAffect( $itemnumber, $borrowernumber, $diffBranchSend, $reserve_id, $desk_id );
}
# check if we have other reserves for this document, if we have a return send the message of transfer
- my ( $messages, $nextreservinfo ) = GetOtherReserves($item);
+ my ( $messages, $nextreservinfo ) = GetOtherReserves($itemnumber);
- my $borr = GetMember( borrowernumber => $nextreservinfo );
- my $name = $borr->{'surname'} . ", " . $borr->{'title'} . " " . $borr->{'firstname'};
+ my $patron = Koha::Patrons->find( $nextreservinfo );
if ( $messages->{'transfert'} ) {
$template->param(
- itemtitle => $iteminfo->{'title'},
- itemnumber => $iteminfo->{'itemnumber'},
- itembiblionumber => $iteminfo->{'biblionumber'},
- iteminfo => $iteminfo->{'author'},
- tobranchname => GetBranchName($messages->{'transfert'}),
- name => $name,
- borrowernumber => $borrowernumber,
- borcnum => $borr->{'cardnumber'},
- borfirstname => $borr->{'firstname'},
- borsurname => $borr->{'surname'},
+ itemtitle => $biblio->title,
+ itembiblionumber => $biblio->biblionumber,
+ iteminfo => $biblio->author,
+ patron => $patron,
diffbranch => 1,
);
}
my $borrower;
my $returned = 0;
my $messages;
-my $issueinformation;
-my $itemnumber;
+my $issue;
my $barcode = $query->param('barcode');
my $exemptfine = $query->param('exemptfine');
if (
my $dropboxmode = $query->param('dropboxmode');
my $dotransfer = $query->param('dotransfer');
my $canceltransfer = $query->param('canceltransfer');
+my $transit = $query->param('transit');
my $dest = $query->param('dest');
-my $calendar = Koha::Calendar->new( branchcode => $userenv_branch );
#dropbox: get last open day (today - 1)
-my $today = DateTime->now( time_zone => C4::Context->tz());
-my $dropboxdate = $calendar->addDate($today, -1);
+my $dropboxdate = Koha::Checkouts::calculate_dropbox_date();
my $return_date_override = $query->param('return_date_override');
+my $return_date_override_dt;
my $return_date_override_remember =
$query->param('return_date_override_remember');
if ($return_date_override) {
if ( C4::Context->preference('SpecifyReturnDate') ) {
- my $return_date_override_dt = eval {dt_from_string( $return_date_override ) };
+ $return_date_override_dt = eval {dt_from_string( $return_date_override ) };
if ( $return_date_override_dt ) {
# note that we've overriden the return date
$template->param( return_date_was_overriden => 1);
# An item has been returned to a branch other than the homebranch, and the librarian has chosen to initiate a transfer
my $transferitem = $query->param('transferitem');
my $tobranch = $query->param('tobranch');
- ModItemTransfer($transferitem, $userenv_branch, $tobranch);
+ my $trigger = $query->param('trigger');
+ ModItemTransfer($transferitem, $userenv_branch, $tobranch, $trigger);
}
-if ($canceltransfer){
- $itemnumber=$query->param('itemnumber');
- DeleteTransfer($itemnumber);
+if ($transit) {
+ my $transfer = Koha::Item::Transfers->find($transit);
+ if ( $canceltransfer ) {
+ $transfer->cancel({ reason => 'Manual', force => 1});
+ $template->param( transfercancelled => 1);
+ } else {
+ $transfer->transit;
+ }
+} elsif ($canceltransfer){
+ my $item = Koha::Items->find($itemnumber);
+ my $transfer = $item->get_transfer;
+ $transfer->cancel({ reason => 'Manual', force => 1});
if($dest eq "ttr"){
print $query->redirect("/cgi-bin/koha/circ/transferstoreceive.pl");
exit;
}
}
+
# actually return book and prepare item table.....
my $returnbranch;
if ($barcode) {
$barcode =~ s/^\s*|\s*$//g; # remove leading/trailing whitespace
$barcode = barcodedecode($barcode) if C4::Context->preference('itemBarcodeInputFilter');
- $itemnumber = GetItemnumberFromBarcode($barcode);
+ my $item = Koha::Items->find({ barcode => $barcode });
+
+ if ( $item ) {
+ $itemnumber = $item->itemnumber;
+ # Check if we should display a checkin message, based on the the item
+ # type of the checked in item
+ my $itemtype = Koha::ItemTypes->find( $item->effective_itemtype );
+ if ( $itemtype && $itemtype->checkinmsg ) {
+ $template->param(
+ checkinmsg => $itemtype->checkinmsg,
+ checkinmsgtype => $itemtype->checkinmsgtype,
+ );
+ }
-#
-# save the return
-#
+ # make sure return branch respects home branch circulation rules, default to homebranch
+ my $hbr = GetBranchItemRule($item->homebranch, $itemtype ? $itemtype->itemtype : undef )->{'returnbranch'} || "homebranch";
+ $returnbranch = $hbr ne 'noreturn' ? $item->$hbr : $userenv_branch; # can be noreturn, homebranch or holdingbranch
- # get biblio description
- my $biblio = GetBiblioFromItemNumber($itemnumber);
- # fix up item type for display
- $biblio->{'itemtype'} = C4::Context->preference('item-level_itypes') ? $biblio->{'itype'} : $biblio->{'itemtype'};
+ my $materials = $item->materials;
+ my $descriptions = Koha::AuthorisedValues->get_description_by_koha_field({frameworkcode => '', kohafield =>'items.materials', authorised_value => $materials });
+ $materials = $descriptions->{lib} // $materials;
- # Check if we should display a checkin message, based on the the item
- # type of the checked in item
- my $itemtype = Koha::ItemTypes->find( $biblio->{'itemtype'} );
- if ( $itemtype && $itemtype->checkinmsg ) {
+ my $checkout = $item->checkout;
+ my $biblio = $item->biblio;
$template->param(
- checkinmsg => $itemtype->checkinmsg,
- checkinmsgtype => $itemtype->checkinmsgtype,
+ title => $biblio->title,
+ returnbranch => $returnbranch,
+ author => $biblio->author,
+ itembiblionumber => $biblio->biblionumber,
+ biblionumber => $biblio->biblionumber,
+ additional_materials => $materials,
+ issue => $checkout,
+ item => $item,
);
- }
-
- # make sure return branch respects home branch circulation rules, default to homebranch
- my $hbr = GetBranchItemRule($biblio->{'homebranch'}, $itemtype ? $itemtype->itemtype : undef )->{'returnbranch'} || "homebranch";
- $returnbranch = $biblio->{$hbr};
-
- my $materials = $biblio->{'materials'};
- my $avcode = GetAuthValCode('items.materials');
- if ($avcode) {
- $materials = GetKohaAuthorisedValueLib($avcode, $materials);
- }
-
- $template->param(
- title => $biblio->{'title'},
- homebranch => $biblio->{'homebranch'},
- holdingbranch => $biblio->{'holdingbranch'},
- returnbranch => $returnbranch,
- author => $biblio->{'author'},
- itembarcode => $biblio->{'barcode'},
- itemtype => $biblio->{'itemtype'},
- ccode => $biblio->{'ccode'},
- itembiblionumber => $biblio->{'biblionumber'},
- biblionumber => $biblio->{'biblionumber'},
- borrower => $borrower,
- additional_materials => $materials,
- );
+ } # FIXME else we should not call AddReturn but set BadBarcode directly instead
my %input = (
counter => 0,
barcode => $barcode,
);
+ my $return_date = $dropboxmode ? $dropboxdate : $return_date_override_dt;
+
+ # Block return if multi-part and confirm has not been received
+ my $needs_confirm =
+ C4::Context->preference("CircConfirmItemParts")
+ && $item
+ && $item->materials
+ && !$query->param('multiple_confirm');
+ $template->param( 'multiple_confirmed' => 1 )
+ if $query->param('multiple_confirm');
+
# do the return
- ( $returned, $messages, $issueinformation, $borrower ) =
- AddReturn( $barcode, $userenv_branch, $exemptfine, $dropboxmode, $return_date_override, $dropboxdate );
+ ( $returned, $messages, $issue, $borrower ) =
+ AddReturn( $barcode, $userenv_branch, $exemptfine, $return_date )
+ unless $needs_confirm;
if ($returned) {
- my $time_now = DateTime->now( time_zone => C4::Context->tz )->truncate( to => 'minute');
- my $duedate = $issueinformation->{date_due}->strftime('%Y-%m-%d %H:%M');
+ my $time_now = dt_from_string()->truncate( to => 'minute');
+ my $date_due_dt = dt_from_string( $issue->date_due, 'sql' );
+ my $duedate = $date_due_dt->strftime('%Y-%m-%d %H:%M');
$returneditems{0} = $barcode;
$riborrowernumber{0} = $borrower->{'borrowernumber'};
$riduedate{0} = $duedate;
$input{borrowernumber} = $borrower->{'borrowernumber'};
$input{duedate} = $duedate;
unless ( $dropboxmode ) {
- $input{return_overdue} = 1 if (DateTime->compare($issueinformation->{date_due}, DateTime->now()) == -1);
+ $input{return_overdue} = 1 if (DateTime->compare($date_due_dt, dt_from_string()) == -1);
} else {
- $input{return_overdue} = 1 if (DateTime->compare($issueinformation->{date_due}, $dropboxdate) == -1);
+ $input{return_overdue} = 1 if (DateTime->compare($date_due_dt, $dropboxdate) == -1);
}
push( @inputloop, \%input );
if ( C4::Context->preference("FineNotifyAtCheckin") ) {
- my ( $od, $issue, $fines ) = GetMemberIssuesAndFines( $borrower->{'borrowernumber'} );
- if ($fines && $fines > 0) {
- $template->param( fines => sprintf("%.2f",$fines) );
+ my $patron = Koha::Patrons->find( $borrower->{borrowernumber} );
+ my $balance = $patron->account->balance;
+
+ if ($balance > 0) {
+ $template->param( fines => sprintf("%.2f", $balance) );
$template->param( fineborrowernumber => $borrower->{'borrowernumber'} );
}
}
if (C4::Context->preference("WaitingNotifyAtCheckin") ) {
#Check for waiting holds
- my @reserves = GetReservesFromBorrowernumber($borrower->{'borrowernumber'});
- my $waiting_holds = 0;
- foreach my $num_res (@reserves) {
- if ( $num_res->{'found'} eq 'W' && $num_res->{'branchcode'} eq $userenv_branch) {
- $waiting_holds++;
- }
- }
+ my $patron = Koha::Patrons->find( $borrower->{borrowernumber} );
+ my $waiting_holds = $patron->holds->search({ found => 'W', branchcode => $userenv_branch })->count;
if ($waiting_holds > 0) {
$template->param(
waiting_holds => $waiting_holds,
);
}
}
- } elsif ( C4::Context->preference('ShowAllCheckins') and !$messages->{'BadBarcode'} ) {
+ } elsif ( C4::Context->preference('ShowAllCheckins') and !$messages->{'BadBarcode'} and !$needs_confirm ) {
$input{duedate} = 0;
$returneditems{0} = $barcode;
$riduedate{0} = 0;
push( @inputloop, \%input );
}
$template->param( privacy => $borrower->{privacy} );
+
+ if ( $needs_confirm ) {
+ $template->param( needs_confirm => $needs_confirm );
+ }
}
$template->param( inputloop => \@inputloop );
my $reserved = 0;
# new op dev : we check if the document must be returned to his homebranch directly,
-# if the document is transfered, we have warning message .
+# if the document is transferred, we have warning message .
if ( $messages->{'WasTransfered'} ) {
$template->param(
found => 1,
- transfer => 1,
+ transfer => $messages->{'WasTransfered'},
+ trigger => $messages->{'TransferTrigger'},
itemnumber => $itemnumber,
);
}
$template->param(
found => 1,
needstransfer => $messages->{'NeedsTransfer'},
- itemnumber => $itemnumber,
+ trigger => $messages->{'TransferTrigger'},
);
}
);
}
-# case of wrong transfert, if the document wasn't transfered to the right library (according to branchtransfer (tobranch) BDD)
+# case of wrong transfert, if the document wasn't transferred to the right library (according to branchtransfer (tobranch) BDD)
if ( $messages->{'WrongTransfer'} and not $messages->{'WasTransfered'}) {
+
+ # Trigger modal to prompt librarian
$template->param(
WrongTransfer => 1,
TransferWaitingAt => $messages->{'WrongTransfer'},
WrongTransferItem => $messages->{'WrongTransferItem'},
- itemnumber => $itemnumber,
+ trigger => $messages->{'TransferTrigger'},
);
- my $reserve = $messages->{'ResFound'};
- my $branchname = $branches->{ $reserve->{'branchcode'} }->{'branchname'};
- my $borr = C4::Members::GetMember( borrowernumber => $reserve->{'borrowernumber'} );
- my $name = $borr->{'surname'} . ", " . $borr->{'title'} . " " . $borr->{'firstname'};
+ # Update the transfer to reflect the new item holdingbranch
+ my $new_transfer = updateWrongTransfer($messages->{'WrongTransferItem'},$messages->{'WrongTransfer'}, $userenv_branch);
$template->param(
- wname => $name,
- wborfirstname => $borr->{'firstname'},
- wborsurname => $borr->{'surname'},
- wbortitle => $borr->{'title'},
- wborphone => $borr->{'phone'},
- wboremail => $borr->{'email'},
- wborstnum => $borr->{streetnumber},
- wboraddress => $borr->{'address'},
- wboraddress2 => $borr->{'address2'},
- wborcity => $borr->{'city'},
- wborzip => $borr->{'zipcode'},
- wborrowernumber => $reserve->{'borrowernumber'},
- wborcnum => $borr->{'cardnumber'},
- wtransfertFrom => $userenv_branch,
+ NewTransfer => $new_transfer->id
);
+
+ my $reserve = $messages->{'ResFound'};
+ if ( $reserve ) {
+ my $patron = Koha::Patrons->find( $reserve->{'borrowernumber'} );
+ $template->param(
+ patron => $patron,
+ );
+ }
}
#
#
if ( $messages->{'ResFound'}) {
my $reserve = $messages->{'ResFound'};
- my $branchname = $branches->{ $reserve->{'branchcode'} }->{'branchname'};
- my $borr = C4::Members::GetMember( borrowernumber => $reserve->{'borrowernumber'} );
+ my $patron = Koha::Patrons->find( $reserve->{borrowernumber} );
my $holdmsgpreferences = C4::Members::Messaging::GetMessagingPreferences( { borrowernumber => $reserve->{'borrowernumber'}, message_name => 'Hold_Filled' } );
- if ( $reserve->{'ResFound'} eq "Waiting" or $reserve->{'ResFound'} eq "Reserved" ) {
- if ( $reserve->{'ResFound'} eq "Waiting" ) {
- $template->param(
- waiting => ($userenv_branch eq $reserve->{'branchcode'} ? 1 : 0 ),
- );
- } elsif ( $reserve->{'ResFound'} eq "Reserved" ) {
+ my $branchCheck = ( $userenv_branch eq $reserve->{branchcode} );
+ if ( $reserve->{'ResFound'} eq "Waiting" ) {
+ $template->param(
+ waiting => $branchCheck ? 1 : undef,
+ );
+ } elsif ( C4::Context->preference('HoldsAutoFill') ) {
+ my $item = Koha::Items->find( $itemnumber );
+ my $biblio = $item->biblio;
+
+ my $diffBranchSend = !$branchCheck ? $reserve->{branchcode} : undef;
+ ModReserveAffect( $reserve->{itemnumber}, $reserve->{borrowernumber}, $diffBranchSend, $reserve->{reserve_id}, $desk_id );
+ my ( $messages, $nextreservinfo ) = GetOtherReserves($reserve->{itemnumber});
+
+ $template->param(
+ hold_auto_filled => 1,
+ print_slip => C4::Context->preference('HoldsAutoFillPrintSlip'),
+ reserve_id => $nextreservinfo->{reserve_id},
+ );
+
+ if ( $messages->{'transfert'} ) {
$template->param(
- intransit => ($userenv_branch eq $reserve->{'branchcode'} ? 0 : 1 ),
- transfertodo => ($userenv_branch eq $reserve->{'branchcode'} ? 0 : 1 ),
- resbarcode => $barcode,
- reserved => 1,
+ itemtitle => $biblio->title,
+ itembiblionumber => $biblio->biblionumber,
+ iteminfo => $biblio->author,
+ diffbranch => 1,
);
}
-
- # same params for Waiting or Reserved
+ } else {
$template->param(
- found => 1,
- currentbranch => $branches->{$userenv_branch}->{'branchname'},
- destbranchname => $branches->{ $reserve->{'branchcode'} }->{'branchname'},
- name => $borr->{'surname'} . ", " . $borr->{'title'} . " " . $borr->{'firstname'},
- borfirstname => $borr->{'firstname'},
- borsurname => $borr->{'surname'},
- bortitle => $borr->{'title'},
- borphone => $borr->{'phone'},
- boremail => $borr->{'email'},
- boraddress => $borr->{'address'},
- boraddress2 => $borr->{'address2'},
- borstnum => $borr->{streetnumber},
- borcity => $borr->{'city'},
- borzip => $borr->{'zipcode'},
- borcnum => $borr->{'cardnumber'},
- debarred => $borr->{'debarred'},
- gonenoaddress => $borr->{'gonenoaddress'},
- barcode => $barcode,
- destbranch => $reserve->{'branchcode'},
- borrowernumber => $reserve->{'borrowernumber'},
- itemnumber => $reserve->{'itemnumber'},
- reservenotes => $reserve->{'reservenotes'},
- bormessagepref => $holdmsgpreferences->{'transports'},
+ intransit => $branchCheck ? undef : 1,
+ transfertodo => $branchCheck ? undef : 1,
+ reserve_id => $reserve->{reserve_id},
+ reserved => 1,
);
- } # else { ; } # error?
+ }
+
+ # same params for Waiting or Reserved
+ $template->param(
+ found => 1,
+ patron => $patron,
+ barcode => $barcode,
+ destbranch => $reserve->{'branchcode'},
+ reservenotes => $reserve->{'reservenotes'},
+ reserve_id => $reserve->{reserve_id},
+ bormessagepref => $holdmsgpreferences->{'transports'},
+ );
}
# Error Messages
elsif ( $code eq 'NotIssued' ) {
$err{notissued} = 1;
$err{msg} = '';
- $err{msg} = $branches->{ $messages->{'IsPermanent'} }->{'branchname'} if $messages->{'IsPermanent'};
}
elsif ( $code eq 'LocalUse' ) {
$err{localuse} = 1;
}
elsif ( $code eq 'WasLost' ) {
$err{waslost} = 1;
+ $exit_required_p = 1 if C4::Context->preference("BlockReturnOfLostItems");
}
elsif ( $code eq 'LostItemFeeRefunded' ) {
$template->param( LostItemFeeRefunded => 1 );
}
+ elsif ( $code eq 'LostItemFeeCharged' ) {
+ $template->param( LostItemFeeCharged => 1 );
+ }
+ elsif ( $code eq 'LostItemFeeRestored' ) {
+ $template->param( LostItemFeeRestored => 1 );
+ }
elsif ( $code eq 'ResFound' ) {
; # FIXME... anything to do here?
}
$err{withdrawn} = 1;
$exit_required_p = 1 if C4::Context->preference("BlockReturnOfWithdrawnItems");
}
- elsif ( ( $code eq 'IsPermanent' ) && ( not $messages->{'ResFound'} ) ) {
- if ( $messages->{'IsPermanent'} ne $userenv_branch ) {
- $err{ispermanent} = 1;
- $err{msg} =
- $branches->{ $messages->{'IsPermanent'} }->{'branchname'};
- }
- }
elsif ( $code eq 'WrongTransfer' ) {
; # FIXME... anything to do here?
}
}
elsif ( $code eq 'NeedsTransfer' ) {
}
+ elsif ( $code eq 'TransferTrigger' ) {
+ ; # Handled alongside NeedsTransfer
+ }
+ elsif ( $code eq 'TransferArrived' ) {
+ $err{transferred} = $messages->{'TransferArrived'};
+ }
elsif ( $code eq 'Wrongbranch' ) {
}
elsif ( $code eq 'Debarred' ) {
elsif ( $code eq 'ForeverDebarred' ) {
$err{foreverdebarred} = $messages->{'ForeverDebarred'};
}
+ elsif ( $code eq 'ItemLocationUpdated' ) {
+ $err{ItemLocationUpdated} = $messages->{ItemLocationUpdated};
+ }
elsif ( $code eq 'NotForLoanStatusUpdated' ) {
$err{NotForLoanStatusUpdated} = $messages->{NotForLoanStatusUpdated};
}
- else {
+ elsif ( $code eq 'DataCorrupted' ) {
+ $err{data_corrupted} = 1;
+ }
+ elsif ( $code eq 'ReturnClaims' ) {
+ $template->param( ReturnClaims => $messages->{ReturnClaims} );
+ } else {
die "Unknown error code $code"; # note we need all the (empty) elsif's above, or we die.
# This forces the issue of staying in sync w/ Circulation.pm
}
my $returned_counter = ( C4::Context->preference('numReturnedItemsToShow') ) ? C4::Context->preference('numReturnedItemsToShow') : 8;
my $count = 0;
my @riloop;
-my $shelflocations = GetKohaAuthorisedValues('items.location','');
+my $shelflocations =
+ { map { $_->{authorised_value} => $_->{lib} } Koha::AuthorisedValues->get_descriptions_by_koha_field( { frameworkcode => '', kohafield => 'items.location' } ) };
foreach ( sort { $a <=> $b } keys %returneditems ) {
my %ri;
if ( $count++ < $returned_counter ) {
$ri{hour} = $duedate->hour();
$ri{minute} = $duedate->minute();
$ri{duedate} = output_pref($duedate);
- my $b = C4::Members::GetMember( borrowernumber => $riborrowernumber{$_} );
+ my $patron = Koha::Patrons->find( $riborrowernumber{$_} );
unless ( $dropboxmode ) {
- $ri{return_overdue} = 1 if (DateTime->compare($duedate, DateTime->now()) == -1);
+ $ri{return_overdue} = 1 if (DateTime->compare($duedate, dt_from_string()) == -1);
} else {
$ri{return_overdue} = 1 if (DateTime->compare($duedate, $dropboxdate) == -1);
}
- $ri{borrowernumber} = $b->{'borrowernumber'};
- $ri{borcnum} = $b->{'cardnumber'};
- $ri{borfirstname} = $b->{'firstname'};
- $ri{borsurname} = $b->{'surname'};
- $ri{bortitle} = $b->{'title'};
- $ri{bornote} = $b->{'borrowernotes'};
- $ri{borcategorycode}= $b->{'categorycode'};
+ $ri{patron} = $patron,
+ $ri{borissuescount} = $patron->checkouts->count;
}
else {
$ri{borrowernumber} = $riborrowernumber{$_};
}
- # my %ri;
- my $biblio = GetBiblioFromItemNumber(GetItemnumberFromBarcode($bar_code));
- my $item = GetItem( GetItemnumberFromBarcode($bar_code) );
- # fix up item type for display
- $biblio->{'itemtype'} = C4::Context->preference('item-level_itypes') ? $biblio->{'itype'} : $biblio->{'itemtype'};
- $ri{itembiblionumber} = $biblio->{'biblionumber'};
- $ri{itemtitle} = $biblio->{'title'};
- $ri{itemauthor} = $biblio->{'author'};
- $ri{itemcallnumber} = $biblio->{'itemcallnumber'};
- $ri{dateaccessioned} = $item->{dateaccessioned};
- $ri{itemtype} = $biblio->{'itemtype'};
- $ri{itemnote} = $biblio->{'itemnotes'};
- $ri{itemnotes_nonpublic} = $item->{'itemnotes_nonpublic'};
- $ri{ccode} = $biblio->{'ccode'};
- $ri{itemnumber} = $biblio->{'itemnumber'};
+ my $item = Koha::Items->find({ barcode => $bar_code });
+ next unless $item; # FIXME The item has been deleted in the meantime,
+ # we could handle that better displaying a message in the template
+
+ my $biblio = $item->biblio;
+ # FIXME pass $item to the template and we are done here...
+ $ri{itembiblionumber} = $biblio->biblionumber;
+ $ri{itemtitle} = $biblio->title;
+ $ri{subtitle} = $biblio->subtitle;
+ $ri{part_name} = $biblio->part_name;
+ $ri{part_number} = $biblio->part_number;
+ $ri{itemauthor} = $biblio->author;
+ $ri{itemcallnumber} = $item->itemcallnumber;
+ $ri{dateaccessioned} = $item->dateaccessioned;
+ $ri{recordtype} = $biblio->itemtype;
+ $ri{itemtype} = $item->itype;
+ $ri{itemnote} = $item->itemnotes;
+ $ri{itemnotes_nonpublic} = $item->itemnotes_nonpublic;
+ $ri{ccode} = $item->ccode;
+ $ri{enumchron} = $item->enumchron;
+ $ri{itemnumber} = $item->itemnumber;
$ri{barcode} = $bar_code;
- $ri{homebranch} = $item->{'homebranch'};
- $ri{holdingbranch} = $item->{'holdingbranch'};
+ $ri{homebranch} = $item->homebranch;
+ $ri{holdingbranch} = $item->holdingbranch;
+ $ri{damaged} = $item->damaged;
- $ri{location} = $biblio->{'location'};
+ $ri{location} = $item->location;
my $shelfcode = $ri{'location'};
$ri{'location'} = $shelflocations->{$shelfcode} if ( defined( $shelfcode ) && defined($shelflocations) && exists( $shelflocations->{$shelfcode} ) );
}
push @riloop, \%ri;
}
-my ($genbrname, $genprname);
-if (my $b = $branches->{$userenv_branch}) {
- $genbrname = $b->{'branchname'};
-}
-if (my $p = $printers->{$printer}) {
- $genprname = $p->{'printername'};
-}
+
$template->param(
riloop => \@riloop,
- genbrname => $genbrname,
- genprname => $genprname,
- branchname => $genbrname,
- printer => $printer,
errmsgloop => \@errmsgloop,
exemptfine => $exemptfine,
dropboxmode => $dropboxmode,
- dropboxdate => output_pref($dropboxdate),
+ dropboxdate => $dropboxdate,
forgivemanualholdsexpire => $forgivemanualholdsexpire,
overduecharges => $overduecharges,
AudioAlerts => C4::Context->preference("AudioAlerts"),
- BlockReturnOfWithdrawnItems => C4::Context->preference("BlockReturnOfWithdrawnItems"),
);
-$itemnumber = GetItemnumberFromBarcode( $barcode );
-if ( $itemnumber ) {
- my ( $holdingBranch, $collectionBranch ) = GetCollectionItemBranches( $itemnumber );
- if ( $holdingBranch and $collectionBranch ) {
- $holdingBranch //= '';
- $collectionBranch //= $returnbranch;
- if ( ! ( $holdingBranch eq $collectionBranch ) ) {
- $template->param(
- collectionItemNeedsTransferred => 1,
- collectionBranchName => GetBranchName($collectionBranch),
- collectionBranch => $collectionBranch,
- itemnumber => $itemnumber,
- );
+if ( $barcode ) {
+ my $item_from_barcode = Koha::Items->find({barcode => $barcode }); # How many times do we fetch this item?!?
+ if ( $item_from_barcode ) {
+ $itemnumber = $item_from_barcode->itemnumber;
+ my ( $holdingBranch, $collectionBranch ) = GetCollectionItemBranches( $itemnumber );
+ if ( $holdingBranch and $collectionBranch ) {
+ $holdingBranch //= '';
+ $collectionBranch //= $returnbranch;
+ if ( ! ( $holdingBranch eq $collectionBranch ) ) {
+ $template->param(
+ collectionItemNeedsTransferred => 1,
+ collectionBranch => $collectionBranch,
+ );
+ }
}
}
}
+$template->param( itemnumber => $itemnumber );
+
+# Checking if there is a Fast Cataloging Framework
+$template->param( fast_cataloging => 1 ) if Koha::BiblioFrameworks->find( 'FA' );
+
# actually print the page!
output_html_with_http_headers $query, $cookie, $template->output;
projects / srvgit / blobdiff