use DateTime;
use C4::Auth qw/:DEFAULT get_session/;
+use C4::Output;
+use C4::Circulation;
+use C4::Reserves;
use C4::Biblio;
use C4::Circulation;
use C4::Context;
use C4::Members::Messaging;
use C4::Members;
use C4::Output;
-use C4::Print;
use C4::Reserves;
use C4::RotatingCollections;
use Koha::AuthorisedValues;
template_name => "circ/returns.tt",
query => $query,
type => "intranet",
- authnotrequired => 0,
flagsrequired => { circulate => "circulate_remaining_permissions" },
}
);
my $sessionID = $query->cookie("CGISESSID");
my $session = get_session($sessionID);
-if ($session->param('branch') eq 'NO_LIBRARY_SET'){
- # no branch set we can't return
- print $query->redirect("/cgi-bin/koha/circ/selectbranchprinter.pl");
- exit;
-}
# Print a reserve slip on this page
if ( $query->param('print_slip') ) {
$template->param(
print_slip => 1,
- borrowernumber => scalar $query->param('borrowernumber'), # FIXME We should send a Koha::Patron and raise an error if not exist.
- biblionumber => scalar $query->param('biblionumber'),
- itemnumber => scalar $query->param('itemnumber'),
+ reserve_id => scalar $query->param('reserve_id'),
);
}
#####################
#Global vars
-my $printers = GetPrinters();
my $userenv = C4::Context->userenv;
my $userenv_branch = $userenv->{'branch'} // '';
-my $printer = $userenv->{'branchprinter'} // '';
my $forgivemanualholdsexpire = $query->param('forgivemanualholdsexpire');
my $overduecharges = (C4::Context->preference('finesMode') && C4::Context->preference('finesMode') ne 'off');
- #
-# Some code to handle the error if there is no branch or printer setting.....
-#
# Set up the item stack ....
my %returneditems;
# An item has been returned to a branch other than the homebranch, and the librarian has chosen to initiate a transfer
my $transferitem = $query->param('transferitem');
my $tobranch = $query->param('tobranch');
- ModItemTransfer($transferitem, $userenv_branch, $tobranch);
+ my $trigger = $query->param('trigger');
+ ModItemTransfer($transferitem, $userenv_branch, $tobranch, $trigger);
}
if ($canceltransfer){
my $checkout = $item->checkout;
my $biblio = $item->biblio;
$template->param(
- title => $biblio->title,
- homebranch => $item->homebranch,
- holdingbranch => $item->holdingbranch,
- returnbranch => $returnbranch,
- author => $biblio->author,
- itembarcode => $item->barcode,
- itemtype => $item->effective_itemtype,
- ccode => $item->ccode,
- itembiblionumber => $biblio->biblionumber,
- biblionumber => $biblio->biblionumber,
+ title => $biblio->title,
+ homebranch => $item->homebranch,
+ holdingbranch => $item->holdingbranch,
+ returnbranch => $returnbranch,
+ author => $biblio->author,
+ itembarcode => $item->barcode,
+ itemtype => $item->effective_itemtype,
+ ccode => $item->ccode,
+ itembiblionumber => $biblio->biblionumber,
+ biblionumber => $biblio->biblionumber,
additional_materials => $materials,
- issue => $checkout,
+ issue => $checkout,
);
} # FIXME else we should not call AddReturn but set BadBarcode directly instead
my $return_date = $dropboxmode ? $dropboxdate : $return_date_override_dt;
+ # Block return if multi-part and confirm has not been received
+ my $needs_confirm = 0;
+ if ( C4::Context->preference("CircConfirmParts") ) {
+ if ( $item->materials > 0 && !$query->param('multiple_confirm') ) {
+ $needs_confirm = 1;
+ }
+ }
+
# do the return
( $returned, $messages, $issue, $borrower ) =
- AddReturn( $barcode, $userenv_branch, $exemptfine, $return_date );
+ AddReturn( $barcode, $userenv_branch, $exemptfine, $return_date )
+ unless $needs_confirm;
if ($returned) {
- my $time_now = DateTime->now( time_zone => C4::Context->tz )->truncate( to => 'minute');
+ my $time_now = dt_from_string()->truncate( to => 'minute');
my $date_due_dt = dt_from_string( $issue->date_due, 'sql' );
my $duedate = $date_due_dt->strftime('%Y-%m-%d %H:%M');
$returneditems{0} = $barcode;
$input{borrowernumber} = $borrower->{'borrowernumber'};
$input{duedate} = $duedate;
unless ( $dropboxmode ) {
- $input{return_overdue} = 1 if (DateTime->compare($date_due_dt, DateTime->now()) == -1);
+ $input{return_overdue} = 1 if (DateTime->compare($date_due_dt, dt_from_string()) == -1);
} else {
$input{return_overdue} = 1 if (DateTime->compare($date_due_dt, $dropboxdate) == -1);
}
);
}
}
- } elsif ( C4::Context->preference('ShowAllCheckins') and !$messages->{'BadBarcode'} ) {
+ } elsif ( C4::Context->preference('ShowAllCheckins') and !$messages->{'BadBarcode'} and !$needs_confirm ) {
$input{duedate} = 0;
$returneditems{0} = $barcode;
$riduedate{0} = 0;
push( @inputloop, \%input );
}
$template->param( privacy => $borrower->{privacy} );
+
+ if ( $needs_confirm ) {
+ $template->param( needs_confirm => $needs_confirm );
+ }
}
$template->param( inputloop => \@inputloop );
+
my $found = 0;
my $waiting = 0;
my $reserved = 0;
$template->param(
found => 1,
needstransfer => $messages->{'NeedsTransfer'},
+ trigger => $messages->{'TransferTrigger'},
itemnumber => $itemnumber,
);
}
ModReserveAffect( $reserve->{itemnumber}, $reserve->{borrowernumber}, $diffBranchSend, $reserve->{reserve_id} );
my ( $messages, $nextreservinfo ) = GetOtherReserves($reserve->{itemnumber});
- my $patron = Koha::Patrons->find( $nextreservinfo );
-
$template->param(
hold_auto_filled => 1,
print_slip => C4::Context->preference('HoldsAutoFillPrintSlip'),
- patron => $patron,
- borrowernumber => $patron->id,
- biblionumber => $biblio->id,
+ reserve_id => $nextreservinfo->{reserve_id},
+ itemnumber => $itemnumber,
);
if ( $messages->{'transfert'} ) {
$template->param(
- itemtitle => $biblio->title,
- itemnumber => $item->itemnumber,
+ itemtitle => $biblio->title,
itembiblionumber => $biblio->biblionumber,
- iteminfo => $biblio->author,
- diffbranch => 1,
+ iteminfo => $biblio->author,
+ diffbranch => 1,
);
}
}
transfertodo => $branchCheck ? undef : 1,
reserve_id => $reserve->{reserve_id},
reserved => 1,
+ itemnumber => $itemnumber,
);
}
patron => $patron,
barcode => $barcode,
destbranch => $reserve->{'branchcode'},
- itemnumber => $reserve->{'itemnumber'},
reservenotes => $reserve->{'reservenotes'},
reserve_id => $reserve->{reserve_id},
bormessagepref => $holdmsgpreferences->{'transports'},
}
elsif ( $code eq 'NeedsTransfer' ) {
}
+ elsif ( $code eq 'TransferTrigger' ) {
+ ; # Handled alongside NeedsTransfer
+ }
elsif ( $code eq 'Wrongbranch' ) {
}
elsif ( $code eq 'Debarred' ) {
elsif ( $code eq 'ForeverDebarred' ) {
$err{foreverdebarred} = $messages->{'ForeverDebarred'};
}
+ elsif ( $code eq 'ItemLocationUpdated' ) {
+ $err{ItemLocationUpdated} = $messages->{ItemLocationUpdated};
+ }
elsif ( $code eq 'NotForLoanStatusUpdated' ) {
$err{NotForLoanStatusUpdated} = $messages->{NotForLoanStatusUpdated};
}
elsif ( $code eq 'DataCorrupted' ) {
$err{data_corrupted} = 1;
}
- else {
+ elsif ( $code eq 'ReturnClaims' ) {
+ $template->param( ReturnClaims => $messages->{ReturnClaims} );
+ } else {
die "Unknown error code $code"; # note we need all the (empty) elsif's above, or we die.
# This forces the issue of staying in sync w/ Circulation.pm
}
$ri{duedate} = output_pref($duedate);
my $patron = Koha::Patrons->find( $riborrowernumber{$_} );
unless ( $dropboxmode ) {
- $ri{return_overdue} = 1 if (DateTime->compare($duedate, DateTime->now()) == -1);
+ $ri{return_overdue} = 1 if (DateTime->compare($duedate, dt_from_string()) == -1);
} else {
$ri{return_overdue} = 1 if (DateTime->compare($duedate, $dropboxdate) == -1);
}
my $item = Koha::Items->find({ barcode => $bar_code });
next unless $item; # FIXME The item has been deleted in the meantime,
# we could handle that better displaying a message in the template
+
my $biblio = $item->biblio;
# FIXME pass $item to the template and we are done here...
$ri{itembiblionumber} = $biblio->biblionumber;
$ri{itemtitle} = $biblio->title;
+ $ri{subtitle} = $biblio->subtitle;
+ $ri{part_name} = $biblio->part_name;
+ $ri{part_number} = $biblio->part_number;
$ri{itemauthor} = $biblio->author;
$ri{itemcallnumber} = $item->itemcallnumber;
$ri{dateaccessioned} = $item->dateaccessioned;
- $ri{itemtype} = $item->effective_itemtype;
+ $ri{recordtype} = $biblio->itemtype;
+ $ri{itemtype} = $item->itype;
$ri{itemnote} = $item->itemnotes;
$ri{itemnotes_nonpublic} = $item->itemnotes_nonpublic;
$ri{ccode} = $item->ccode;
$template->param(
riloop => \@riloop,
- printer => $printer,
errmsgloop => \@errmsgloop,
exemptfine => $exemptfine,
dropboxmode => $dropboxmode,
AudioAlerts => C4::Context->preference("AudioAlerts"),
);
-my $item_from_barcode = Koha::Items->find({barcode => $barcode }); # How many times do we fetch this item?!?
-if ( $item_from_barcode ) {
- $itemnumber = $item_from_barcode->itemnumber;
- my ( $holdingBranch, $collectionBranch ) = GetCollectionItemBranches( $itemnumber );
- if ( $holdingBranch and $collectionBranch ) {
- $holdingBranch //= '';
- $collectionBranch //= $returnbranch;
- if ( ! ( $holdingBranch eq $collectionBranch ) ) {
- $template->param(
- collectionItemNeedsTransferred => 1,
- collectionBranch => $collectionBranch,
- itemnumber => $itemnumber,
- );
+if ( $barcode ) {
+ my $item_from_barcode = Koha::Items->find({barcode => $barcode }); # How many times do we fetch this item?!?
+ if ( $item_from_barcode ) {
+ $itemnumber = $item_from_barcode->itemnumber;
+ my ( $holdingBranch, $collectionBranch ) = GetCollectionItemBranches( $itemnumber );
+ if ( $holdingBranch and $collectionBranch ) {
+ $holdingBranch //= '';
+ $collectionBranch //= $returnbranch;
+ if ( ! ( $holdingBranch eq $collectionBranch ) ) {
+ $template->param(
+ collectionItemNeedsTransferred => 1,
+ collectionBranch => $collectionBranch,
+ itemnumber => $itemnumber,
+ );
+ }
}
}
}
projects / srvgit / blobdiff