Bug 24909: Add unprivileged route to get a bibliographic record

[srvgit] / circ / bookcount.pl

diff --git a/circ/bookcount.pl b/circ/bookcount.pl
index 3543d92..0d86946 100755 (executable)
--- a/circ/bookcount.pl
+++ b/circ/bookcount.pl
@@ -28,30 +28,17 @@ use C4::Circulation;
 use C4::Output;
 use C4::Koha;
 use C4::Auth;
-use C4::Biblio; # GetBiblioItemData
+use Koha::Biblios;
 use Koha::DateUtils;
 use Koha::Libraries;
 
 my $input        = new CGI;
 my $itm          = $input->param('itm');
-my $bi           = $input->param('bi');
 my $biblionumber = $input->param('biblionumber');
 
-my $idata = itemdatanum($itm);
-my $data  = GetBiblioItemData($bi);
+my $biblio = Koha::Biblios->find( $biblionumber );
+my $item   = Koha::Items->find( $itm );
 
-my $lastmove = lastmove($itm);
-
-my $lastdate;
-my $count;
-if ( not $lastmove ) {
-    $count = issuessince( $itm, 0 );
-} else {
-    $lastdate = $lastmove->{'datearrived'};
-    $count = issuessince( $itm, $lastdate );
-}
-
-# make the page ...
 
 my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
     {
@@ -64,6 +51,21 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
     }
 );
 
+output_and_exit( $input, $cookie, $template, 'unknown_biblio')
+    unless $biblio;
+output_and_exit( $input, $cookie, $template, 'unknown_item')
+    unless $item;
+
+my $lastdate;
+my $count;
+my $lastmove = lastmove($itm);
+if ( not $lastmove ) {
+    $count = issuessince( $itm, 0 );
+} else {
+    $lastdate = $lastmove->{'datearrived'};
+    $count = issuessince( $itm, $lastdate );
+}
+
 my $libraries = Koha::Libraries->search({}, { order_by => ['branchname'] })->unblessed;
 for my $library ( @$libraries ) {
     $library->{selected} = 1 if $library->{branchcode} eq C4::Context->userenv->{branch};
@@ -73,12 +75,11 @@ for my $library ( @$libraries ) {
 
 $template->param(
     biblionumber            => $biblionumber,
-    title                   => $data->{'title'},
-    author                  => $data->{'author'},
-    barcode                 => $idata->{'barcode'},
-    biblioitemnumber        => $bi,
-    homebranch              => $idata->{homebranch},
-    holdingbranch           => $idata->{holdingbranch},
+    title                   => $biblio->title,
+    author                  => $biblio->author,
+    barcode                 => $item->barcode,
+    homebranch              => $item->homebranch,
+    holdingbranch           => $item->holdingbranch,
     lastdate                => $lastdate ? $lastdate : 0,
     count                   => $count,
     libraries               => $libraries,
@@ -87,13 +88,6 @@ $template->param(
 output_html_with_http_headers $input, $cookie, $template->output;
 exit;
 
-sub itemdatanum {
-    my ($itemnumber) = @_;
-    my $sth = C4::Context->dbh->prepare("SELECT * FROM items WHERE itemnumber=?");
-    $sth->execute($itemnumber);
-    return $sth->fetchrow_hashref;
-}
-
 sub lastmove {
     my ($itemnumber) = @_;
     my $dbh = C4::Context->dbh;