use CGI;
use C4::Auth;
use C4::Dates qw/format_date format_date_in_iso/;
+use C4::Debug;
use Date::Calc qw/Today Add_Delta_YM/;
-use vars qw($debug);
-
-BEGIN {
- $debug = $ENV{DEBUG} || 0;
-}
-
my $input = new CGI;
my $order = $input->param('order');
my $startdate=$input->param('from');
query => $input,
type => "intranet",
authnotrequired => 0,
- flagsrequired => { circulate => 1 },
+ flagsrequired => { circulate => "circulate_remaining_permissions" },
debug => 1,
}
);
my $dbh = C4::Context->dbh;
my ($sqlorderby, $sqldatewhere, $presqldatewhere) = ("","","");
$debug and warn format_date_in_iso($startdate) . "\n" . format_date_in_iso($enddate);
+my @query_params = ();
# the dates below is to check for compliance of the current date range
-#$sqldatewhere .= " AND date >= " . $dbh->quote(format_date_in_iso($startdate)) if ($startdate) ;
-$sqldatewhere .= " AND date <= " . $dbh->quote(format_date_in_iso($enddate)) if ($enddate) ;
+if ($enddate) {
+ $sqldatewhere .= " AND date <= ?";
+ push @query_params, format_date_in_iso($enddate);
+}
+push @query_params, $max_bill;
# the date below is to check for compliance of all fees prior
-$presqldatewhere .= " AND date < " . $dbh->quote(format_date_in_iso($startdate)) if ($startdate) ;
+if ($startdate) {
+ $presqldatewhere .= " AND date < ?";
+ push @query_params, format_date_in_iso($startdate);
+}
+push @query_params, $max_bill;
if ($order eq "patron") {
- $sqlorderby = " order by surname, firstname ";
+ $sqlorderby = " ORDER BY surname, firstname ";
} elsif ($order eq "fee") {
- $sqlorderby = " order by l_amountoutstanding DESC ";
+ $sqlorderby = " ORDER BY l_amountoutstanding DESC ";
} elsif ($order eq "desc") {
- $sqlorderby = " order by l_description ";
+ $sqlorderby = " ORDER BY l_description ";
} elsif ($order eq "type") {
- $sqlorderby = " order by l_accounttype ";
+ $sqlorderby = " ORDER BY l_accounttype ";
} elsif ($order eq "date") {
- $sqlorderby = " order by l_date DESC ";
+ $sqlorderby = " ORDER BY l_date DESC ";
} elsif ($order eq "total") {
- $sqlorderby = " order by sum_amount DESC ";
+ $sqlorderby = " ORDER BY sum_amount DESC ";
} else {
- $sqlorderby = " order by surname, firstname ";
+ $sqlorderby = " ORDER BY surname, firstname ";
}
my $strsth =
"SELECT
- GROUP_CONCAT(accountlines.accounttype ORDER BY accountlines.date DESC SEPARATOR '<br>') as l_accounttype,
- GROUP_CONCAT(description ORDER BY accountlines.date DESC SEPARATOR '<br>') as l_description,
- GROUP_CONCAT(round(amountoutstanding,2) ORDER BY accountlines.date DESC SEPARATOR '<br>') as l_amountoutstanding,
- GROUP_CONCAT(accountlines.date ORDER BY accountlines.date DESC SEPARATOR '<br>') as l_date,
- GROUP_CONCAT(accountlines.itemnumber ORDER BY accountlines.date DESC SEPARATOR '<br>') as l_itemnumber,
+ GROUP_CONCAT(accountlines.accounttype ORDER BY accountlines.date DESC SEPARATOR '<br/>') as l_accounttype,
+ GROUP_CONCAT(description ORDER BY accountlines.date DESC SEPARATOR '<br/>') as l_description,
+ GROUP_CONCAT(round(amountoutstanding,2) ORDER BY accountlines.date DESC SEPARATOR '<br/>') as l_amountoutstanding,
+ GROUP_CONCAT(accountlines.date ORDER BY accountlines.date DESC SEPARATOR '<br/>') as l_date,
+ GROUP_CONCAT(accountlines.itemnumber ORDER BY accountlines.date DESC SEPARATOR '<br/>') as l_itemnumber,
count(*) as cnt,
max(accountlines.date) as maxdate,
round(sum(amountoutstanding),2) as sum_amount,
IN (SELECT borrowernumber FROM accountlines
where borrowernumber >= 0
$sqldatewhere
- GROUP BY accountlines.borrowernumber HAVING sum(amountoutstanding) >= $max_bill )
+ GROUP BY accountlines.borrowernumber HAVING sum(amountoutstanding) >= ? )
AND accountlines.borrowernumber
NOT IN (SELECT borrowernumber FROM accountlines
where borrowernumber >= 0
$presqldatewhere
- GROUP BY accountlines.borrowernumber HAVING sum(amountoutstanding) >= $max_bill )
+ GROUP BY accountlines.borrowernumber HAVING sum(amountoutstanding) >= ? )
";
if (C4::Context->preference('IndependantBranches')){
$strsth .= " AND borrowers.branchcode=? ";
+ push @query_params, C4::Context->userenv->{'branch'};
}
-$strsth .= " GROUP BY accountlines.borrowernumber HAVING sum(amountoutstanding) >= $max_bill " . $sqlorderby;
+$strsth .= " GROUP BY accountlines.borrowernumber HAVING sum(amountoutstanding) >= ? " . $sqlorderby;
+push @query_params, $max_bill;
+
my $sth = $dbh->prepare($strsth);
+$sth->execute(@query_params);
-if (C4::Context->preference('IndependantBranches')){
- $sth->execute(C4::Context->userenv->{'branch'});
-}
-else {
- $sth->execute();
-}
my @billingdata;
my $previous;
my $this;